s3-pam_smbpass: Make sure PAM_MAXTRIES can be returned.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/pam_smbpass/support.c b/source3/pam_smbpass/support.c
index 7c96804af687e2a0d4cc8819ffadb8f6fbbdd72d..c49c2c525ca6190796cc8af729d0e7e756320ce4 100644 (file)
--- a/source3/pam_smbpass/support.c
+++ b/source3/pam_smbpass/support.c
@@ -411,6 +411,8 @@ int _smb_verify_password( pam_handle_t * pamh, struct samu *sampass,
 
         const char *service = NULL;
 
+        retval = PAM_AUTH_ERR;
+
         _pam_get_item( pamh, PAM_SERVICE, &service );
 
         if (data_name != NULL) {
@@ -460,7 +462,6 @@ int _smb_verify_password( pam_handle_t * pamh, struct samu *sampass,
                   "failed auth request by %s for service %s as %s(%d)",
                   uidtoname(getuid()),
                   service ? service : "**unknown**", name);
-        retval = PAM_AUTH_ERR;
     }
 
     _pam_delete( data_name );