Fix from Guenter Kukkukk <linux@kukkukk.com> to fix listing against
authorJeremy Allison <jra@samba.org>
Thu, 28 Feb 2008 10:22:13 +0000 (02:22 -0800)
committerJeremy Allison <jra@samba.org>
Thu, 28 Feb 2008 10:22:13 +0000 (02:22 -0800)
OS/2 servers. OS/2 returns eclass == ERRDOS && ecode == ERRnofiles
for a zero entry directory listing.
Jeremy.
(This used to be commit b34da627053581a9584367e177566d4a2cef7e82)

source3/libsmb/clierror.c
source3/libsmb/clilist.c

index 587abade59dc212dee4a5f29287848c1aca99f6f..36746419f7a0ab1c0d7c9888bf5ba49a3f8697d8 100644 (file)
@@ -483,3 +483,15 @@ void cli_set_nt_error(struct cli_state *cli, NTSTATUS status)
        SSVAL(cli->inbuf,smb_flg2, SVAL(cli->inbuf,smb_flg2)|FLAGS2_32_BIT_ERROR_CODES);
        SIVAL(cli->inbuf, smb_rcls, NT_STATUS_V(status));
 }
+
+/* Reset an error. */
+
+void cli_reset_error(struct cli_state *cli)
+{
+        if (SVAL(cli->inbuf,smb_flg2) & FLAGS2_32_BIT_ERROR_CODES) {
+               SIVAL(cli->inbuf, smb_rcls, NT_STATUS_V(NT_STATUS_OK));
+       } else {
+               SCVAL(cli->inbuf,smb_rcls,0);
+               SSVAL(cli->inbuf,smb_err,0);
+       }
+}
index e1b16154f24ad2720ea2981ed4d99875782c91b9..50918458b081010b8211493e1fbf23fea9340fd3 100644 (file)
@@ -328,7 +328,7 @@ int cli_list_new(struct cli_state *cli,const char *Mask,uint16 attribute,
                                       &rparam, &param_len,
                                       &rdata, &data_len) &&
                     cli_is_dos_error(cli)) {
-                       /* we need to work around a Win95 bug - sometimes
+                       /* We need to work around a Win95 bug - sometimes
                           it gives ERRSRV/ERRerror temprarily */
                        uint8 eclass;
                        uint32 ecode;
@@ -337,6 +337,20 @@ int cli_list_new(struct cli_state *cli,const char *Mask,uint16 attribute,
                        SAFE_FREE(rparam);
 
                        cli_dos_error(cli, &eclass, &ecode);
+
+                       /*
+                        * OS/2 might return "no more files",
+                        * which just tells us, that searchcount is zero
+                        * in this search.
+                        * Guenter Kukkukk <linux@kukkukk.com>
+                        */
+
+                       if (eclass == ERRDOS && ecode == ERRnofiles) {
+                               ff_searchcount = 0;
+                               cli_reset_error(cli);
+                               break;
+                       }
+
                        if (eclass != ERRSRV || ecode != ERRerror)
                                break;
                        smb_msleep(100);