idmap: don't generally forbid id==0 from idmap_unix_id_is_in_range()
authorMichael Adam <obnox@samba.org>
Mon, 15 Aug 2016 21:07:33 +0000 (23:07 +0200)
committerKarolin Seeger <kseeger@samba.org>
Tue, 13 Sep 2016 10:27:28 +0000 (12:27 +0200)
commit9a320f60cf52bc5266b221874a805ed3dfdd6c62
treef19f9424f984f04fcdccb4b582e246f756ebe291
parentc6ac8764649fe47226f115d1ae18a0220400e932
idmap: don't generally forbid id==0 from idmap_unix_id_is_in_range()

If the range allows it, then id==0 should not be forbidden.
This seems to have been taken in from idmap_ldap when the
function was originally created.

See 634cd2e0451d4388c3e3f78239495cf595368b15 .
The other backends don't seem to have had that
extra check for id == 0.

The reasoning for this change is that the range check should
apply to all cases. If the range includes the 0, then it
should be possible to get it as result. In particular,
this way, the function becomes applicable also to the
passdb backend case, e.g. in a samba4-ad-dc setup where
the Admin gets uid == 0.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12155

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit c21976d4b1c604699299f2c0f768c1add93b349d)
source3/winbindd/idmap_util.c