selftest: GetNCChanges can 'accept' a repeated bad request
authorTim Beale <timbeale@catalyst.net.nz>
Mon, 14 Aug 2017 03:31:08 +0000 (15:31 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 29 Aug 2017 05:23:28 +0000 (07:23 +0200)
commit6158f1839fe42e9a5c9daacd3182f06527462fdf
treefff2ac263b384501e0dd0e46bc0f58f631db1c40
parent3c8fa7b27f29baf9c1c8309db2ac91816255c931
selftest: GetNCChanges can 'accept' a repeated bad request

In theory, if we send the exact same rejected request again, we should
get the same response back from the DC. However, we don't - the request
is accepted if we send it a second time.

This patch updates the repl_rodc test to demonstrate the problem (which
now causes the test to fail).

Note that although the bad GetNCChanges request is not rejected outright,
the response that gets sent back is empty - it has no objects in it, so
it's not an actual security hole. It is annoying problem for writing
self-tests though.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
selftest/knownfail.d/repl_rodc [new file with mode: 0644]
source4/torture/drs/python/repl_rodc.py