r6694: a simple CLDAP torture test
[sfrench/samba-autobuild/.git] / source4 / torture / torture.c
index 3bc0b6303b6f5bfe82710dbbc2efb07cfffcf0d8..bb411558d63b44a3b1cf52ec95fc8585e8b7571c 100644 (file)
 */
 
 #include "includes.h"
+#include "dynconfig.h"
+#include "clilist.h"
+#include "lib/cmdline/popt_common.h"
+#include "libcli/raw/libcliraw.h"
+#include "system/time.h"
+#include "system/wait.h"
+#include "system/filesys.h"
+#include "ioctl.h"
+#include "librpc/gen_ndr/ndr_security.h"
 
 int torture_nprocs=4;
 int torture_numops=100;
 int torture_entries=1000;
 int torture_failures=1;
+int torture_seed=0;
 static int procnum; /* records process count number when forking */
 static struct smbcli_state *current_cli;
 static BOOL use_oplocks;
 static BOOL use_level_II_oplocks;
-static BOOL use_kerberos;
 
 BOOL torture_showall = False;
 
@@ -36,12 +45,15 @@ BOOL torture_showall = False;
 
 static struct smbcli_state *open_nbt_connection(void)
 {
-       struct nmb_name called, calling;
+       struct nbt_name called, calling;
        struct smbcli_state *cli;
        const char *host = lp_parm_string(-1, "torture", "host");
 
-       make_nmb_name(&calling, lp_netbios_name(), 0x0);
-       choose_called_name(&called, host, 0x20);
+       calling.name = lp_netbios_name();
+       calling.type = NBT_NAME_CLIENT;
+       calling.scope = NULL;
+
+       nbt_choose_called_name(NULL, &called, host, NBT_NAME_SERVER);
 
        cli = smbcli_state_init(NULL);
        if (!cli) {
@@ -54,26 +66,10 @@ static struct smbcli_state *open_nbt_connection(void)
                return cli;
        }
 
-       cli->transport->socket->timeout = 120000; /* set a really long timeout (2 minutes) */
-
        if (!smbcli_transport_establish(cli, &calling, &called)) {
-               /*
-                * Well, that failed, try *SMBSERVER ... 
-                * However, we must reconnect as well ...
-                */
-               if (!smbcli_socket_connect(cli, host)) {
-                       printf("Failed to connect with %s\n", host);
-                       return False;
-               }
-
-               make_nmb_name(&called, "*SMBSERVER", 0x20);
-               if (!smbcli_transport_establish(cli, &calling, &called)) {
-                       printf("%s rejected the session\n",host);
-                       printf("We tried with a called name of %s & %s\n",
-                               host, "*SMBSERVER");
-                       smbcli_shutdown(cli);
-                       return NULL;
-               }
+               printf("%s rejected the session\n",host);
+               smbcli_shutdown(cli);
+               return NULL;
        }
 
        return cli;
@@ -83,22 +79,12 @@ BOOL torture_open_connection_share(struct smbcli_state **c,
                                   const char *hostname, 
                                   const char *sharename)
 {
-       BOOL retry;
-       int flags = 0;
        NTSTATUS status;
-       const char *username = lp_parm_string(-1, "torture", "username");
-       const char *userdomain = lp_parm_string(-1, "torture", "userdomain");
-       const char *password = lp_parm_string(-1, "torture", "password");
-
-       if (use_kerberos)
-               flags |= SMBCLI_FULL_CONNECTION_USE_KERBEROS;
 
        status = smbcli_full_connection(NULL,
-                                       c, lp_netbios_name(),
-                                       hostname, NULL, 
-                                       sharename, "?????", 
-                                       username, username[0]?userdomain:"",
-                                       password, flags, &retry);
+                                       c, hostname, 
+                                       sharename, NULL,
+                                       cmdline_credentials);
        if (!NT_STATUS_IS_OK(status)) {
                printf("Failed to open connection - %s\n", nt_errstr(status));
                return False;
@@ -106,7 +92,6 @@ BOOL torture_open_connection_share(struct smbcli_state **c,
 
        (*c)->transport->options.use_oplocks = use_oplocks;
        (*c)->transport->options.use_level2_oplocks = use_level_II_oplocks;
-       (*c)->transport->socket->timeout = 120000;
 
        return True;
 }
@@ -133,9 +118,9 @@ BOOL torture_close_connection(struct smbcli_state *c)
        return ret;
 }
 
-
 /* open a rpc connection to the chosen binding string */
-NTSTATUS torture_rpc_connection(struct dcerpc_pipe **p, 
+NTSTATUS torture_rpc_connection(TALLOC_CTX *parent_ctx, 
+                               struct dcerpc_pipe **p, 
                                const char *pipe_name,
                                const char *pipe_uuid, 
                                uint32_t pipe_version)
@@ -148,16 +133,16 @@ NTSTATUS torture_rpc_connection(struct dcerpc_pipe **p,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       status = dcerpc_pipe_connect(p, binding, pipe_uuid, pipe_version,
-                                    lp_parm_string(-1, "torture", "userdomain"), 
-                                    lp_parm_string(-1, "torture", "username"),
-                                    lp_parm_string(-1, "torture", "password"));
+       status = dcerpc_pipe_connect(parent_ctx, 
+                                    p, binding, pipe_uuid, pipe_version,
+                                    cmdline_credentials);
  
         return status;
 }
 
 /* open a rpc connection to a specific transport */
-NTSTATUS torture_rpc_connection_transport(struct dcerpc_pipe **p, 
+NTSTATUS torture_rpc_connection_transport(TALLOC_CTX *parent_ctx, 
+                                         struct dcerpc_pipe **p, 
                                          const char *pipe_name,
                                          const char *pipe_uuid, 
                                          uint32_t pipe_version,
@@ -165,39 +150,36 @@ NTSTATUS torture_rpc_connection_transport(struct dcerpc_pipe **p,
 {
         NTSTATUS status;
        const char *binding = lp_parm_string(-1, "torture", "binding");
-       struct dcerpc_binding b;
-       TALLOC_CTX *mem_ctx = talloc_init("torture_rpc_connection_smb");
+       struct dcerpc_binding *b;
+       TALLOC_CTX *mem_ctx = talloc_named(parent_ctx, 0, "torture_rpc_connection_smb");
 
        if (!binding) {
                printf("You must specify a ncacn binding string\n");
+               talloc_free(mem_ctx);
                return NT_STATUS_INVALID_PARAMETER;
        }
 
        status = dcerpc_parse_binding(mem_ctx, binding, &b);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0,("Failed to parse dcerpc binding '%s'\n", binding));
-               talloc_destroy(mem_ctx);
+               talloc_free(mem_ctx);
                return status;
        }
 
-       b.transport = transport;
+       b->transport = transport;
 
-       status = dcerpc_pipe_connect_b(p, &b, pipe_uuid, pipe_version,
-                                      lp_parm_string(-1, "torture", "userdomain"), 
-                                      lp_parm_string(-1, "torture", "username"),
-                                      lp_parm_string(-1, "torture", "password"));
+       status = dcerpc_pipe_connect_b(mem_ctx, p, b, pipe_uuid, pipe_version,
+                                                                  cmdline_credentials);
+                                          
+       if (NT_STATUS_IS_OK(status)) {
+               *p = talloc_reference(parent_ctx, *p);
+       } else {
+               *p = NULL;
+       }
+       talloc_free(mem_ctx);
         return status;
 }
 
-/* close a rpc connection to a named pipe */
-NTSTATUS torture_rpc_close(struct dcerpc_pipe *p)
-{
-       dcerpc_pipe_close(p);
-       return NT_STATUS_OK;
-}
-
-
 /* check if the server produced the expected error code */
 BOOL check_error(const char *location, struct smbcli_state *c, 
                 uint8_t eclass, uint32_t ecode, NTSTATUS nterr)
@@ -253,7 +235,7 @@ static BOOL rw_torture(struct smbcli_state *c)
        int fnum2;
        pid_t pid2, pid = getpid();
        int i, j;
-       char buf[1024];
+       uint8_t buf[1024];
        BOOL correct = True;
 
        fnum2 = smbcli_open(c->tree, lockfname, O_RDWR | O_CREAT | O_EXCL, 
@@ -267,7 +249,7 @@ static BOOL rw_torture(struct smbcli_state *c)
 
 
        for (i=0;i<torture_numops;i++) {
-               uint_t n = (uint_t)sys_random()%10;
+               uint_t n = (uint_t)random()%10;
                if (i % 10 == 0) {
                        printf("%d\r", i); fflush(stdout);
                }
@@ -284,13 +266,13 @@ static BOOL rw_torture(struct smbcli_state *c)
                        break;
                }
 
-               if (smbcli_write(c->tree, fnum, 0, (char *)&pid, 0, sizeof(pid)) != sizeof(pid)) {
+               if (smbcli_write(c->tree, fnum, 0, &pid, 0, sizeof(pid)) != sizeof(pid)) {
                        printf("write failed (%s)\n", smbcli_errstr(c->tree));
                        correct = False;
                }
 
                for (j=0;j<50;j++) {
-                       if (smbcli_write(c->tree, fnum, 0, (char *)buf, 
+                       if (smbcli_write(c->tree, fnum, 0, buf, 
                                      sizeof(pid)+(j*sizeof(buf)), 
                                      sizeof(buf)) != sizeof(buf)) {
                                printf("write failed (%s)\n", smbcli_errstr(c->tree));
@@ -300,7 +282,7 @@ static BOOL rw_torture(struct smbcli_state *c)
 
                pid2 = 0;
 
-               if (smbcli_read(c->tree, fnum, (char *)&pid2, 0, sizeof(pid)) != sizeof(pid)) {
+               if (smbcli_read(c->tree, fnum, &pid2, 0, sizeof(pid)) != sizeof(pid)) {
                        printf("read failed (%s)\n", smbcli_errstr(c->tree));
                        correct = False;
                }
@@ -352,17 +334,16 @@ static BOOL rw_torture3(struct smbcli_state *c, const char *lockfname)
 {
        int fnum = -1;
        uint_t i = 0;
-       char buf[131072];
-       char buf_rd[131072];
+       uint8_t buf[131072];
+       uint8_t buf_rd[131072];
        uint_t count;
        uint_t countprev = 0;
        ssize_t sent = 0;
        BOOL correct = True;
 
-       srandom(1);
        for (i = 0; i < sizeof(buf); i += sizeof(uint32_t))
        {
-               SIVAL(buf, i, sys_random());
+               SIVAL(buf, i, random());
        }
 
        if (procnum == 0)
@@ -402,7 +383,7 @@ static BOOL rw_torture3(struct smbcli_state *c, const char *lockfname)
 
                if (procnum == 0)
                {
-                       sent = ((uint_t)sys_random()%(20))+ 1;
+                       sent = ((uint_t)random()%(20))+ 1;
                        if (sent > sizeof(buf) - count)
                        {
                                sent = sizeof(buf) - count;
@@ -483,7 +464,7 @@ static BOOL rw_torture2(struct smbcli_state *c1, struct smbcli_state *c2)
 
        for (i=0;i<torture_numops;i++)
        {
-               size_t buf_size = ((uint_t)sys_random()%(sizeof(buf)-1))+ 1;
+               size_t buf_size = ((uint_t)random()%(sizeof(buf)-1))+ 1;
                if (i % 10 == 0) {
                        printf("%d\r", i); fflush(stdout);
                }
@@ -529,7 +510,9 @@ static BOOL rw_torture2(struct smbcli_state *c1, struct smbcli_state *c2)
        return correct;
 }
 
-static BOOL run_readwritetest(int dummy)
+#define BOOLSTR(b) ((b) ? "Yes" : "No")
+
+static BOOL run_readwritetest(void)
 {
        struct smbcli_state *cli1, *cli2;
        BOOL test1, test2 = True;
@@ -577,14 +560,14 @@ static BOOL run_readwritemulti(struct smbcli_state *cli, int dummy)
   this checks to see if a secondary tconx can use open files from an
   earlier tconx
  */
-static BOOL run_tcon_test(int dummy)
+static BOOL run_tcon_test(void)
 {
        struct smbcli_state *cli;
        const char *fname = "\\tcontest.tmp";
        int fnum1;
        uint16_t cnum1, cnum2, cnum3;
        uint16_t vuid1, vuid2;
-       char buf[4];
+       uint8_t buf[4];
        BOOL ret = True;
        struct smbcli_tree *tree1;
        const char *host = lp_parm_string(-1, "torture", "host");
@@ -732,25 +715,18 @@ static BOOL tcon_devtest(struct smbcli_state *cli,
 /*
  checks for correct tconX support
  */
-static BOOL run_tcon_devtype_test(int dummy)
+static BOOL run_tcon_devtype_test(void)
 {
        struct smbcli_state *cli1 = NULL;
-       BOOL retry;
-       int flags = 0;
        NTSTATUS status;
        BOOL ret = True;
        const char *host = lp_parm_string(-1, "torture", "host");
        const char *share = lp_parm_string(-1, "torture", "share");
-       const char *username = lp_parm_string(-1, "torture", "username");
-       const char *userdomain = lp_parm_string(-1, "torture", "userdomain");
-       const char *password = lp_parm_string(-1, "torture", "password");
        
        status = smbcli_full_connection(NULL,
-                                       &cli1, lp_netbios_name(),
-                                       host, NULL, 
-                                       share, "?????",
-                                       username, userdomain,
-                                       password, flags, &retry);
+                                       &cli1, host, 
+                                       share, NULL,
+                                       cmdline_credentials);
 
        if (!NT_STATUS_IS_OK(status)) {
                printf("could not open connection\n");
@@ -800,12 +776,12 @@ static BOOL run_tcon_devtype_test(int dummy)
 test whether fnums and tids open on one VC are available on another (a major
 security hole)
 */
-static BOOL run_fdpasstest(int dummy)
+static BOOL run_fdpasstest(void)
 {
        struct smbcli_state *cli1, *cli2;
        const char *fname = "\\fdpass.tst";
        int fnum1, oldtid;
-       pstring buf;
+       uint8_t buf[1024];
 
        if (!torture_open_connection(&cli1) || !torture_open_connection(&cli2)) {
                return False;
@@ -856,59 +832,6 @@ static BOOL run_fdpasstest(int dummy)
 }
 
 
-/*
-  This test checks that 
-
-  1) the server does not allow an unlink on a file that is open
-*/
-static BOOL run_unlinktest(int dummy)
-{
-       struct smbcli_state *cli;
-       const char *fname = "\\unlink.tst";
-       int fnum;
-       BOOL correct = True;
-
-       if (!torture_open_connection(&cli)) {
-               return False;
-       }
-
-       printf("starting unlink test\n");
-
-       smbcli_unlink(cli->tree, fname);
-
-       cli->session->pid = 1;
-
-       printf("Opening a file\n");
-
-       fnum = smbcli_open(cli->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
-       if (fnum == -1) {
-               printf("open of %s failed (%s)\n", fname, smbcli_errstr(cli->tree));
-               return False;
-       }
-
-       printf("Unlinking a open file\n");
-
-       if (NT_STATUS_IS_OK(smbcli_unlink(cli->tree, fname))) {
-               printf("error: server allowed unlink on an open file\n");
-               correct = False;
-       } else {
-               correct = check_error(__location__, cli, ERRDOS, ERRbadshare, 
-                                     NT_STATUS_SHARING_VIOLATION);
-       }
-
-       smbcli_close(cli->tree, fnum);
-       smbcli_unlink(cli->tree, fname);
-
-       if (!torture_close_connection(cli)) {
-               correct = False;
-       }
-
-       printf("unlink test finished\n");
-       
-       return correct;
-}
-
-
 /*
 test the timing of deferred open requests
 */
@@ -930,22 +853,21 @@ static BOOL run_deferopen(struct smbcli_state *cli, int dummy)
                int fnum = -1;
 
                do {
-                       struct timeval tv_start, tv_end;
-                       GetTimeOfDay(&tv_start);
-                       fnum = smbcli_nt_create_full(cli->tree, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS,
-                               FILE_ATTRIBUTE_NORMAL, NTCREATEX_SHARE_ACCESS_NONE,
-                               NTCREATEX_DISP_OPEN_IF, 0, 0);
+                       struct timeval tv;
+                       tv = timeval_current();
+                       fnum = smbcli_nt_create_full(cli->tree, fname, 0, 
+                                                    SEC_RIGHTS_FILE_ALL,
+                                                    FILE_ATTRIBUTE_NORMAL, 
+                                                    NTCREATEX_SHARE_ACCESS_NONE,
+                                                    NTCREATEX_DISP_OPEN_IF, 0, 0);
                        if (fnum != -1) {
                                break;
                        }
-                       GetTimeOfDay(&tv_end);
                        if (NT_STATUS_EQUAL(smbcli_nt_error(cli->tree),NT_STATUS_SHARING_VIOLATION)) {
-                               /* Sharing violation errors need to be 1 second apart. */
-                               int64_t tdif = usec_time_diff(&tv_end, &tv_start);
-                               if (tdif < 500000 || tdif > 1500000) {
-                                       fprintf(stderr,"Timing incorrect %lld.%lld for share violation\n",
-                                               tdif / (int64_t)1000000, 
-                                               tdif % (int64_t)1000000);
+                               double e = timeval_elapsed(&tv);
+                               if (e < 0.5 || e > 1.5) {
+                                       fprintf(stderr,"Timing incorrect %.2f violation\n",
+                                               e);
                                }
                        }
                } while (NT_STATUS_EQUAL(smbcli_nt_error(cli->tree),NT_STATUS_SHARING_VIOLATION));
@@ -1080,7 +1002,7 @@ static BOOL run_maxfidtest(struct smbcli_state *cli, int dummy)
 }
 
 /* send smb negprot commands, not reading the response */
-static BOOL run_negprot_nowait(int dummy)
+static BOOL run_negprot_nowait(void)
 {
        int i;
        struct smbcli_state *cli, *cli2;
@@ -1098,7 +1020,7 @@ static BOOL run_negprot_nowait(int dummy)
        for (i=0;i<10000;i++) {
                struct smbcli_request *req;
                time_t t1 = time(NULL);
-               req = smb_negprot_send(cli->transport, PROTOCOL_NT1);
+               req = smb_raw_negotiate_send(cli->transport, PROTOCOL_NT1);
                while (req->state == SMBCLI_REQUEST_SEND && time(NULL) < t1+5) {
                        smbcli_transport_process(cli->transport);
                }
@@ -1144,7 +1066,7 @@ static BOOL run_negprot_nowait(int dummy)
 /*
   This checks how the getatr calls works
 */
-static BOOL run_attrtest(int dummy)
+static BOOL run_attrtest(void)
 {
        struct smbcli_state *cli;
        int fnum;
@@ -1215,7 +1137,7 @@ static BOOL run_attrtest(int dummy)
 /*
   This checks a couple of trans2 calls
 */
-static BOOL run_trans2test(int dummy)
+static BOOL run_trans2test(void)
 {
        struct smbcli_state *cli;
        int fnum;
@@ -1325,7 +1247,7 @@ static BOOL run_trans2test(int dummy)
 
        fnum = smbcli_open(cli->tree, fname2, 
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
-       smbcli_write(cli->tree, fnum,  0, (char *)&fnum, 0, sizeof(fnum));
+       smbcli_write(cli->tree, fnum,  0, &fnum, 0, sizeof(fnum));
        smbcli_close(cli->tree, fnum);
        if (NT_STATUS_IS_ERR(smbcli_qpathinfo2(cli->tree, "\\trans2\\", &c_time, &a_time, &m_time2, &w_time, &size, NULL, NULL))) {
                printf("ERROR: qpathinfo2 failed (%s)\n", smbcli_errstr(cli->tree));
@@ -1349,56 +1271,30 @@ static BOOL run_trans2test(int dummy)
 }
 
 
-/*
-  print out server properties
- */
-static BOOL run_properties(int dummy)
-{
-       struct smbcli_state *cli;
-       BOOL correct = True;
-       
-       printf("starting properties test\n");
-       
-       ZERO_STRUCT(cli);
-
-       if (!torture_open_connection(&cli)) {
-               return False;
-       }
-       
-       d_printf("Capabilities 0x%08x\n", cli->transport->negotiate.capabilities);
-
-       if (!torture_close_connection(cli)) {
-               correct = False;
-       }
-
-       return correct;
-}
-
-
 
 /* FIRST_DESIRED_ACCESS   0xf019f */
-#define FIRST_DESIRED_ACCESS   SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA|SA_RIGHT_FILE_APPEND_DATA|\
-                               SA_RIGHT_FILE_READ_EA|                           /* 0xf */ \
-                               SA_RIGHT_FILE_WRITE_EA|SA_RIGHT_FILE_READ_ATTRIBUTES|     /* 0x90 */ \
-                               SA_RIGHT_FILE_WRITE_ATTRIBUTES|                  /* 0x100 */ \
-                               STD_RIGHT_DELETE_ACCESS|STD_RIGHT_READ_CONTROL_ACCESS|\
-                               STD_RIGHT_WRITE_DAC_ACCESS|STD_RIGHT_WRITE_OWNER_ACCESS     /* 0xf0000 */
+#define FIRST_DESIRED_ACCESS   SEC_FILE_READ_DATA|SEC_FILE_WRITE_DATA|SEC_FILE_APPEND_DATA|\
+                               SEC_FILE_READ_EA|                           /* 0xf */ \
+                               SEC_FILE_WRITE_EA|SEC_FILE_READ_ATTRIBUTE|     /* 0x90 */ \
+                               SEC_FILE_WRITE_ATTRIBUTE|                  /* 0x100 */ \
+                               SEC_STD_DELETE|SEC_STD_READ_CONTROL|\
+                               SEC_STD_WRITE_DAC|SEC_STD_WRITE_OWNER     /* 0xf0000 */
 /* SECOND_DESIRED_ACCESS  0xe0080 */
-#define SECOND_DESIRED_ACCESS  SA_RIGHT_FILE_READ_ATTRIBUTES|                   /* 0x80 */ \
-                               STD_RIGHT_READ_CONTROL_ACCESS|STD_RIGHT_WRITE_DAC_ACCESS|\
-                               STD_RIGHT_WRITE_OWNER_ACCESS                      /* 0xe0000 */
+#define SECOND_DESIRED_ACCESS  SEC_FILE_READ_ATTRIBUTE|                   /* 0x80 */ \
+                               SEC_STD_READ_CONTROL|SEC_STD_WRITE_DAC|\
+                               SEC_STD_WRITE_OWNER                      /* 0xe0000 */
 
 #if 0
-#define THIRD_DESIRED_ACCESS   FILE_READ_ATTRIBUTES|                   /* 0x80 */ \
-                               READ_CONTROL_ACCESS|WRITE_DAC_ACCESS|\
-                               SA_RIGHT_FILE_READ_DATA|\
-                               WRITE_OWNER_ACCESS                      /* */
+#define THIRD_DESIRED_ACCESS   FILE_READ_ATTRIBUTE|                   /* 0x80 */ \
+                               READ_CONTROL|WRITE_DAC|\
+                               SEC_FILE_READ_DATA|\
+                               WRITE_OWNER                      /* */
 #endif
 
 /*
   Test ntcreate calls made by xcopy
  */
-static BOOL run_xcopy(int dummy)
+static BOOL run_xcopy(void)
 {
        struct smbcli_state *cli1;
        const char *fname = "\\test.txt";
@@ -1412,9 +1308,11 @@ static BOOL run_xcopy(int dummy)
        }
        
        fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0,
-                                  FIRST_DESIRED_ACCESS, FILE_ATTRIBUTE_ARCHIVE,
-                                  NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 
-                                  0x4044, 0);
+                                     FIRST_DESIRED_ACCESS, 
+                                     FILE_ATTRIBUTE_ARCHIVE,
+                                     NTCREATEX_SHARE_ACCESS_NONE, 
+                                     NTCREATEX_DISP_OVERWRITE_IF, 
+                                     0x4044, 0);
 
        if (fnum1 == -1) {
                printf("First open failed - %s\n", smbcli_errstr(cli1->tree));
@@ -1441,7 +1339,7 @@ static BOOL run_xcopy(int dummy)
 /*
   see how many RPC pipes we can open at once
 */
-static BOOL run_pipe_number(int dummy)
+static BOOL run_pipe_number(void)
 {
        struct smbcli_state *cli1;
        const char *pipe_name = "\\WKSSVC";
@@ -1454,7 +1352,7 @@ static BOOL run_pipe_number(int dummy)
        }
 
        while(1) {
-               fnum = smbcli_nt_create_full(cli1->tree, pipe_name, 0, SA_RIGHT_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
+               fnum = smbcli_nt_create_full(cli1->tree, pipe_name, 0, SEC_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
                if (fnum == -1) {
@@ -1479,7 +1377,7 @@ static BOOL run_pipe_number(int dummy)
   used for testing performance when there are N idle users
   already connected
  */
- static BOOL torture_holdcon(int dummy)
+ static BOOL torture_holdcon(void)
 {
        int i;
        struct smbcli_state **cli;
@@ -1487,7 +1385,7 @@ static BOOL run_pipe_number(int dummy)
 
        printf("Opening %d connections\n", torture_numops);
        
-       cli = malloc(sizeof(struct smbcli_state *) * torture_numops);
+       cli = malloc_array_p(struct smbcli_state *, torture_numops);
 
        for (i=0;i<torture_numops;i++) {
                if (!torture_open_connection(&cli[i])) {
@@ -1529,7 +1427,7 @@ static BOOL run_pipe_number(int dummy)
   Try with a wrong vuid and check error message.
  */
 
-static BOOL run_vuidtest(int dummy)
+static BOOL run_vuidtest(void)
 {
        struct smbcli_state *cli;
        const char *fname = "\\vuid.tst";
@@ -1595,13 +1493,13 @@ static BOOL run_vuidtest(int dummy)
 /*
   Test open mode returns on read-only files.
  */
- static BOOL run_opentest(int dummy)
+ static BOOL run_opentest(void)
 {
        static struct smbcli_state *cli1;
        static struct smbcli_state *cli2;
        const char *fname = "\\readonly.file";
        int fnum1, fnum2;
-       char buf[20];
+       uint8_t buf[20];
        size_t fsize;
        BOOL correct = True;
        char *tmp_path;
@@ -1771,7 +1669,7 @@ error_test4:
        
        printf("TEST #1 testing 2 non-io opens (no delete)\n");
        
-       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
@@ -1780,7 +1678,7 @@ error_test4:
                return False;
        }
 
-       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
        if (fnum2 == -1) {
                printf("test 1 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
@@ -1803,7 +1701,7 @@ error_test10:
 
        printf("TEST #2 testing 2 non-io opens (first with delete)\n");
        
-       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
@@ -1812,7 +1710,7 @@ error_test10:
                return False;
        }
 
-       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
@@ -1836,7 +1734,7 @@ error_test20:
 
        printf("TEST #3 testing 2 non-io opens (second with delete)\n");
        
-       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
@@ -1845,7 +1743,7 @@ error_test20:
                return False;
        }
 
-       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
@@ -1869,7 +1767,7 @@ error_test30:
 
        printf("TEST #4 testing 2 non-io opens (both with delete)\n");
        
-       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
@@ -1878,7 +1776,7 @@ error_test30:
                return False;
        }
 
-       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 != -1) {
@@ -1900,7 +1798,7 @@ error_test40:
 
        printf("TEST #5 testing 2 non-io opens (both with delete - both with file share delete)\n");
        
-       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
@@ -1909,7 +1807,7 @@ error_test40:
                return False;
        }
 
-       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
@@ -1934,7 +1832,7 @@ error_test50:
        
        smbcli_unlink(cli1->tree, fname);
 
-       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
@@ -1943,7 +1841,7 @@ error_test50:
                return False;
        }
 
-       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_READ, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
@@ -1968,7 +1866,7 @@ error_test60:
 
        smbcli_unlink(cli1->tree, fname);
 
-       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
@@ -1977,7 +1875,7 @@ error_test60:
                return False;
        }
 
-       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 != -1) {
@@ -2082,238 +1980,10 @@ error_test80:
 }
 
 
-static uint32_t open_attrs_table[] = {
-               FILE_ATTRIBUTE_NORMAL,
-               FILE_ATTRIBUTE_ARCHIVE,
-               FILE_ATTRIBUTE_READONLY,
-               FILE_ATTRIBUTE_HIDDEN,
-               FILE_ATTRIBUTE_SYSTEM,
-
-               FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY,
-               FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN,
-               FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM,
-               FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN,
-               FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_SYSTEM,
-               FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN|FILE_ATTRIBUTE_SYSTEM,
-
-               FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN,
-               FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_SYSTEM,
-               FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN|FILE_ATTRIBUTE_SYSTEM,
-               FILE_ATTRIBUTE_HIDDEN,FILE_ATTRIBUTE_SYSTEM,
-};
-
-struct trunc_open_results {
-       uint_t num;
-       uint32_t init_attr;
-       uint32_t trunc_attr;
-       uint32_t result_attr;
-};
-
-static struct trunc_open_results attr_results[] = {
-       { 0, FILE_ATTRIBUTE_NORMAL, FILE_ATTRIBUTE_NORMAL, FILE_ATTRIBUTE_ARCHIVE },
-       { 1, FILE_ATTRIBUTE_NORMAL, FILE_ATTRIBUTE_ARCHIVE, FILE_ATTRIBUTE_ARCHIVE },
-       { 2, FILE_ATTRIBUTE_NORMAL, FILE_ATTRIBUTE_READONLY, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY },
-       { 16, FILE_ATTRIBUTE_ARCHIVE, FILE_ATTRIBUTE_NORMAL, FILE_ATTRIBUTE_ARCHIVE },
-       { 17, FILE_ATTRIBUTE_ARCHIVE, FILE_ATTRIBUTE_ARCHIVE, FILE_ATTRIBUTE_ARCHIVE },
-       { 18, FILE_ATTRIBUTE_ARCHIVE, FILE_ATTRIBUTE_READONLY, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY },
-       { 51, FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN },
-       { 54, FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN },
-       { 56, FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN },
-       { 68, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM },
-       { 71, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM },
-       { 73, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_SYSTEM },
-       { 99, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_HIDDEN,FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN },
-       { 102, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN },
-       { 104, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN },
-       { 116, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM },
-       { 119,  FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM,  FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM },
-       { 121, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_SYSTEM },
-       { 170, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM|FILE_ATTRIBUTE_HIDDEN },
-       { 173, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN|FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN|FILE_ATTRIBUTE_SYSTEM },
-       { 227, FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN },
-       { 230, FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_HIDDEN },
-       { 232, FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_HIDDEN },
-       { 244, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM },
-       { 247, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_SYSTEM },
-       { 249, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_ARCHIVE|FILE_ATTRIBUTE_READONLY|FILE_ATTRIBUTE_SYSTEM }
-};
-
-static BOOL run_openattrtest(int dummy)
-{
-       struct smbcli_state *cli1;
-       const char *fname = "\\openattr.file";
-       int fnum1;
-       BOOL correct = True;
-       uint16_t attr;
-       uint_t i, j, k, l;
-       int failures = 0;
-
-       printf("starting open attr test\n");
-       
-       if (!torture_open_connection(&cli1)) {
-               return False;
-       }
-       
-       for (k = 0, i = 0; i < sizeof(open_attrs_table)/sizeof(uint32_t); i++) {
-               smbcli_setatr(cli1->tree, fname, 0, 0);
-               smbcli_unlink(cli1->tree, fname);
-               fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_WRITE_DATA, open_attrs_table[i],
-                                  NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
-
-               if (fnum1 == -1) {
-                       printf("open %d (1) of %s failed (%s)\n", i, fname, smbcli_errstr(cli1->tree));
-                       return False;
-               }
-
-               if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-                       printf("close %d (1) of %s failed (%s)\n", i, fname, smbcli_errstr(cli1->tree));
-                       return False;
-               }
-
-               for (j = 0; j < ARRAY_SIZE(open_attrs_table); j++) {
-                       fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, 
-                                                  SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA, 
-                                                  open_attrs_table[j],
-                                                  NTCREATEX_SHARE_ACCESS_NONE, 
-                                                  NTCREATEX_DISP_OVERWRITE, 0, 0);
-
-                       if (fnum1 == -1) {
-                               for (l = 0; l < ARRAY_SIZE(attr_results); l++) {
-                                       if (attr_results[l].num == k) {
-                                               printf("[%d] trunc open 0x%x -> 0x%x of %s failed - should have succeeded !(0x%x:%s)\n",
-                                                               k, open_attrs_table[i],
-                                                               open_attrs_table[j],
-                                                               fname, NT_STATUS_V(smbcli_nt_error(cli1->tree)), smbcli_errstr(cli1->tree));
-                                               correct = False;
-                                               CHECK_MAX_FAILURES(error_exit);
-                                       }
-                               }
-                               if (NT_STATUS_V(smbcli_nt_error(cli1->tree)) != NT_STATUS_V(NT_STATUS_ACCESS_DENIED)) {
-                                       printf("[%d] trunc open 0x%x -> 0x%x failed with wrong error code %s\n",
-                                                       k, open_attrs_table[i], open_attrs_table[j],
-                                                       smbcli_errstr(cli1->tree));
-                                       correct = False;
-                                       CHECK_MAX_FAILURES(error_exit);
-                               }
-#if 0
-                               printf("[%d] trunc open 0x%x -> 0x%x failed\n", k, open_attrs_table[i], open_attrs_table[j]);
-#endif
-                               k++;
-                               continue;
-                       }
-
-                       if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-                               printf("close %d (2) of %s failed (%s)\n", j, fname, smbcli_errstr(cli1->tree));
-                               return False;
-                       }
-
-                       if (NT_STATUS_IS_ERR(smbcli_getatr(cli1->tree, fname, &attr, NULL, NULL))) {
-                               printf("getatr(2) failed (%s)\n", smbcli_errstr(cli1->tree));
-                               return False;
-                       }
-
-#if 0
-                       printf("[%d] getatr check [0x%x] trunc [0x%x] got attr 0x%x\n",
-                                       k,  open_attrs_table[i],  open_attrs_table[j], attr );
-#endif
-
-                       for (l = 0; l < ARRAY_SIZE(attr_results); l++) {
-                               if (attr_results[l].num == k) {
-                                       if (attr != attr_results[l].result_attr ||
-                                                       open_attrs_table[i] != attr_results[l].init_attr ||
-                                                       open_attrs_table[j] != attr_results[l].trunc_attr) {
-                                               printf("[%d] getatr check failed. [0x%x] trunc [0x%x] got attr 0x%x, should be 0x%x\n",
-                                                       k, open_attrs_table[i],
-                                                       open_attrs_table[j],
-                                                       (uint_t)attr,
-                                                       attr_results[l].result_attr);
-                                               correct = False;
-                                               CHECK_MAX_FAILURES(error_exit);
-                                       }
-                                       break;
-                               }
-                       }
-                       k++;
-               }
-       }
-error_exit:
-       smbcli_setatr(cli1->tree, fname, 0, 0);
-       smbcli_unlink(cli1->tree, fname);
-
-       printf("open attr test %s.\n", correct ? "passed" : "failed");
-
-       if (!torture_close_connection(cli1)) {
-               correct = False;
-       }
-       return correct;
-}
-
-static void list_fn(file_info *finfo, const char *name, void *state)
-{
-       
-}
-
-/*
-  test directory listing speed
- */
-static BOOL run_dirtest(int dummy)
-{
-       int i;
-       struct smbcli_state *cli;
-       int fnum;
-       double t1;
-       BOOL correct = True;
-
-       printf("starting directory test\n");
-
-       if (!torture_open_connection(&cli)) {
-               return False;
-       }
-
-       printf("Creating %d random filenames\n", torture_numops);
-
-       srandom(0);
-       for (i=0;i<torture_numops;i++) {
-               char *fname;
-               asprintf(&fname, "\\%x", (int)random());
-               fnum = smbcli_open(cli->tree, fname, O_RDWR|O_CREAT, DENY_NONE);
-               if (fnum == -1) {
-                       fprintf(stderr,"Failed to open %s\n", fname);
-                       return False;
-               }
-               smbcli_close(cli->tree, fnum);
-               free(fname);
-       }
-
-       t1 = end_timer();
-
-       printf("Matched %d\n", smbcli_list(cli->tree, "a*.*", 0, list_fn, NULL));
-       printf("Matched %d\n", smbcli_list(cli->tree, "b*.*", 0, list_fn, NULL));
-       printf("Matched %d\n", smbcli_list(cli->tree, "xyzabc", 0, list_fn, NULL));
-
-       printf("dirtest core %g seconds\n", end_timer() - t1);
-
-       srandom(0);
-       for (i=0;i<torture_numops;i++) {
-               char *fname;
-               asprintf(&fname, "\\%x", (int)random());
-               smbcli_unlink(cli->tree, fname);
-               free(fname);
-       }
-
-       if (!torture_close_connection(cli)) {
-               correct = False;
-       }
-
-       printf("finished dirtest\n");
-
-       return correct;
-}
-
 /*
   sees what IOCTLs are supported
  */
-BOOL torture_ioctl_test(int dummy)
+BOOL torture_ioctl_test(void)
 {
        struct smbcli_state *cli;
        uint16_t device, function;
@@ -2369,7 +2039,7 @@ BOOL torture_ioctl_test(int dummy)
 /*
   tries variants of chkpath
  */
-BOOL torture_chkpath_test(int dummy)
+BOOL torture_chkpath_test(void)
 {
        struct smbcli_state *cli;
        int fnum;
@@ -2450,178 +2120,8 @@ BOOL torture_chkpath_test(int dummy)
        return ret;
 }
 
-static BOOL run_dirtest1(int dummy)
-{
-       int i;
-       struct smbcli_state *cli;
-       int fnum, num_seen;
-       BOOL correct = True;
-
-       printf("starting directory test\n");
-
-       if (!torture_open_connection(&cli)) {
-               return False;
-       }
-
-       if (smbcli_deltree(cli->tree, "\\LISTDIR") == -1) {
-               fprintf(stderr,"Failed to deltree %s, error=%s\n", "\\LISTDIR", smbcli_errstr(cli->tree));
-               return False;
-       }
-       if (NT_STATUS_IS_ERR(smbcli_mkdir(cli->tree, "\\LISTDIR"))) {
-               fprintf(stderr,"Failed to mkdir %s, error=%s\n", "\\LISTDIR", smbcli_errstr(cli->tree));
-               return False;
-       }
-
-       printf("Creating %d files\n", torture_entries);
-
-       /* Create torture_entries files and torture_entries directories. */
-       for (i=0;i<torture_entries;i++) {
-               char *fname;
-               asprintf(&fname, "\\LISTDIR\\f%d", i);
-               fnum = smbcli_nt_create_full(cli->tree, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS, FILE_ATTRIBUTE_ARCHIVE,
-                                  NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
-               if (fnum == -1) {
-                       fprintf(stderr,"Failed to open %s, error=%s\n", fname, smbcli_errstr(cli->tree));
-                       return False;
-               }
-               free(fname);
-               smbcli_close(cli->tree, fnum);
-       }
-       for (i=0;i<torture_entries;i++) {
-               char *fname;
-               asprintf(&fname, "\\LISTDIR\\d%d", i);
-               if (NT_STATUS_IS_ERR(smbcli_mkdir(cli->tree, fname))) {
-                       fprintf(stderr,"Failed to open %s, error=%s\n", fname, smbcli_errstr(cli->tree));
-                       return False;
-               }
-               free(fname);
-       }
-
-       /* Now ensure that doing an old list sees both files and directories. */
-       num_seen = smbcli_list_old(cli->tree, "\\LISTDIR\\*", FILE_ATTRIBUTE_DIRECTORY, list_fn, NULL);
-       printf("num_seen = %d\n", num_seen );
-       /* We should see (torture_entries) each of files & directories + . and .. */
-       if (num_seen != (2*torture_entries)+2) {
-               correct = False;
-               fprintf(stderr,"entry count mismatch, should be %d, was %d\n",
-                       (2*torture_entries)+2, num_seen);
-       }
-               
-
-       /* Ensure if we have the "must have" bits we only see the
-        * relevant entries.
-        */
-       num_seen = smbcli_list_old(cli->tree, "\\LISTDIR\\*", (FILE_ATTRIBUTE_DIRECTORY<<8)|FILE_ATTRIBUTE_DIRECTORY, list_fn, NULL);
-       printf("num_seen = %d\n", num_seen );
-       if (num_seen != torture_entries+2) {
-               correct = False;
-               fprintf(stderr,"entry count mismatch, should be %d, was %d\n",
-                       torture_entries+2, num_seen);
-       }
-
-       num_seen = smbcli_list_old(cli->tree, "\\LISTDIR\\*", (FILE_ATTRIBUTE_ARCHIVE<<8)|FILE_ATTRIBUTE_DIRECTORY, list_fn, NULL);
-       printf("num_seen = %d\n", num_seen );
-       if (num_seen != torture_entries) {
-               correct = False;
-               fprintf(stderr,"entry count mismatch, should be %d, was %d\n",
-                       torture_entries, num_seen);
-       }
-
-       /* Delete everything. */
-       if (smbcli_deltree(cli->tree, "\\LISTDIR") == -1) {
-               fprintf(stderr,"Failed to deltree %s, error=%s\n", "\\LISTDIR", smbcli_errstr(cli->tree));
-               return False;
-       }
-
-#if 0
-       printf("Matched %d\n", smbcli_list(cli->tree, "a*.*", 0, list_fn, NULL));
-       printf("Matched %d\n", smbcli_list(cli->tree, "b*.*", 0, list_fn, NULL));
-       printf("Matched %d\n", smbcli_list(cli->tree, "xyzabc", 0, list_fn, NULL));
-#endif
-
-       if (!torture_close_connection(cli)) {
-               correct = False;
-       }
-
-       printf("finished dirtest1\n");
-
-       return correct;
-}
-
 
-/*
-   simple test harness for playing with deny modes
- */
-static BOOL run_deny3test(int dummy)
-{
-       struct smbcli_state *cli1, *cli2;
-       int fnum1, fnum2;
-       const char *fname;
-
-       printf("starting deny3 test\n");
-
-       printf("Testing simple deny modes\n");
-       
-       if (!torture_open_connection(&cli1)) {
-               return False;
-       }
-       if (!torture_open_connection(&cli2)) {
-               return False;
-       }
-
-       fname = "\\deny_dos1.dat";
-
-       smbcli_unlink(cli1->tree, fname);
-       fnum1 = smbcli_open(cli1->tree, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
-       fnum2 = smbcli_open(cli1->tree, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
-       if (fnum1 != -1) smbcli_close(cli1->tree, fnum1);
-       if (fnum2 != -1) smbcli_close(cli1->tree, fnum2);
-       smbcli_unlink(cli1->tree, fname);
-       printf("fnum1=%d fnum2=%d\n", fnum1, fnum2);
-
-
-       fname = "\\deny_dos2.dat";
-
-       smbcli_unlink(cli1->tree, fname);
-       fnum1 = smbcli_open(cli1->tree, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
-       fnum2 = smbcli_open(cli2->tree, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
-       if (fnum1 != -1) smbcli_close(cli1->tree, fnum1);
-       if (fnum2 != -1) smbcli_close(cli2->tree, fnum2);
-       smbcli_unlink(cli1->tree, fname);
-       printf("fnum1=%d fnum2=%d\n", fnum1, fnum2);
-
-
-       torture_close_connection(cli1);
-       torture_close_connection(cli2);
-
-       return True;
-}
-
-/*
-  parse a //server/share type UNC name
-*/
-static BOOL parse_unc(const char *unc_name, char **hostname, char **sharename)
-{
-       char *p;
-
-       if (strncmp(unc_name, "//", 2)) {
-               return False;
-       }
-
-       *hostname = strdup(&unc_name[2]);
-       p = strchr_m(&(*hostname)[2],'/');
-       if (!p) {
-               return False;
-       }
-       *p = 0;
-       *sharename = strdup(p+1);
-
-       return True;
-}
-
-
-
-static void sigcont(void)
+static void sigcont(int sig)
 {
 }
 
@@ -2636,6 +2136,9 @@ double torture_create_procs(BOOL (*fn)(struct smbcli_state *, int), BOOL *result
        char **unc_list = NULL;
        const char *p;
        int num_unc_names = 0;
+       struct timeval tv;
+
+       *result = True;
 
        synccount = 0;
 
@@ -2667,16 +2170,16 @@ double torture_create_procs(BOOL (*fn)(struct smbcli_state *, int), BOOL *result
                child_status_out[i] = True;
        }
 
-       start_timer();
+       tv = timeval_current();
 
        for (i=0;i<torture_nprocs;i++) {
                procnum = i;
                if (fork() == 0) {
                        char *myname;
-                       char *hostname=NULL, *sharename;
+                       const char *hostname=NULL, *sharename;
 
                        pid_t mypid = getpid();
-                       sys_srandom(((int)mypid) ^ ((int)time(NULL)));
+                       srandom(((int)mypid) ^ ((int)time(NULL)));
 
                        asprintf(&myname, "CLIENT%d", i);
                        lp_set_cmdline("netbios name", myname);
@@ -2684,8 +2187,8 @@ double torture_create_procs(BOOL (*fn)(struct smbcli_state *, int), BOOL *result
 
 
                        if (unc_list) {
-                               if (!parse_unc(unc_list[i % num_unc_names],
-                                              &hostname, &sharename)) {
+                               if (!smbcli_parse_unc(unc_list[i % num_unc_names],
+                                                     NULL, &hostname, &sharename)) {
                                        printf("Failed to parse UNC name %s\n",
                                               unc_list[i % num_unc_names]);
                                        exit(1);
@@ -2731,28 +2234,29 @@ double torture_create_procs(BOOL (*fn)(struct smbcli_state *, int), BOOL *result
                }
                if (synccount == torture_nprocs) break;
                msleep(100);
-       } while (end_timer() < start_time_limit);
+       } while (timeval_elapsed(&tv) < start_time_limit);
 
        if (synccount != torture_nprocs) {
                printf("FAILED TO START %d CLIENTS (started %d)\n", torture_nprocs, synccount);
                *result = False;
-               return end_timer();
+               return timeval_elapsed(&tv);
        }
 
        printf("Starting %d clients\n", torture_nprocs);
 
        /* start the client load */
-       start_timer();
+       tv = timeval_current();
        for (i=0;i<torture_nprocs;i++) {
                child_status[i] = 0;
        }
-       kill(0, SIGCONT);
 
        printf("%d clients started\n", torture_nprocs);
 
+       kill(0, SIGCONT);
+
        for (i=0;i<torture_nprocs;i++) {
                int ret;
-               while ((ret=waitpid(0, &status, 0)) == -1 && errno == EINTR) /* noop */ ;
+               while ((ret=sys_waitpid(0, &status, 0)) == -1 && errno == EINTR) /* noop */ ;
                if (ret == -1 || WEXITSTATUS(status) != 0) {
                        *result = False;
                }
@@ -2765,15 +2269,15 @@ double torture_create_procs(BOOL (*fn)(struct smbcli_state *, int), BOOL *result
                        *result = False;
                }
        }
-       return end_timer();
+       return timeval_elapsed(&tv);
 }
 
 #define FLAG_MULTIPROC 1
 
 static struct {
        const char *name;
-       BOOL (*fn)(int);
-       uint_t flags;
+       BOOL (*fn)(void);
+       BOOL (*multi_fn)(struct smbcli_state *, int );
 } torture_ops[] = {
        /* base tests */
        {"BASE-FDPASS", run_fdpasstest, 0},
@@ -2784,36 +2288,44 @@ static struct {
        {"BASE-LOCK5",  torture_locktest5,  0},
        {"BASE-LOCK6",  torture_locktest6,  0},
        {"BASE-LOCK7",  torture_locktest7,  0},
-       {"BASE-UNLINK", run_unlinktest, 0},
+       {"BASE-UNLINK", torture_unlinktest, 0},
        {"BASE-ATTR",   run_attrtest,   0},
        {"BASE-TRANS2", run_trans2test, 0},
        {"BASE-NEGNOWAIT", run_negprot_nowait, 0},
-       {"BASE-DIR",  run_dirtest, 0},
-       {"BASE-DIR1",  run_dirtest1, 0},
+       {"BASE-DIR1",  torture_dirtest1, 0},
+       {"BASE-DIR2",  torture_dirtest2, 0},
        {"BASE-DENY1",  torture_denytest1, 0},
        {"BASE-DENY2",  torture_denytest2, 0},
+       {"BASE-DENY3",  torture_denytest3, 0},
+       {"BASE-DENYDOS",  torture_denydos_sharing, 0},
+       {"BASE-NTDENY1",  NULL, torture_ntdenytest1},
+       {"BASE-NTDENY2",  torture_ntdenytest2, 0},
        {"BASE-TCON",  run_tcon_test, 0},
        {"BASE-TCONDEV",  run_tcon_devtype_test, 0},
        {"BASE-VUID", run_vuidtest, 0},
        {"BASE-RW1",  run_readwritetest, 0},
-       {"BASE-RW2",  run_readwritemulti, FLAG_MULTIPROC},
+       {"BASE-RW2",  NULL, run_readwritemulti},
        {"BASE-OPEN", run_opentest, 0},
-       {"BASE-DENY3", run_deny3test, 0},
-       {"BASE-DEFER_OPEN", run_deferopen, FLAG_MULTIPROC},
+       {"BASE-DEFER_OPEN", NULL, run_deferopen},
        {"BASE-XCOPY", run_xcopy, 0},
        {"BASE-RENAME", torture_test_rename, 0},
        {"BASE-DELETE", torture_test_delete, 0},
-       {"BASE-PROPERTIES", run_properties, 0},
+       {"BASE-PROPERTIES", torture_test_properties, 0},
        {"BASE-MANGLE", torture_mangle, 0},
-       {"BASE-OPENATTR", run_openattrtest, 0},
+       {"BASE-OPENATTR", torture_openattrtest, 0},
        {"BASE-CHARSET", torture_charset, 0},
        {"BASE-CHKPATH",  torture_chkpath_test, 0},
        {"BASE-SECLEAK",  torture_sec_leak, 0},
+       {"BASE-DISCONNECT",  torture_disconnect, 0},
+       {"BASE-DELAYWRITE", torture_delay_write, 0},
 
        /* benchmarking tests */
        {"BENCH-HOLDCON",  torture_holdcon, 0},
        {"BENCH-NBENCH",  torture_nbench, 0},
-       {"BENCH-TORTURE",run_torture,    FLAG_MULTIPROC},
+       {"BENCH-TORTURE", NULL, run_torture},
+       {"BENCH-NBT",     torture_bench_nbt, 0},
+       {"BENCH-WINS",    torture_bench_wins, 0},
+       {"BENCH-RPC",     torture_bench_rpc, 0},
 
        /* RAW smb tests */
        {"RAW-QFSINFO", torture_raw_qfsinfo, 0},
@@ -2836,18 +2348,23 @@ static struct {
        {"RAW-CONTEXT", torture_raw_context, 0},
        {"RAW-RENAME", torture_raw_rename, 0},
        {"RAW-SEEK", torture_raw_seek, 0},
+       {"RAW-EAS", torture_raw_eas, 0},
+       {"RAW-STREAMS", torture_raw_streams, 0},
+       {"RAW-ACLS", torture_raw_acls, 0},
        {"RAW-RAP", torture_raw_rap, 0},
+       {"RAW-COMPOSITE", torture_raw_composite, 0},
 
        /* protocol scanners */
        {"SCAN-TRANS2", torture_trans2_scan, 0},
        {"SCAN-NTTRANS", torture_nttrans_scan, 0},
        {"SCAN-ALIASES", torture_trans2_aliases, 0},
        {"SCAN-SMB", torture_smb_scan, 0},
-       {"SCAN-MAXFID", run_maxfidtest, FLAG_MULTIPROC},
+       {"SCAN-MAXFID", NULL, run_maxfidtest},
        {"SCAN-UTABLE", torture_utable, 0},
        {"SCAN-CASETABLE", torture_casetable, 0},
        {"SCAN-PIPE_NUMBER", run_pipe_number, 0},
        {"SCAN-IOCTL",  torture_ioctl_test, 0},
+       {"SCAN-RAP",  torture_rap_scan, 0},
 
        /* rpc testers */
         {"RPC-LSA", torture_rpc_lsa, 0},
@@ -2856,6 +2373,8 @@ static struct {
         {"RPC-SPOOLSS", torture_rpc_spoolss, 0},
         {"RPC-SAMR", torture_rpc_samr, 0},
         {"RPC-NETLOGON", torture_rpc_netlogon, 0},
+        {"RPC-SAMLOGON", torture_rpc_samlogon, 0},
+        {"RPC-SAMSYNC", torture_rpc_samsync, 0},
         {"RPC-SCHANNEL", torture_rpc_schannel, 0},
         {"RPC-WKSSVC", torture_rpc_wkssvc, 0},
         {"RPC-SRVSVC", torture_rpc_srvsvc, 0},
@@ -2864,13 +2383,19 @@ static struct {
         {"RPC-EVENTLOG", torture_rpc_eventlog, 0},
         {"RPC-EPMAPPER", torture_rpc_epmapper, 0},
         {"RPC-WINREG", torture_rpc_winreg, 0},
+        {"RPC-INITSHUTDOWN", torture_rpc_initshutdown, 0},
         {"RPC-OXIDRESOLVE", torture_rpc_oxidresolve, 0},
+        {"RPC-REMACT", torture_rpc_remact, 0},
         {"RPC-MGMT", torture_rpc_mgmt, 0},
         {"RPC-SCANNER", torture_rpc_scanner, 0},
         {"RPC-AUTOIDL", torture_rpc_autoidl, 0},
         {"RPC-COUNTCALLS", torture_rpc_countcalls, 0},
        {"RPC-MULTIBIND", torture_multi_bind, 0},
        {"RPC-DRSUAPI", torture_rpc_drsuapi, 0},
+       {"RPC-LOGIN", torture_rpc_login, 0},
+       {"RPC-ROT", torture_rpc_rot, 0},
+       {"RPC-DSSETUP", torture_rpc_dssetup, 0},
+        {"RPC-ALTERCONTEXT", torture_rpc_alter_context, 0},
 
        /* local (no server) testers */
        {"LOCAL-NTLMSSP", torture_ntlmssp_self_check, 0},
@@ -2879,9 +2404,25 @@ static struct {
        {"LOCAL-MESSAGING", torture_local_messaging, 0},
        {"LOCAL-BINDING", torture_local_binding_string, 0},
        {"LOCAL-IDTREE", torture_local_idtree, 0},
+       {"LOCAL-SOCKET", torture_local_socket, 0},
+
+       /* COM (Component Object Model) testers */
+       {"COM-SIMPLE", torture_com_simple, 0 },
 
        /* ldap testers */
        {"LDAP-BASIC", torture_ldap_basic, 0},
+       {"LDAP-CLDAP", torture_cldap, 0},
+
+       /* nbt tests */
+       {"NBT-REGISTER", torture_nbt_register, 0},
+       {"NBT-WINS", torture_nbt_wins, 0},
+       {"NBT-WINSREPLICATION", torture_nbt_winsreplication, 0},
+       {"NBT-DGRAM", torture_nbt_dgram, 0},
+       
+       /* libnet tests */
+       {"NET-USERINFO", torture_userinfo, 0},
+       {"NET-USERADD", torture_useradd, 0},
+       {"NET-USERDEL", torture_userdel, 0},
 
        {NULL, NULL, 0}};
 
@@ -2911,21 +2452,22 @@ static BOOL run_test(const char *name)
                        matched = True;
                        init_iconv();
                        printf("Running %s\n", torture_ops[i].name);
-                       if (torture_ops[i].flags & FLAG_MULTIPROC) {
-                               BOOL result;
-                               t = torture_create_procs(torture_ops[i].fn, &result);
+                       if (torture_ops[i].multi_fn) {
+                               BOOL result = False;
+                               t = torture_create_procs(torture_ops[i].multi_fn, 
+                                                        &result);
                                if (!result) { 
                                        ret = False;
                                        printf("TEST %s FAILED!\n", torture_ops[i].name);
                                }
                                         
                        } else {
-                               start_timer();
-                               if (!torture_ops[i].fn(0)) {
+                               struct timeval tv = timeval_current();
+                               if (!torture_ops[i].fn()) {
                                        ret = False;
                                        printf("TEST %s FAILED!\n", torture_ops[i].name);
                                }
-                               t = end_timer();
+                               t = timeval_elapsed(&tv);
                        }
                        printf("%s took %g secs\n\n", torture_ops[i].name, t);
                }
@@ -2987,6 +2529,50 @@ static void usage(poptContext pc)
        poptPrintUsage(pc, stdout, 0);
        printf("\n");
 
+       printf("The binding format is:\n\n");
+
+       printf("  TRANSPORT:host[flags]\n\n");
+
+       printf("  where TRANSPORT is either ncacn_np for SMB or ncacn_ip_tcp for RPC/TCP\n\n");
+
+       printf("  'host' is an IP or hostname or netbios name. If the binding string\n");
+       printf("  identifies the server side of an endpoint, 'host' may be an empty\n");
+       printf("  string.\n\n");
+
+       printf("  'flags' can include a SMB pipe name if using the ncacn_np transport or\n");
+       printf("  a TCP port number if using the ncacn_ip_tcp transport, otherwise they\n");
+       printf("  will be auto-determined.\n\n");
+
+       printf("  other recognised flags are:\n\n");
+
+       printf("    sign : enable ntlmssp signing\n");
+       printf("    seal : enable ntlmssp sealing\n");
+       printf("    connect : enable rpc connect level auth (auth, but no sign or seal)\n");
+       printf("    validate: enable the NDR validator\n");
+       printf("    print: enable debugging of the packets\n");
+       printf("    bigendian: use bigendian RPC\n");
+       printf("    padcheck: check reply data for non-zero pad bytes\n\n");
+
+       printf("  For example, these all connect to the samr pipe:\n\n");
+
+       printf("    ncacn_np:myserver\n");
+       printf("    ncacn_np:myserver[samr]\n");
+       printf("    ncacn_np:myserver[\\pipe\\samr]\n");
+       printf("    ncacn_np:myserver[/pipe/samr]\n");
+       printf("    ncacn_np:myserver[samr,sign,print]\n");
+       printf("    ncacn_np:myserver[\\pipe\\samr,sign,seal,bigendian]\n");
+       printf("    ncacn_np:myserver[/pipe/samr,seal,validate]\n");
+       printf("    ncacn_np:\n");
+       printf("    ncacn_np:[/pipe/samr]\n\n");
+
+       printf("    ncacn_ip_tcp:myserver\n");
+       printf("    ncacn_ip_tcp:myserver[1024]\n");
+       printf("    ncacn_ip_tcp:myserver[1024,sign,seal]\n\n");
+
+       printf("The unc format is:\n\n");
+
+       printf("    //server/share\n\n");
+
        printf("tests are:");
        for (i=0;torture_ops[i].name;i++) {
                if ((i%perline)==0) {
@@ -2997,19 +2583,19 @@ static void usage(poptContext pc)
        printf("\n\n");
 
        printf("default test is ALL\n");
-       
+
        exit(1);
 }
 
 static BOOL is_binding_string(const char *binding_string)
 {
        TALLOC_CTX *mem_ctx = talloc_init("is_binding_string");
-       struct dcerpc_binding binding_struct;
+       struct dcerpc_binding *binding_struct;
        NTSTATUS status;
        
        status = dcerpc_parse_binding(mem_ctx, binding_string, &binding_struct);
 
-       talloc_destroy(mem_ctx);
+       talloc_free(mem_ctx);
        return NT_STATUS_IS_OK(status);
 }
 
@@ -3028,7 +2614,7 @@ static BOOL is_binding_string(const char *binding_string)
        struct poptOption long_options[] = {
                POPT_AUTOHELP
                {"smb-ports",   'p', POPT_ARG_STRING, NULL,             0,      "SMB ports",    NULL},
-               {"seed",          0, POPT_ARG_STRING, NULL,             0,      "seed",         NULL},
+               {"seed",          0, POPT_ARG_INT,  &torture_seed,      0,      "seed",         NULL},
                {"num-progs",     0, POPT_ARG_INT,  &torture_nprocs,    0,      "num progs",    NULL},
                {"num-ops",       0, POPT_ARG_INT,  &torture_numops,    0,      "num ops",      NULL},
                {"entries",       0, POPT_ARG_INT,  &torture_entries,   0,      "entries",      NULL},
@@ -3054,7 +2640,7 @@ static BOOL is_binding_string(const char *binding_string)
 #endif
 
        pc = poptGetContext("smbtorture", argc, (const char **) argv, long_options, 
-                               POPT_CONTEXT_KEEP_FIRST);
+                           POPT_CONTEXT_KEEP_FIRST);
 
        poptSetOtherOptionHelp(pc, "<binding>|<unc> TEST1 TEST2 ...");
 
@@ -3073,7 +2659,7 @@ static BOOL is_binding_string(const char *binding_string)
                        parse_dns(poptGetOptArg(pc));
                        break;
                case OPT_DANGEROUS:
-                       lp_set_cmdline("torture:dangerous", "1");
+                       lp_set_cmdline("torture:dangerous", "Yes");
                        break;
                default:
                        d_printf("Invalid option %s: %s\n", 
@@ -3085,9 +2671,17 @@ static BOOL is_binding_string(const char *binding_string)
 
        lp_load(dyn_CONFIGFILE,True,False,False);
        load_interfaces();
-       srandom(time(NULL));
 
-       argv_new = (const char **)poptGetArgs(pc);
+       smbtorture_init_subsystems;
+
+
+       if (torture_seed == 0) {
+               torture_seed = time(NULL);
+       } 
+       printf("Using seed %d\n", torture_seed);
+       srandom(torture_seed);
+
+       argv_new = discard_const_p(char *, poptGetArgs(pc));
 
        argc_new = argc;
        for (i=0; i<argc; i++) {
@@ -3112,9 +2706,10 @@ static BOOL is_binding_string(const char *binding_string)
                lp_set_cmdline("torture:binding", argv_new[1]);
        } else {
                char *binding = NULL;
-               char *host = NULL, *share = NULL;
+               const char *host = NULL, *share = NULL;
 
-               if (!parse_unc(argv_new[1], &host, &share)) {
+               if (!smbcli_parse_unc(argv_new[1], NULL, &host, &share)) {
+                       d_printf("Invalid option: %s is not a valid torture target (share or binding string)\n\n", argv_new[1]);
                        usage(pc);
                }
 
@@ -3124,25 +2719,6 @@ static BOOL is_binding_string(const char *binding_string)
                lp_set_cmdline("torture:binding", binding);
        }
 
-       if (!lp_parm_string(-1,"torture","username")) {
-               lp_set_cmdline("torture:username", cmdline_get_username());
-       }
-       if (!lp_parm_string(-1,"torture","userdomain")) {
-               /* 
-                * backward compatibility
-                * maybe we should remove this to make this consistent
-                * for all cmdline tools
-                * --metze
-                */
-               if (strequal(lp_netbios_name(),cmdline_get_userdomain())) {
-                       cmdline_set_userdomain(lp_workgroup());
-               }
-               lp_set_cmdline("torture:userdomain", cmdline_get_userdomain());
-       }
-       if (!lp_parm_string(-1,"torture","password")) {
-               lp_set_cmdline("torture:password", cmdline_get_userpassword());
-       }
-
        if (argc_new == 0) {
                printf("You must specify a test to run, or 'ALL'\n");
        } else {