[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.
[sfrench/samba-autobuild/.git] / source3 / passdb / secrets.c
index f6b1ece7d4c7e33e08c7dbbf6bf013c2fad5a710..771adb96e3dbf9c63751de8bf29d1bee86ed1448 100644 (file)
@@ -1,4 +1,4 @@
-/* 
+/*
    Unix SMB/CIFS implementation.
    Copyright (C) Andrew Tridgell 1992-2001
    Copyright (C) Andrew Bartlett      2002
@@ -7,17 +7,16 @@
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 /* the Samba secrets database stores any generated, private information
@@ -37,11 +36,11 @@ BOOL global_machine_password_needs_changing;
  * Use a TDB to store an incrementing random seed.
  *
  * Initialised to the current pid, the very first time Samba starts,
- * and incremented by one each time it is needed.  
- * 
+ * and incremented by one each time it is needed.
+ *
  * @note Not called by systems with a working /dev/urandom.
  */
-static void get_rand_seed(int *new_seed) 
+static void get_rand_seed(int *new_seed)
 {
        *new_seed = sys_getpid();
        if (tdb) {
@@ -69,8 +68,8 @@ BOOL secrets_init(void)
        }
 
        /**
-        * Set a reseed function for the crypto random generator 
-        * 
+        * Set a reseed function for the crypto random generator
+        *
         * This avoids a problem where systems without /dev/urandom
         * could send the same challenge to multiple clients
         */
@@ -97,15 +96,16 @@ void *secrets_fetch(const char *key, size_t *size)
        return dbuf.dptr;
 }
 
-/* store a secrets entry 
+/* store a secrets entry
  */
 BOOL secrets_store(const char *key, const void *data, size_t size)
 {
        secrets_init();
        if (!tdb)
                return False;
-       return tdb_store(tdb, string_tdb_data(key), make_tdb_data(data, size),
-                        TDB_REPLACE) == 0;
+       return tdb_trans_store(tdb, string_tdb_data(key),
+                              make_tdb_data((const uint8 *)data, size),
+                              TDB_REPLACE) == 0;
 }
 
 
@@ -116,7 +116,7 @@ BOOL secrets_delete(const char *key)
        secrets_init();
        if (!tdb)
                return False;
-       return tdb_delete(tdb, string_tdb_data(key)) == 0;
+       return tdb_trans_delete(tdb, string_tdb_data(key)) == 0;
 }
 
 BOOL secrets_store_domain_sid(const char *domain, const DOM_SID *sid)
@@ -147,7 +147,7 @@ BOOL secrets_fetch_domain_sid(const char *domain, DOM_SID *sid)
        if (dyn_sid == NULL)
                return False;
 
-       if (size != sizeof(DOM_SID)) { 
+       if (size != sizeof(DOM_SID)) {
                SAFE_FREE(dyn_sid);
                return False;
        }
@@ -157,36 +157,39 @@ BOOL secrets_fetch_domain_sid(const char *domain, DOM_SID *sid)
        return True;
 }
 
-BOOL secrets_store_domain_guid(const char *domain, struct uuid *guid)
+BOOL secrets_store_domain_guid(const char *domain, struct GUID *guid)
 {
        fstring key;
 
        slprintf(key, sizeof(key)-1, "%s/%s", SECRETS_DOMAIN_GUID, domain);
        strupper_m(key);
-       return secrets_store(key, guid, sizeof(struct uuid));
+       return secrets_store(key, guid, sizeof(struct GUID));
 }
 
-BOOL secrets_fetch_domain_guid(const char *domain, struct uuid *guid)
+BOOL secrets_fetch_domain_guid(const char *domain, struct GUID *guid)
 {
-       struct uuid *dyn_guid;
+       struct GUID *dyn_guid;
        fstring key;
        size_t size = 0;
-       struct uuid new_guid;
+       struct GUID new_guid;
 
        slprintf(key, sizeof(key)-1, "%s/%s", SECRETS_DOMAIN_GUID, domain);
        strupper_m(key);
-       dyn_guid = (struct uuid *)secrets_fetch(key, &size);
-
-       if ((!dyn_guid) && (lp_server_role() == ROLE_DOMAIN_PDC)) {
-               smb_uuid_generate_random(&new_guid);
-               if (!secrets_store_domain_guid(domain, &new_guid))
-                       return False;
-               dyn_guid = (struct uuid *)secrets_fetch(key, &size);
-               if (dyn_guid == NULL)
+       dyn_guid = (struct GUID *)secrets_fetch(key, &size);
+
+       if (!dyn_guid) {
+               if (lp_server_role() == ROLE_DOMAIN_PDC) {
+                       smb_uuid_generate_random(&new_guid);
+                       if (!secrets_store_domain_guid(domain, &new_guid))
+                               return False;
+                       dyn_guid = (struct GUID *)secrets_fetch(key, &size);
+               }
+               if (dyn_guid == NULL) {
                        return False;
+               }
        }
 
-       if (size != sizeof(struct uuid)) { 
+       if (size != sizeof(struct GUID)) {
                DEBUG(1,("UUID size %d is wrong!\n", (int)size));
                SAFE_FREE(dyn_guid);
                return False;
@@ -204,11 +207,11 @@ BOOL secrets_fetch_domain_guid(const char *domain, struct uuid *guid)
  *
  * @return stored password's key
  **/
-const char *trust_keystr(const char *domain)
+static const char *trust_keystr(const char *domain)
 {
        static fstring keystr;
 
-       slprintf(keystr,sizeof(keystr)-1,"%s/%s", 
+       slprintf(keystr,sizeof(keystr)-1,"%s/%s",
                 SECRETS_MACHINE_ACCT_PASS, domain);
        strupper_m(keystr);
 
@@ -228,7 +231,7 @@ static char *trustdom_keystr(const char *domain)
 
        pstr_sprintf(keystr, "%s/%s", SECRETS_DOMTRUST_ACCT_PASS, domain);
        strupper_m(keystr);
-               
+
        return keystr;
 }
 
@@ -242,7 +245,7 @@ BOOL secrets_lock_trust_account_password(const char *domain, BOOL dolock)
                return False;
 
        if (dolock)
-               return (tdb_lock_bystring(tdb, trust_keystr(domain),0) == 0);
+               return (tdb_lock_bystring(tdb, trust_keystr(domain)) == 0);
        else
                tdb_unlock_bystring(tdb, trust_keystr(domain));
        return True;
@@ -252,9 +255,9 @@ BOOL secrets_lock_trust_account_password(const char *domain, BOOL dolock)
  Routine to get the default secure channel type for trust accounts
 ************************************************************************/
 
-uint32 get_default_sec_channel(void) 
+uint32 get_default_sec_channel(void)
 {
-       if (lp_server_role() == ROLE_DOMAIN_BDC || 
+       if (lp_server_role() == ROLE_DOMAIN_BDC ||
            lp_server_role() == ROLE_DOMAIN_PDC) {
                return SEC_CHAN_BDC;
        } else {
@@ -276,7 +279,7 @@ BOOL secrets_fetch_trust_account_password(const char *domain, uint8 ret_pwd[16],
        char *plaintext;
        size_t size = 0;
 
-       plaintext = secrets_fetch_machine_password(domain, pass_last_set_time, 
+       plaintext = secrets_fetch_machine_password(domain, pass_last_set_time,
                                                   channel);
        if (plaintext) {
                DEBUG(4,("Using cleartext machine password\n"));
@@ -285,11 +288,12 @@ BOOL secrets_fetch_trust_account_password(const char *domain, uint8 ret_pwd[16],
                return True;
        }
 
-       if (!(pass = secrets_fetch(trust_keystr(domain), &size))) {
+       if (!(pass = (struct machine_acct_pass *)secrets_fetch(
+                     trust_keystr(domain), &size))) {
                DEBUG(5, ("secrets_fetch failed!\n"));
                return False;
        }
-       
+
        if (size != sizeof(*pass)) {
                DEBUG(0, ("secrets were of incorrect size!\n"));
                return False;
@@ -307,7 +311,7 @@ BOOL secrets_fetch_trust_account_password(const char *domain, uint8 ret_pwd[16],
        /* Test if machine password has expired and needs to be changed */
        if (lp_machine_password_timeout()) {
                if (pass->mod_time > 0 && time(NULL) > (pass->mod_time +
-                               lp_machine_password_timeout())) {
+                               (time_t)lp_machine_password_timeout())) {
                        global_machine_password_needs_changing = True;
                }
        }
@@ -316,6 +320,136 @@ BOOL secrets_fetch_trust_account_password(const char *domain, uint8 ret_pwd[16],
        return True;
 }
 
+/**
+ * Pack SID passed by pointer
+ *
+ * @param pack_buf pointer to buffer which is to be filled with packed data
+ * @param bufsize size of packing buffer
+ * @param sid pointer to sid to be packed
+ *
+ * @return length of the packed representation of the whole structure
+ **/
+static size_t tdb_sid_pack(uint8 *pack_buf, int bufsize, DOM_SID* sid)
+{
+       int idx;
+       size_t len = 0;
+
+       if (!sid || !pack_buf) return -1;
+
+       len += tdb_pack(pack_buf + len, bufsize - len, "bb", sid->sid_rev_num,
+                       sid->num_auths);
+
+       for (idx = 0; idx < 6; idx++) {
+               len += tdb_pack(pack_buf + len, bufsize - len, "b",
+                               sid->id_auth[idx]);
+       }
+
+       for (idx = 0; idx < MAXSUBAUTHS; idx++) {
+               len += tdb_pack(pack_buf + len, bufsize - len, "d",
+                               sid->sub_auths[idx]);
+       }
+
+       return len;
+}
+
+/**
+ * Unpack SID into a pointer
+ *
+ * @param pack_buf pointer to buffer with packed representation
+ * @param bufsize size of the buffer
+ * @param sid pointer to sid structure to be filled with unpacked data
+ *
+ * @return size of structure unpacked from buffer
+ **/
+static size_t tdb_sid_unpack(uint8 *pack_buf, int bufsize, DOM_SID* sid)
+{
+       int idx, len = 0;
+
+       if (!sid || !pack_buf) return -1;
+
+       len += tdb_unpack(pack_buf + len, bufsize - len, "bb",
+                         &sid->sid_rev_num, &sid->num_auths);
+
+       for (idx = 0; idx < 6; idx++) {
+               len += tdb_unpack(pack_buf + len, bufsize - len, "b",
+                                 &sid->id_auth[idx]);
+       }
+
+       for (idx = 0; idx < MAXSUBAUTHS; idx++) {
+               len += tdb_unpack(pack_buf + len, bufsize - len, "d",
+                                 &sid->sub_auths[idx]);
+       }
+
+       return len;
+}
+
+/**
+ * Pack TRUSTED_DOM_PASS passed by pointer
+ *
+ * @param pack_buf pointer to buffer which is to be filled with packed data
+ * @param bufsize size of the buffer
+ * @param pass pointer to trusted domain password to be packed
+ *
+ * @return length of the packed representation of the whole structure
+ **/
+static size_t tdb_trusted_dom_pass_pack(uint8 *pack_buf, int bufsize,
+                                       TRUSTED_DOM_PASS* pass)
+{
+       int idx, len = 0;
+
+       if (!pack_buf || !pass) return -1;
+
+       /* packing unicode domain name and password */
+       len += tdb_pack(pack_buf + len, bufsize - len, "d",
+                       pass->uni_name_len);
+
+       for (idx = 0; idx < 32; idx++)
+               len +=  tdb_pack(pack_buf + len, bufsize - len, "w",
+                                pass->uni_name[idx]);
+
+       len += tdb_pack(pack_buf + len, bufsize - len, "dPd", pass->pass_len,
+                            pass->pass, pass->mod_time);
+
+       /* packing SID structure */
+       len += tdb_sid_pack(pack_buf + len, bufsize - len, &pass->domain_sid);
+
+       return len;
+}
+
+
+/**
+ * Unpack TRUSTED_DOM_PASS passed by pointer
+ *
+ * @param pack_buf pointer to buffer with packed representation
+ * @param bufsize size of the buffer
+ * @param pass pointer to trusted domain password to be filled with unpacked data
+ *
+ * @return size of structure unpacked from buffer
+ **/
+static size_t tdb_trusted_dom_pass_unpack(uint8 *pack_buf, int bufsize,
+                                         TRUSTED_DOM_PASS* pass)
+{
+       int idx, len = 0;
+
+       if (!pack_buf || !pass) return -1;
+
+       /* unpack unicode domain name and plaintext password */
+       len += tdb_unpack(pack_buf, bufsize - len, "d", &pass->uni_name_len);
+
+       for (idx = 0; idx < 32; idx++)
+               len +=  tdb_unpack(pack_buf + len, bufsize - len, "w",
+                                  &pass->uni_name[idx]);
+
+       len += tdb_unpack(pack_buf + len, bufsize - len, "dPd",
+                         &pass->pass_len, &pass->pass, &pass->mod_time);
+
+       /* unpack domain sid */
+       len += tdb_sid_unpack(pack_buf + len, bufsize - len,
+                             &pass->domain_sid);
+
+       return len;
+}
+
 /************************************************************************
  Routine to get account password to trusted domain
 ************************************************************************/
@@ -325,15 +459,16 @@ BOOL secrets_fetch_trusted_domain_password(const char *domain, char** pwd,
 {
        struct trusted_dom_pass pass;
        size_t size = 0;
-       
+
        /* unpacking structures */
-       char* pass_buf;
+       uint8 *pass_buf;
        int pass_len = 0;
 
        ZERO_STRUCT(pass);
 
        /* fetching trusted domain password structure */
-       if (!(pass_buf = secrets_fetch(trustdom_keystr(domain), &size))) {
+       if (!(pass_buf = (uint8 *)secrets_fetch(trustdom_keystr(domain),
+                                              &size))) {
                DEBUG(5, ("secrets_fetch failed!\n"));
                return False;
        }
@@ -346,8 +481,8 @@ BOOL secrets_fetch_trusted_domain_password(const char *domain, char** pwd,
                DEBUG(5, ("Invalid secrets size. Unpacked data doesn't match trusted_dom_pass structure.\n"));
                return False;
        }
-                       
-       /* the trust's password */      
+
+       /* the trust's password */
        if (pwd) {
                *pwd = SMB_STRDUP(pass.pass);
                if (!*pwd) {
@@ -360,7 +495,7 @@ BOOL secrets_fetch_trusted_domain_password(const char *domain, char** pwd,
 
        /* domain sid */
        if (sid != NULL) sid_copy(sid, &pass.domain_sid);
-               
+
        return True;
 }
 
@@ -397,18 +532,19 @@ BOOL secrets_store_trusted_domain_password(const char* domain, const char* pwd,
        pstring pass_buf;
        int pass_len = 0;
        int pass_buf_len = sizeof(pass_buf);
-       
+
        struct trusted_dom_pass pass;
        ZERO_STRUCT(pass);
 
-       if (push_ucs2_allocate(&uni_dom_name, domain) < 0) {
+       if (push_ucs2_allocate(&uni_dom_name, domain) == (size_t)-1) {
                DEBUG(0, ("Could not convert domain name %s to unicode\n",
                          domain));
                return False;
        }
-       
+
        strncpy_w(pass.uni_name, uni_dom_name, sizeof(pass.uni_name) - 1);
        pass.uni_name_len = strlen_w(uni_dom_name)+1;
+       SAFE_FREE(uni_dom_name);
 
        /* last change time */
        pass.mod_time = time(NULL);
@@ -419,8 +555,8 @@ BOOL secrets_store_trusted_domain_password(const char* domain, const char* pwd,
 
        /* domain sid */
        sid_copy(&pass.domain_sid, sid);
-       
-       pass_len = tdb_trusted_dom_pass_pack(pass_buf, pass_buf_len, &pass);
+
+       pass_len = tdb_trusted_dom_pass_pack((uint8 *)pass_buf, pass_buf_len, &pass);
 
        return secrets_store(trustdom_keystr(domain), (void *)&pass_buf, pass_len);
 }
@@ -438,7 +574,7 @@ BOOL secrets_store_machine_password(const char *pass, const char *domain, uint32
        uint32 sec_channel_type;
 
        asprintf(&key, "%s/%s", SECRETS_MACHINE_PASSWORD, domain);
-       if (!key) 
+       if (!key)
                return False;
        strupper_m(key);
 
@@ -447,9 +583,9 @@ BOOL secrets_store_machine_password(const char *pass, const char *domain, uint32
 
        if (!ret)
                return ret;
-       
+
        asprintf(&key, "%s/%s", SECRETS_MACHINE_LAST_CHANGE_TIME, domain);
-       if (!key) 
+       if (!key)
                return False;
        strupper_m(key);
 
@@ -458,7 +594,7 @@ BOOL secrets_store_machine_password(const char *pass, const char *domain, uint32
        SAFE_FREE(key);
 
        asprintf(&key, "%s/%s", SECRETS_MACHINE_SEC_CHANNEL_TYPE, domain);
-       if (!key) 
+       if (!key)
                return False;
        strupper_m(key);
 
@@ -474,7 +610,7 @@ BOOL secrets_store_machine_password(const char *pass, const char *domain, uint32
  the password is assumed to be a null terminated ascii string.
 ************************************************************************/
 
-char *secrets_fetch_machine_password(const char *domain, 
+char *secrets_fetch_machine_password(const char *domain,
                                     time_t *pass_last_set_time,
                                     uint32 *channel)
 {
@@ -484,13 +620,13 @@ char *secrets_fetch_machine_password(const char *domain,
        strupper_m(key);
        ret = (char *)secrets_fetch(key, NULL);
        SAFE_FREE(key);
-       
+
        if (pass_last_set_time) {
                size_t size;
                uint32 *last_set_time;
                asprintf(&key, "%s/%s", SECRETS_MACHINE_LAST_CHANGE_TIME, domain);
                strupper_m(key);
-               last_set_time = secrets_fetch(key, &size);
+               last_set_time = (unsigned int *)secrets_fetch(key, &size);
                if (last_set_time) {
                        *pass_last_set_time = IVAL(last_set_time,0);
                        SAFE_FREE(last_set_time);
@@ -499,13 +635,13 @@ char *secrets_fetch_machine_password(const char *domain,
                }
                SAFE_FREE(key);
        }
-       
+
        if (channel) {
                size_t size;
                uint32 *channel_type;
                asprintf(&key, "%s/%s", SECRETS_MACHINE_SEC_CHANNEL_TYPE, domain);
                strupper_m(key);
-               channel_type = secrets_fetch(key, &size);
+               channel_type = (unsigned int *)secrets_fetch(key, &size);
                if (channel_type) {
                        *channel = IVAL(channel_type,0);
                        SAFE_FREE(channel_type);
@@ -514,49 +650,8 @@ char *secrets_fetch_machine_password(const char *domain,
                }
                SAFE_FREE(key);
        }
-       
-       return ret;
-}
-
-/*******************************************************************
- Wrapper around retrieving the trust account password
-*******************************************************************/
-                                                                                                                     
-BOOL get_trust_pw(const char *domain, uint8 ret_pwd[16], uint32 *channel)
-{
-       DOM_SID sid;
-       char *pwd;
-       time_t last_set_time;
-                                                                                                                     
-       /* if we are a DC and this is not our domain, then lookup an account
-               for the domain trust */
-                                                                                                                     
-       if ( IS_DC && !strequal(domain, lp_workgroup()) && lp_allow_trusted_domains() ) {
-               if (!secrets_fetch_trusted_domain_password(domain, &pwd, &sid,
-                                                       &last_set_time)) {
-                       DEBUG(0, ("get_trust_pw: could not fetch trust "
-                               "account password for trusted domain %s\n",
-                               domain));
-                       return False;
-               }
-                                                                                                                     
-               *channel = SEC_CHAN_DOMAIN;
-               E_md4hash(pwd, ret_pwd);
-               SAFE_FREE(pwd);
-
-               return True;
-       }
-                                                                                                                     
-       /* Just get the account for the requested domain. In the future this
-        * might also cover to be member of more than one domain. */
-                                                                                                                     
-       if (secrets_fetch_trust_account_password(domain, ret_pwd,
-                                               &last_set_time, channel))
-               return True;
 
-       DEBUG(5, ("get_trust_pw: could not fetch trust account "
-               "password for domain %s\n", domain));
-       return False;
+       return ret;
 }
 
 /************************************************************************
@@ -581,14 +676,14 @@ BOOL secrets_store_ldap_pw(const char* dn, char* pw)
 {
        char *key = NULL;
        BOOL ret;
-       
+
        if (asprintf(&key, "%s/%s", SECRETS_LDAP_BIND_PW, dn) < 0) {
                DEBUG(0, ("secrets_store_ldap_pw: asprintf failed!\n"));
                return False;
        }
-               
+
        ret = secrets_store(key, pw, strlen(pw)+1);
-       
+
        SAFE_FREE(key);
        return ret;
 }
@@ -601,15 +696,15 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
 {
        char *key = NULL;
        size_t size = 0;
-       
+
        *dn = smb_xstrdup(lp_ldap_admin_dn());
-       
+
        if (asprintf(&key, "%s/%s", SECRETS_LDAP_BIND_PW, *dn) < 0) {
                SAFE_FREE(*dn);
                DEBUG(0, ("fetch_ldap_pw: asprintf failed!\n"));
        }
-       
-       *pw=secrets_fetch(key, &size);
+
+       *pw=(char *)secrets_fetch(key, &size);
        SAFE_FREE(key);
 
        if (!size) {
@@ -618,7 +713,7 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
                char* old_style_key = SMB_STRDUP(*dn);
                char *data;
                fstring old_style_pw;
-               
+
                if (!old_style_key) {
                        DEBUG(0, ("fetch_ldap_pw: strdup failed!\n"));
                        return False;
@@ -626,8 +721,8 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
 
                for (p=old_style_key; *p; p++)
                        if (*p == ',') *p = '/';
-       
-               data=secrets_fetch(old_style_key, &size);
+
+               data=(char *)secrets_fetch(old_style_key, &size);
                if (!size && size < sizeof(old_style_pw)) {
                        DEBUG(0,("fetch_ldap_pw: neither ldap secret retrieved!\n"));
                        SAFE_FREE(old_style_key);
@@ -645,7 +740,7 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
                        DEBUG(0,("fetch_ldap_pw: ldap secret could not be upgraded!\n"));
                        SAFE_FREE(old_style_key);
                        SAFE_FREE(*dn);
-                       return False;                   
+                       return False;
                }
                if (!secrets_delete(old_style_key)) {
                        DEBUG(0,("fetch_ldap_pw: old ldap secret could not be deleted!\n"));
@@ -653,61 +748,78 @@ BOOL fetch_ldap_pw(char **dn, char** pw)
 
                SAFE_FREE(old_style_key);
 
-               *pw = smb_xstrdup(old_style_pw);                
+               *pw = smb_xstrdup(old_style_pw);
        }
-       
+
        return True;
 }
 
 /**
  * Get trusted domains info from secrets.tdb.
- **/ 
+ **/
 
 NTSTATUS secrets_trusted_domains(TALLOC_CTX *mem_ctx, uint32 *num_domains,
                                 struct trustdom_info ***domains)
 {
        TDB_LIST_NODE *keys, *k;
        char *pattern;
+       TALLOC_CTX *tmp_ctx;
+
+       if (!(tmp_ctx = talloc_new(mem_ctx))) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
        if (!secrets_init()) return NT_STATUS_ACCESS_DENIED;
-       
+
        /* generate searching pattern */
-       pattern = talloc_asprintf(mem_ctx, "%s/*", SECRETS_DOMTRUST_ACCT_PASS);
+       pattern = talloc_asprintf(tmp_ctx, "%s/*", SECRETS_DOMTRUST_ACCT_PASS);
        if (pattern == NULL) {
                DEBUG(0, ("secrets_trusted_domains: talloc_asprintf() "
                          "failed!\n"));
+               TALLOC_FREE(tmp_ctx);
                return NT_STATUS_NO_MEMORY;
        }
 
-       *domains = NULL;
        *num_domains = 0;
 
+       /*
+        * Make sure that a talloc context for the trustdom_info structs
+        * exists
+        */
+
+       if (!(*domains = TALLOC_ARRAY(mem_ctx, struct trustdom_info *, 1))) {
+               TALLOC_FREE(tmp_ctx);
+               return NT_STATUS_NO_MEMORY;
+       }
+
        /* fetching trusted domains' data and collecting them in a list */
        keys = tdb_search_keys(tdb, pattern);
 
        /* searching for keys in secrets db -- way to go ... */
        for (k = keys; k; k = k->next) {
-               char *packed_pass;
+               uint8 *packed_pass;
                size_t size = 0, packed_size = 0;
                struct trusted_dom_pass pass;
                char *secrets_key;
                struct trustdom_info *dom_info;
-               
+
                /* important: ensure null-termination of the key string */
-               secrets_key = talloc_strndup(mem_ctx,
-                                            k->node_key.dptr,
+               secrets_key = talloc_strndup(tmp_ctx,
+                                            (const char *)k->node_key.dptr,
                                             k->node_key.dsize);
                if (!secrets_key) {
                        DEBUG(0, ("strndup failed!\n"));
+                       tdb_search_list_free(keys);
+                       TALLOC_FREE(tmp_ctx);
                        return NT_STATUS_NO_MEMORY;
                }
 
-               packed_pass = secrets_fetch(secrets_key, &size);
+               packed_pass = (uint8 *)secrets_fetch(secrets_key, &size);
                packed_size = tdb_trusted_dom_pass_unpack(packed_pass, size,
                                                          &pass);
                /* packed representation isn't needed anymore */
                SAFE_FREE(packed_pass);
-               
+
                if (size != packed_size) {
                        DEBUG(2, ("Secrets record %s is invalid!\n",
                                  secrets_key));
@@ -722,34 +834,39 @@ NTSTATUS secrets_trusted_domains(TALLOC_CTX *mem_ctx, uint32 *num_domains,
                        continue;
                }
 
-               dom_info = TALLOC_P(mem_ctx, struct trustdom_info);
-               if (dom_info == NULL) {
+               if (!(dom_info = TALLOC_P(*domains, struct trustdom_info))) {
                        DEBUG(0, ("talloc failed\n"));
+                       tdb_search_list_free(keys);
+                       TALLOC_FREE(tmp_ctx);
                        return NT_STATUS_NO_MEMORY;
                }
 
-               if (pull_ucs2_talloc(mem_ctx, &dom_info->name,
-                                    pass.uni_name) < 0) {
+               if (pull_ucs2_talloc(dom_info, &dom_info->name,
+                                    pass.uni_name) == (size_t)-1) {
                        DEBUG(2, ("pull_ucs2_talloc failed\n"));
+                       tdb_search_list_free(keys);
+                       TALLOC_FREE(tmp_ctx);
                        return NT_STATUS_NO_MEMORY;
                }
 
                sid_copy(&dom_info->sid, &pass.domain_sid);
 
-               ADD_TO_ARRAY(mem_ctx, struct trustdom_info *, dom_info,
+               ADD_TO_ARRAY(*domains, struct trustdom_info *, dom_info,
                             domains, num_domains);
 
                if (*domains == NULL) {
+                       tdb_search_list_free(keys);
+                       TALLOC_FREE(tmp_ctx);
                        return NT_STATUS_NO_MEMORY;
                }
-               talloc_steal(*domains, dom_info);
        }
-       
+
        DEBUG(5, ("secrets_get_trusted_domains: got %d domains\n",
                  *num_domains));
 
        /* free the results of searching the keys */
        tdb_search_list_free(keys);
+       TALLOC_FREE(tmp_ctx);
 
        return NT_STATUS_OK;
 }
@@ -766,7 +883,7 @@ BOOL secrets_named_mutex(const char *name, unsigned int timeout)
        if (!secrets_init())
                return False;
 
-       ret = tdb_lock_bystring(tdb, name, timeout);
+       ret = tdb_lock_bystring_with_timeout(tdb, name, timeout);
        if (ret == 0)
                DEBUG(10,("secrets_named_mutex: got mutex for %s\n", name ));
 
@@ -839,7 +956,7 @@ BOOL secrets_fetch_afs_key(const char *cell, struct afs_key *result)
 
 /******************************************************************************
   When kerberos is not available, choose between anonymous or
-  authenticated connections.  
+  authenticated connections.
 
   We need to use an authenticated connection if DCs have the
   RestrictAnonymous registry entry set > 0, or the "Additional
@@ -850,19 +967,19 @@ BOOL secrets_fetch_afs_key(const char *cell, struct afs_key *result)
 *******************************************************************************/
 void secrets_fetch_ipc_userpass(char **username, char **domain, char **password)
 {
-       *username = secrets_fetch(SECRETS_AUTH_USER, NULL);
-       *domain = secrets_fetch(SECRETS_AUTH_DOMAIN, NULL);
-       *password = secrets_fetch(SECRETS_AUTH_PASSWORD, NULL);
-       
+       *username = (char *)secrets_fetch(SECRETS_AUTH_USER, NULL);
+       *domain = (char *)secrets_fetch(SECRETS_AUTH_DOMAIN, NULL);
+       *password = (char *)secrets_fetch(SECRETS_AUTH_PASSWORD, NULL);
+
        if (*username && **username) {
 
                if (!*domain || !**domain)
                        *domain = smb_xstrdup(lp_workgroup());
-               
+
                if (!*password || !**password)
                        *password = smb_xstrdup("");
 
-               DEBUG(3, ("IPC$ connections done by user %s\\%s\n", 
+               DEBUG(3, ("IPC$ connections done by user %s\\%s\n",
                          *domain, *username));
 
        } else {
@@ -892,7 +1009,7 @@ static TDB_CONTEXT *open_schannel_session_store(TALLOC_CTX *mem_ctx)
 
         if (!tdb_sc) {
                 DEBUG(0,("open_schannel_session_store: Failed to open %s\n", fname));
-               talloc_free(fname);
+               TALLOC_FREE(fname);
                 return NULL;
         }
 
@@ -900,7 +1017,7 @@ static TDB_CONTEXT *open_schannel_session_store(TALLOC_CTX *mem_ctx)
        if (vers.dptr == NULL) {
                /* First opener, no version. */
                SIVAL(&ver,0,1);
-               vers.dptr = (char *)&ver;
+               vers.dptr = (uint8 *)&ver;
                vers.dsize = 4;
                tdb_store_bystring(tdb_sc, "SCHANNEL_STORE_VERSION", vers, TDB_REPLACE);
                vers.dptr = NULL;
@@ -920,7 +1037,7 @@ static TDB_CONTEXT *open_schannel_session_store(TALLOC_CTX *mem_ctx)
        }
 
        SAFE_FREE(vers.dptr);
-       talloc_free(fname);
+       TALLOC_FREE(fname);
 
        return tdb_sc;
 }
@@ -930,13 +1047,15 @@ static TDB_CONTEXT *open_schannel_session_store(TALLOC_CTX *mem_ctx)
  Note we must be root here.
 *******************************************************************************/
 
-BOOL secrets_store_schannel_session_info(TALLOC_CTX *mem_ctx, const struct dcinfo *pdc)
+BOOL secrets_store_schannel_session_info(TALLOC_CTX *mem_ctx,
+                               const char *remote_machine,
+                               const struct dcinfo *pdc)
 {
        TDB_CONTEXT *tdb_sc = NULL;
        TDB_DATA value;
        BOOL ret;
        char *keystr = talloc_asprintf(mem_ctx, "%s/%s", SECRETS_SCHANNEL_STATE,
-                               pdc->remote_machine);
+                               remote_machine);
        if (!keystr) {
                return False;
        }
@@ -955,9 +1074,9 @@ BOOL secrets_store_schannel_session_info(TALLOC_CTX *mem_ctx, const struct dcinf
                                pdc->remote_machine,
                                pdc->domain);
 
-       value.dptr = TALLOC(mem_ctx, value.dsize);
+       value.dptr = TALLOC_ARRAY(mem_ctx, uint8, value.dsize);
        if (!value.dptr) {
-               talloc_free(keystr);
+               TALLOC_FREE(keystr);
                return False;
        }
 
@@ -974,8 +1093,8 @@ BOOL secrets_store_schannel_session_info(TALLOC_CTX *mem_ctx, const struct dcinf
 
        tdb_sc = open_schannel_session_store(mem_ctx);
        if (!tdb_sc) {
-               talloc_free(keystr);
-               talloc_free(value.dptr);
+               TALLOC_FREE(keystr);
+               TALLOC_FREE(value.dptr);
                return False;
        }
 
@@ -985,8 +1104,8 @@ BOOL secrets_store_schannel_session_info(TALLOC_CTX *mem_ctx, const struct dcinf
                keystr ));
 
        tdb_close(tdb_sc);
-       talloc_free(keystr);
-       talloc_free(value.dptr);
+       TALLOC_FREE(keystr);
+       TALLOC_FREE(value.dptr);
        return ret;
 }
 
@@ -1022,7 +1141,7 @@ BOOL secrets_restore_schannel_session_info(TALLOC_CTX *mem_ctx,
 
        tdb_sc = open_schannel_session_store(mem_ctx);
        if (!tdb_sc) {
-               talloc_free(keystr);
+               TALLOC_FREE(keystr);
                return False;
        }
 
@@ -1034,8 +1153,6 @@ BOOL secrets_restore_schannel_session_info(TALLOC_CTX *mem_ctx,
                return False;
        }
 
-       tdb_close(tdb_sc);
-
        pdc = TALLOC_ZERO_P(mem_ctx, struct dcinfo);
 
        /* Retrieve the record. */
@@ -1051,19 +1168,22 @@ BOOL secrets_restore_schannel_session_info(TALLOC_CTX *mem_ctx,
                                &pdc->domain);
 
        if (ret == -1 || l1 != 8 || l2 != 8 || l3 != 8 || l4 != 16 || l5 != 16) {
-               talloc_free(keystr);
-               talloc_free(pdc);
+               /* Bad record - delete it. */
+               tdb_delete_bystring(tdb_sc, keystr);
+               tdb_close(tdb_sc);
+               TALLOC_FREE(keystr);
+               TALLOC_FREE(pdc);
                SAFE_FREE(pseed_chal);
                SAFE_FREE(pclnt_chal);
                SAFE_FREE(psrv_chal);
                SAFE_FREE(psess_key);
                SAFE_FREE(pmach_pw);
                SAFE_FREE(value.dptr);
-               /* Bad record - delete it. */
-               tdb_delete_bystring(tdb_sc, keystr);
                return False;
        }
 
+       tdb_close(tdb_sc);
+
        memcpy(pdc->seed_chal.data, pseed_chal, 8);
        memcpy(pdc->clnt_chal.data, pclnt_chal, 8);
        memcpy(pdc->srv_chal.data, psrv_chal, 8);
@@ -1083,10 +1203,52 @@ BOOL secrets_restore_schannel_session_info(TALLOC_CTX *mem_ctx,
        SAFE_FREE(psess_key);
        SAFE_FREE(pmach_pw);
 
-       talloc_free(keystr);
+       TALLOC_FREE(keystr);
        SAFE_FREE(value.dptr);
 
        *ppdc = pdc;
 
        return True;
 }
+
+BOOL secrets_store_generic(const char *owner, const char *key, const char *secret)
+{
+       char *tdbkey = NULL;
+       BOOL ret;
+
+       if (asprintf(&tdbkey, "SECRETS/GENERIC/%s/%s", owner, key) < 0) {
+               DEBUG(0, ("asprintf failed!\n"));
+               return False;
+       }
+
+       ret = secrets_store(tdbkey, secret, strlen(secret)+1);
+
+       SAFE_FREE(tdbkey);
+       return ret;
+}
+
+/*******************************************************************
+ Find the ldap password.
+******************************************************************/
+
+char *secrets_fetch_generic(const char *owner, const char *key)
+{
+       char *secret = NULL;
+       char *tdbkey = NULL;
+
+       if (( ! owner) || ( ! key)) {
+               DEBUG(1, ("Invalid Paramters"));
+               return NULL;
+       }
+
+       if (asprintf(&tdbkey, "SECRETS/GENERIC/%s/%s", owner, key) < 0) {
+               DEBUG(0, ("Out of memory!\n"));
+               return NULL;
+       }
+
+       secret = (char *)secrets_fetch(tdbkey, NULL);
+       SAFE_FREE(tdbkey);
+
+       return secret;
+}
+