s3: Explicitly handle inbuf in cli_trans_done
[sfrench/samba-autobuild/.git] / source3 / libsmb / clitrans.c
index bbdfb75fcd1863d3d0e0aba3a53ff78c0064fa89..56580e6a6dce0206842801aa3c94e2426a138644 100644 (file)
@@ -94,14 +94,12 @@ bool cli_send_trans(struct cli_state *cli, int trans,
                return False;
        }
 
-       /* Note we're in a trans state. Save the sequence
-        * numbers for replies. */
-       client_set_trans_sign_state_on(cli, mid);
+       cli_state_seqnum_persistent(cli, mid);
 
        if (this_ldata < ldata || this_lparam < lparam) {
                /* receive interim response */
                if (!cli_receive_smb(cli) || cli_is_error(cli)) {
-                       client_set_trans_sign_state_off(cli, mid);
+                       cli_state_seqnum_remove(cli, mid);
                        return(False);
                }
 
@@ -112,9 +110,6 @@ bool cli_send_trans(struct cli_state *cli, int trans,
                        this_lparam = MIN(lparam-tot_param,cli->max_xmit - 500); /* hack */
                        this_ldata = MIN(ldata-tot_data,cli->max_xmit - (500+this_lparam));
 
-                       client_set_trans_sign_state_off(cli, mid);
-                       client_set_trans_sign_state_on(cli, mid);
-
                        cli_set_message(cli->outbuf,trans==SMBtrans?8:9,0,True);
                        SCVAL(cli->outbuf,smb_com,(trans==SMBtrans ? SMBtranss : SMBtranss2));
 
@@ -138,21 +133,14 @@ bool cli_send_trans(struct cli_state *cli, int trans,
                                memcpy(outdata,data+tot_data,this_ldata);
                        cli_setup_bcc(cli, outdata+this_ldata);
 
-                       /*
-                        * Save the mid we're using. We need this for finding
-                        * signing replies.
-                        */
-                       mid = cli->mid;
-
                        show_msg(cli->outbuf);
+
+                       cli->mid = mid;
                        if (!cli_send_smb(cli)) {
-                               client_set_trans_sign_state_off(cli, mid);
+                               cli_state_seqnum_remove(cli, mid);
                                return False;
                        }
 
-                       /* Ensure we use the same mid for the secondaries. */
-                       cli->mid = mid;
-
                        tot_data += this_ldata;
                        tot_param += this_lparam;
                }
@@ -174,10 +162,14 @@ bool cli_receive_trans(struct cli_state *cli,int trans,
        unsigned int this_data,this_param;
        NTSTATUS status;
        bool ret = False;
+       uint16_t mid;
 
        *data_len = *param_len = 0;
 
+       mid = SVAL(cli->outbuf,smb_mid);
+
        if (!cli_receive_smb(cli)) {
+               cli_state_seqnum_remove(cli, mid);
                return False;
        }
 
@@ -188,6 +180,7 @@ bool cli_receive_trans(struct cli_state *cli,int trans,
                DEBUG(0,("Expected %s response, got command 0x%02x\n",
                         trans==SMBtrans?"SMBtrans":"SMBtrans2",
                         CVAL(cli->inbuf,smb_com)));
+               cli_state_seqnum_remove(cli, mid);
                return False;
        }
 
@@ -340,6 +333,8 @@ bool cli_receive_trans(struct cli_state *cli,int trans,
 
   out:
 
+       cli_state_seqnum_remove(cli, mid);
+
        if (ret) {
                /* Ensure the last 2 bytes of param and data are 2 null
                 * bytes. These are malloc'ed, but not included in any
@@ -353,7 +348,6 @@ bool cli_receive_trans(struct cli_state *cli,int trans,
                }
        }
 
-       client_set_trans_sign_state_off(cli, SVAL(cli->inbuf,smb_mid));
        return ret;
 }
 
@@ -421,14 +415,12 @@ bool cli_send_nt_trans(struct cli_state *cli,
                return False;
        }
 
-       /* Note we're in a trans state. Save the sequence
-        * numbers for replies. */
-       client_set_trans_sign_state_on(cli, mid);
+       cli_state_seqnum_persistent(cli, mid);
 
        if (this_ldata < ldata || this_lparam < lparam) {
                /* receive interim response */
                if (!cli_receive_smb(cli) || cli_is_error(cli)) {
-                       client_set_trans_sign_state_off(cli, mid);
+                       cli_state_seqnum_remove(cli, mid);
                        return(False);
                }
 
@@ -461,22 +453,14 @@ bool cli_send_nt_trans(struct cli_state *cli,
                                memcpy(outdata,data+tot_data,this_ldata);
                        cli_setup_bcc(cli, outdata+this_ldata);
 
-                       /*
-                        * Save the mid we're using. We need this for finding
-                        * signing replies.
-                        */
-                       mid = cli->mid;
-
                        show_msg(cli->outbuf);
 
+                       cli->mid = mid;
                        if (!cli_send_smb(cli)) {
-                               client_set_trans_sign_state_off(cli, mid);
+                               cli_state_seqnum_remove(cli, mid);
                                return False;
                        }
 
-                       /* Ensure we use the same mid for the secondaries. */
-                       cli->mid = mid;
-
                        tot_data += this_ldata;
                        tot_param += this_lparam;
                }
@@ -499,10 +483,14 @@ bool cli_receive_nt_trans(struct cli_state *cli,
        uint8 eclass;
        uint32 ecode;
        bool ret = False;
+       uint16_t mid;
 
        *data_len = *param_len = 0;
 
+       mid = SVAL(cli->outbuf,smb_mid);
+
        if (!cli_receive_smb(cli)) {
+               cli_state_seqnum_remove(cli, mid);
                return False;
        }
 
@@ -512,6 +500,7 @@ bool cli_receive_nt_trans(struct cli_state *cli,
        if (CVAL(cli->inbuf,smb_com) != SMBnttrans) {
                DEBUG(0,("Expected SMBnttrans response, got command 0x%02x\n",
                         CVAL(cli->inbuf,smb_com)));
+               cli_state_seqnum_remove(cli, mid);
                return(False);
        }
 
@@ -685,6 +674,8 @@ bool cli_receive_nt_trans(struct cli_state *cli,
 
   out:
 
+       cli_state_seqnum_remove(cli, mid);
+
        if (ret) {
                /* Ensure the last 2 bytes of param and data are 2 null
                 * bytes. These are malloc'ed, but not included in any
@@ -698,7 +689,6 @@ bool cli_receive_nt_trans(struct cli_state *cli,
                }
        }
 
-       client_set_trans_sign_state_off(cli, SVAL(cli->inbuf,smb_mid));
        return ret;
 }
 
@@ -712,7 +702,10 @@ struct cli_trans_state {
        struct event_context *ev;
        uint8_t cmd;
        uint16_t mid;
+       uint32_t seqnum;
        const char *pipe_name;
+       uint8_t *pipe_name_conv;
+       size_t pipe_name_conv_len;
        uint16_t fid;
        uint16_t function;
        int flags;
@@ -729,27 +722,132 @@ struct cli_trans_state {
        struct trans_recvblob rdata;
 
        TALLOC_CTX *secondary_request_ctx;
+
+       struct iovec iov[4];
+       uint8_t pad[4];
+       uint16_t vwv[32];
 };
 
-static void cli_trans_recv_helper(struct async_req *req);
+static NTSTATUS cli_pull_trans(uint8_t *inbuf,
+                              uint8_t wct, uint16_t *vwv,
+                              uint16_t num_bytes, uint8_t *bytes,
+                              uint8_t smb_cmd, bool expect_first_reply,
+                              uint8_t *pnum_setup, uint16_t **psetup,
+                              uint32_t *ptotal_param, uint32_t *pnum_param,
+                              uint32_t *pparam_disp, uint8_t **pparam,
+                              uint32_t *ptotal_data, uint32_t *pnum_data,
+                              uint32_t *pdata_disp, uint8_t **pdata)
+{
+       uint32_t param_ofs, data_ofs;
+
+       if (expect_first_reply) {
+               if ((wct != 0) || (num_bytes != 0)) {
+                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
+               }
+               return NT_STATUS_OK;
+       }
+
+       switch (smb_cmd) {
+       case SMBtrans:
+       case SMBtrans2:
+               if (wct < 10) {
+                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
+               }
+               *ptotal_param   = SVAL(vwv + 0, 0);
+               *ptotal_data    = SVAL(vwv + 1, 0);
+               *pnum_param     = SVAL(vwv + 3, 0);
+               param_ofs       = SVAL(vwv + 4, 0);
+               *pparam_disp    = SVAL(vwv + 5, 0);
+               *pnum_data      = SVAL(vwv + 6, 0);
+               data_ofs        = SVAL(vwv + 7, 0);
+               *pdata_disp     = SVAL(vwv + 8, 0);
+               *pnum_setup     = CVAL(vwv + 9, 0);
+               if (wct < 10 + (*pnum_setup)) {
+                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
+               }
+               *psetup = vwv + 10;
+
+               break;
+       case SMBnttrans:
+               if (wct < 18) {
+                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
+               }
+               *ptotal_param   = IVAL(vwv, 3);
+               *ptotal_data    = IVAL(vwv, 7);
+               *pnum_param     = IVAL(vwv, 11);
+               param_ofs       = IVAL(vwv, 15);
+               *pparam_disp    = IVAL(vwv, 19);
+               *pnum_data      = IVAL(vwv, 23);
+               data_ofs        = IVAL(vwv, 27);
+               *pdata_disp     = IVAL(vwv, 31);
+               *pnum_setup     = CVAL(vwv, 35);
+               *psetup         = vwv + 18;
+               break;
+
+       default:
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
+       /*
+        * Check for buffer overflows. data_ofs needs to be checked against
+        * the incoming buffer length, data_disp against the total
+        * length. Likewise for param_ofs/param_disp.
+        */
+
+       if (trans_oob(smb_len(inbuf), param_ofs, *pnum_param)
+           || trans_oob(*ptotal_param, *pparam_disp, *pnum_param)
+           || trans_oob(smb_len(inbuf), data_ofs, *pnum_data)
+           || trans_oob(*ptotal_data, *pdata_disp, *pnum_data)) {
+               return NT_STATUS_INVALID_NETWORK_RESPONSE;
+       }
+
+       *pparam = (uint8_t *)inbuf + 4 + param_ofs;
+       *pdata = (uint8_t *)inbuf + 4 + data_ofs;
+
+       return NT_STATUS_OK;
+}
 
-static struct async_req *cli_ship_trans(TALLOC_CTX *mem_ctx,
-                                       struct cli_trans_state *state)
+static NTSTATUS cli_trans_pull_blob(TALLOC_CTX *mem_ctx,
+                                   struct trans_recvblob *blob,
+                                   uint32_t total, uint32_t thistime,
+                                   uint8_t *buf, uint32_t displacement)
 {
-       TALLOC_CTX *frame;
-       struct async_req *result = NULL;
-       struct cli_request *cli_req;
-       uint8_t wct;
-       uint16_t *vwv;
-       uint8_t *bytes = NULL;
+       if (blob->data == NULL) {
+               if (total > blob->max) {
+                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
+               }
+               blob->total = total;
+               blob->data = TALLOC_ARRAY(mem_ctx, uint8_t, total);
+               if (blob->data == NULL) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+       }
+
+       if (total > blob->total) {
+               return NT_STATUS_INVALID_NETWORK_RESPONSE;
+       }
+
+       if (thistime) {
+               memcpy(blob->data + displacement, buf, thistime);
+               blob->received += thistime;
+       }
+
+       return NT_STATUS_OK;
+}
+
+static void cli_trans_format(struct cli_trans_state *state, uint8_t *pwct,
+                            int *piov_count)
+{
+       uint8_t wct = 0;
+       struct iovec *iov = state->iov;
+       uint8_t *pad = state->pad;
+       uint16_t *vwv = state->vwv;
        uint16_t param_offset;
        uint16_t this_param = 0;
        uint16_t this_data = 0;
        uint32_t useable_space;
        uint8_t cmd;
 
-       frame = talloc_stackframe();
-
        cmd = state->cmd;
 
        if ((state->param_sent != 0) || (state->data_sent != 0)) {
@@ -761,29 +859,24 @@ static struct async_req *cli_ship_trans(TALLOC_CTX *mem_ctx,
 
        switch (cmd) {
        case SMBtrans:
-               bytes = TALLOC_ZERO_P(talloc_tos(), uint8_t); /* padding */
-               if (bytes == NULL) {
-                       goto fail;
-               }
-               bytes = smb_bytes_push_str(
-                       bytes, (state->cli->capabilities & CAP_UNICODE) != 0,
-                       state->pipe_name);
-               if (bytes == NULL) {
-                       goto fail;
-               }
+               pad[0] = 0;
+               iov[0].iov_base = (void *)pad;
+               iov[0].iov_len = 1;
+               iov[1].iov_base = (void *)state->pipe_name_conv;
+               iov[1].iov_len = state->pipe_name_conv_len;
                wct = 14 + state->num_setup;
-               param_offset += talloc_get_size(bytes);
+               param_offset += iov[0].iov_len + iov[1].iov_len;
+               iov += 2;
                break;
        case SMBtrans2:
-               bytes = TALLOC_ARRAY(talloc_tos(), uint8_t, 3); /* padding */
-               if (bytes == NULL) {
-                       goto fail;
-               }
-               bytes[0] = 0;
-               bytes[1] = 'D'; /* Copy this from "old" 3.0 behaviour */
-               bytes[2] = ' ';
+               pad[0] = 0;
+               pad[1] = 'D'; /* Copy this from "old" 3.0 behaviour */
+               pad[2] = ' ';
+               iov[0].iov_base = (void *)pad;
+               iov[0].iov_len = 3;
                wct = 14 + state->num_setup;
-               param_offset += talloc_get_size(bytes);
+               param_offset += 3;
+               iov += 1;
                break;
        case SMBtranss:
                wct = 8;
@@ -797,8 +890,6 @@ static struct async_req *cli_ship_trans(TALLOC_CTX *mem_ctx,
        case SMBnttranss:
                wct = 18;
                break;
-       default:
-               goto fail;
        }
 
        useable_space = state->cli->max_xmit - smb_size - sizeof(uint16_t)*wct;
@@ -806,17 +897,19 @@ static struct async_req *cli_ship_trans(TALLOC_CTX *mem_ctx,
        if (state->param_sent < state->num_param) {
                this_param = MIN(state->num_param - state->param_sent,
                                 useable_space);
+               iov[0].iov_base = (void *)(state->param + state->param_sent);
+               iov[0].iov_len = this_param;
+               iov += 1;
        }
 
        if (state->data_sent < state->num_data) {
                this_data = MIN(state->num_data - state->data_sent,
                                useable_space - this_param);
+               iov[0].iov_base = (void *)(state->data + state->data_sent);
+               iov[0].iov_len = this_data;
+               iov += 1;
        }
 
-       vwv = TALLOC_ARRAY(talloc_tos(), uint16_t, wct);
-       if (vwv == NULL) {
-               goto fail;
-       }
        param_offset += wct * sizeof(uint16_t);
 
        DEBUG(10, ("num_setup=%u, max_setup=%u, "
@@ -897,215 +990,123 @@ static struct async_req *cli_ship_trans(TALLOC_CTX *mem_ctx,
                break;
        }
 
-       bytes = (uint8_t *)talloc_append_blob(
-               talloc_tos(), bytes,
-               data_blob_const(state->param + state->param_sent, this_param));
-       if (bytes == NULL) {
-               goto fail;
-       }
        state->param_sent += this_param;
-
-       bytes = (uint8_t *)talloc_append_blob(
-               talloc_tos(), bytes,
-               data_blob_const(state->data + state->data_sent, this_data));
-       if (bytes == NULL) {
-               goto fail;
-       }
        state->data_sent += this_data;
 
-       if ((cmd == SMBtrans) || (cmd == SMBtrans2) || (cmd == SMBnttrans)) {
-               /*
-                * Primary request, retrieve our mid
-                */
-               result = cli_request_send(mem_ctx, state->ev, state->cli,
-                                         cmd, 0, wct, vwv,
-                                         talloc_get_size(bytes), bytes);
-               if (result == NULL) {
-                       goto fail;
-               }
-               cli_req = talloc_get_type_abort(result->private_data,
-                                               struct cli_request);
-               state->mid = cli_req->mid;
-       } else {
-               uint16_t num_bytes = talloc_get_size(bytes);
-               /*
-                * Secondary request, we have to fix up the mid. Thus we do
-                * the chain_cork/chain/uncork ourselves.
-                */
-               if (!cli_chain_cork(state->cli, state->ev,
-                                   wct * sizeof(uint16_t) + num_bytes + 3)) {
-                       goto fail;
-               }
-               result = cli_request_send(mem_ctx, state->ev, state->cli,
-                                         cmd, 0, wct, vwv, num_bytes, bytes);
-               if (result == NULL) {
-                       goto fail;
-               }
-               cli_req = talloc_get_type_abort(result->private_data,
-                                               struct cli_request);
-               cli_req->recv_helper.fn = cli_trans_recv_helper;
-               cli_req->recv_helper.priv = state;
-               cli_req->mid = state->mid;
-               client_set_trans_sign_state_off(state->cli, state->mid);
-               cli_chain_uncork(state->cli);
-       }
-
-       client_set_trans_sign_state_on(state->cli, state->mid);
-
- fail:
-       TALLOC_FREE(frame);
-       return result;
+       *pwct = wct;
+       *piov_count = iov - state->iov;
 }
 
-static void cli_trans_ship_rest(struct async_req *req,
-                               struct cli_trans_state *state)
-{
-       state->secondary_request_ctx = talloc_new(state);
-       if (state->secondary_request_ctx == NULL) {
-               async_req_error(req, NT_STATUS_NO_MEMORY);
-               return;
-       }
-
-       while ((state->param_sent < state->num_param)
-              || (state->data_sent < state->num_data)) {
-               struct async_req *cli_req;
+static void cli_trans_done(struct tevent_req *subreq);
 
-               cli_req = cli_ship_trans(state->secondary_request_ctx, state);
-               if (cli_req == NULL) {
-                       async_req_error(req, NT_STATUS_NO_MEMORY);
-                       return;
-               }
-       }
-}
-
-static NTSTATUS cli_pull_trans(struct async_req *req,
-                              struct cli_request *cli_req,
-                              uint8_t smb_cmd, bool expect_first_reply,
-                              uint8_t *pnum_setup, uint16_t **psetup,
-                              uint32_t *ptotal_param, uint32_t *pnum_param,
-                              uint32_t *pparam_disp, uint8_t **pparam,
-                              uint32_t *ptotal_data, uint32_t *pnum_data,
-                              uint32_t *pdata_disp, uint8_t **pdata)
+struct tevent_req *cli_trans_send(
+       TALLOC_CTX *mem_ctx, struct event_context *ev,
+       struct cli_state *cli, uint8_t cmd,
+       const char *pipe_name, uint16_t fid, uint16_t function, int flags,
+       uint16_t *setup, uint8_t num_setup, uint8_t max_setup,
+       uint8_t *param, uint32_t num_param, uint32_t max_param,
+       uint8_t *data, uint32_t num_data, uint32_t max_data)
 {
-       uint32_t param_ofs, data_ofs;
+       struct tevent_req *req, *subreq;
+       struct cli_trans_state *state;
+       int iov_count;
        uint8_t wct;
-       uint16_t *vwv;
-       uint16_t num_bytes;
-       uint8_t *bytes;
        NTSTATUS status;
 
-       status = cli_pull_reply(req, &wct, &vwv, &num_bytes, &bytes);
-
-       /*
-        * We can receive something like STATUS_MORE_ENTRIES, so don't use
-        * !NT_STATUS_IS_OK(status) here.
-        */
-
-       if (NT_STATUS_IS_ERR(status)) {
-               return status;
+       req = tevent_req_create(mem_ctx, &state, struct cli_trans_state);
+       if (req == NULL) {
+               return NULL;
        }
 
-       if (expect_first_reply) {
-               if ((wct != 0) || (num_bytes != 0)) {
-                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
+       if ((cmd == SMBtrans) || (cmd == SMBtrans2)) {
+               if ((num_param > 0xffff) || (max_param > 0xffff)
+                   || (num_data > 0xffff) || (max_data > 0xffff)) {
+                       DEBUG(3, ("Attempt to send invalid trans2 request "
+                                 "(setup %u, params %u/%u, data %u/%u)\n",
+                                 (unsigned)num_setup,
+                                 (unsigned)num_param, (unsigned)max_param,
+                                 (unsigned)num_data, (unsigned)max_data));
+                       tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER);
+                       return tevent_req_post(req, ev);
                }
-               return NT_STATUS_OK;
        }
 
-       switch (smb_cmd) {
-       case SMBtrans:
-       case SMBtrans2:
-               if (wct < 10) {
-                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
-               }
-               *ptotal_param   = SVAL(vwv + 0, 0);
-               *ptotal_data    = SVAL(vwv + 1, 0);
-               *pnum_param     = SVAL(vwv + 3, 0);
-               param_ofs       = SVAL(vwv + 4, 0);
-               *pparam_disp    = SVAL(vwv + 5, 0);
-               *pnum_data      = SVAL(vwv + 6, 0);
-               data_ofs        = SVAL(vwv + 7, 0);
-               *pdata_disp     = SVAL(vwv + 8, 0);
-               *pnum_setup     = CVAL(vwv + 9, 0);
-               if (wct < 10 + (*pnum_setup)) {
-                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
-               }
-               *psetup = vwv + 10;
-
-               break;
-       case SMBnttrans:
-               if (wct < 18) {
-                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
-               }
-               *ptotal_param   = IVAL(vwv, 3);
-               *ptotal_data    = IVAL(vwv, 7);
-               *pnum_param     = IVAL(vwv, 11);
-               param_ofs       = IVAL(vwv, 15);
-               *pparam_disp    = IVAL(vwv, 19);
-               *pnum_data      = IVAL(vwv, 23);
-               data_ofs        = IVAL(vwv, 27);
-               *pdata_disp     = IVAL(vwv, 31);
-               *pnum_setup     = CVAL(vwv, 35);
-               *psetup         = vwv + 18;
-               break;
+       /*
+        * The largest wct will be for nttrans (19+num_setup). Make sure we
+        * don't overflow state->vwv in cli_trans_format.
+        */
 
-       default:
-               return NT_STATUS_INTERNAL_ERROR;
+       if ((num_setup + 19) > ARRAY_SIZE(state->vwv)) {
+               tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER);
+               return tevent_req_post(req, ev);
        }
 
-       /*
-        * Check for buffer overflows. data_ofs needs to be checked against
-        * the incoming buffer length, data_disp against the total
-        * length. Likewise for param_ofs/param_disp.
-        */
+       state->cli = cli;
+       state->ev = ev;
+       state->cmd = cmd;
+       state->flags = flags;
+       state->num_rsetup = 0;
+       state->rsetup = NULL;
+       ZERO_STRUCT(state->rparam);
+       ZERO_STRUCT(state->rdata);
 
-       if (trans_oob(smb_len(cli_req->inbuf), param_ofs, *pnum_param)
-           || trans_oob(*ptotal_param, *pparam_disp, *pnum_param)
-           || trans_oob(smb_len(cli_req->inbuf), data_ofs, *pnum_data)
-           || trans_oob(*ptotal_data, *pdata_disp, *pnum_data)) {
-               return NT_STATUS_INVALID_NETWORK_RESPONSE;
+       if ((pipe_name != NULL)
+           && (!convert_string_talloc(state, CH_UNIX,
+                                      cli_ucs2(cli) ? CH_UTF16LE : CH_DOS,
+                                      pipe_name, strlen(pipe_name) + 1,
+                                      &state->pipe_name_conv,
+                                      &state->pipe_name_conv_len, true))) {
+               tevent_req_nterror(req, NT_STATUS_NO_MEMORY);
+               return tevent_req_post(req, ev);
        }
+       state->fid = fid;       /* trans2 */
+       state->function = function; /* nttrans */
 
-       *pparam = (uint8_t *)cli_req->inbuf + 4 + param_ofs;
-       *pdata = (uint8_t *)cli_req->inbuf + 4 + data_ofs;
+       state->setup = setup;
+       state->num_setup = num_setup;
+       state->max_setup = max_setup;
 
-       return NT_STATUS_OK;
-}
+       state->param = param;
+       state->num_param = num_param;
+       state->param_sent = 0;
+       state->rparam.max = max_param;
 
-static NTSTATUS cli_trans_pull_blob(TALLOC_CTX *mem_ctx,
-                                   struct trans_recvblob *blob,
-                                   uint32_t total, uint32_t thistime,
-                                   uint8_t *buf, uint32_t displacement)
-{
-       if (blob->data == NULL) {
-               if (total > blob->max) {
-                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
-               }
-               blob->total = total;
-               blob->data = TALLOC_ARRAY(mem_ctx, uint8_t, total);
-               if (blob->data == NULL) {
-                       return NT_STATUS_NO_MEMORY;
-               }
-       }
+       state->data = data;
+       state->num_data = num_data;
+       state->data_sent = 0;
+       state->rdata.max = max_data;
 
-       if (total > blob->total) {
-               return NT_STATUS_INVALID_NETWORK_RESPONSE;
-       }
+       cli_trans_format(state, &wct, &iov_count);
 
-       if (thistime) {
-               memcpy(blob->data + displacement, buf, thistime);
-               blob->received += thistime;
+       subreq = cli_smb_req_create(state, ev, cli, cmd, 0, wct, state->vwv,
+                                   iov_count, state->iov);
+       if (tevent_req_nomem(subreq, req)) {
+               return tevent_req_post(req, ev);
        }
-
-       return NT_STATUS_OK;
+       state->mid = cli_smb_req_mid(subreq);
+       status = cli_smb_req_send(subreq);
+       if (!NT_STATUS_IS_OK(status)) {
+               tevent_req_nterror(req, status);
+               return tevent_req_post(req, state->ev);
+       }
+       cli_state_seqnum_persistent(cli, state->mid);
+       tevent_req_set_callback(subreq, cli_trans_done, req);
+       return req;
 }
 
-static void cli_trans_recv_helper(struct async_req *req)
+static void cli_trans_done(struct tevent_req *subreq)
 {
-       struct cli_request *cli_req = talloc_get_type_abort(
-               req->private_data, struct cli_request);
-       struct cli_trans_state *state = talloc_get_type_abort(
-               cli_req->recv_helper.priv, struct cli_trans_state);
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct cli_trans_state *state = tevent_req_data(
+               req, struct cli_trans_state);
+       NTSTATUS status;
+       bool sent_all;
+       uint8_t wct;
+       uint16_t *vwv;
+       uint32_t num_bytes;
+       uint8_t *bytes;
+       uint8_t *inbuf;
        uint8_t num_setup       = 0;
        uint16_t *setup         = NULL;
        uint32_t total_param    = 0;
@@ -1116,16 +1117,13 @@ static void cli_trans_recv_helper(struct async_req *req)
        uint32_t data_disp      = 0;
        uint8_t *param          = NULL;
        uint8_t *data           = NULL;
-       bool sent_all;
-       NTSTATUS status;
-
-       sent_all = (state->param_sent == state->num_param)
-               && (state->data_sent == state->num_data);
 
-       status = cli_pull_trans(
-               req, cli_req, state->cmd, !sent_all, &num_setup, &setup,
-               &total_param, &num_param, &param_disp, &param,
-               &total_data, &num_data, &data_disp, &data);
+       status = cli_smb_recv(subreq, state, &inbuf, 0, &wct, &vwv,
+                             &num_bytes, &bytes);
+       /*
+        * Do not TALLOC_FREE(subreq) here, we might receive more than
+        * one response for the same mid.
+        */
 
        /*
         * We can receive something like STATUS_MORE_ENTRIES, so don't use
@@ -1133,30 +1131,44 @@ static void cli_trans_recv_helper(struct async_req *req)
         */
 
        if (NT_STATUS_IS_ERR(status)) {
-               async_req_error(req, status);
-               return;
+               goto fail;
        }
 
-       if (!sent_all) {
-               cli_trans_ship_rest(req, state);
-               return;
+       sent_all = ((state->param_sent == state->num_param)
+                   && (state->data_sent == state->num_data));
+
+       status = cli_pull_trans(
+               inbuf, wct, vwv, num_bytes, bytes,
+               state->cmd, !sent_all, &num_setup, &setup,
+               &total_param, &num_param, &param_disp, &param,
+               &total_data, &num_data, &data_disp, &data);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               goto fail;
        }
 
-       /*
-        * We've just received a real response. This means that we don't need
-        * the secondary cli_request structures anymore, they have all been
-        * shipped to the server.
-        */
-       TALLOC_FREE(state->secondary_request_ctx);
+       if (!sent_all) {
+               int iov_count;
 
-       if (num_setup != 0) {
-               TALLOC_FREE(state->rsetup);
-               state->rsetup = (uint16_t *)TALLOC_MEMDUP(
-                       state, setup, sizeof(uint16_t) * num_setup);
-               if (state->rsetup == NULL) {
-                       async_req_error(req, NT_STATUS_NO_MEMORY);
+               TALLOC_FREE(subreq);
+
+               cli_trans_format(state, &wct, &iov_count);
+
+               subreq = cli_smb_req_create(state, state->ev, state->cli,
+                                           state->cmd + 1, 0, wct, state->vwv,
+                                           iov_count, state->iov);
+               if (tevent_req_nomem(subreq, req)) {
                        return;
                }
+               cli_smb_req_set_mid(subreq, state->mid);
+
+               status = cli_smb_req_send(subreq);
+
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto fail;
+               }
+               tevent_req_set_callback(subreq, cli_trans_done, req);
+               return;
        }
 
        status = cli_trans_pull_blob(
@@ -1165,8 +1177,7 @@ static void cli_trans_recv_helper(struct async_req *req)
 
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(10, ("Pulling params failed: %s\n", nt_errstr(status)));
-               async_req_error(req, status);
-               return;
+               goto fail;
        }
 
        status = cli_trans_pull_blob(
@@ -1175,151 +1186,51 @@ static void cli_trans_recv_helper(struct async_req *req)
 
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(10, ("Pulling data failed: %s\n", nt_errstr(status)));
-               async_req_error(req, status);
-               return;
+               goto fail;
        }
 
        if ((state->rparam.total == state->rparam.received)
            && (state->rdata.total == state->rdata.received)) {
-               client_set_trans_sign_state_off(state->cli, state->mid);
-               async_req_done(req);
-       }
-}
-
-struct async_req *cli_trans_send(
-       TALLOC_CTX *mem_ctx, struct event_context *ev,
-       struct cli_state *cli, uint8_t trans_cmd,
-       const char *pipe_name, uint16_t fid, uint16_t function, int flags,
-       uint16_t *setup, uint8_t num_setup, uint8_t max_setup,
-       uint8_t *param, uint32_t num_param, uint32_t max_param,
-       uint8_t *data, uint32_t num_data, uint32_t max_data)
-{
-       struct async_req *req;
-       struct cli_request *cli_req;
-       struct cli_trans_state *state;
-
-       /*
-        * We can't use it in a chained request chain, we'd get the offset
-        * calculations wrong.
-        */
-
-       if (cli_in_chain(cli)) {
-               return NULL;
-       }
-
-       if ((trans_cmd == SMBtrans) || (trans_cmd == SMBtrans2)) {
-               if ((num_param > 0xffff) || (max_param > 0xffff)
-                   || (num_data > 0xffff) || (max_data > 0xffff)) {
-                       DEBUG(3, ("Attempt to send invalid trans2 request "
-                                 "(setup %u, params %u/%u, data %u/%u)\n",
-                                 (unsigned)num_setup,
-                                 (unsigned)num_param, (unsigned)max_param,
-                                 (unsigned)num_data, (unsigned)max_data));
-                       return NULL;
-               }
-       }
-
-       state = talloc(mem_ctx, struct cli_trans_state);
-       if (state == NULL) {
-               goto nomem;
-       }
-
-       state->cli = cli;
-       state->ev = ev;
-       state->cmd = trans_cmd;
-       state->num_rsetup = 0;
-       state->rsetup = NULL;
-       ZERO_STRUCT(state->rparam);
-       ZERO_STRUCT(state->rdata);
-       state->secondary_request_ctx = NULL;
-
-       if (trans_cmd == SMBtrans) {
-               state->pipe_name = talloc_strdup(state, pipe_name);
-               if (state->pipe_name == NULL) {
-                       goto nomem;
-               }
-       }
-       if (trans_cmd == SMBtrans2) {
-               state->fid = fid;
-       }
-       if (trans_cmd == SMBnttrans) {
-               state->function = function;
-       }
-
-       state->flags = flags;
-
-       if (setup != NULL) {
-               state->setup = (uint16_t *)TALLOC_MEMDUP(
-                       state, setup, sizeof(*setup) * num_setup);
-               if (state->setup == NULL) {
-                       goto nomem;
-               }
-               state->num_setup = num_setup;
-       } else {
-               state->setup = NULL;
-               state->num_setup = 0;
+               TALLOC_FREE(subreq);
+               cli_state_seqnum_remove(state->cli, state->mid);
+               tevent_req_done(req);
+               return;
        }
 
-       state->max_setup = max_setup;
+       TALLOC_FREE(inbuf);
 
-       if (param != NULL) {
-               state->param = (uint8_t *)TALLOC_MEMDUP(state, param,
-                                                       num_param);
-               if (state->param == NULL) {
-                       goto nomem;
-               }
-               state->num_param = num_param;
-       } else {
-               state->param = NULL;
-               state->num_param = 0;
+       if (!cli_smb_req_set_pending(subreq)) {
+               status = NT_STATUS_NO_MEMORY;
+               goto fail;
        }
+       return;
 
-       state->param_sent = 0;
-       state->rparam.max = max_param;
-
-       if (data != NULL) {
-               state->data = (uint8_t *)TALLOC_MEMDUP(state, data, num_data);
-               if (state->data == NULL) {
-                       goto nomem;
-               }
-               state->num_data = num_data;
-       } else {
-               state->data = NULL;
-               state->num_data = 0;
-       }
+ fail:
+       cli_state_seqnum_remove(state->cli, state->mid);
+       TALLOC_FREE(subreq);
+       tevent_req_nterror(req, status);
+}
 
-       state->data_sent = 0;
-       state->rdata.max = max_data;
+NTSTATUS cli_trans_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
+                       uint16_t **setup, uint8_t min_setup,
+                       uint8_t *num_setup,
+                       uint8_t **param, uint32_t min_param,
+                       uint32_t *num_param,
+                       uint8_t **data, uint32_t min_data,
+                       uint32_t *num_data)
+{
+       struct cli_trans_state *state = tevent_req_data(
+               req, struct cli_trans_state);
+       NTSTATUS status;
 
-       req = cli_ship_trans(state, state);
-       if (req == NULL) {
-               goto nomem;
+       if (tevent_req_is_nterror(req, &status)) {
+               return status;
        }
 
-       cli_req = talloc_get_type_abort(req->private_data, struct cli_request);
-       cli_req->recv_helper.fn = cli_trans_recv_helper;
-       cli_req->recv_helper.priv = state;
-
-       return req;
-
- nomem:
-       TALLOC_FREE(state);
-       return NULL;
-}
-
-NTSTATUS cli_trans_recv(struct async_req *req, TALLOC_CTX *mem_ctx,
-                       uint16_t **setup, uint8_t *num_setup,
-                       uint8_t **param, uint32_t *num_param,
-                       uint8_t **data, uint32_t *num_data)
-{
-       struct cli_request *cli_req = talloc_get_type_abort(
-               req->private_data, struct cli_request);
-       struct cli_trans_state *state = talloc_get_type_abort(
-               cli_req->recv_helper.priv, struct cli_trans_state);
-
-       SMB_ASSERT(req->state >= ASYNC_REQ_DONE);
-       if (req->state == ASYNC_REQ_ERROR) {
-               return req->status;
+       if ((state->num_rsetup < min_setup)
+           || (state->rparam.total < min_param)
+           || (state->rdata.total < min_data)) {
+               return NT_STATUS_INVALID_NETWORK_RESPONSE;
        }
 
        if (setup != NULL) {
@@ -1353,25 +1264,26 @@ NTSTATUS cli_trans(TALLOC_CTX *mem_ctx, struct cli_state *cli,
                   uint16_t *setup, uint8_t num_setup, uint8_t max_setup,
                   uint8_t *param, uint32_t num_param, uint32_t max_param,
                   uint8_t *data, uint32_t num_data, uint32_t max_data,
-                  uint16_t **rsetup, uint8_t *num_rsetup,
-                  uint8_t **rparam, uint32_t *num_rparam,
-                  uint8_t **rdata, uint32_t *num_rdata)
+                  uint16_t **rsetup, uint8_t min_rsetup, uint8_t *num_rsetup,
+                  uint8_t **rparam, uint32_t min_rparam, uint32_t *num_rparam,
+                  uint8_t **rdata, uint32_t min_rdata, uint32_t *num_rdata)
 {
        TALLOC_CTX *frame = talloc_stackframe();
        struct event_context *ev;
-       struct async_req *req;
-       NTSTATUS status = NT_STATUS_NO_MEMORY;
+       struct tevent_req *req;
+       NTSTATUS status = NT_STATUS_OK;
 
-       if (cli->fd_event != NULL) {
+       if (cli_has_async_calls(cli)) {
                /*
                 * Can't use sync call while an async call is in flight
                 */
-               cli_set_error(cli, NT_STATUS_INVALID_PARAMETER);
+               status = NT_STATUS_INVALID_PARAMETER;
                goto fail;
        }
 
        ev = event_context_init(frame);
        if (ev == NULL) {
+               status = NT_STATUS_NO_MEMORY;
                goto fail;
        }
 
@@ -1381,16 +1293,22 @@ NTSTATUS cli_trans(TALLOC_CTX *mem_ctx, struct cli_state *cli,
                             param, num_param, max_param,
                             data, num_data, max_data);
        if (req == NULL) {
+               status = NT_STATUS_NO_MEMORY;
                goto fail;
        }
 
-       while (req->state < ASYNC_REQ_DONE) {
-               event_loop_once(ev);
+       if (!tevent_req_poll(req, ev)) {
+               status = map_nt_error_from_unix(errno);
+               goto fail;
        }
 
-       status = cli_trans_recv(req, mem_ctx, rsetup, num_rsetup,
-                               rparam, num_rparam, rdata, num_rdata);
+       status = cli_trans_recv(req, mem_ctx, rsetup, min_rsetup, num_rsetup,
+                               rparam, min_rparam, num_rparam,
+                               rdata, min_rdata, num_rdata);
  fail:
        TALLOC_FREE(frame);
+       if (!NT_STATUS_IS_OK(status)) {
+               cli_set_error(cli, status);
+       }
        return status;
 }