r23151: Re-arrange the logic so it looks identical to the
[sfrench/samba-autobuild/.git] / source / smbd / open.c
index 4e91cdfd2a1b406ca8cfc7da6a4038ce68b13cf9..987da7a94daa0bd79df39bafff3272f8587250f1 100644 (file)
@@ -38,43 +38,48 @@ struct deferred_open_record {
  fd support routines - attempt to do a dos_open.
 ****************************************************************************/
 
-static BOOL fd_open(struct connection_struct *conn,
+static NTSTATUS fd_open(struct connection_struct *conn,
                    const char *fname, 
                    files_struct *fsp,
                    int flags,
                    mode_t mode)
 {
-       int sav;
+       NTSTATUS status = NT_STATUS_OK;
 
 #ifdef O_NOFOLLOW
-       if (!lp_symlinks(SNUM(conn))) {
+       /* 
+        * Never follow symlinks on a POSIX client. The
+        * client should be doing this.
+        */
+
+       if (fsp->posix_open || !lp_symlinks(SNUM(conn))) {
                flags |= O_NOFOLLOW;
        }
 #endif
 
        fsp->fh->fd = SMB_VFS_OPEN(conn,fname,fsp,flags,mode);
-       sav = errno;
+       if (fsp->fh->fd == -1) {
+               status = map_nt_error_from_unix(errno);
+       }
 
        DEBUG(10,("fd_open: name %s, flags = 0%o mode = 0%o, fd = %d. %s\n",
                    fname, flags, (int)mode, fsp->fh->fd,
                (fsp->fh->fd == -1) ? strerror(errno) : "" ));
 
-       errno = sav;
-       return fsp->fh->fd != -1;
+       return status;
 }
 
 /****************************************************************************
  Close the file associated with a fsp.
 ****************************************************************************/
 
-int fd_close(struct connection_struct *conn,
-            files_struct *fsp)
+NTSTATUS fd_close(struct connection_struct *conn, files_struct *fsp)
 {
        if (fsp->fh->fd == -1) {
-               return 0; /* What we used to call a stat open. */
+               return NT_STATUS_OK; /* What we used to call a stat open. */
        }
        if (fsp->fh->ref_count > 1) {
-               return 0; /* Shared handle. Only close last reference. */
+               return NT_STATUS_OK; /* Shared handle. Only close last reference. */
        }
        return fd_close_posix(conn, fsp);
 }
@@ -84,100 +89,111 @@ int fd_close(struct connection_struct *conn,
  Do this by fd if possible.
 ****************************************************************************/
 
-void change_owner_to_parent(connection_struct *conn,
-                           files_struct *fsp,
-                           const char *fname,
-                           SMB_STRUCT_STAT *psbuf)
+static void change_file_owner_to_parent(connection_struct *conn,
+                                       const char *inherit_from_dir,
+                                       files_struct *fsp)
 {
-       const char *parent_path = parent_dirname(fname);
        SMB_STRUCT_STAT parent_st;
        int ret;
 
-       ret = SMB_VFS_STAT(conn, parent_path, &parent_st);
+       ret = SMB_VFS_STAT(conn, inherit_from_dir, &parent_st);
        if (ret == -1) {
-               DEBUG(0,("change_owner_to_parent: failed to stat parent "
+               DEBUG(0,("change_file_owner_to_parent: failed to stat parent "
                         "directory %s. Error was %s\n",
-                        parent_path, strerror(errno) ));
+                        inherit_from_dir, strerror(errno) ));
                return;
        }
 
-       if (fsp && fsp->fh->fd != -1) {
-               become_root();
-               ret = SMB_VFS_FCHOWN(fsp, fsp->fh->fd, parent_st.st_uid, (gid_t)-1);
-               unbecome_root();
-               if (ret == -1) {
-                       DEBUG(0,("change_owner_to_parent: failed to fchown "
-                                "file %s to parent directory uid %u. Error "
-                                "was %s\n", fname,
-                                (unsigned int)parent_st.st_uid,
-                                strerror(errno) ));
-               }
+       become_root();
+       ret = SMB_VFS_FCHOWN(fsp, fsp->fh->fd, parent_st.st_uid, (gid_t)-1);
+       unbecome_root();
+       if (ret == -1) {
+               DEBUG(0,("change_file_owner_to_parent: failed to fchown "
+                        "file %s to parent directory uid %u. Error "
+                        "was %s\n", fsp->fsp_name,
+                        (unsigned int)parent_st.st_uid,
+                        strerror(errno) ));
+       }
 
-               DEBUG(10,("change_owner_to_parent: changed new file %s to "
-                         "parent directory uid %u.\n", fname,
-                         (unsigned int)parent_st.st_uid ));
+       DEBUG(10,("change_file_owner_to_parent: changed new file %s to "
+                 "parent directory uid %u.\n", fsp->fsp_name,
+                 (unsigned int)parent_st.st_uid ));
+}
 
-       } else {
-               /* We've already done an lstat into psbuf, and we know it's a
-                  directory. If we can cd into the directory and the dev/ino
-                  are the same then we can safely chown without races as
-                  we're locking the directory in place by being in it.  This
-                  should work on any UNIX (thanks tridge :-). JRA.
-               */
-
-               pstring saved_dir;
-               SMB_STRUCT_STAT sbuf;
-
-               if (!vfs_GetWd(conn,saved_dir)) {
-                       DEBUG(0,("change_owner_to_parent: failed to get "
-                                "current working directory\n"));
-                       return;
-               }
+static void change_dir_owner_to_parent(connection_struct *conn,
+                                      const char *inherit_from_dir,
+                                      const char *fname,
+                                      SMB_STRUCT_STAT *psbuf)
+{
+       pstring saved_dir;
+       SMB_STRUCT_STAT sbuf;
+       SMB_STRUCT_STAT parent_st;
+       int ret;
 
-               /* Chdir into the new path. */
-               if (vfs_ChDir(conn, fname) == -1) {
-                       DEBUG(0,("change_owner_to_parent: failed to change "
-                                "current working directory to %s. Error "
-                                "was %s\n", fname, strerror(errno) ));
-                       goto out;
-               }
+       ret = SMB_VFS_STAT(conn, inherit_from_dir, &parent_st);
+       if (ret == -1) {
+               DEBUG(0,("change_dir_owner_to_parent: failed to stat parent "
+                        "directory %s. Error was %s\n",
+                        inherit_from_dir, strerror(errno) ));
+               return;
+       }
 
-               if (SMB_VFS_STAT(conn,".",&sbuf) == -1) {
-                       DEBUG(0,("change_owner_to_parent: failed to stat "
-                                "directory '.' (%s) Error was %s\n",
-                                fname, strerror(errno)));
-                       goto out;
-               }
+       /* We've already done an lstat into psbuf, and we know it's a
+          directory. If we can cd into the directory and the dev/ino
+          are the same then we can safely chown without races as
+          we're locking the directory in place by being in it.  This
+          should work on any UNIX (thanks tridge :-). JRA.
+       */
 
-               /* Ensure we're pointing at the same place. */
-               if (sbuf.st_dev != psbuf->st_dev ||
-                   sbuf.st_ino != psbuf->st_ino ||
-                   sbuf.st_mode != psbuf->st_mode ) {
-                       DEBUG(0,("change_owner_to_parent: "
-                                "device/inode/mode on directory %s changed. "
-                                "Refusing to chown !\n", fname ));
-                       goto out;
-               }
+       if (!vfs_GetWd(conn,saved_dir)) {
+               DEBUG(0,("change_dir_owner_to_parent: failed to get "
+                        "current working directory\n"));
+               return;
+       }
 
-               become_root();
-               ret = SMB_VFS_CHOWN(conn, ".", parent_st.st_uid, (gid_t)-1);
-               unbecome_root();
-               if (ret == -1) {
-                       DEBUG(10,("change_owner_to_parent: failed to chown "
-                                 "directory %s to parent directory uid %u. "
-                                 "Error was %s\n", fname,
-                                 (unsigned int)parent_st.st_uid, strerror(errno) ));
-                       goto out;
-               }
+       /* Chdir into the new path. */
+       if (vfs_ChDir(conn, fname) == -1) {
+               DEBUG(0,("change_dir_owner_to_parent: failed to change "
+                        "current working directory to %s. Error "
+                        "was %s\n", fname, strerror(errno) ));
+               goto out;
+       }
 
-               DEBUG(10,("change_owner_to_parent: changed ownership of new "
-                         "directory %s to parent directory uid %u.\n",
-                         fname, (unsigned int)parent_st.st_uid ));
+       if (SMB_VFS_STAT(conn,".",&sbuf) == -1) {
+               DEBUG(0,("change_dir_owner_to_parent: failed to stat "
+                        "directory '.' (%s) Error was %s\n",
+                        fname, strerror(errno)));
+               goto out;
+       }
 
-  out:
+       /* Ensure we're pointing at the same place. */
+       if (sbuf.st_dev != psbuf->st_dev ||
+           sbuf.st_ino != psbuf->st_ino ||
+           sbuf.st_mode != psbuf->st_mode ) {
+               DEBUG(0,("change_dir_owner_to_parent: "
+                        "device/inode/mode on directory %s changed. "
+                        "Refusing to chown !\n", fname ));
+               goto out;
+       }
 
-               vfs_ChDir(conn,saved_dir);
+       become_root();
+       ret = SMB_VFS_CHOWN(conn, ".", parent_st.st_uid, (gid_t)-1);
+       unbecome_root();
+       if (ret == -1) {
+               DEBUG(10,("change_dir_owner_to_parent: failed to chown "
+                         "directory %s to parent directory uid %u. "
+                         "Error was %s\n", fname,
+                         (unsigned int)parent_st.st_uid, strerror(errno) ));
+               goto out;
        }
+
+       DEBUG(10,("change_dir_owner_to_parent: changed ownership of new "
+                 "directory %s to parent directory uid %u.\n",
+                 fname, (unsigned int)parent_st.st_uid ));
+
+ out:
+
+       vfs_ChDir(conn,saved_dir);
 }
 
 /****************************************************************************
@@ -186,13 +202,16 @@ void change_owner_to_parent(connection_struct *conn,
 
 static NTSTATUS open_file(files_struct *fsp,
                          connection_struct *conn,
-                         const char *fname,
+                         const char *parent_dir,
+                         const char *name,
+                         const char *path,
                          SMB_STRUCT_STAT *psbuf,
                          int flags,
                          mode_t unx_mode,
                          uint32 access_mask, /* client requested access mask. */
                          uint32 open_access_mask) /* what we're actually using in the open. */
 {
+       NTSTATUS status = NT_STATUS_OK;
        int accmode = (flags & O_ACCMODE);
        int local_flags = flags;
        BOOL file_existed = VALID_STAT(*psbuf);
@@ -215,7 +234,7 @@ static NTSTATUS open_file(files_struct *fsp,
        if (!CAN_WRITE(conn)) {
                /* It's a read-only share - fail if we wanted to write. */
                if(accmode != O_RDONLY) {
-                       DEBUG(3,("Permission denied opening %s\n",fname));
+                       DEBUG(3,("Permission denied opening %s\n", path));
                        return NT_STATUS_ACCESS_DENIED;
                } else if(flags & O_CREAT) {
                        /* We don't want to write - but we must make sure that
@@ -241,7 +260,7 @@ static NTSTATUS open_file(files_struct *fsp,
 
        if ((accmode == O_RDONLY) && ((flags & O_TRUNC) == O_TRUNC)) {
                DEBUG(10,("open_file: truncate requested on read-only open "
-                         "for file %s\n",fname ));
+                         "for file %s\n", path));
                local_flags = (flags & ~O_ACCMODE)|O_RDWR;
        }
 
@@ -270,21 +289,35 @@ static NTSTATUS open_file(files_struct *fsp,
 
                /* Don't create files with Microsoft wildcard characters. */
                if ((local_flags & O_CREAT) && !file_existed &&
-                   ms_has_wild(fname))  {
+                   ms_has_wild(path))  {
                        return NT_STATUS_OBJECT_NAME_INVALID;
                }
 
                /* Actually do the open */
-               if (!fd_open(conn, fname, fsp, local_flags, unx_mode)) {
+               status = fd_open(conn, path, fsp, local_flags, unx_mode);
+               if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(3,("Error opening file %s (%s) (local_flags=%d) "
                                 "(flags=%d)\n",
-                                fname,strerror(errno),local_flags,flags));
-                       return map_nt_error_from_unix(errno);
+                                path,nt_errstr(status),local_flags,flags));
+                       return status;
                }
 
-               /* Inherit the ACL if the file was created. */
                if ((local_flags & O_CREAT) && !file_existed) {
-                       inherit_access_acl(conn, fname, unx_mode);
+
+                       /* Inherit the ACL if required */
+                       if (lp_inherit_perms(SNUM(conn))) {
+                               inherit_access_acl(conn, parent_dir, path,
+                                                  unx_mode);
+                       }
+
+                       /* Change the owner if required. */
+                       if (lp_inherit_owner(SNUM(conn))) {
+                               change_file_owner_to_parent(conn, parent_dir,
+                                                           fsp);
+                       }
+
+                       notify_fname(conn, NOTIFY_ACTION_ADDED,
+                                    FILE_NOTIFY_CHANGE_FILE_NAME, path);
                }
 
        } else {
@@ -295,19 +328,19 @@ static NTSTATUS open_file(files_struct *fsp,
                int ret;
 
                if (fsp->fh->fd == -1) {
-                       ret = SMB_VFS_STAT(conn, fname, psbuf);
+                       ret = SMB_VFS_STAT(conn, path, psbuf);
                } else {
                        ret = SMB_VFS_FSTAT(fsp,fsp->fh->fd,psbuf);
                        /* If we have an fd, this stat should succeed. */
                        if (ret == -1) {
                                DEBUG(0,("Error doing fstat on open file %s "
-                                        "(%s)\n", fname,strerror(errno) ));
+                                        "(%s)\n", path,strerror(errno) ));
                        }
                }
 
                /* For a non-io open, this stat failing means file not found. JRA */
                if (ret == -1) {
-                       NTSTATUS status = map_nt_error_from_unix(errno);
+                       status = map_nt_error_from_unix(errno);
                        fd_close(conn, fsp);
                        return status;
                }
@@ -343,12 +376,8 @@ static NTSTATUS open_file(files_struct *fsp,
        fsp->sent_oplock_break = NO_BREAK_SENT;
        fsp->is_directory = False;
        fsp->is_stat = False;
-       if (conn->aio_write_behind_list &&
-           is_in_path(fname, conn->aio_write_behind_list, conn->case_sensitive)) {
-               fsp->aio_write_behind = True;
-       }
 
-       string_set(&fsp->fsp_name,fname);
+       string_set(&fsp->fsp_name, path);
        fsp->wcp = NULL; /* Write cache pointer. */
 
        DEBUG(2,("%s opened file %s read=%s write=%s (numopen=%d)\n",
@@ -625,7 +654,7 @@ static BOOL delay_for_oplocks(struct share_mode_lock *lck,
        BOOL valid_entry = False;
        BOOL delay_it = False;
        BOOL have_level2 = False;
-       BOOL ret;
+       NTSTATUS status;
        char msg[MSG_SMB_SHARE_MODE_ENTRY_SIZE];
 
        if (oplock_request & INTERNAL_OPEN_ONLY) {
@@ -713,10 +742,13 @@ static BOOL delay_for_oplocks(struct share_mode_lock *lck,
                SSVAL(msg,6,exclusive->op_type | FORCE_OPLOCK_BREAK_TO_NONE);
        }
 
-       ret = message_send_pid(exclusive->pid, MSG_SMB_BREAK_REQUEST,
-                              msg, MSG_SMB_SHARE_MODE_ENTRY_SIZE, True);
-       if (!ret) {
-               DEBUG(3, ("Could not send oplock break message\n"));
+       status = messaging_send_buf(smbd_messaging_context(), exclusive->pid,
+                                   MSG_SMB_BREAK_REQUEST,
+                                   (uint8 *)msg,
+                                   MSG_SMB_SHARE_MODE_ENTRY_SIZE);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(3, ("Could not send oplock break message: %s\n",
+                         nt_errstr(status)));
        }
 
        return True;
@@ -783,28 +815,6 @@ static void defer_open(struct share_mode_lock *lck,
        srv_defer_sign_response(mid);
 }
 
-/****************************************************************************
- Set a kernel flock on a file for NFS interoperability.
- This requires a patch to Linux.
-****************************************************************************/
-
-static void kernel_flock(files_struct *fsp, uint32 share_mode)
-{
-#if HAVE_KERNEL_SHARE_MODES
-       int kernel_mode = 0;
-       if (share_mode == FILE_SHARE_WRITE) {
-               kernel_mode = LOCK_MAND|LOCK_WRITE;
-       } else if (share_mode == FILE_SHARE_READ) {
-               kernel_mode = LOCK_MAND|LOCK_READ;
-       } else if (share_mode == FILE_SHARE_NONE) {
-               kernel_mode = LOCK_MAND;
-       }
-       if (kernel_mode) {
-               flock(fsp->fh->fd, kernel_mode);
-       }
-#endif
-       ;
-}
 
 /****************************************************************************
  On overwrite open ensure that the attributes match.
@@ -1112,6 +1122,8 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
        int flags2=0;
        BOOL file_existed = VALID_STAT(*psbuf);
        BOOL def_acl = False;
+       BOOL posix_open = False;
+       BOOL new_file_created = False;
        SMB_DEV_T dev = 0;
        SMB_INO_T inode = 0;
        NTSTATUS fsp_open = NT_STATUS_ACCESS_DENIED;
@@ -1126,6 +1138,9 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
        struct share_mode_lock *lck = NULL;
        uint32 open_access_mask = access_mask;
        NTSTATUS status;
+       int ret_flock;
+       char *parent_dir;
+       const char *newname;
 
        if (conn->printer) {
                /* 
@@ -1142,9 +1157,21 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
                return print_fsp_open(conn, fname, result);
        }
 
-       /* We add aARCH to this as this mode is only used if the file is
-        * created new. */
-       unx_mode = unix_mode(conn, new_dos_attributes | aARCH,fname, True);
+       if (!parent_dirname_talloc(tmp_talloc_ctx(), fname, &parent_dir,
+                                  &newname)) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       if (new_dos_attributes & FILE_FLAG_POSIX_SEMANTICS) {
+               posix_open = True;
+               unx_mode = (mode_t)(new_dos_attributes & ~FILE_FLAG_POSIX_SEMANTICS);
+               new_dos_attributes = 0;
+       } else {
+               /* We add aARCH to this as this mode is only used if the file is
+                * created new. */
+               unx_mode = unix_mode(conn, new_dos_attributes | aARCH, fname,
+                                    parent_dir);
+       }
 
        DEBUG(10, ("open_file_ntcreate: fname=%s, dos_attrs=0x%x "
                   "access_mask=0x%x share_access=0x%x "
@@ -1177,13 +1204,16 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
                remove_deferred_open_smb_message(mid);
        }
 
-       if (!check_name(fname,conn)) {
-               return map_nt_error_from_unix(errno);
+       status = check_name(conn, fname);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        } 
 
-       new_dos_attributes &= SAMBA_ATTRIBUTES_MASK;
-       if (file_existed) {
-               existing_dos_attributes = dos_mode(conn, fname, psbuf);
+       if (!posix_open) {
+               new_dos_attributes &= SAMBA_ATTRIBUTES_MASK;
+               if (file_existed) {
+                       existing_dos_attributes = dos_mode(conn, fname, psbuf);
+               }
        }
 
        /* ignore any oplock requests if oplocks are disabled */
@@ -1196,7 +1226,7 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
        /* this is for OS/2 long file names - say we don't support them */
        if (!lp_posix_pathnames() && strstr(fname,".+,;=[].")) {
                /* OS/2 Workplace shell fix may be main code stream in a later
-                * release. */ 
+                * release. */
                DEBUG(5,("open_file_ntcreate: OS/2 long filenames are not "
                         "supported.\n"));
                if (use_nt_status()) {
@@ -1278,7 +1308,7 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
        /* We only care about matching attributes on file exists and
         * overwrite. */
 
-       if (file_existed && ((create_disposition == FILE_OVERWRITE) ||
+       if (!posix_open && file_existed && ((create_disposition == FILE_OVERWRITE) ||
                             (create_disposition == FILE_OVERWRITE_IF))) {
                if (!open_match_attributes(conn, fname,
                                           existing_dos_attributes,
@@ -1320,7 +1350,15 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
         */
 
        if (access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) {
-               flags = O_RDWR;
+               /* DENY_DOS opens are always underlying read-write on the
+                  file handle, no matter what the requested access mask
+                   says. */
+               if ((create_options & NTCREATEX_OPTIONS_PRIVATE_DENY_DOS) ||
+                       access_mask & (FILE_READ_ATTRIBUTES|FILE_READ_DATA|FILE_READ_EA|FILE_EXECUTE)) {
+                       flags = O_RDWR;
+               } else {
+                       flags = O_WRONLY;
+               }
        } else {
                flags = O_RDONLY;
        }
@@ -1335,7 +1373,11 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
        }
 #endif /* O_SYNC */
   
-       if (!CAN_WRITE(conn)) {
+       if (posix_open & (access_mask & FILE_APPEND_DATA)) {
+               flags2 |= O_APPEND;
+       }
+
+       if (!posix_open && !CAN_WRITE(conn)) {
                /*
                 * We should really return a permission denied error if either
                 * O_CREAT or O_TRUNC are set, but for compatibility with
@@ -1369,6 +1411,8 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
        fsp->access_mask = open_access_mask; /* We change this to the
                                              * requested access_mask after
                                              * the open is done. */
+       fsp->posix_open = posix_open;
+
        /* Ensure no SAMBA_PRIVATE bits can be set. */
        fsp->oplock_type = (oplock_request & ~SAMBA_PRIVATE_OPLOCK_MASK);
 
@@ -1468,11 +1512,13 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
 
                        if (flags & O_RDWR) {
                                can_access_mask = FILE_READ_DATA|FILE_WRITE_DATA;
+                       } else if (flags & O_WRONLY) {
+                               can_access_mask = FILE_WRITE_DATA;
                        } else {
                                can_access_mask = FILE_READ_DATA;
                        }
 
-                       if (((flags & O_RDWR) && !CAN_WRITE(conn)) ||
+                       if (((can_access_mask & FILE_WRITE_DATA) && !CAN_WRITE(conn)) ||
                            !can_access_file(conn,fname,psbuf,can_access_mask)) {
                                can_access = False;
                        }
@@ -1546,8 +1592,7 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
         */
 
         if ((flags2 & O_CREAT) && lp_inherit_acls(SNUM(conn)) &&
-           (def_acl = directory_has_default_acl(conn,
-                                                parent_dirname(fname)))) {
+           (def_acl = directory_has_default_acl(conn, parent_dir))) {
                unx_mode = 0777;
        }
 
@@ -1561,8 +1606,9 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
         * open_file strips any O_TRUNC flags itself.
         */
 
-       fsp_open = open_file(fsp,conn,fname,psbuf,flags|flags2,unx_mode,
-                            access_mask, open_access_mask);
+       fsp_open = open_file(fsp, conn, parent_dir, newname, fname, psbuf,
+                            flags|flags2, unx_mode, access_mask,
+                            open_access_mask);
 
        if (!NT_STATUS_IS_OK(fsp_open)) {
                if (lck != NULL) {
@@ -1604,10 +1650,33 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
                        return NT_STATUS_SHARING_VIOLATION;
                }
 
+               /* First pass - send break only on batch oplocks. */
+               if (delay_for_oplocks(lck, fsp, 1, oplock_request)) {
+                       schedule_defer_open(lck, request_time);
+                       TALLOC_FREE(lck);
+                       fd_close(conn, fsp);
+                       file_free(fsp);
+                       return NT_STATUS_SHARING_VIOLATION;
+               }
+
                status = open_mode_check(conn, fname, lck,
                                         access_mask, share_access,
                                         create_options, &file_existed);
 
+               if (NT_STATUS_IS_OK(status)) {
+                       /* We might be going to allow this open. Check oplock
+                        * status again. */
+                       /* Second pass - send break for both batch or
+                        * exclusive oplocks. */
+                       if (delay_for_oplocks(lck, fsp, 2, oplock_request)) {
+                               schedule_defer_open(lck, request_time);
+                               TALLOC_FREE(lck);
+                               fd_close(conn, fsp);
+                               file_free(fsp);
+                               return NT_STATUS_SHARING_VIOLATION;
+                       }
+               }
+
                if (!NT_STATUS_IS_OK(status)) {
                        struct deferred_open_record state;
 
@@ -1644,9 +1713,18 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
            these only read them. Nobody but Samba can ever set a deny
            mode and we have already checked our more authoritative
            locking database for permission to set this deny mode. If
-           the kernel refuses the operations then the kernel is wrong */
+           the kernel refuses the operations then the kernel is wrong.
+          note that GPFS supports it as well - jmcd */
+
+       ret_flock = SMB_VFS_KERNEL_FLOCK(fsp, fsp->fh->fd, share_access);
+       if(ret_flock == -1 ){
 
-       kernel_flock(fsp, share_access);
+               TALLOC_FREE(lck);
+               fd_close(conn, fsp);
+               file_free(fsp);
+               
+               return NT_STATUS_SHARING_VIOLATION;
+       }
 
        /*
         * At this point onwards, we can guarentee that the share entry
@@ -1691,11 +1769,6 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
                }
        } else {
                info = FILE_WAS_CREATED;
-               /* Change the owner if required. */
-               if (lp_inherit_owner(SNUM(conn))) {
-                       change_owner_to_parent(conn, fsp, fsp->fsp_name,
-                                              psbuf);
-               }
        }
 
        if (pinfo) {
@@ -1714,36 +1787,39 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
                        fsp->oplock_type = NO_OPLOCK;
                }
        }
-       set_share_mode(lck, fsp, current_user.ut.uid, 0, fsp->oplock_type);
 
-       if (info == FILE_WAS_OVERWRITTEN || info == FILE_WAS_CREATED ||
-           info == FILE_WAS_SUPERSEDED) {
+       if (info == FILE_WAS_OVERWRITTEN || info == FILE_WAS_CREATED || info == FILE_WAS_SUPERSEDED) {
+               new_file_created = True;
+       }
 
-               /* Handle strange delete on close create semantics. */
-               if (create_options & FILE_DELETE_ON_CLOSE) {
-                       status = can_set_delete_on_close(fsp, True, new_dos_attributes);
+       set_share_mode(lck, fsp, current_user.ut.uid, 0, fsp->oplock_type, new_file_created);
 
-                       if (!NT_STATUS_IS_OK(status)) {
-                               /* Remember to delete the mode we just added. */
-                               del_share_mode(lck, fsp);
-                               TALLOC_FREE(lck);
-                               fd_close(conn,fsp);
-                               file_free(fsp);
-                               return status;
-                       }
-                       /* Note that here we set the *inital* delete on close flag,
-                          not the regular one. */
-                       set_delete_on_close_token(lck, &current_user.ut);
-                       lck->initial_delete_on_close = True;
-                       lck->modified = True;
+       /* Handle strange delete on close create semantics. */
+       if ((create_options & FILE_DELETE_ON_CLOSE) && can_set_initial_delete_on_close(lck)) {
+               status = can_set_delete_on_close(fsp, True, new_dos_attributes);
+
+               if (!NT_STATUS_IS_OK(status)) {
+                       /* Remember to delete the mode we just added. */
+                       del_share_mode(lck, fsp);
+                       TALLOC_FREE(lck);
+                       fd_close(conn,fsp);
+                       file_free(fsp);
+                       return status;
                }
+               /* Note that here we set the *inital* delete on close flag,
+                  not the regular one. The magic gets handled in close. */
+               fsp->initial_delete_on_close = True;
+       }
        
+       if (new_file_created) {
                /* Files should be initially set as archive */
                if (lp_map_archive(SNUM(conn)) ||
                    lp_store_dos_attributes(SNUM(conn))) {
-                       file_set_dosmode(conn, fname,
+                       if (!posix_open) {
+                               file_set_dosmode(conn, fname,
                                         new_dos_attributes | aARCH, NULL,
-                                        True);
+                                        parent_dir);
+                       }
                }
        }
 
@@ -1752,7 +1828,7 @@ NTSTATUS open_file_ntcreate(connection_struct *conn,
         * selected.
         */
 
-       if (!file_existed && !def_acl) {
+       if (!posix_open && !file_existed && !def_acl) {
 
                int saved_errno = errno; /* We might get ENOSYS in the next
                                          * call.. */
@@ -1823,7 +1899,8 @@ NTSTATUS open_file_fchmod(connection_struct *conn, const char *fname,
 
        /* note! we must use a non-zero desired access or we don't get
            a real file descriptor. Oh what a twisted web we weave. */
-       status = open_file(fsp,conn,fname,psbuf,O_WRONLY,0,FILE_WRITE_DATA,FILE_WRITE_DATA);
+       status = open_file(fsp, conn, NULL, NULL, fname, psbuf, O_WRONLY, 0,
+                          FILE_WRITE_DATA, FILE_WRITE_DATA);
 
        /* 
         * This is not a user visible file open.
@@ -1844,11 +1921,90 @@ NTSTATUS open_file_fchmod(connection_struct *conn, const char *fname,
  Close the fchmod file fd - ensure no locks are lost.
 ****************************************************************************/
 
-int close_file_fchmod(files_struct *fsp)
+NTSTATUS close_file_fchmod(files_struct *fsp)
 {
-       int ret = fd_close(fsp->conn, fsp);
+       NTSTATUS status = fd_close(fsp->conn, fsp);
        file_free(fsp);
-       return ret;
+       return status;
+}
+
+static NTSTATUS mkdir_internal(connection_struct *conn,
+                               const char *name,
+                               uint32 file_attributes,
+                               SMB_STRUCT_STAT *psbuf)
+{
+       mode_t mode;
+       char *parent_dir;
+       const char *dirname;
+       NTSTATUS status;
+
+       if(!CAN_WRITE(conn)) {
+               DEBUG(5,("mkdir_internal: failing create on read-only share "
+                        "%s\n", lp_servicename(SNUM(conn))));
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       status = check_name(conn, name);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       if (!parent_dirname_talloc(tmp_talloc_ctx(), name, &parent_dir,
+                                  &dirname)) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       if (file_attributes & FILE_FLAG_POSIX_SEMANTICS) {
+               mode = (mode_t)(file_attributes & ~FILE_FLAG_POSIX_SEMANTICS);
+       } else {
+               mode = unix_mode(conn, aDIR, name, parent_dir);
+       }
+
+       if (SMB_VFS_MKDIR(conn, name, mode) != 0) {
+               return map_nt_error_from_unix(errno);
+       }
+
+       /* Ensure we're checking for a symlink here.... */
+       /* We don't want to get caught by a symlink racer. */
+
+       if (SMB_VFS_LSTAT(conn, name, psbuf) == -1) {
+               DEBUG(2, ("Could not stat directory '%s' just created: %s\n",
+                         name, strerror(errno)));
+               return map_nt_error_from_unix(errno);
+       }
+
+       if (!S_ISDIR(psbuf->st_mode)) {
+               DEBUG(0, ("Directory just '%s' created is not a directory\n",
+                         name));
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       if (lp_inherit_perms(SNUM(conn))) {
+               inherit_access_acl(conn, parent_dir, name, mode);
+       }
+
+       if (!(file_attributes & FILE_FLAG_POSIX_SEMANTICS)) {
+               /*
+                * Check if high bits should have been set,
+                * then (if bits are missing): add them.
+                * Consider bits automagically set by UNIX, i.e. SGID bit from parent
+                * dir.
+                */
+               if (mode & ~(S_IRWXU|S_IRWXG|S_IRWXO) && (mode & ~psbuf->st_mode)) {
+                       SMB_VFS_CHMOD(conn, name,
+                                     psbuf->st_mode | (mode & ~psbuf->st_mode));
+               }
+       }
+
+       /* Change the owner if required. */
+       if (lp_inherit_owner(SNUM(conn))) {
+               change_dir_owner_to_parent(conn, parent_dir, name, psbuf);
+       }
+
+       notify_fname(conn, NOTIFY_ACTION_ADDED, FILE_NOTIFY_CHANGE_DIR_NAME,
+                    name);
+
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
@@ -1862,24 +2018,25 @@ NTSTATUS open_directory(connection_struct *conn,
                        uint32 share_access,
                        uint32 create_disposition,
                        uint32 create_options,
+                       uint32 file_attributes,
                        int *pinfo,
                        files_struct **result)
 {
        files_struct *fsp = NULL;
        BOOL dir_existed = VALID_STAT(*psbuf) ? True : False;
-       BOOL create_dir = False;
        struct share_mode_lock *lck = NULL;
        NTSTATUS status;
        int info = 0;
 
        DEBUG(5,("open_directory: opening directory %s, access_mask = 0x%x, "
                 "share_access = 0x%x create_options = 0x%x, "
-                "create_disposition = 0x%x\n",
+                "create_disposition = 0x%x, file_attributes = 0x%x\n",
                 fname,
                 (unsigned int)access_mask,
                 (unsigned int)share_access,
                 (unsigned int)create_options,
-                (unsigned int)create_disposition));
+                (unsigned int)create_disposition,
+                (unsigned int)file_attributes));
 
        if (is_ntfs_stream_name(fname)) {
                DEBUG(0,("open_directory: %s is a stream name!\n", fname ));
@@ -1888,44 +2045,60 @@ NTSTATUS open_directory(connection_struct *conn,
 
        switch( create_disposition ) {
                case FILE_OPEN:
-                       /* If directory exists open. If directory doesn't
-                        * exist error. */
-                       if (!dir_existed) {
-                               DEBUG(5,("open_directory: FILE_OPEN requested "
-                                        "for directory %s and it doesn't "
-                                        "exist.\n", fname ));
-                               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
-                       }
+
                        info = FILE_WAS_OPENED;
+
+                       /*
+                        * We want to follow symlinks here.
+                        */
+
+                       if (SMB_VFS_STAT(conn, fname, psbuf) != 0) {
+                               return map_nt_error_from_unix(errno);
+                       }
+                               
                        break;
 
                case FILE_CREATE:
+
                        /* If directory exists error. If directory doesn't
                         * exist create. */
-                       if (dir_existed) {
-                               DEBUG(5,("open_directory: FILE_CREATE "
-                                        "requested for directory %s and it "
-                                        "already exists.\n", fname ));
-                               if (use_nt_status()) {
-                                       return NT_STATUS_OBJECT_NAME_COLLISION;
-                               } else {
-                                       return NT_STATUS_DOS(ERRDOS,
-                                                            ERRfilexists);
-                               }
+
+                       status = mkdir_internal(conn,
+                                               fname,
+                                               file_attributes,
+                                               psbuf);
+
+                       if (!NT_STATUS_IS_OK(status)) {
+                               DEBUG(2, ("open_directory: unable to create "
+                                         "%s. Error was %s\n", fname,
+                                         nt_errstr(status)));
+                               return status;
                        }
-                       create_dir = True;
+
                        info = FILE_WAS_CREATED;
                        break;
 
                case FILE_OPEN_IF:
-                       /* If directory exists open. If directory doesn't
-                        * exist create. */
-                       if (!dir_existed) {
-                               create_dir = True;
+                       /*
+                        * If directory exists open. If directory doesn't
+                        * exist create.
+                        */
+
+                       status = mkdir_internal(conn,
+                                               fname,
+                                               file_attributes,
+                                               psbuf);
+
+                       if (NT_STATUS_IS_OK(status)) {
                                info = FILE_WAS_CREATED;
-                       } else {
+                       }
+
+                       if (NT_STATUS_EQUAL(status,
+                                           NT_STATUS_OBJECT_NAME_COLLISION)) {
                                info = FILE_WAS_OPENED;
+                               status = NT_STATUS_OK;
                        }
+                               
                        break;
 
                case FILE_SUPERSEDE:
@@ -1938,35 +2111,10 @@ NTSTATUS open_directory(connection_struct *conn,
                        return NT_STATUS_INVALID_PARAMETER;
        }
 
-       if (create_dir) {
-               /*
-                * Try and create the directory.
-                */
-
-               /* We know bad_path is false as it's caught earlier. */
-
-               status = mkdir_internal(conn, fname, False);
-
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(2,("open_directory: unable to create %s. "
-                                "Error was %s\n", fname, strerror(errno) ));
-                       /* Ensure we return the correct NT status to the
-                        * client. */
-                       return status;
-               }
-
-               /* Ensure we're checking for a symlink here.... */
-               /* We don't want to get caught by a symlink racer. */
-
-               if(SMB_VFS_LSTAT(conn,fname, psbuf) != 0) {
-                       return map_nt_error_from_unix(errno);
-               }
-
-               if(!S_ISDIR(psbuf->st_mode)) {
-                       DEBUG(0,("open_directory: %s is not a directory !\n",
-                                fname ));
-                       return NT_STATUS_NOT_A_DIRECTORY;
-               }
+       if(!S_ISDIR(psbuf->st_mode)) {
+               DEBUG(5,("open_directory: %s is not a directory !\n",
+                        fname ));
+               return NT_STATUS_NOT_A_DIRECTORY;
        }
 
        status = file_new(conn, &fsp);
@@ -1997,6 +2145,8 @@ NTSTATUS open_directory(connection_struct *conn,
        fsp->sent_oplock_break = NO_BREAK_SENT;
        fsp->is_directory = True;
        fsp->is_stat = False;
+       fsp->posix_open = (file_attributes & FILE_FLAG_POSIX_SEMANTICS) ? True : False;
+
        string_set(&fsp->fsp_name,fname);
 
        lck = get_share_mode_lock(NULL, fsp->dev, fsp->inode,
@@ -2019,30 +2169,27 @@ NTSTATUS open_directory(connection_struct *conn,
                return status;
        }
 
-       set_share_mode(lck, fsp, current_user.ut.uid, 0, NO_OPLOCK);
+       set_share_mode(lck, fsp, current_user.ut.uid, 0, NO_OPLOCK, True);
 
        /* For directories the delete on close bit at open time seems
           always to be honored on close... See test 19 in Samba4 BASE-DELETE. */
        if (create_options & FILE_DELETE_ON_CLOSE) {
                status = can_set_delete_on_close(fsp, True, 0);
-               if (!NT_STATUS_IS_OK(status)) {
+               if (!NT_STATUS_IS_OK(status) && !NT_STATUS_EQUAL(status, NT_STATUS_DIRECTORY_NOT_EMPTY)) {
                        TALLOC_FREE(lck);
                        file_free(fsp);
                        return status;
                }
 
-               set_delete_on_close_token(lck, &current_user.ut);
-               lck->initial_delete_on_close = True;
-               lck->modified = True;
+               if (NT_STATUS_IS_OK(status)) {
+                       /* Note that here we set the *inital* delete on close flag,
+                          not the regular one. The magic gets handled in close. */
+                       fsp->initial_delete_on_close = True;
+               }
        }
 
        TALLOC_FREE(lck);
 
-       /* Change the owner if required. */
-       if ((info == FILE_WAS_CREATED) && lp_inherit_owner(SNUM(conn))) {
-               change_owner_to_parent(conn, fsp, fsp->fsp_name, psbuf);
-       }
-
        if (pinfo) {
                *pinfo = info;
        }
@@ -2053,6 +2200,30 @@ NTSTATUS open_directory(connection_struct *conn,
        return NT_STATUS_OK;
 }
 
+NTSTATUS create_directory(connection_struct *conn, const char *directory)
+{
+       NTSTATUS status;
+       SMB_STRUCT_STAT sbuf;
+       files_struct *fsp;
+
+       SET_STAT_INVALID(sbuf);
+       
+       status = open_directory(conn, directory, &sbuf,
+                               FILE_READ_ATTRIBUTES, /* Just a stat open */
+                               FILE_SHARE_NONE, /* Ignored for stat opens */
+                               FILE_CREATE,
+                               0,
+                               FILE_ATTRIBUTE_DIRECTORY,
+                               NULL,
+                               &fsp);
+
+       if (NT_STATUS_IS_OK(status)) {
+               close_file(fsp, NORMAL_CLOSE);
+       }
+
+       return status;
+}
+
 /****************************************************************************
  Open a pseudo-file (no locking checks - a 'stat' open).
 ****************************************************************************/
@@ -2110,18 +2281,24 @@ NTSTATUS open_file_stat(connection_struct *conn, const char *fname,
  smbd process.
 ****************************************************************************/
 
-void msg_file_was_renamed(int msg_type, struct process_id src, void *buf, size_t len)
+void msg_file_was_renamed(struct messaging_context *msg,
+                         void *private_data,
+                         uint32_t msg_type,
+                         struct server_id server_id,
+                         DATA_BLOB *data)
 {
        files_struct *fsp;
-       char *frm = (char *)buf;
+       char *frm = (char *)data->data;
        SMB_DEV_T dev;
        SMB_INO_T inode;
        const char *sharepath;
        const char *newname;
        size_t sp_len;
 
-       if (buf == NULL || len < MSG_FILE_RENAMED_MIN_SIZE + 2) {
-                DEBUG(0, ("msg_file_was_renamed: Got invalid msg len %d\n", (int)len));
+       if (data->data == NULL
+           || data->length < MSG_FILE_RENAMED_MIN_SIZE + 2) {
+                DEBUG(0, ("msg_file_was_renamed: Got invalid msg len %d\n",
+                         data->length));
                 return;
         }