r22846: Chunk one to replace message_send_pid with messaging_send: Deep inside
[sfrench/samba-autobuild/.git] / source / smbd / blocking.c
index c0512d5539b4d47280fc23d0e468e87788f51085..ab2b0949bd6c7d2fa921f6b0575b9ff656a1ea4d 100644 (file)
 */
 
 #include "includes.h"
+#undef DBGC_CLASS
+#define DBGC_CLASS DBGC_LOCKING
 
-extern char *OutBuffer;
+extern int max_send;
 
 /****************************************************************************
  This is the structure to queue to implement blocking locks.
  notify. It consists of the requesting SMB and the expiry time.
 *****************************************************************************/
 
-typedef struct {
-       ubi_slNode msg_next;
+typedef struct _blocking_lock_record {
+       struct _blocking_lock_record *next;
+       struct _blocking_lock_record *prev;
        int com_type;
        files_struct *fsp;
-       time_t expire_time;
+       struct timeval expire_time;
        int lock_num;
        SMB_BIG_UINT offset;
        SMB_BIG_UINT count;
-       uint16 lock_pid;
+       uint32 lock_pid;
+       enum brl_flavour lock_flav;
+       enum brl_type lock_type;
        char *inbuf;
        int length;
 } blocking_lock_record;
 
-static ubi_slList blocking_lock_queue = { NULL, (ubi_slNodePtr)&blocking_lock_queue, 0};
+/* dlink list we store pending lock records on. */
+static blocking_lock_record *blocking_lock_queue;
+
+/* dlink list we move cancelled lock records onto. */
+static blocking_lock_record *blocking_lock_cancelled_queue;
+
+/* The event that makes us process our blocking lock queue */
+static struct timed_event *brl_timeout;
 
 /****************************************************************************
  Destructor for the above structure.
@@ -53,45 +65,91 @@ static void free_blocking_lock_record(blocking_lock_record *blr)
 }
 
 /****************************************************************************
Get the files_struct given a particular queued SMB.
-*****************************************************************************/
Determine if this is a secondary element of a chained SMB.
+  **************************************************************************/
 
-static files_struct *get_fsp_from_pkt(char *inbuf)
+static BOOL in_chained_smb(void)
 {
-       switch(CVAL(inbuf,smb_com)) {
-               case SMBlock:
-               case SMBlockread:
-                       return file_fsp(inbuf,smb_vwv0);
-               case SMBlockingX:
-                       return file_fsp(inbuf,smb_vwv2);
-               default:
-                       DEBUG(0,("get_fsp_from_pkt: PANIC - unknown type on blocking lock queue - exiting.!\n"));
-                       exit_server("PANIC - unknown type on blocking lock queue");
-       }
-       return NULL; /* Keep compiler happy. */
+       return (chain_size != 0);
+}
+
+static void received_unlock_msg(int msg_type, struct server_id src,
+                               void *buf, size_t len,
+                               void *private_data);
+static void process_blocking_lock_queue(void);
+
+static void brl_timeout_fn(struct event_context *event_ctx,
+                          struct timed_event *te,
+                          const struct timeval *now,
+                          void *private_data)
+{
+       SMB_ASSERT(brl_timeout == te);
+       TALLOC_FREE(brl_timeout);
+
+       change_to_root_user();  /* TODO: Possibly run all timed events as
+                                * root */
+
+       process_blocking_lock_queue();
 }
 
 /****************************************************************************
- Determine if this is a secondary element of a chained SMB.
-  **************************************************************************/
+ After a change to blocking_lock_queue, recalculate the timed_event for the
+ next processing.
+****************************************************************************/
 
-static BOOL in_chained_smb(void)
+static BOOL recalc_brl_timeout(void)
 {
-       return (chain_size != 0);
+       blocking_lock_record *brl;
+       struct timeval next_timeout;
+
+       TALLOC_FREE(brl_timeout);
+
+       next_timeout = timeval_zero();  
+
+       for (brl = blocking_lock_queue; brl; brl = brl->next) {
+               if (timeval_is_zero(&brl->expire_time)) {
+                       continue;
+               }
+
+               if (timeval_is_zero(&next_timeout)) {
+                       next_timeout = brl->expire_time;
+               }
+               else {
+                       next_timeout = timeval_min(&next_timeout,
+                                                  &brl->expire_time);
+               }
+       }
+
+       if (timeval_is_zero(&next_timeout)) {
+               return True;
+       }
+
+       if (!(brl_timeout = event_add_timed(smbd_event_context(), NULL,
+                                           next_timeout, "brl_timeout",
+                                           brl_timeout_fn, NULL))) {
+               return False;
+       }
+
+       return True;
 }
 
-static void received_unlock_msg(int msg_type, pid_t src, void *buf, size_t len);
 
 /****************************************************************************
  Function to push a blocking lock request onto the lock queue.
 ****************************************************************************/
 
-BOOL push_blocking_lock_request( char *inbuf, int length, int lock_timeout,
-               int lock_num, uint16 lock_pid, SMB_BIG_UINT offset, SMB_BIG_UINT count)
+BOOL push_blocking_lock_request( struct byte_range_lock *br_lck,
+               char *inbuf, int length,
+               files_struct *fsp,
+               int lock_timeout,
+               int lock_num,
+               uint32 lock_pid,
+               enum brl_type lock_type,
+               enum brl_flavour lock_flav,
+               SMB_BIG_UINT offset, SMB_BIG_UINT count)
 {
        static BOOL set_lock_msg;
        blocking_lock_record *blr;
-       BOOL my_lock_ctx = False;
        NTSTATUS status;
 
        if(in_chained_smb() ) {
@@ -104,48 +162,69 @@ BOOL push_blocking_lock_request( char *inbuf, int length, int lock_timeout,
         * the expiration time here.
         */
 
-       if((blr = (blocking_lock_record *)malloc(sizeof(blocking_lock_record))) == NULL) {
+       if((blr = SMB_MALLOC_P(blocking_lock_record)) == NULL) {
                DEBUG(0,("push_blocking_lock_request: Malloc fail !\n" ));
                return False;
        }
 
-       if((blr->inbuf = (char *)malloc(length)) == NULL) {
+       blr->next = NULL;
+       blr->prev = NULL;
+
+       if((blr->inbuf = (char *)SMB_MALLOC(length)) == NULL) {
                DEBUG(0,("push_blocking_lock_request: Malloc fail (2)!\n" ));
                SAFE_FREE(blr);
                return False;
        }
 
        blr->com_type = CVAL(inbuf,smb_com);
-       blr->fsp = get_fsp_from_pkt(inbuf);
-       blr->expire_time = (lock_timeout == -1) ? (time_t)-1 : time(NULL) + (time_t)lock_timeout;
+       blr->fsp = fsp;
+       if (lock_timeout == -1) {
+               blr->expire_time.tv_sec = 0;
+               blr->expire_time.tv_usec = 0; /* Never expire. */
+       } else {
+               blr->expire_time = timeval_current_ofs(lock_timeout/1000,
+                                       (lock_timeout % 1000) * 1000);
+       }
        blr->lock_num = lock_num;
        blr->lock_pid = lock_pid;
+       blr->lock_flav = lock_flav;
+       blr->lock_type = lock_type;
        blr->offset = offset;
        blr->count = count;
        memcpy(blr->inbuf, inbuf, length);
        blr->length = length;
 
        /* Add a pending lock record for this. */
-       status = brl_lock(blr->fsp->dev, blr->fsp->inode, blr->fsp->fnum,
-                       lock_pid, sys_getpid(), blr->fsp->conn->cnum,
-                       offset, count, PENDING_LOCK, &my_lock_ctx);
+       status = brl_lock(smbd_messaging_context(), br_lck,
+                       lock_pid,
+                       procid_self(),
+                       offset,
+                       count,
+                       lock_type == READ_LOCK ? PENDING_READ_LOCK : PENDING_WRITE_LOCK,
+                       blr->lock_flav,
+                       lock_timeout ? True : False); /* blocking_lock. */
 
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0,("push_blocking_lock_request: failed to add PENDING_LOCK record.\n"));
+               DLIST_REMOVE(blocking_lock_queue, blr);
                free_blocking_lock_record(blr);
                return False;
        }
 
-       ubi_slAddTail(&blocking_lock_queue, blr);
+       DLIST_ADD_END(blocking_lock_queue, blr, blocking_lock_record *);
+       recalc_brl_timeout();
 
        /* Ensure we'll receive messages when this is unlocked. */
        if (!set_lock_msg) {
-               message_register(MSG_SMB_UNLOCK, received_unlock_msg);
+               message_register(MSG_SMB_UNLOCK, received_unlock_msg,
+                                NULL);
                set_lock_msg = True;
        }
 
-       DEBUG(3,("push_blocking_lock_request: lock request length=%d blocked with expiry time %d (+%d) \
-for fnum = %d, name = %s\n", length, (int)blr->expire_time, lock_timeout,
+       DEBUG(3,("push_blocking_lock_request: lock request length=%d blocked with "
+               "expiry time (%u sec. %u usec) (+%d msec) for fnum = %d, name = %s\n",
+               length, (unsigned int)blr->expire_time.tv_sec,
+               (unsigned int)blr->expire_time.tv_usec, lock_timeout,
                blr->fsp->fnum, blr->fsp->fsp_name ));
 
        /* Push the MID of this packet on the signing queue. */
@@ -158,13 +237,15 @@ for fnum = %d, name = %s\n", length, (int)blr->expire_time, lock_timeout,
  Return a smd with a given size.
 *****************************************************************************/
 
-static void send_blocking_reply(char *outbuf, int outsize)
+static void send_blocking_reply(char *outbuf, int outsize, const char *inbuf)
 {
-       if(outsize > 4)
-               smb_setlen(outbuf,outsize - 4);
+       if(outsize > 4) {
+               smb_setlen(inbuf, outbuf,outsize - 4);
+       }
 
-       if (!send_smb(smbd_server_fd(),outbuf))
-               exit_server("send_blocking_reply: send_smb failed.");
+       if (!send_smb(smbd_server_fd(),outbuf)) {
+               exit_server_cleanly("send_blocking_reply: send_smb failed.");
+       }
 }
 
 /****************************************************************************
@@ -173,13 +254,13 @@ static void send_blocking_reply(char *outbuf, int outsize)
 
 static void reply_lockingX_success(blocking_lock_record *blr)
 {
-       char *outbuf = OutBuffer;
+       char *outbuf = get_OutBuffer();
        int bufsize = BUFFER_SIZE;
        char *inbuf = blr->inbuf;
        int outsize = 0;
 
        construct_reply_common(inbuf, outbuf);
-       set_message(outbuf,2,0,True);
+       set_message(inbuf,outbuf,2,0,True);
 
        /*
         * As this message is a lockingX call we must handle
@@ -193,7 +274,7 @@ static void reply_lockingX_success(blocking_lock_record *blr)
 
        outsize += chain_size;
 
-       send_blocking_reply(outbuf,outsize);
+       send_blocking_reply(outbuf,outsize,inbuf);
 }
 
 /****************************************************************************
@@ -202,7 +283,7 @@ static void reply_lockingX_success(blocking_lock_record *blr)
 
 static void generic_blocking_lock_error(blocking_lock_record *blr, NTSTATUS status)
 {
-       char *outbuf = OutBuffer;
+       char *outbuf = get_OutBuffer();
        char *inbuf = blr->inbuf;
        construct_reply_common(inbuf, outbuf);
 
@@ -212,9 +293,24 @@ static void generic_blocking_lock_error(blocking_lock_record *blr, NTSTATUS stat
                status = NT_STATUS_FILE_LOCK_CONFLICT;
        }
 
+       if (NT_STATUS_EQUAL(status, NT_STATUS_FILE_LOCK_CONFLICT)) {
+               /* Store the last lock error. */
+               files_struct *fsp = blr->fsp;
+
+               fsp->last_lock_failure.context.smbpid = blr->lock_pid;
+               fsp->last_lock_failure.context.tid = fsp->conn->cnum;
+               fsp->last_lock_failure.context.pid = procid_self();
+               fsp->last_lock_failure.start = blr->offset;
+               fsp->last_lock_failure.size = blr->count;
+               fsp->last_lock_failure.fnum = fsp->fnum;
+               fsp->last_lock_failure.lock_type = READ_LOCK; /* Don't care. */
+               fsp->last_lock_failure.lock_flav = blr->lock_flav;
+       }
+
        ERROR_NT(status);
-       if (!send_smb(smbd_server_fd(),outbuf))
-               exit_server("generic_blocking_lock_error: send_smb failed.");
+       if (!send_smb(smbd_server_fd(),outbuf)) {
+               exit_server_cleanly("generic_blocking_lock_error: send_smb failed.");
+       }
 }
 
 /****************************************************************************
@@ -226,10 +322,9 @@ static void reply_lockingX_error(blocking_lock_record *blr, NTSTATUS status)
 {
        char *inbuf = blr->inbuf;
        files_struct *fsp = blr->fsp;
-       connection_struct *conn = conn_find(SVAL(inbuf,smb_tid));
        uint16 num_ulocks = SVAL(inbuf,smb_vwv6);
        SMB_BIG_UINT count = (SMB_BIG_UINT)0, offset = (SMB_BIG_UINT) 0;
-       uint16 lock_pid;
+       uint32 lock_pid;
        unsigned char locktype = CVAL(inbuf,smb_vwv3);
        BOOL large_file_format = (locktype & LOCKING_ANDX_LARGE_FILES);
        char *data;
@@ -260,7 +355,12 @@ static void reply_lockingX_error(blocking_lock_record *blr, NTSTATUS status)
                 * request would never have been queued. JRA.
                 */
                
-               do_unlock(fsp,conn,lock_pid,count,offset);
+               do_unlock(smbd_messaging_context(),
+                       fsp,
+                       lock_pid,
+                       count,
+                       offset,
+                       WINDOWS_LOCK);
        }
        
        generic_blocking_lock_error(blr, status);
@@ -273,145 +373,31 @@ static void reply_lockingX_error(blocking_lock_record *blr, NTSTATUS status)
 static void blocking_lock_reply_error(blocking_lock_record *blr, NTSTATUS status)
 {
        switch(blr->com_type) {
-       case SMBlock:
-       case SMBlockread:
-               generic_blocking_lock_error(blr, status);
-               break;
        case SMBlockingX:
                reply_lockingX_error(blr, status);
                break;
+       case SMBtrans2:
+       case SMBtranss2:
+               {
+                       char *outbuf = get_OutBuffer();
+                       char *inbuf = blr->inbuf;
+                       construct_reply_common(inbuf, outbuf);
+                       /* construct_reply_common has done us the favor to pre-fill the
+                        * command field with SMBtranss2 which is wrong :-)
+                        */
+                       SCVAL(outbuf,smb_com,SMBtrans2);
+                       ERROR_NT(status);
+                       if (!send_smb(smbd_server_fd(),outbuf)) {
+                               exit_server_cleanly("blocking_lock_reply_error: send_smb failed.");
+                       }
+                       break;
+               }
        default:
                DEBUG(0,("blocking_lock_reply_error: PANIC - unknown type on blocking lock queue - exiting.!\n"));
                exit_server("PANIC - unknown type on blocking lock queue");
        }
 }
 
-/****************************************************************************
- Attempt to finish off getting all pending blocking locks for a lockread call.
- Returns True if we want to be removed from the list.
-*****************************************************************************/
-
-static BOOL process_lockread(blocking_lock_record *blr)
-{
-       char *outbuf = OutBuffer;
-       char *inbuf = blr->inbuf;
-       ssize_t nread = -1;
-       char *data, *p;
-       int outsize = 0;
-       SMB_BIG_UINT startpos;
-       size_t numtoread;
-       NTSTATUS status;
-       connection_struct *conn = conn_find(SVAL(inbuf,smb_tid));
-       files_struct *fsp = blr->fsp;
-       BOOL my_lock_ctx = False;
-
-       numtoread = SVAL(inbuf,smb_vwv1);
-       startpos = (SMB_BIG_UINT)IVAL(inbuf,smb_vwv2);
-       
-       numtoread = MIN(BUFFER_SIZE-outsize,numtoread);
-       data = smb_buf(outbuf) + 3;
-       status = do_lock_spin( fsp, conn, SVAL(inbuf,smb_pid), (SMB_BIG_UINT)numtoread, startpos, READ_LOCK, &my_lock_ctx);
-       if (NT_STATUS_V(status)) {
-               if (!NT_STATUS_EQUAL(status,NT_STATUS_LOCK_NOT_GRANTED) &&
-                       !NT_STATUS_EQUAL(status,NT_STATUS_FILE_LOCK_CONFLICT)) {
-                       /*
-                        * We have other than a "can't get lock"
-                        * error. Send an error.
-                        * Return True so we get dequeued.
-                        */
-                       generic_blocking_lock_error(blr, status);
-                       return True;
-               }
-
-               /*
-                * Still waiting for lock....
-                */
-               
-               DEBUG(10,("process_lockread: failed to get lock for file = %s. Still waiting....\n",
-                         fsp->fsp_name));
-               return False;
-       }
-
-       nread = read_file(fsp,data,startpos,numtoread);
-
-       if (nread < 0) {
-               generic_blocking_lock_error(blr,NT_STATUS_ACCESS_DENIED);
-               return True;
-       }
-       
-       construct_reply_common(inbuf, outbuf);
-       outsize = set_message(outbuf,5,0,True);
-       
-       outsize += nread;
-       SSVAL(outbuf,smb_vwv0,nread);
-       SSVAL(outbuf,smb_vwv5,nread+3);
-       p = smb_buf(outbuf);
-       *p++ = 1;
-       SSVAL(p,0,nread); p += 2;
-       set_message_end(outbuf, p+nread);
-       
-       DEBUG(3, ( "process_lockread file = %s, fnum=%d num=%d nread=%d\n",
-                  fsp->fsp_name, fsp->fnum, (int)numtoread, (int)nread ) );
-       
-       send_blocking_reply(outbuf,outsize);
-       return True;
-}
-
-/****************************************************************************
- Attempt to finish off getting all pending blocking locks for a lock call.
- Returns True if we want to be removed from the list.
-*****************************************************************************/
-
-static BOOL process_lock(blocking_lock_record *blr)
-{
-       char *outbuf = OutBuffer;
-       char *inbuf = blr->inbuf;
-       int outsize;
-       SMB_BIG_UINT count = (SMB_BIG_UINT)0, offset = (SMB_BIG_UINT)0;
-       NTSTATUS status;
-       connection_struct *conn = conn_find(SVAL(inbuf,smb_tid));
-       files_struct *fsp = blr->fsp;
-       BOOL my_lock_ctx = False;
-
-       count = IVAL_TO_SMB_OFF_T(inbuf,smb_vwv1);
-       offset = IVAL_TO_SMB_OFF_T(inbuf,smb_vwv3);
-
-       errno = 0;
-       status = do_lock_spin(fsp, conn, SVAL(inbuf,smb_pid), count, offset, WRITE_LOCK, &my_lock_ctx);
-       if (NT_STATUS_IS_ERR(status)) {
-               if (!NT_STATUS_EQUAL(status,NT_STATUS_LOCK_NOT_GRANTED) &&
-                       !NT_STATUS_EQUAL(status,NT_STATUS_FILE_LOCK_CONFLICT)) {
-                       /*
-                        * We have other than a "can't get lock"
-                        * error. Send an error.
-                        * Return True so we get dequeued.
-                        */
-                       
-                       blocking_lock_reply_error(blr, status);
-                       return True;
-               }
-               /*
-                * Still can't get the lock - keep waiting.
-                */
-               DEBUG(10,("process_lock: failed to get lock for file = %s. Still waiting....\n",
-                         fsp->fsp_name));
-               return False;
-       }
-
-       /*
-        * Success - we got the lock.
-        */
-       
-       DEBUG(3,("process_lock : file=%s fnum=%d offset=%.0f count=%.0f\n",
-                fsp->fsp_name, fsp->fnum, (double)offset, (double)count));
-       
-       construct_reply_common(inbuf, outbuf);
-       outsize = set_message(outbuf,0,0,True);
-       send_blocking_reply(outbuf,outsize);
-       return True;
-}
-
 /****************************************************************************
  Attempt to finish off getting all pending blocking locks for a lockingX call.
  Returns True if we want to be removed from the list.
@@ -422,14 +408,12 @@ static BOOL process_lockingX(blocking_lock_record *blr)
        char *inbuf = blr->inbuf;
        unsigned char locktype = CVAL(inbuf,smb_vwv3);
        files_struct *fsp = blr->fsp;
-       connection_struct *conn = conn_find(SVAL(inbuf,smb_tid));
        uint16 num_ulocks = SVAL(inbuf,smb_vwv6);
        uint16 num_locks = SVAL(inbuf,smb_vwv7);
        SMB_BIG_UINT count = (SMB_BIG_UINT)0, offset = (SMB_BIG_UINT)0;
-       uint16 lock_pid;
+       uint32 lock_pid;
        BOOL large_file_format = (locktype & LOCKING_ANDX_LARGE_FILES);
        char *data;
-       BOOL my_lock_ctx = False;
        NTSTATUS status = NT_STATUS_OK;
 
        data = smb_buf(inbuf) + ((large_file_format ? 20 : 10)*num_ulocks);
@@ -438,8 +422,9 @@ static BOOL process_lockingX(blocking_lock_record *blr)
         * Data now points at the beginning of the list
         * of smb_lkrng structs.
         */
-       
+
        for(; blr->lock_num < num_locks; blr->lock_num++) {
+               struct byte_range_lock *br_lck = NULL;
                BOOL err;
 
                lock_pid = get_lock_pid( data, blr->lock_num, large_file_format);
@@ -451,9 +436,22 @@ static BOOL process_lockingX(blocking_lock_record *blr)
                 * request would never have been queued. JRA.
                 */
                errno = 0;
-               status = do_lock_spin(fsp,conn,lock_pid,count,offset, 
-                                ((locktype & 1) ? READ_LOCK : WRITE_LOCK), &my_lock_ctx);
-               if (NT_STATUS_IS_ERR(status)) break;
+               br_lck = do_lock(smbd_messaging_context(),
+                               fsp,
+                               lock_pid,
+                               count,
+                               offset, 
+                               ((locktype & LOCKING_ANDX_SHARED_LOCK) ?
+                                       READ_LOCK : WRITE_LOCK),
+                               WINDOWS_LOCK,
+                               True,
+                               &status);
+
+               TALLOC_FREE(br_lck);
+
+               if (NT_STATUS_IS_ERR(status)) {
+                       break;
+               }
        }
 
        if(blr->lock_num == num_locks) {
@@ -489,6 +487,52 @@ Waiting....\n",
        return False;
 }
 
+/****************************************************************************
+ Attempt to get the posix lock request from a SMBtrans2 call.
+ Returns True if we want to be removed from the list.
+*****************************************************************************/
+
+static BOOL process_trans2(blocking_lock_record *blr)
+{
+       char *inbuf = blr->inbuf;
+       char *outbuf;
+       char params[2];
+       NTSTATUS status;
+       struct byte_range_lock *br_lck = do_lock(smbd_messaging_context(),
+                                               blr->fsp,
+                                               blr->lock_pid,
+                                               blr->count,
+                                               blr->offset,
+                                               blr->lock_type,
+                                               blr->lock_flav,
+                                               True,
+                                               &status);
+       TALLOC_FREE(br_lck);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               if (ERROR_WAS_LOCK_DENIED(status)) {
+                       /* Still can't get the lock, just keep waiting. */
+                       return False;
+               }       
+               /*
+                * We have other than a "can't get lock"
+                * error. Send an error and return True so we get dequeued.
+                */
+               blocking_lock_reply_error(blr, status);
+               return True;
+       }
+
+       /* We finally got the lock, return success. */
+       outbuf = get_OutBuffer();
+       construct_reply_common(inbuf, outbuf);
+       SCVAL(outbuf,smb_com,SMBtrans2);
+       SSVAL(params,0,0);
+       /* Fake up max_data_bytes here - we know it fits. */
+       send_trans2_replies(inbuf, outbuf, max_send, params, 2, NULL, 0, 0xffff);
+       return True;
+}
+
+
 /****************************************************************************
  Process a blocking lock SMB.
  Returns True if we want to be removed from the list.
@@ -497,12 +541,11 @@ Waiting....\n",
 static BOOL blocking_lock_record_process(blocking_lock_record *blr)
 {
        switch(blr->com_type) {
-               case SMBlock:
-                       return process_lock(blr);
-               case SMBlockread:
-                       return process_lockread(blr);
                case SMBlockingX:
                        return process_lockingX(blr);
+               case SMBtrans2:
+               case SMBtranss2:
+                       return process_trans2(blr);
                default:
                        DEBUG(0,("blocking_lock_record_process: PANIC - unknown type on blocking lock queue - exiting.!\n"));
                        exit_server("PANIC - unknown type on blocking lock queue");
@@ -511,31 +554,42 @@ static BOOL blocking_lock_record_process(blocking_lock_record *blr)
 }
 
 /****************************************************************************
Delete entries by fnum from the blocking lock pending queue.
Cancel entries by fnum from the blocking lock pending queue.
 *****************************************************************************/
 
-void remove_pending_lock_requests_by_fid(files_struct *fsp)
+void cancel_pending_lock_requests_by_fid(files_struct *fsp, struct byte_range_lock *br_lck)
 {
-       blocking_lock_record *blr = (blocking_lock_record *)ubi_slFirst( &blocking_lock_queue );
-       blocking_lock_record *prev = NULL;
+       blocking_lock_record *blr, *next = NULL;
 
-       while(blr != NULL) {
+       for(blr = blocking_lock_queue; blr; blr = next) {
+               next = blr->next;
                if(blr->fsp->fnum == fsp->fnum) {
+                       unsigned char locktype = 0;
 
-                       DEBUG(10,("remove_pending_lock_requests_by_fid - removing request type %d for \
-file %s fnum = %d\n", blr->com_type, fsp->fsp_name, fsp->fnum ));
+                       if (blr->com_type == SMBlockingX) {
+                               locktype = CVAL(blr->inbuf,smb_vwv3);
+                       }
 
-                       brl_unlock(blr->fsp->dev, blr->fsp->inode, blr->fsp->fnum,
-                               blr->lock_pid, sys_getpid(), blr->fsp->conn->cnum,
-                               blr->offset, blr->count, True, NULL, NULL);
+                       if (br_lck) {
+                               DEBUG(10,("remove_pending_lock_requests_by_fid - removing request type %d for \
+file %s fnum = %d\n", blr->com_type, fsp->fsp_name, fsp->fnum ));
 
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
-                       continue;
+                               brl_lock_cancel(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+
+                               blocking_lock_cancel(fsp,
+                                       blr->lock_pid,
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav,
+                                       locktype,
+                                       NT_STATUS_RANGE_NOT_LOCKED);
+                       }
                }
-
-               prev = blr;
-               blr = (blocking_lock_record *)ubi_slNext(blr);
        }
 }
 
@@ -545,91 +599,84 @@ file %s fnum = %d\n", blr->com_type, fsp->fsp_name, fsp->fnum ));
 
 void remove_pending_lock_requests_by_mid(int mid)
 {
-       blocking_lock_record *blr = (blocking_lock_record *)ubi_slFirst( &blocking_lock_queue );
-       blocking_lock_record *prev = NULL;
+       blocking_lock_record *blr, *next = NULL;
 
-       while(blr != NULL) {
+       for(blr = blocking_lock_queue; blr; blr = next) {
+               next = blr->next;
                if(SVAL(blr->inbuf,smb_mid) == mid) {
                        files_struct *fsp = blr->fsp;
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
 
-                       DEBUG(10,("remove_pending_lock_requests_by_mid - removing request type %d for \
+                       if (br_lck) {
+                               DEBUG(10,("remove_pending_lock_requests_by_mid - removing request type %d for \
 file %s fnum = %d\n", blr->com_type, fsp->fsp_name, fsp->fnum ));
 
+                               brl_lock_cancel(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
+
                        blocking_lock_reply_error(blr,NT_STATUS_FILE_LOCK_CONFLICT);
-                       brl_unlock(blr->fsp->dev, blr->fsp->inode, blr->fsp->fnum,
-                               blr->lock_pid, sys_getpid(), blr->fsp->conn->cnum,
-                               blr->offset, blr->count, True, NULL, NULL);
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
-                       continue;
+                       DLIST_REMOVE(blocking_lock_queue, blr);
+                       free_blocking_lock_record(blr);
                }
-
-               prev = blr;
-               blr = (blocking_lock_record *)ubi_slNext(blr);
        }
 }
 
 /****************************************************************************
-  Set a flag as an unlock request affects one of our pending locks.
+ Is this mid a blocking lock request on the queue ?
 *****************************************************************************/
 
-static void received_unlock_msg(int msg_type, pid_t src, void *buf, size_t len)
+BOOL blocking_lock_was_deferred(int mid)
 {
-       DEBUG(10,("received_unlock_msg\n"));
-       process_blocking_lock_queue(time(NULL));
+       blocking_lock_record *blr, *next = NULL;
+
+       for(blr = blocking_lock_queue; blr; blr = next) {
+               next = blr->next;
+               if(SVAL(blr->inbuf,smb_mid) == mid) {
+                       return True;
+               }
+       }
+       return False;
 }
 
 /****************************************************************************
- Return the number of seconds to the next blocking locks timeout, or default_timeout
+  Set a flag as an unlock request affects one of our pending locks.
 *****************************************************************************/
 
-unsigned blocking_locks_timeout(unsigned default_timeout)
+static void received_unlock_msg(int msg_type, struct server_id src,
+                               void *buf, size_t len,
+                               void *private_data)
 {
-       unsigned timeout = default_timeout;
-       time_t t;
-       blocking_lock_record *blr = (blocking_lock_record *)ubi_slFirst(&blocking_lock_queue);
-
-       /* note that we avoid the time() syscall if there are no blocking locks */
-       if (!blr)
-               return timeout;
-
-       t = time(NULL);
-
-       while (blr) {
-               if ((blr->expire_time != (time_t)-1) &&
-                                       (timeout > (blr->expire_time - t))) {
-                       timeout = blr->expire_time - t;
-               }
-               blr = (blocking_lock_record *)ubi_slNext(blr);
-       }
-
-       if (timeout < 1)
-               timeout = 1;
-
-       return timeout;
+       DEBUG(10,("received_unlock_msg\n"));
+       process_blocking_lock_queue();
 }
 
 /****************************************************************************
  Process the blocking lock queue. Note that this is only called as root.
 *****************************************************************************/
 
-void process_blocking_lock_queue(time_t t)
+static void process_blocking_lock_queue(void)
 {
-       blocking_lock_record *blr = (blocking_lock_record *)ubi_slFirst( &blocking_lock_queue );
-       blocking_lock_record *prev = NULL;
-
-       if(blr == NULL)
-               return;
+       struct timeval tv_curr = timeval_current();
+       blocking_lock_record *blr, *next = NULL;
+       BOOL recalc_timeout = False;
 
        /*
         * Go through the queue and see if we can get any of the locks.
         */
 
-       while(blr != NULL) {
+       for (blr = blocking_lock_queue; blr; blr = next) {
                connection_struct *conn = NULL;
                uint16 vuid;
                files_struct *fsp = NULL;
 
+               next = blr->next;
+
                /*
                 * Ensure we don't have any old chain_fsp values
                 * sitting around....
@@ -645,54 +692,82 @@ void process_blocking_lock_queue(time_t t)
                DEBUG(5,("process_blocking_lock_queue: examining pending lock fnum = %d for file %s\n",
                        fsp->fnum, fsp->fsp_name ));
 
-               if((blr->expire_time != -1) && (blr->expire_time <= t)) {
+               if (!timeval_is_zero(&blr->expire_time) && timeval_compare(&blr->expire_time, &tv_curr) <= 0) {
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+
                        /*
                         * Lock expired - throw away all previously
                         * obtained locks and return lock error.
                         */
-                       DEBUG(5,("process_blocking_lock_queue: pending lock fnum = %d for file %s timed out.\n",
-                               fsp->fnum, fsp->fsp_name ));
 
-                       brl_unlock(fsp->dev, fsp->inode, fsp->fnum,
-                               blr->lock_pid, sys_getpid(), conn->cnum,
-                               blr->offset, blr->count, True, NULL, NULL);
+                       if (br_lck) {
+                               DEBUG(5,("process_blocking_lock_queue: pending lock fnum = %d for file %s timed out.\n",
+                                       fsp->fnum, fsp->fsp_name ));
+
+                               brl_lock_cancel(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
 
                        blocking_lock_reply_error(blr,NT_STATUS_FILE_LOCK_CONFLICT);
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
+                       DLIST_REMOVE(blocking_lock_queue, blr);
+                       free_blocking_lock_record(blr);
+                       recalc_timeout = True;
                        continue;
                }
 
                if(!change_to_user(conn,vuid)) {
-                       DEBUG(0,("process_blocking_lock_queue: Unable to become user vuid=%d.\n",
-                               vuid ));
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+
                        /*
                         * Remove the entry and return an error to the client.
                         */
-                       blocking_lock_reply_error(blr,NT_STATUS_ACCESS_DENIED);
 
-                       brl_unlock(fsp->dev, fsp->inode, fsp->fnum,
-                                       blr->lock_pid, sys_getpid(), conn->cnum,
-                                       blr->offset, blr->count, True, NULL, NULL);
+                       if (br_lck) {
+                               brl_lock_cancel(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
 
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
+                       DEBUG(0,("process_blocking_lock_queue: Unable to become user vuid=%d.\n",
+                               vuid ));
+                       blocking_lock_reply_error(blr,NT_STATUS_ACCESS_DENIED);
+                       DLIST_REMOVE(blocking_lock_queue, blr);
+                       free_blocking_lock_record(blr);
+                       recalc_timeout = True;
                        continue;
                }
 
-               if(!set_current_service(conn,True)) {
-                       DEBUG(0,("process_blocking_lock_queue: Unable to become service Error was %s.\n", strerror(errno) ));
+               if(!set_current_service(conn,SVAL(blr->inbuf,smb_flg),True)) {
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+
                        /*
                         * Remove the entry and return an error to the client.
                         */
-                       blocking_lock_reply_error(blr,NT_STATUS_ACCESS_DENIED);
 
-                       brl_unlock(fsp->dev, fsp->inode, fsp->fnum,
-                                       blr->lock_pid, sys_getpid(), conn->cnum,
-                                       blr->offset, blr->count, True, NULL, NULL);
+                       if (br_lck) {
+                               brl_lock_cancel(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
 
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
+                       DEBUG(0,("process_blocking_lock_queue: Unable to become service Error was %s.\n", strerror(errno) ));
+                       blocking_lock_reply_error(blr,NT_STATUS_ACCESS_DENIED);
+                       DLIST_REMOVE(blocking_lock_queue, blr);
+                       free_blocking_lock_record(blr);
+                       recalc_timeout = True;
                        change_to_root_user();
                        continue;
                }
@@ -704,23 +779,123 @@ void process_blocking_lock_queue(time_t t)
                 */
 
                if(blocking_lock_record_process(blr)) {
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+
+                       if (br_lck) {
+                               brl_lock_cancel(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
+
+                       DLIST_REMOVE(blocking_lock_queue, blr);
+                       free_blocking_lock_record(blr);
+                       recalc_timeout = True;
+               }
+               change_to_root_user();
+       }
 
-                       brl_unlock(fsp->dev, fsp->inode, fsp->fnum,
-                                       blr->lock_pid, sys_getpid(), conn->cnum,
-                                       blr->offset, blr->count, True, NULL, NULL);
+       if (recalc_timeout) {
+               recalc_brl_timeout();
+       }
+}
 
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
-                       change_to_root_user();
-                       continue;
+/****************************************************************************
+ Handle a cancel message. Lock already moved onto the cancel queue.
+*****************************************************************************/
+
+#define MSG_BLOCKING_LOCK_CANCEL_SIZE (sizeof(blocking_lock_record *) + sizeof(NTSTATUS))
+
+static void process_blocking_lock_cancel_message(int msg_type,
+                                                struct server_id src,
+                                                void *buf, size_t len,
+                                                void *private_data)
+{
+       NTSTATUS err;
+       const char *msg = (const char *)buf;
+       blocking_lock_record *blr;
+
+       if (buf == NULL) {
+               smb_panic("process_blocking_lock_cancel_message: null msg\n");
+       }
+
+       if (len != MSG_BLOCKING_LOCK_CANCEL_SIZE) {
+               DEBUG(0, ("process_blocking_lock_cancel_message: "
+                       "Got invalid msg len %d\n", (int)len));
+               smb_panic("process_blocking_lock_cancel_message: bad msg\n");
+        }
+
+       memcpy(&blr, msg, sizeof(blr));
+       memcpy(&err, &msg[sizeof(blr)], sizeof(NTSTATUS));
+
+       DEBUG(10,("process_blocking_lock_cancel_message: returning error %s\n",
+               nt_errstr(err) ));
+
+       blocking_lock_reply_error(blr, err);
+       DLIST_REMOVE(blocking_lock_cancelled_queue, blr);
+       free_blocking_lock_record(blr);
+}
+
+/****************************************************************************
+ Send ourselves a blocking lock cancelled message. Handled asynchronously above.
+*****************************************************************************/
+
+BOOL blocking_lock_cancel(files_struct *fsp,
+                       uint32 lock_pid,
+                       SMB_BIG_UINT offset,
+                       SMB_BIG_UINT count,
+                       enum brl_flavour lock_flav,
+                       unsigned char locktype,
+                        NTSTATUS err)
+{
+       static BOOL initialized;
+       char msg[MSG_BLOCKING_LOCK_CANCEL_SIZE];
+       blocking_lock_record *blr;
+
+       if (!initialized) {
+               /* Register our message. */
+               message_register(MSG_SMB_BLOCKING_LOCK_CANCEL,
+                                process_blocking_lock_cancel_message,
+                                NULL);
+
+               initialized = True;
+       }
+
+       for (blr = blocking_lock_queue; blr; blr = blr->next) {
+               if (fsp == blr->fsp &&
+                               lock_pid == blr->lock_pid &&
+                               offset == blr->offset &&
+                               count == blr->count &&
+                               lock_flav == blr->lock_flav) {
+                       break;
                }
+       }
 
-               change_to_root_user();
+       if (!blr) {
+               return False;
+       }
 
-               /*
-                * Move to the next in the list.
-                */
-               prev = blr;
-               blr = (blocking_lock_record *)ubi_slNext(blr);
+       /* Check the flags are right. */
+       if (blr->com_type == SMBlockingX &&
+               (locktype & LOCKING_ANDX_LARGE_FILES) !=
+                       (CVAL(blr->inbuf,smb_vwv3) & LOCKING_ANDX_LARGE_FILES)) {
+               return False;
        }
+
+       /* Move to cancelled queue. */
+       DLIST_REMOVE(blocking_lock_queue, blr);
+       DLIST_ADD(blocking_lock_cancelled_queue, blr);
+
+       /* Create the message. */
+       memcpy(msg, &blr, sizeof(blr));
+       memcpy(&msg[sizeof(blr)], &err, sizeof(NTSTATUS));
+
+       message_send_pid(pid_to_procid(sys_getpid()),
+                       MSG_SMB_BLOCKING_LOCK_CANCEL,
+                       &msg, sizeof(msg), True);
+
+       return True;
 }