Fixed the printerdata code to return NO_MORE_ITEMS if a size is requested
[sfrench/samba-autobuild/.git] / source / rpc_server / srv_spoolss_nt.c
index c31fd8ebf5a1f1cbfb830704f708e46ec9a92eb5..99ead42ffd08ab19f13a0b3982fdf89f11de2596 100644 (file)
  *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
-
 #include "includes.h"
 
-#ifndef MANGLE_DRIVER_PATH
-#define MANGLE_DRIVER_PATH 0
-#endif
-
 extern int DEBUGLEVEL;
 extern pstring global_myname;
 
@@ -54,7 +49,7 @@ typedef struct _Printer{
        POLICY_HND printer_hnd;
        BOOL printer_type;
        union {
-               fstring printername;
+               fstring handlename;
                fstring printerservername;
        } dev;
        uint32 type;
@@ -84,7 +79,8 @@ static ubi_dlList Printer_list;
 static ubi_dlList counter_list;
 
 
-#define OPEN_HANDLE(pnum)    ((pnum!=NULL) && (pnum->open!=False))
+#define OPEN_HANDLE(pnum)    ((pnum!=NULL) && (pnum->open!=False) && (IVAL(pnum->printer_hnd.data,16)==(uint32)sys_getpid()))
+#define OUR_HANDLE(pnum) ((pnum==NULL)?"NULL":(IVAL(pnum->data,16)==sys_getpid()?"OURS":"OTHER"))
 
 /* translate between internal status numbers and NT status numbers */
 static int nt_printj_status(int v)
@@ -182,7 +178,7 @@ static BOOL close_printer_handle(POLICY_HND *hnd)
        Printer_entry *Printer = find_printer_index_by_hnd(hnd);
 
        if (!OPEN_HANDLE(Printer)) {
-               DEBUG(3,("Error closing printer handle\n"));
+               DEBUG(0,("close_printer_handle: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
                return False;
        }
 
@@ -211,34 +207,73 @@ static BOOL delete_printer_handle(POLICY_HND *hnd)
        Printer_entry *Printer = find_printer_index_by_hnd(hnd);
 
        if (!OPEN_HANDLE(Printer)) {
-               DEBUG(3,("Error closing printer handle\n"));
+               DEBUG(0,("delete_printer_handle: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
                return False;
        }
 
-       if (del_a_printer(Printer->dev.printername) != 0) {
-               DEBUG(3,("Error deleting printer %s\n", Printer->dev.printername));
+       if (del_a_printer(Printer->dev.handlename) != 0) {
+               DEBUG(3,("Error deleting printer %s\n", Printer->dev.handlename));
                return False;
        }
 
+       if (*lp_deleteprinter_cmd()) {
+
+               pid_t local_pid = sys_getpid();
+               char *cmd = lp_deleteprinter_cmd();
+               char *path;
+               pstring tmp_file;
+               pstring command;
+               int ret;
+               int i;
+
+               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+               else
+                       path = tmpdir();
+               
+               /* Printer->dev.handlename equals portname equals sharename */
+               slprintf(command, sizeof(command), "%s \"%s\"", cmd,
+                                       Printer->dev.handlename);
+               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+
+               unlink(tmp_file);
+               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+               ret = smbrun(command, tmp_file, False);
+               if (ret != 0) {
+                       unlink(tmp_file);
+                       return False;
+               }
+               DEBUGADD(10,("returned [%d]\n", ret));
+               DEBUGADD(10,("Unlinking output file [%s]\n", tmp_file));
+               unlink(tmp_file);
+
+               if ( ( i = lp_servicenumber( Printer->dev.handlename ) ) >= 0 ) {
+                       lp_remove_service( i );
+                       lp_killservice( i );
+                       return True;
+               } else
+                       return False;
+       }
+
        return True;
 }      
 
 /****************************************************************************
   return the snum of a printer corresponding to an handle
 ****************************************************************************/
-static BOOL get_printer_snum(const POLICY_HND *hnd, int *number)
+static BOOL get_printer_snum(POLICY_HND *hnd, int *number)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(hnd);
                
        if (!OPEN_HANDLE(Printer)) {
-               DEBUG(3,("Error getting printer - take a nap quickly !\n"));
+               DEBUG(0,("get_printer_snum: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
                return False;
        }
        
        switch (Printer->printer_type) {
        case PRINTER_HANDLE_IS_PRINTER:            
-               DEBUG(4,("short name:%s\n", Printer->dev.printername));                 
-               *number = print_queue_snum(Printer->dev.printername);
+               DEBUG(4,("short name:%s\n", Printer->dev.handlename));                  
+               *number = print_queue_snum(Printer->dev.handlename);
                return (*number != -1);
        case PRINTER_HANDLE_IS_PRINTSERVER:
                return False;
@@ -249,28 +284,6 @@ static BOOL get_printer_snum(const POLICY_HND *hnd, int *number)
        }
 }
 
-/****************************************************************************
-  find first available printer slot. creates a printer handle for you.
- ****************************************************************************/
-static BOOL open_printer_hnd(POLICY_HND *hnd)
-{
-       Printer_entry *new_printer;
-
-       if((new_printer=(Printer_entry *)malloc(sizeof(Printer_entry))) == NULL)
-               return False;
-
-       ZERO_STRUCTP(new_printer);
-       
-       new_printer->open = True;
-       new_printer->notify.option=NULL;
-                               
-       memcpy(&new_printer->printer_hnd, hnd, sizeof(*hnd));
-       
-       ubi_dlAddHead( &Printer_list, (ubi_dlNode *)new_printer);
-
-       return True;
-}
-
 /****************************************************************************
   set printer handle type.
 ****************************************************************************/
@@ -279,7 +292,7 @@ static BOOL set_printer_hnd_accesstype(POLICY_HND *hnd, uint32 access_required)
        Printer_entry *Printer = find_printer_index_by_hnd(hnd);
 
        if (!OPEN_HANDLE(Printer)) {
-               DEBUG(4,("Error setting printer type=%x", access_required));
+               DEBUG(0,("set_printer_hnd_accesstype: Invalid handle (%s)", OUR_HANDLE(hnd)));
                return False;
        }
 
@@ -289,27 +302,21 @@ static BOOL set_printer_hnd_accesstype(POLICY_HND *hnd, uint32 access_required)
 }
 
 /****************************************************************************
 set printer handle type.
 check if it's \\server or \\server\printer
Set printer handle type.
Check if it's \\server or \\server\printer
 ****************************************************************************/
-static BOOL set_printer_hnd_printertype(POLICY_HND *hnd, char *printername)
+
+static BOOL set_printer_hnd_printertype(Printer_entry *Printer, char *handlename)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(hnd);
-               
-       if (!OPEN_HANDLE(Printer)) {
-               DEBUGADD(4,("Error setting printer name %s", printername));
-               return False;
-       }
-       
-       DEBUG(3,("Setting printer type=%s\n", printername));
+       DEBUG(3,("Setting printer type=%s\n", handlename));
 
-       if ( strlen(printername) < 3 ) {
-               DEBUGADD(4,("A print server must have at least 1 char ! %s\n", printername));
+       if ( strlen(handlename) < 3 ) {
+               DEBUGADD(4,("A print server must have at least 1 char ! %s\n", handlename));
                return False;
        }
 
        /* it's a print server */
-       if (!strchr(printername+2, '\\')) {
+       if (!strchr(handlename+2, '\\')) {
                DEBUGADD(4,("Printer is a print server\n"));
                Printer->printer_type = PRINTER_HANDLE_IS_PRINTSERVER;          
                return True;
@@ -325,34 +332,29 @@ static BOOL set_printer_hnd_printertype(POLICY_HND *hnd, char *printername)
 }
 
 /****************************************************************************
 set printer handle printername.
Set printer handle name.
 ****************************************************************************/
-static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
+
+static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(hnd);
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        int snum;
        int n_services=lp_numservices();
        char *aprinter;
        BOOL found=False;
        
-       if (!OPEN_HANDLE(Printer)) {
-               DEBUG(0,("Error setting printer name=%s\n", printername));
-               return False;
-       }
-
-       DEBUG(4,("Setting printer name=%s (len=%d)\n", printername, strlen(printername)));
+       DEBUG(4,("Setting printer name=%s (len=%d)\n", handlename, strlen(handlename)));
 
        if (Printer->printer_type==PRINTER_HANDLE_IS_PRINTSERVER) {
                ZERO_STRUCT(Printer->dev.printerservername);
-               strncpy(Printer->dev.printerservername, printername, strlen(printername));
+               strncpy(Printer->dev.printerservername, handlename, strlen(handlename));
                return True;
        }
 
        if (Printer->printer_type!=PRINTER_HANDLE_IS_PRINTER)
                return False;
        
-       aprinter=strchr(printername+2, '\\');
+       aprinter=strchr(handlename+2, '\\');
        aprinter++;
 
        DEBUGADD(5,("searching for [%s] (len=%d)\n", aprinter, strlen(aprinter)));
@@ -375,7 +377,7 @@ static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
                if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
                        continue;
 
-               DEBUG(10,("set_printer_hnd_printername: printername [%s], aprinter [%s]\n", 
+               DEBUG(10,("set_printer_hnd_name: name [%s], aprinter [%s]\n", 
                                printer->info_2->printername, aprinter ));
 
                if ( strlen(printer->info_2->printername) != strlen(aprinter) ) {
@@ -392,7 +394,7 @@ static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
        }
 
        /* 
-        * if we haven't found a printer with the given printername
+        * if we haven't found a printer with the given handlename
         * then it can be a share name as you can open both \\server\printer and
         * \\server\share
         */
@@ -410,12 +412,12 @@ static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
                        if ( !(lp_snum_ok(snum) && lp_print_ok(snum) ) )
                                continue;
                
-                       DEBUGADD(5,("set_printer_hnd_printername: share:%s\n",lp_servicename(snum)));
+                       DEBUGADD(5,("set_printer_hnd_name: share:%s\n",lp_servicename(snum)));
 
                        if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
                                continue;
 
-                       DEBUG(10,("set_printer_hnd_printername: printername [%s], aprinter [%s]\n", 
+                       DEBUG(10,("set_printer_hnd_name: printername [%s], aprinter [%s]\n", 
                                        printer->info_2->printername, aprinter ));
 
                        if ( strlen(lp_servicename(snum)) != strlen(aprinter) ) {
@@ -438,17 +440,53 @@ static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
        }
        
        snum--;
-       DEBUGADD(4,("set_printer_hnd_printername: Printer found: %s -> %s[%x]\n",
+       DEBUGADD(4,("set_printer_hnd_name: Printer found: %s -> %s[%x]\n",
                        printer->info_2->printername, lp_servicename(snum),snum));
 
-       ZERO_STRUCT(Printer->dev.printername);
-       strncpy(Printer->dev.printername, lp_servicename(snum), strlen(lp_servicename(snum)));
+       ZERO_STRUCT(Printer->dev.handlename);
+       strncpy(Printer->dev.handlename, lp_servicename(snum), strlen(lp_servicename(snum)));
        
        free_a_printer(&printer, 2);
 
        return True;
 }
 
+/****************************************************************************
+  find first available printer slot. creates a printer handle for you.
+ ****************************************************************************/
+
+static BOOL open_printer_hnd(POLICY_HND *hnd, char *name)
+{
+       Printer_entry *new_printer;
+
+       clear_handle(hnd);
+       create_printer_hnd(hnd);
+
+       if((new_printer=(Printer_entry *)malloc(sizeof(Printer_entry))) == NULL)
+               return False;
+
+       ZERO_STRUCTP(new_printer);
+       
+       new_printer->open = True;
+       new_printer->notify.option=NULL;
+                               
+       memcpy(&new_printer->printer_hnd, hnd, sizeof(*hnd));
+       
+       ubi_dlAddHead( &Printer_list, (ubi_dlNode *)new_printer);
+
+       if (!set_printer_hnd_printertype(new_printer, name)) {
+               close_printer_handle(hnd);
+               return False;
+       }
+       
+       if (!set_printer_hnd_name(new_printer, name)) {
+               close_printer_handle(hnd);
+               return False;
+       }
+
+       return True;
+}
+
 /********************************************************************
  Return True is the handle is a print server.
  ********************************************************************/
@@ -494,7 +532,11 @@ static BOOL alloc_buffer_size(NEW_BUFFER *buffer, uint32 buffer_size)
 
        prs_set_offset(ps, old_offset);
 
+#if 0 /* JRATEST */
+       buffer->string_at_end = buffer_size;
+#else
        buffer->string_at_end=prs_data_size(ps);
+#endif
 
        return True;
 }
@@ -511,8 +553,6 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
 {
        fstring name;
        
-       clear_handle(handle);
-       
        if (printername == NULL)
                return ERROR_INVALID_PRINTER_NAME;
 
@@ -522,20 +562,9 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
 
        DEBUGADD(3,("checking name: %s\n",name));
 
-       create_printer_hnd(handle);
-
-       open_printer_hnd(handle);
-       
-       if (!set_printer_hnd_printertype(handle, name)) {
-               close_printer_handle(handle);
+       if (!open_printer_hnd(handle, name))
                return ERROR_INVALID_PRINTER_NAME;
-       }
        
-       if (!set_printer_hnd_printername(handle, name)) {
-               close_printer_handle(handle);
-               return ERROR_INVALID_PRINTER_NAME;
-       }
-
 /*
        if (printer_default->datatype_ptr != NULL)
        {
@@ -742,7 +771,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
 /********************************************************************
  GetPrinterData on a printer Handle.
 ********************************************************************/
-static BOOL getprinterdata_printer(const POLICY_HND *handle,
+static BOOL getprinterdata_printer(POLICY_HND *handle,
                                fstring value, uint32 *type, 
                                uint8 **data, uint32 *needed, uint32 in_size )
 {
@@ -754,8 +783,10 @@ static BOOL getprinterdata_printer(const POLICY_HND *handle,
        
        DEBUG(5,("getprinterdata_printer\n"));
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("getprinterdata_printer: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return False;
+       }
 
        if(!get_printer_snum(handle, &snum))
                return False;
@@ -796,7 +827,7 @@ static BOOL getprinterdata_printer(const POLICY_HND *handle,
 /********************************************************************
  * spoolss_getprinterdata
  ********************************************************************/
-uint32 _spoolss_getprinterdata(const POLICY_HND *handle, UNISTR2 *valuename,
+uint32 _spoolss_getprinterdata(POLICY_HND *handle, UNISTR2 *valuename,
                                uint32 in_size,
                                uint32 *type,
                                uint32 *out_size,
@@ -825,6 +856,7 @@ uint32 _spoolss_getprinterdata(const POLICY_HND *handle, UNISTR2 *valuename,
        if (!OPEN_HANDLE(Printer)) {
                if((*data=(uint8 *)malloc(4*sizeof(uint8))) == NULL)
                        return ERROR_NOT_ENOUGH_MEMORY;
+               DEBUG(0,("_spoolss_getprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
        
@@ -866,7 +898,7 @@ uint32 _spoolss_getprinterdata(const POLICY_HND *handle, UNISTR2 *valuename,
  * in fact ReplyOpenPrinter is the changenotify equivalent on the spoolss pipe
  * called from api_spoolss_rffpcnex 
  ********************************************************************/
-uint32 _spoolss_rffpcnex(const POLICY_HND *handle, uint32 flags, uint32 options,
+uint32 _spoolss_rffpcnex(POLICY_HND *handle, uint32 flags, uint32 options,
                         const UNISTR2 *localmachine, uint32 printerlocal,
                         SPOOL_NOTIFY_OPTION *option)
 {
@@ -874,8 +906,10 @@ uint32 _spoolss_rffpcnex(const POLICY_HND *handle, uint32 flags, uint32 options,
 
        Printer_entry *Printer=find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_rffpcnex: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        Printer->notify.flags=flags;
        Printer->notify.options=options;
@@ -951,8 +985,12 @@ static void spoolss_notify_driver_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, p
  ********************************************************************/
 static void spoolss_notify_comment(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+       if (*printer->info_2->comment == '\0')
+               data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
                        lp_comment(snum), sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       else
+               data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       printer->info_2->comment, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -1508,7 +1546,7 @@ static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *
  * fill a notify_info struct with info asked
  * 
  ********************************************************************/
-static uint32 printer_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
+static uint32 printer_notify_info(POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
 {
        int snum;
        Printer_entry *Printer=find_printer_index_by_hnd(hnd);
@@ -1569,13 +1607,15 @@ static uint32 printer_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info
 /********************************************************************
  * spoolss_rfnpcnex
  ********************************************************************/
-uint32 _spoolss_rfnpcnex( const POLICY_HND *handle, uint32 change,
+uint32 _spoolss_rfnpcnex( POLICY_HND *handle, uint32 change,
                          SPOOL_NOTIFY_OPTION *option, SPOOL_NOTIFY_INFO *info)
 {
        Printer_entry *Printer=find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_rfnpcnex: Invalid handle (%s).\n",OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        DEBUG(4,("Printer type %x\n",Printer->printer_type));
 
@@ -1731,14 +1771,21 @@ static BOOL construct_printer_info_1(fstring server, uint32 flags, PRINTER_INFO_
 
        printer->flags=flags;
 
-       snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",server, ntprinter->info_2->printername,
-               ntprinter->info_2->drivername, lp_comment(snum));
+       if (*ntprinter->info_2->comment == '\0') {
+               init_unistr(&printer->comment, lp_comment(snum));
+               snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",server, ntprinter->info_2->printername,
+                       ntprinter->info_2->drivername, lp_comment(snum));
+       }
+       else {
+               init_unistr(&printer->comment, ntprinter->info_2->comment); /* saved comment. */
+               snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",server, ntprinter->info_2->printername,
+                       ntprinter->info_2->drivername, ntprinter->info_2->comment);
+       }
                
        snprintf(chaine2,sizeof(chaine)-1,"%s%s", server, ntprinter->info_2->printername);
 
        init_unistr(&printer->description, chaine);
        init_unistr(&printer->name, chaine2);   
-       init_unistr(&printer->comment, lp_comment(snum));
        
        free_a_printer(&ntprinter,2);
 
@@ -1788,19 +1835,16 @@ static DEVICEMODE *construct_dev_mode(int snum, char *servername)
 
        if (printer->info_2->devmode)
                ntdevmode = dup_nt_devicemode(printer->info_2->devmode);
+#if 0 /* JFMTEST */
        else
                ntdevmode = construct_nt_devicemode(printer->info_2->printername);
-
+#endif
        if (ntdevmode == NULL)
                goto fail;
 
        DEBUGADD(8,("loading DEVICEMODE\n"));
 
-#if 0 /* JRATEST */
-       snprintf(adevice, sizeof(adevice), "\\\\%s\\%s", global_myname, ntdevmode->devicename);
-#else /* JRATEST */
        snprintf(adevice, sizeof(adevice), "\\\\%s\\%s", global_myname, printer->info_2->printername);
-#endif /* JRATEST */
        init_unistr(&devmode->devicename, adevice);
 
        snprintf(aform, sizeof(aform), ntdevmode->formname);
@@ -1886,9 +1930,14 @@ static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer
        init_unistr(&printer->servername, chaine);                              /* servername*/
        init_unistr(&printer->printername, chaine2);                            /* printername*/
        init_unistr(&printer->sharename, lp_servicename(snum));                 /* sharename */
-       init_unistr(&printer->portname, lp_servicename(snum));                  /* port */      
+       init_unistr(&printer->portname, ntprinter->info_2->portname);                   /* port */      
        init_unistr(&printer->drivername, ntprinter->info_2->drivername);       /* drivername */
-       init_unistr(&printer->comment, lp_comment(snum));                       /* comment */   
+
+       if (*ntprinter->info_2->comment == '\0')
+               init_unistr(&printer->comment, lp_comment(snum));                       /* comment */   
+       else
+               init_unistr(&printer->comment, ntprinter->info_2->comment); /* saved comment. */
+
        init_unistr(&printer->location, ntprinter->info_2->location);           /* location */  
        init_unistr(&printer->sepfile, ntprinter->info_2->sepfile);             /* separator file */
        init_unistr(&printer->printprocessor, ntprinter->info_2->printprocessor);/* print processor */
@@ -1905,8 +1954,9 @@ static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer
        printer->cjobs = count;                                                 /* jobs */
        printer->averageppm = ntprinter->info_2->averageppm;                    /* average pages per minute */
                        
-       if((printer->devmode = construct_dev_mode(snum, servername)) == NULL)
-               goto err;
+       if((printer->devmode = construct_dev_mode(snum, servername)) == NULL) {
+               DEBUG(8, ("Returning NULL Devicemode!\n"));
+       }
 
        if (ntprinter->info_2->secdesc_buf && ntprinter->info_2->secdesc_buf->len != 0) {
                /* steal the printer info sec_desc structure.  [badly done]. */
@@ -1922,13 +1972,6 @@ static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer
        free_a_printer(&ntprinter, 2);
        safe_free(queue);
        return True;
-
-  err:
-
-       if (ntprinter)
-               free_a_printer(&ntprinter, 2);
-       safe_free(queue);
-       return False;
 }
 
 /********************************************************************
@@ -2466,73 +2509,66 @@ uint32 _spoolss_getprinter(POLICY_HND *handle, uint32 level,
 }      
                
 /********************************************************************
- * construct_printer_driver_info_1
- * fill a construct_printer_driver_info_1 struct
+ * fill a DRIVER_INFO_1 struct
  ********************************************************************/
-static void fill_printer_driver_info_1(DRIVER_INFO_1 *info, 
-                                       NT_PRINTER_DRIVER_INFO_LEVEL driver, 
-                                      fstring servername, fstring architecture)
+static void fill_printer_driver_info_1(DRIVER_INFO_1 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername, fstring architecture)
 {
-       init_unistr( &(info->name), driver.info_3->name);
+       init_unistr( &info->name, driver.info_3->name);
 }
 
-static void construct_printer_driver_info_1(DRIVER_INFO_1 *info, int snum, 
-                                            fstring servername, fstring architecture)
+/********************************************************************
+ * construct_printer_driver_info_1
+ ********************************************************************/
+static uint32 construct_printer_driver_info_1(DRIVER_INFO_1 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {      
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
 
        ZERO_STRUCT(driver);
 
-       get_a_printer(&printer, 2, lp_servicename(snum) );
-       get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture);    
-       
+       if (get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       if (get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version) != 0)
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
+
        fill_printer_driver_info_1(info, driver, servername, architecture);
 
        free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
 }
 
 /********************************************************************
  * construct_printer_driver_info_2
  * fill a printer_info_2 struct
  ********************************************************************/
-static void fill_printer_driver_info_2(DRIVER_INFO_2 *info, 
-                                       NT_PRINTER_DRIVER_INFO_LEVEL driver, 
-                                      fstring servername, fstring architecture)
+static void fill_printer_driver_info_2(DRIVER_INFO_2 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername)
 {
-       pstring where;
        pstring temp_driverpath;
        pstring temp_datafile;
        pstring temp_configfile;
-       fstring short_archi;
-
-       get_short_archi(short_archi,architecture);
-       
-       snprintf(where,sizeof(where)-1,"\\\\%s\\print$\\%s\\%s\\", servername, short_archi, driver.info_3->name);
 
        info->version=driver.info_3->cversion;
 
-       init_unistr( &(info->name),         driver.info_3->name );
-       init_unistr( &(info->architecture), architecture );
-       
-       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "%s%s", where, 
-                driver.info_3->driverpath);
-       init_unistr( &(info->driverpath),   temp_driverpath );
+       init_unistr( &info->name, driver.info_3->name );
+       init_unistr( &info->architecture, driver.info_3->environment );
+
+       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "\\\\%s%s", servername, driver.info_3->driverpath);
+       init_unistr( &info->driverpath, temp_driverpath );
 
-       snprintf(temp_datafile,   sizeof(temp_datafile)-1, "%s%s", where, 
-                driver.info_3->datafile);
-       init_unistr( &(info->datafile),     temp_datafile );
+       snprintf(temp_datafile, sizeof(temp_datafile)-1, "\\\\%s%s", servername, driver.info_3->datafile);
+       init_unistr( &info->datafile, temp_datafile );
 
-       snprintf(temp_configfile, sizeof(temp_configfile)-1, "%s%s", where, 
-                driver.info_3->configfile);
-       init_unistr( &(info->configfile),   temp_configfile );  
+       snprintf(temp_configfile, sizeof(temp_configfile)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+       init_unistr( &info->configfile, temp_configfile );      
 }
 
 /********************************************************************
  * construct_printer_driver_info_2
  * fill a printer_info_2 struct
  ********************************************************************/
-static void construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstring servername, fstring architecture)
+static uint32 construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
@@ -2540,12 +2576,17 @@ static void construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstri
        ZERO_STRUCT(printer);
        ZERO_STRUCT(driver);
 
-       get_a_printer(&printer, 2, lp_servicename(snum) );
-       get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture);    
+       if (!get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       if (!get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version) != 0)
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
 
-       fill_printer_driver_info_2(info, driver, servername, architecture);
+       fill_printer_driver_info_2(info, driver, servername);
 
        free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
 }
 
 /********************************************************************
@@ -2553,7 +2594,7 @@ static void construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstri
  *
  * convert an array of ascii string to a UNICODE string
  ********************************************************************/
-static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *where)
+static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *servername)
 {
        int i=0;
        int j=0;
@@ -2571,7 +2612,7 @@ static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *whe
                        if (!v) v = ""; /* hack to handle null lists */
                }
                if (strlen(v) == 0) break;
-               snprintf(line, sizeof(line)-1, "%s%s", where, v);
+               snprintf(line, sizeof(line)-1, "\\\\%s%s", servername, v);
                DEBUGADD(6,("%d:%s:%d\n", i, line, strlen(line)));
                if((*uni_array=Realloc(*uni_array, (j+strlen(line)+2)*sizeof(uint16))) == NULL) {
                        DEBUG(0,("init_unistr_array: Realloc error\n" ));
@@ -2592,67 +2633,65 @@ static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *whe
  * construct_printer_info_3
  * fill a printer_info_3 struct
  ********************************************************************/
-static void fill_printer_driver_info_3(DRIVER_INFO_3 *info, 
-                                       NT_PRINTER_DRIVER_INFO_LEVEL driver, 
-                                      fstring servername, fstring architecture)
+static void fill_printer_driver_info_3(DRIVER_INFO_3 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername)
 {
-       pstring where;
        pstring temp_driverpath;
        pstring temp_datafile;
        pstring temp_configfile;
        pstring temp_helpfile;
-       fstring short_archi;
-       
-       get_short_archi(short_archi, architecture);
-       
-#if MANGLE_DRIVER_PATH
-       snprintf(where,sizeof(where)-1,"\\\\%s\\print$\\%s\\%s\\", servername, short_archi, driver.info_3->name);
-#else
-       snprintf(where,sizeof(where)-1,"\\\\%s\\print$\\%s\\", servername, short_archi);
-#endif
 
        info->version=driver.info_3->cversion;
 
-       init_unistr( &info->name,         driver.info_3->name );        
-       init_unistr( &info->architecture, architecture );
-       
-       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "%s%s", where, driver.info_3->driverpath);          
+       init_unistr( &info->name, driver.info_3->name );        
+       init_unistr( &info->architecture, driver.info_3->environment );
+
+       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "\\\\%s%s", servername, driver.info_3->driverpath);                 
        init_unistr( &info->driverpath, temp_driverpath );
-       
-       snprintf(temp_datafile,   sizeof(temp_datafile)-1,   "%s%s", where, driver.info_3->datafile); 
+
+       snprintf(temp_datafile, sizeof(temp_datafile)-1, "\\\\%s%s", servername, driver.info_3->datafile); 
        init_unistr( &info->datafile, temp_datafile );
-       
-       snprintf(temp_configfile, sizeof(temp_configfile)-1, "%s%s", where, driver.info_3->configfile);
+
+       snprintf(temp_configfile, sizeof(temp_configfile)-1, "\\\\%s%s", servername, driver.info_3->configfile);
        init_unistr( &info->configfile, temp_configfile );      
-       
-       snprintf(temp_helpfile,   sizeof(temp_helpfile)-1,   "%s%s", where, driver.info_3->helpfile);
+
+       snprintf(temp_helpfile, sizeof(temp_helpfile)-1, "\\\\%s%s", servername, driver.info_3->helpfile);
        init_unistr( &info->helpfile, temp_helpfile );
 
        init_unistr( &info->monitorname, driver.info_3->monitorname );
        init_unistr( &info->defaultdatatype, driver.info_3->defaultdatatype );
 
        info->dependentfiles=NULL;
-       init_unistr_array(&info->dependentfiles, driver.info_3->dependentfiles, where);
+       init_unistr_array(&info->dependentfiles, driver.info_3->dependentfiles, servername);
 }
 
 /********************************************************************
  * construct_printer_info_3
  * fill a printer_info_3 struct
  ********************************************************************/
-static void construct_printer_driver_info_3(DRIVER_INFO_3 *info, int snum, 
-                                            fstring servername, fstring architecture)
+static uint32 construct_printer_driver_info_3(DRIVER_INFO_3 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {      
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-
+uint32 status=0;
        ZERO_STRUCT(driver);
 
-       get_a_printer(&printer, 2, lp_servicename(snum) );      
-       get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture);    
+       status=get_a_printer(&printer, 2, lp_servicename(snum) );
+       DEBUG(8,("construct_printer_driver_info_3: status: %d\n", status));
+       if (status != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       status=get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version);    
+       DEBUG(8,("construct_printer_driver_info_3: status: %d\n", status));
+       if (status != 0) {
+               free_a_printer(&printer,2);
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
+       }
 
-       fill_printer_driver_info_3(info, driver, servername, architecture);
+       fill_printer_driver_info_3(info, driver, servername);
 
        free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
 }
 
 /****************************************************************************
@@ -2665,14 +2704,19 @@ static void free_printer_driver_info_3(DRIVER_INFO_3 *info)
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level1(fstring servername, fstring architecture, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinterdriver2_level1(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_1 *info=NULL;
+       uint32 status;
        
        if((info=(DRIVER_INFO_1 *)malloc(sizeof(DRIVER_INFO_1))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
        
-       construct_printer_driver_info_1(info, snum, servername, architecture);
+       status=construct_printer_driver_info_1(info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               safe_free(info);
+               return status;
+       }
 
        /* check the required size. */  
        *needed += spoolss_size_printer_driver_info_1(info);
@@ -2696,14 +2740,19 @@ static uint32 getprinterdriver2_level1(fstring servername, fstring architecture,
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level2(fstring servername, fstring architecture, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinterdriver2_level2(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_2 *info=NULL;
+       uint32 status;
        
        if((info=(DRIVER_INFO_2 *)malloc(sizeof(DRIVER_INFO_2))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
        
-       construct_printer_driver_info_2(info, snum, servername, architecture);
+       status=construct_printer_driver_info_2(info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               safe_free(info);
+               return status;
+       }
 
        /* check the required size. */  
        *needed += spoolss_size_printer_driver_info_2(info);
@@ -2727,13 +2776,17 @@ static uint32 getprinterdriver2_level2(fstring servername, fstring architecture,
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level3(fstring servername, fstring architecture, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinterdriver2_level3(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_3 info;
+       uint32 status;
 
        ZERO_STRUCT(info);
 
-       construct_printer_driver_info_3(&info, snum, servername, architecture);
+       status=construct_printer_driver_info_3(&info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               return status;
+       }
 
        /* check the required size. */  
        *needed += spoolss_size_printer_driver_info_3(&info);
@@ -2756,7 +2809,7 @@ static uint32 getprinterdriver2_level3(fstring servername, fstring architecture,
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_getprinterdriver2(const POLICY_HND *handle, const UNISTR2 *uni_arch, uint32 level, 
+uint32 _spoolss_getprinterdriver2(POLICY_HND *handle, const UNISTR2 *uni_arch, uint32 level, 
                                uint32 clientmajorversion, uint32 clientminorversion,
                                NEW_BUFFER *buffer, uint32 offered,
                                uint32 *needed, uint32 *servermajorversion, uint32 *serverminorversion)
@@ -2779,13 +2832,13 @@ uint32 _spoolss_getprinterdriver2(const POLICY_HND *handle, const UNISTR2 *uni_a
 
        switch (level) {
        case 1:
-               return getprinterdriver2_level1(servername, architecture, snum, buffer, offered, needed);
+               return getprinterdriver2_level1(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
                break;
        case 2:
-               return getprinterdriver2_level2(servername, architecture, snum, buffer, offered, needed);
+               return getprinterdriver2_level2(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
                break;                          
        case 3:
-               return getprinterdriver2_level3(servername, architecture, snum, buffer, offered, needed);
+               return getprinterdriver2_level3(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
                break;                          
        default:
                return ERROR_INVALID_LEVEL;
@@ -2795,12 +2848,11 @@ uint32 _spoolss_getprinterdriver2(const POLICY_HND *handle, const UNISTR2 *uni_a
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_startpageprinter(const POLICY_HND *handle)
+uint32 _spoolss_startpageprinter(POLICY_HND *handle)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (OPEN_HANDLE(Printer))
-       {
+       if (OPEN_HANDLE(Printer)) {
                Printer->page_started=True;
                return 0x0;
        }
@@ -2811,13 +2863,12 @@ uint32 _spoolss_startpageprinter(const POLICY_HND *handle)
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_endpageprinter(const POLICY_HND *handle)
+uint32 _spoolss_endpageprinter(POLICY_HND *handle)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
-       {
-               DEBUG(3,("Error in endpageprinter printer handle\n"));
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_endpageprinter: Invalid handle (%s).\n",OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
        
@@ -2832,20 +2883,29 @@ uint32 _spoolss_endpageprinter(const POLICY_HND *handle)
  * called from the spoolss dispatcher
  *
  ********************************************************************/
-uint32 _spoolss_startdocprinter( const POLICY_HND *handle, uint32 level,
-                                uint32 vuid, DOC_INFO *docinfo, uint32 *jobid)
+uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
+                               pipes_struct *p, DOC_INFO *docinfo, 
+                               uint32 *jobid)
 {
        DOC_INFO_1 *info_1 = &docinfo->doc_info_1;
        int snum;
        pstring jobname;
        fstring datatype;
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       struct current_user user;
 
-       if (!OPEN_HANDLE(Printer))
-       {
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_startdocprinter: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
 
+       if (p->ntlmssp_auth_validated) {
+               memcpy(&user, &p->pipe_user, sizeof(user));
+       } else {
+               extern struct current_user current_user;
+               memcpy(&user, &current_user, sizeof(user));
+       }
+
        /*
         * a nice thing with NT is it doesn't listen to what you tell it.
         * when asked to send _only_ RAW datas, it tries to send datas
@@ -2858,30 +2918,28 @@ uint32 _spoolss_startdocprinter( const POLICY_HND *handle, uint32 level,
         * server-side code. *nnnnnggggh!*
         */
        
-       if (info_1->p_datatype != 0)
-       {
-               unistr2_to_ascii(datatype, &(info_1->docname), sizeof(datatype));
-               if (strcmp(datatype, "RAW") != 0)
-               {
+       if (info_1->p_datatype != 0) {
+               unistr2_to_ascii(datatype, &info_1->docname, sizeof(datatype));
+               if (strcmp(datatype, "RAW") != 0) {
                        (*jobid)=0;
                        return ERROR_INVALID_DATATYPE;
                }               
        }                
        
        /* get the share number of the printer */
-       if (!get_printer_snum(handle, &snum))
-       {
+       if (!get_printer_snum(handle, &snum)) {
                return ERROR_INVALID_HANDLE;
        }
 
        unistr2_to_ascii(jobname, &info_1->docname, sizeof(jobname));
        
-       Printer->jobid = print_job_start(snum, vuid, jobname);
+       Printer->jobid = print_job_start(&user, snum, jobname);
+
+       /* An error occured in print_job_start() so return an appropriate
+          NT error code. */
 
-       /* need to map error codes properly - for now give out of
-          memory as I don't know the correct codes (tridge) */
        if (Printer->jobid == -1) {
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return map_nt_error_from_unix(errno);
        }
        
        Printer->document_started=True;
@@ -2895,13 +2953,12 @@ uint32 _spoolss_startdocprinter( const POLICY_HND *handle, uint32 level,
  * called from the spoolss dispatcher
  *
  ********************************************************************/
-uint32 _spoolss_enddocprinter(const POLICY_HND *handle)
+uint32 _spoolss_enddocprinter(POLICY_HND *handle)
 {
        Printer_entry *Printer=find_printer_index_by_hnd(handle);
        
-       if (!OPEN_HANDLE(Printer))
-       {
-               DEBUG(3,("Error in enddocprinter handle\n"));
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_enddocprinter: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
        
@@ -2914,20 +2971,20 @@ uint32 _spoolss_enddocprinter(const POLICY_HND *handle)
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_writeprinter( const POLICY_HND *handle,
+uint32 _spoolss_writeprinter( POLICY_HND *handle,
                                uint32 buffer_size,
-                               const uint8 *buffer,
+                               uint8 *buffer,
                                uint32 *buffer_written)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
        
-       if (!OPEN_HANDLE(Printer))
-       {
-               DEBUG(3,("Error in writeprinter handle\n"));
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_writeprinter: Invalid handle (%s)\n",OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
 
-       (*buffer_written) = print_job_write(Printer->jobid, buffer, buffer_size);
+       (*buffer_written) = print_job_write(Printer->jobid, (char *)buffer, 
+                                           buffer_size);
 
        return 0x0;
 }
@@ -2937,54 +2994,198 @@ uint32 _spoolss_writeprinter( const POLICY_HND *handle,
  * called from the spoolss dispatcher
  *
  ********************************************************************/
-static uint32 control_printer(const POLICY_HND *handle, uint32 command,
-                             uint16 vuid)
+static uint32 control_printer(POLICY_HND *handle, uint32 command,
+                             pipes_struct *p)
 {
+       struct current_user user;
        int snum;
+       int errcode = 0;
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
+       if (p->ntlmssp_auth_validated) {
+               memcpy(&user, &p->pipe_user, sizeof(user));
+       } else {
+               extern struct current_user current_user;
+               memcpy(&user, &current_user, sizeof(user));
+       }
+
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("control_printer: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        if (!get_printer_snum(handle, &snum) )   
                return ERROR_INVALID_HANDLE;
 
        switch (command) {
        case PRINTER_CONTROL_PAUSE:
-               if (print_queue_pause(snum, vuid)) {
+               if (print_queue_pause(&user, snum, &errcode)) {
                        return 0;
                }
                break;
        case PRINTER_CONTROL_RESUME:
        case PRINTER_CONTROL_UNPAUSE:
-               if (print_queue_resume(snum, vuid)) {
+               if (print_queue_resume(&user, snum, &errcode)) {
                        return 0;
                }
                break;
        case PRINTER_CONTROL_PURGE:
-               if (print_queue_purge(snum, vuid)) {
+               if (print_queue_purge(&user, snum, &errcode)) {
                        return 0;
                }
                break;
        }
 
+       if (errcode)
+               return (uint32)errcode;
+
        return ERROR_INVALID_FUNCTION;
 }
 
+/********************************************************************
+ * api_spoolss_abortprinter
+ ********************************************************************/
+
+uint32 _spoolss_abortprinter(POLICY_HND *handle, pipes_struct *p)
+{
+       return control_printer(handle, PRINTER_CONTROL_PURGE, p);
+}
+
 /********************************************************************
  * called by spoolss_api_setprinter
  * when updating a printer description
  ********************************************************************/
-static uint32 update_printer_sec(const POLICY_HND *handle, uint32 level,
+static uint32 update_printer_sec(POLICY_HND *handle, uint32 level,
                                 const SPOOL_PRINTER_INFO_LEVEL *info,
-                                SEC_DESC_BUF *secdesc_ctr)
+                                pipes_struct *p, SEC_DESC_BUF *secdesc_ctr)
 {
+       struct current_user user;
+       uint32 result;
+       int snum;
+
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer) || !get_printer_snum(handle, &snum)) {
+               DEBUG(0,("update_printer_sec: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
+
+       /* Work out which user is performing the operation */
+       if (p->ntlmssp_auth_validated) {
+               memcpy(&user, &p->pipe_user, sizeof(user));
+       } else {
+               extern struct current_user current_user;
+               memcpy(&user, &current_user, sizeof(user));
+       }
+
+       /* Check the user has permissions to change the security
+          descriptor.  By experimentation with two NT machines, the user
+          requires Full Access to the printer to change security
+          information. */ 
+       if (!print_access_check(&user, snum, PRINTER_ACCESS_ADMINISTER)) {
+               result = ERROR_ACCESS_DENIED;
+               goto done;
+       }
+
+       result = nt_printing_setsec(Printer->dev.handlename, secdesc_ctr);
+
+ done:
+       return result;
+}
+
+/********************************************************************
+ Do Samba sanity checks on a printer info struct.
+ ********************************************************************/
+
+static BOOL check_printer_ok(NT_PRINTER_INFO_LEVEL_2 *info, int snum)
+{
+       /*
+        * Ensure that this printer is shared under the correct name
+        * as this is what Samba insists upon.
+        */
+
+       if (!(info->attributes & PRINTER_ATTRIBUTE_SHARED)) {
+               DEBUG(10,("check_printer_ok: SHARED check failed (%x).\n", (unsigned int)info->attributes ));
+               return False;
+       }
+
+       if (!(info->attributes & PRINTER_ATTRIBUTE_RAW_ONLY)) {
+               /* NT forgets to set the raw attribute but sends the correct type. */
+               if (strequal(info->datatype, "RAW"))
+                       info->attributes |= PRINTER_ATTRIBUTE_RAW_ONLY;
+               else {
+                       DEBUG(10,("check_printer_ok: RAW check failed (%x).\n", (unsigned int)info->attributes ));
+                       return False;
+               }
+       }
 
-       return nt_printing_setsec(Printer->dev.printername, secdesc_ctr);
+       if (!strequal(info->sharename, lp_servicename(snum))) {
+               DEBUG(10,("check_printer_ok: NAME check failed (%s) (%s).\n", info->sharename, lp_servicename(snum)));
+               return False;
+       }
+
+       return True;
+}
+
+/****************************************************************************
+****************************************************************************/
+static BOOL add_printer_hook(NT_PRINTER_INFO_LEVEL *printer)
+{
+       pid_t local_pid = sys_getpid();
+       char *cmd = lp_addprinter_cmd();
+       char *path;
+       char **qlines;
+       pstring tmp_file;
+       pstring command;
+       pstring driverlocation;
+       int numlines;
+       int ret;
+
+       if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+               path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+       else
+               path = tmpdir();
+
+       /* build driver path... only 9X architecture is needed for legacy reasons */
+       slprintf(driverlocation, sizeof(driverlocation)-1, "\\\\%s\\print$\\WIN40\\0",
+                       global_myname);
+       /* change \ to \\ for the shell */
+       all_string_sub(driverlocation,"\\","\\\\",sizeof(pstring));
+       
+       slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+       slprintf(command, sizeof(command), "%s \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\"",
+                       cmd, printer->info_2->printername, printer->info_2->sharename,
+                       printer->info_2->portname, printer->info_2->drivername,
+                       printer->info_2->location, driverlocation);
+
+       unlink(tmp_file);
+       DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+       ret = smbrun(command, tmp_file, False);
+       DEBUGADD(10,("returned [%d]\n", ret));
+
+       if ( ret != 0 ) {
+               unlink(tmp_file);
+               return False;
+       }
+
+       numlines = 0;
+       qlines = file_lines_load(tmp_file, &numlines);
+       DEBUGADD(10,("Lines returned = [%d]\n", numlines));
+       DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
+       unlink(tmp_file);
+
+       if(numlines) {
+               // Set the portname to what the script says the portname should be
+               strncpy(printer->info_2->portname, qlines[0], sizeof(printer->info_2->portname));
+               DEBUGADD(6,("Line[0] = [%s]\n", qlines[0]));
+
+               // Send SIGHUP to process group... is there a better way?
+               kill(0, SIGHUP);
+               add_all_printers();
+       }
+
+       file_lines_free(qlines);
+       return True;
 }
 
 /********************************************************************
@@ -2992,30 +3193,49 @@ static uint32 update_printer_sec(const POLICY_HND *handle, uint32 level,
  * when updating a printer description
  ********************************************************************/
 
-static uint32 update_printer(const POLICY_HND *handle, uint32 level,
+static uint32 update_printer(POLICY_HND *handle, uint32 level,
                            const SPOOL_PRINTER_INFO_LEVEL *info,
                            DEVICEMODE *devmode)
 {
        int snum;
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
-       
+       uint32 result;
+
        DEBUG(8,("update_printer\n"));
        
+       result = NT_STATUS_NO_PROBLEMO;
+
+       /* Check calling user has permission to update printer description */ 
+
        if (level!=2) {
                DEBUG(0,("Send a mail to samba@samba.org\n"));
                DEBUGADD(0,("with the following message: update_printer: level!=2\n"));
-               return ERROR_INVALID_LEVEL;
+               result = ERROR_INVALID_LEVEL;
+               goto done;
        }
 
-       if (!OPEN_HANDLE(Printer))
-               return ERROR_INVALID_HANDLE;
+       if (!OPEN_HANDLE(Printer)) {
+               result = ERROR_INVALID_HANDLE;
+               goto done;
+       }
 
-       if (!get_printer_snum(handle, &snum) )
-               return ERROR_INVALID_HANDLE;
-       
-       if(get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(handle, &snum)) {
+               result = ERROR_INVALID_HANDLE;
+               goto done;
+       }
+
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("printer property change denied by security "
+                         "descriptor\n"));
+               result = ERROR_ACCESS_DENIED;
+               goto done;
+       }
+       
+       if(get_a_printer(&printer, 2, lp_servicename(snum)) != 0) {
+               result = ERROR_INVALID_HANDLE;
+               goto done;
+       }
 
        DEBUGADD(8,("Converting info_2 struct\n"));
 
@@ -3047,41 +3267,60 @@ static uint32 update_printer(const POLICY_HND *handle, uint32 level,
                        free_nt_devicemode(&printer->info_2->devmode);
                printer->info_2->devmode=NULL;
        }
-                       
+
+       /*
+        * Do sanity check on the requested changes for Samba.
+        */
+
+       if (!check_printer_ok(printer->info_2, snum)) {
+               result = ERROR_INVALID_PARAMETER;
+               goto done;
+       }
+
+       if (*lp_addprinter_cmd() )
+               if ( !add_printer_hook(printer) ) {
+                       result = ERROR_ACCESS_DENIED;
+                       goto done;
+               }
+       
        if (add_a_printer(*printer, 2)!=0) {
                /* I don't really know what to return here !!! */
-               free_a_printer(&printer, 2);
-               return ERROR_ACCESS_DENIED;
+               result = ERROR_ACCESS_DENIED;
+               goto done;
        }
 
+ done:
        free_a_printer(&printer, 2);
 
-       return NT_STATUS_NO_PROBLEMO;
+       return result;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setprinter(const POLICY_HND *handle, uint32 level,
+uint32 _spoolss_setprinter(POLICY_HND *handle, uint32 level,
                           const SPOOL_PRINTER_INFO_LEVEL *info,
                           DEVMODE_CTR devmode_ctr,
                           SEC_DESC_BUF *secdesc_ctr,
-                          uint32 command, uint16 vuid)
+                          uint32 command, pipes_struct *p)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
        
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_setprinter: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        /* check the level */   
        switch (level) {
                case 0:
-                       return control_printer(handle, command, vuid);
+                       return control_printer(handle, command, p);
                        break;
                case 2:
                        return update_printer(handle, level, info, devmode_ctr.devmode);
                        break;
                case 3:
-                       return update_printer_sec(handle, level, info, secdesc_ctr);
+                       return update_printer_sec(handle, level, info, p,
+                                                 secdesc_ctr);
                        break;
                default:
                        return ERROR_INVALID_LEVEL;
@@ -3091,12 +3330,14 @@ uint32 _spoolss_setprinter(const POLICY_HND *handle, uint32 level,
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_fcpn(const POLICY_HND *handle)
+uint32 _spoolss_fcpn(POLICY_HND *handle)
 {
        Printer_entry *Printer= find_printer_index_by_hnd(handle);
        
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_fcpn: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
        
        Printer->notify.flags=0;
        Printer->notify.options=0;
@@ -3112,10 +3353,15 @@ uint32 _spoolss_fcpn(const POLICY_HND *handle)
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addjob(const POLICY_HND *handle, uint32 level,
-                       NEW_BUFFER *buffer, uint32 offered)
+uint32 _spoolss_addjob(POLICY_HND *handle, uint32 level,
+                      NEW_BUFFER *buffer, uint32 offered,
+                      uint32 *needed)
 {
-       return NT_STATUS_NO_PROBLEMO;
+       *needed = 0;
+       return ERROR_INVALID_PARAMETER; /* this is what a NT server
+                                           returns for AddJob. AddJob
+                                           must fail on non-local
+                                           printers */
 }
 
 /****************************************************************************
@@ -3132,19 +3378,19 @@ static void fill_job_info_1(JOB_INFO_1 *job_info, print_queue_struct *queue,
        snprintf(temp_name, sizeof(temp_name), "\\\\%s", global_myname);
 
        job_info->jobid=queue->job;     
-       init_unistr(&(job_info->printername), lp_servicename(snum));
-       init_unistr(&(job_info->machinename), temp_name);
-       init_unistr(&(job_info->username), queue->user);
-       init_unistr(&(job_info->document), queue->file);
-       init_unistr(&(job_info->datatype), "RAW");
-       init_unistr(&(job_info->text_status), "");
+       init_unistr(&job_info->printername, lp_servicename(snum));
+       init_unistr(&job_info->machinename, temp_name);
+       init_unistr(&job_info->username, queue->user);
+       init_unistr(&job_info->document, queue->file);
+       init_unistr(&job_info->datatype, "RAW");
+       init_unistr(&job_info->text_status, "");
        job_info->status=nt_printj_status(queue->status);
        job_info->priority=queue->priority;
        job_info->position=position;
        job_info->totalpages=0;
        job_info->pagesprinted=0;
 
-       make_systemtime(&(job_info->submitted), t);
+       make_systemtime(&job_info->submitted, t);
 }
 
 /****************************************************************************
@@ -3169,16 +3415,16 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
        
        snprintf(chaine, sizeof(chaine)-1, "\\\\%s\\%s", global_myname, ntprinter->info_2->printername);
 
-       init_unistr(&(job_info->printername), chaine);
+       init_unistr(&job_info->printername, chaine);
        
-       init_unistr(&(job_info->machinename), temp_name);
-       init_unistr(&(job_info->username), queue->user);
-       init_unistr(&(job_info->document), queue->file);
-       init_unistr(&(job_info->notifyname), queue->user);
-       init_unistr(&(job_info->datatype), "RAW");
-       init_unistr(&(job_info->printprocessor), "winprint");
-       init_unistr(&(job_info->parameters), "");
-       init_unistr(&(job_info->text_status), "");
+       init_unistr(&job_info->machinename, temp_name);
+       init_unistr(&job_info->username, queue->user);
+       init_unistr(&job_info->document, queue->file);
+       init_unistr(&job_info->notifyname, queue->user);
+       init_unistr(&job_info->datatype, "RAW");
+       init_unistr(&job_info->printprocessor, "winprint");
+       init_unistr(&job_info->parameters, "");
+       init_unistr(&job_info->text_status, "");
        
 /* and here the security descriptor */
 
@@ -3220,13 +3466,13 @@ static uint32 enumjobs_level1(print_queue_struct *queue, int snum,
        }
        
        for (i=0; i<*returned; i++)
-               fill_job_info_1(&(info[i]), &(queue[i]), i, snum);
+               fill_job_info_1(&info[i], &queue[i], i, snum);
 
        safe_free(queue);
 
        /* check the required size. */  
        for (i=0; i<*returned; i++)
-               (*needed) += spoolss_size_job_info_1(&(info[i]));
+               (*needed) += spoolss_size_job_info_1(&info[i]);
 
        if (!alloc_buffer_size(buffer, *needed)) {
                safe_free(info);
@@ -3235,7 +3481,7 @@ static uint32 enumjobs_level1(print_queue_struct *queue, int snum,
 
        /* fill the buffer with the structures */
        for (i=0; i<*returned; i++)
-               new_smb_io_job_info_1("", buffer, &(info[i]), 0);       
+               new_smb_io_job_info_1("", buffer, &info[i], 0); 
 
        /* clear memory */
        safe_free(info);
@@ -3266,13 +3512,13 @@ static uint32 enumjobs_level2(print_queue_struct *queue, int snum,
        }
        
        for (i=0; i<*returned; i++)
-               fill_job_info_2(&(info[i]), &(queue[i]), i, snum);
+               fill_job_info_2(&(info[i]), &queue[i], i, snum);
 
        safe_free(queue);
 
        /* check the required size. */  
        for (i=0; i<*returned; i++)
-               (*needed) += spoolss_size_job_info_2(&(info[i]));
+               (*needed) += spoolss_size_job_info_2(&info[i]);
 
        if (!alloc_buffer_size(buffer, *needed)) {
                safe_free(info);
@@ -3281,7 +3527,7 @@ static uint32 enumjobs_level2(print_queue_struct *queue, int snum,
 
        /* fill the buffer with the structures */
        for (i=0; i<*returned; i++)
-               new_smb_io_job_info_2("", buffer, &(info[i]), 0);       
+               new_smb_io_job_info_2("", buffer, &info[i], 0); 
 
        /* clear memory */
        safe_free(info);
@@ -3336,21 +3582,22 @@ uint32 _spoolss_enumjobs( POLICY_HND *handle, uint32 firstjob, uint32 numofjobs,
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_schedulejob( const POLICY_HND *handle, uint32 jobid)
+uint32 _spoolss_schedulejob( POLICY_HND *handle, uint32 jobid)
 {
        return 0x0;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setjob( const POLICY_HND *handle,
+uint32 _spoolss_setjob( POLICY_HND *handle,
                                uint32 jobid,
                                uint32 level,
-                               uint32 vuid,
+                               pipes_struct *p,
                                JOB_INFO *ctr,
                                uint32 command)
 
 {
+       struct current_user user;
        int snum;
        print_status_struct prt_status;
                
@@ -3364,16 +3611,23 @@ uint32 _spoolss_setjob( const POLICY_HND *handle,
                return ERROR_INVALID_PRINTER_NAME;
        }
        
+       if (p->ntlmssp_auth_validated) {
+               memcpy(&user, &p->pipe_user, sizeof(user));
+       } else {
+               extern struct current_user current_user;
+               memcpy(&user, &current_user, sizeof(user));
+       }
+
        switch (command) {
        case JOB_CONTROL_CANCEL:
        case JOB_CONTROL_DELETE:
-               if (print_job_delete(vuid, jobid)) return 0x0;
+               if (print_job_delete(&user, jobid)) return 0x0;
                break;
        case JOB_CONTROL_PAUSE:
-               if (print_job_pause(vuid, jobid)) return 0x0;
+               if (print_job_pause(&user, jobid)) return 0x0;
                break;
        case JOB_CONTROL_RESUME:
-               if (print_job_resume(vuid, jobid)) return 0x0;
+               if (print_job_resume(&user, jobid)) return 0x0;
                break;
        default:
                return ERROR_INVALID_LEVEL;
@@ -3385,24 +3639,46 @@ uint32 _spoolss_setjob( const POLICY_HND *handle,
 /****************************************************************************
  Enumerates all printer drivers at level 1.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static uint32 enumprinterdrivers_level1(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
+       int ndrivers;
+       uint32 version;
+       fstring *list = NULL;
+
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
        DRIVER_INFO_1 *driver_info_1=NULL;
 
-       ZERO_STRUCT(driver);
+       *returned=0;
 
-       if((driver_info_1=(DRIVER_INFO_1 *)malloc(*returned * sizeof(DRIVER_INFO_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+#define MAX_VERSION 4
 
-       for (i=0; i<*returned; i++) {
-               get_a_printer_driver(&driver, 3, list[i], architecture);
-               fill_printer_driver_info_1(&(driver_info_1[i]), driver, servername, architecture );
+       for (version=0; version<MAX_VERSION; version++) {
+               list=NULL;
+               ndrivers=get_ntdrivers(&list, architecture, version);
+               DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
+
+               if(ndrivers == -1)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+
+               if(ndrivers != 0) {
+                       if((driver_info_1=(DRIVER_INFO_1 *)Realloc(driver_info_1, (*returned+ndrivers) * sizeof(DRIVER_INFO_1))) == NULL) {
+                               safe_free(list);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
+               }
+
+               for (i=0; i<ndrivers; i++) {
+                       DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+                       ZERO_STRUCT(driver);
+                       get_a_printer_driver(&driver, 3, list[i], architecture, version);
+                       fill_printer_driver_info_1(&(driver_info_1[*returned+i]), driver, servername, architecture );           
+               }       
+
+               *returned+=ndrivers;
+               safe_free(list);
        }
        
-       safe_free(list);
-       
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d]'s size\n",i));
@@ -3433,28 +3709,46 @@ static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstri
 /****************************************************************************
  Enumerates all printer drivers at level 2.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level2(fstring *list, fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static uint32 enumprinterdrivers_level2(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
+       int ndrivers;
+       uint32 version;
+       fstring *list = NULL;
+
+       NT_PRINTER_DRIVER_INFO_LEVEL driver;
        DRIVER_INFO_2 *driver_info_2=NULL;
 
-       if (*returned > 0 && 
-           !(driver_info_2=(DRIVER_INFO_2 *)malloc(*returned * sizeof(DRIVER_INFO_2))))
-               return ERROR_NOT_ENOUGH_MEMORY;
+       *returned=0;
 
-       for (i=0; i<*returned; i++) {
-               NT_PRINTER_DRIVER_INFO_LEVEL driver;
-               ZERO_STRUCT(driver);
-               if (get_a_printer_driver(&driver, 3, list[i], architecture)
-                   != 0) { 
-                       *returned = i;
-                       break;
+#define MAX_VERSION 4
+
+       for (version=0; version<MAX_VERSION; version++) {
+               list=NULL;
+               ndrivers=get_ntdrivers(&list, architecture, version);
+               DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
+
+               if(ndrivers == -1)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+
+               if(ndrivers != 0) {
+                       if((driver_info_2=(DRIVER_INFO_2 *)Realloc(driver_info_2, (*returned+ndrivers) * sizeof(DRIVER_INFO_2))) == NULL) {
+                               safe_free(list);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
                }
-               fill_printer_driver_info_2(&(driver_info_2[i]), driver, servername, architecture );
+               
+               for (i=0; i<ndrivers; i++) {
+                       DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+                       ZERO_STRUCT(driver);
+                       get_a_printer_driver(&driver, 3, list[i], architecture, version);
+                       fill_printer_driver_info_2(&(driver_info_2[*returned+i]), driver, servername);          
+               }       
+
+               *returned+=ndrivers;
+               safe_free(list);
        }
        
-       safe_free(list);
-       
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d]'s size\n",i));
@@ -3485,24 +3779,46 @@ static uint32 enumprinterdrivers_level2(fstring *list, fstring servername, fstri
 /****************************************************************************
  Enumerates all printer drivers at level 3.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level3(fstring *list, fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static uint32 enumprinterdrivers_level3(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
+       int ndrivers;
+       uint32 version;
+       fstring *list = NULL;
+
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
        DRIVER_INFO_3 *driver_info_3=NULL;
 
-       ZERO_STRUCT(driver);
+       *returned=0;
 
-       if((driver_info_3=(DRIVER_INFO_3 *)malloc((*returned)*sizeof(DRIVER_INFO_3))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+#define MAX_VERSION 4
 
-       for (i=0; i<*returned; i++) {
-               get_a_printer_driver(&driver, 3, list[i], architecture);
-               fill_printer_driver_info_3(&(driver_info_3[i]), driver, servername, architecture );
+       for (version=0; version<MAX_VERSION; version++) {
+               list=NULL;
+               ndrivers=get_ntdrivers(&list, architecture, version);
+               DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
+
+               if(ndrivers == -1)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+
+               if(ndrivers != 0) {
+                       if((driver_info_3=(DRIVER_INFO_3 *)Realloc(driver_info_3, (*returned+ndrivers) * sizeof(DRIVER_INFO_3))) == NULL) {
+                               safe_free(list);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
+               }
+
+               for (i=0; i<ndrivers; i++) {
+                       DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+                       ZERO_STRUCT(driver);
+                       get_a_printer_driver(&driver, 3, list[i], architecture, version);
+                       fill_printer_driver_info_3(&(driver_info_3[*returned+i]), driver, servername);          
+               }       
+
+               *returned+=ndrivers;
+               safe_free(list);
        }
-       
-       safe_free(list);
-       
+
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d]'s size\n",i));
@@ -3514,9 +3830,9 @@ static uint32 enumprinterdrivers_level3(fstring *list, fstring servername, fstri
                return ERROR_INSUFFICIENT_BUFFER;
        }
        
-       /* fill the buffer with the form structures */
+       /* fill the buffer with the driver structures */
        for (i=0; i<*returned; i++) {
-               DEBUGADD(6,("adding form [%d] to buffer\n",i));
+               DEBUGADD(6,("adding driver [%d] to buffer\n",i));
                new_smb_io_printer_driver_info_3("", buffer, &driver_info_3[i], 0);
        }
 
@@ -3540,7 +3856,6 @@ uint32 _spoolss_enumprinterdrivers( UNISTR2 *name, UNISTR2 *environment, uint32
                                    NEW_BUFFER *buffer, uint32 offered,
                                    uint32 *needed, uint32 *returned)
 {
-       int i;
        fstring *list = NULL;
        fstring servername;
        fstring architecture;
@@ -3551,26 +3866,20 @@ uint32 _spoolss_enumprinterdrivers( UNISTR2 *name, UNISTR2 *environment, uint32
        *returned=0;
 
        unistr2_to_ascii(architecture, environment, sizeof(architecture)-1);
-       *returned=get_ntdrivers(&list, architecture);
 
-       DEBUGADD(4,("we have: [%d] drivers in environment [%s]\n", *returned, architecture));
-       if(*returned == -1)
-               return ERROR_NOT_ENOUGH_MEMORY;
-
-       for (i=0; i<*returned; i++)
-               DEBUGADD(5,("driver: [%s]\n", list[i]));
-       
        switch (level) {
        case 1:
-               return enumprinterdrivers_level1(list, servername, architecture, buffer, offered, needed, returned);
+               return enumprinterdrivers_level1(servername, architecture, buffer, offered, needed, returned);
                break;
        case 2:
-               return enumprinterdrivers_level2(list, servername, architecture, buffer, offered, needed, returned);
+               return enumprinterdrivers_level2(servername, architecture, buffer, offered, needed, returned);
                break;
        case 3:
-               return enumprinterdrivers_level3(list, servername, architecture, buffer, offered, needed, returned);
+               return enumprinterdrivers_level3(servername, architecture, buffer, offered, needed, returned);
                break;
        default:
+               *returned=0;
+               safe_free(list);
                return ERROR_INVALID_LEVEL;
                break;
        }
@@ -3578,10 +3887,10 @@ uint32 _spoolss_enumprinterdrivers( UNISTR2 *name, UNISTR2 *environment, uint32
 
 /****************************************************************************
 ****************************************************************************/
-static void fill_form_1(FORM_1 *form, nt_forms_struct *list, int position)
+static void fill_form_1(FORM_1 *form, nt_forms_struct *list)
 {
        form->flag=list->flag;
-       init_unistr(&(form->name), list->name);
+       init_unistr(&form->name, list->name);
        form->width=list->width;
        form->length=list->length;
        form->left=list->left;
@@ -3592,7 +3901,7 @@ static void fill_form_1(FORM_1 *form, nt_forms_struct *list, int position)
        
 /****************************************************************************
 ****************************************************************************/
-uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level, 
+uint32 _new_spoolss_enumforms( POLICY_HND *handle, uint32 level, 
                               NEW_BUFFER *buffer, uint32 offered, 
                               uint32 *needed, uint32 *numofforms)
 {
@@ -3620,7 +3929,7 @@ uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level,
                /* construct the list of form structures */
                for (i=0; i<*numofforms; i++) {
                        DEBUGADD(6,("Filling form number [%d]\n",i));
-                       fill_form_1(&(forms_1[i]), &(list[i]), i);
+                       fill_form_1(&forms_1[i], &list[i]);
                }
                
                safe_free(list);
@@ -3628,7 +3937,7 @@ uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level,
                /* check the required size. */
                for (i=0; i<*numofforms; i++) {
                        DEBUGADD(6,("adding form [%d]'s size\n",i));
-                       buffer_size += spoolss_size_form_1(&(forms_1[i]));
+                       buffer_size += spoolss_size_form_1(&forms_1[i]);
                }
 
                *needed=buffer_size;            
@@ -3641,7 +3950,7 @@ uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level,
                /* fill the buffer with the form structures */
                for (i=0; i<*numofforms; i++) {
                        DEBUGADD(6,("adding form [%d] to buffer\n",i));
-                       new_smb_io_form_1("", buffer, &(forms_1[i]), 0);
+                       new_smb_io_form_1("", buffer, &forms_1[i], 0);
                }
 
                safe_free(forms_1);
@@ -3660,6 +3969,69 @@ uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level,
 
 }
 
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_getform( POLICY_HND *handle, uint32 level, UNISTR2 *uni_formname, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+{
+       nt_forms_struct *list=NULL;
+       FORM_1 form_1;
+       fstring form_name;
+       int buffer_size=0;
+       int numofforms, i;
+
+       unistr2_to_ascii(form_name, uni_formname, sizeof(form_name)-1);
+
+       DEBUG(4,("_spoolss_getform\n"));
+       DEBUGADD(5,("Offered buffer size [%d]\n", offered));
+       DEBUGADD(5,("Info level [%d]\n",          level));
+
+       numofforms = get_ntforms(&list);
+       DEBUGADD(5,("Number of forms [%d]\n",     numofforms));
+
+       if (numofforms == 0)
+               return ERROR_NO_MORE_ITEMS;
+
+       switch (level) {
+       case 1:
+
+               /* Check if the requested name is in the list of form structures */
+               for (i=0; i<numofforms; i++) {
+
+                       DEBUG(4,("_spoolss_getform: checking form %s (want %s)\n", list[i].name, form_name));
+
+                       if (strequal(form_name, list[i].name)) {
+                               DEBUGADD(6,("Found form %s number [%d]\n", form_name, i));
+                               fill_form_1(&form_1, &list[i]);
+                               break;
+                       }
+               }
+               
+               safe_free(list);
+
+               /* check the required size. */
+
+               *needed=spoolss_size_form_1(&form_1);
+               
+               if (!alloc_buffer_size(buffer, buffer_size)){
+                       return ERROR_INSUFFICIENT_BUFFER;
+               }
+
+               if (*needed > offered) {
+                       return ERROR_INSUFFICIENT_BUFFER;
+               }
+
+               /* fill the buffer with the form structures */
+               DEBUGADD(6,("adding form %s [%d] to buffer\n", form_name, i));
+               new_smb_io_form_1("", buffer, &form_1, 0);
+
+               return NT_STATUS_NO_PROBLEMO;
+                       
+       default:
+               safe_free(list);
+               return ERROR_INVALID_LEVEL;
+       }
+}
+
 /****************************************************************************
 ****************************************************************************/
 static void fill_port_1(PORT_INFO_1 *port, char *name)
@@ -3684,46 +4056,70 @@ static void fill_port_2(PORT_INFO_2 *port, char *name)
 ****************************************************************************/
 static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       int n_services=lp_numservices();
-       int snum;
-       int i=0;
-       
        PORT_INFO_1 *ports=NULL;
+       int i=0;
 
-       for (snum=0; snum<n_services; snum++)
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) )
-                       (*returned)++;
-
-       if((ports=(PORT_INFO_1 *)malloc( (*returned+1) * sizeof(PORT_INFO_1) )) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
-       
-       for (snum=0; snum<n_services; snum++) {
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) ) {
-                       /*
-                        * Ensure this port name is unique.
-                        */
-                       int j;
-
-                       DEBUG(10,("enumports_level_1: port name %s\n", PRINTERNAME(snum)));
+       if (*lp_enumports_cmd()) {
+               pid_t local_pid = sys_getpid();
+               char *cmd = lp_enumports_cmd();
+               char *path;
+               char **qlines;
+               pstring tmp_file;
+               pstring command;
+               int numlines;
+               int ret;
+
+               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+               else
+                       path = tmpdir();
+
+               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+               slprintf(command, sizeof(command), "%s \"%d\"", cmd, 1);
+
+               unlink(tmp_file);
+               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+               ret = smbrun(command, tmp_file, False);
+               DEBUG(10,("Returned [%d]\n", ret));
+               if (ret != 0) {
+                       unlink(tmp_file);
+                       // Is this the best error to return here?
+                       return ERROR_ACCESS_DENIED;
+               }
 
-                       for(j = 0; j < i; j++) {
-                               fstring port_name;
-                               unistr_to_dos(port_name, (const char *)&ports[j].port_name.buffer[0], sizeof(port_name));
+               numlines = 0;
+               qlines = file_lines_load(tmp_file, &numlines);
+               DEBUGADD(10,("Lines returned = [%d]\n", numlines));
+               DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
+               unlink(tmp_file);
 
-                               if (strequal(port_name, PRINTERNAME(snum)))
-                                       break;
+               if(numlines) {
+                       if((ports=(PORT_INFO_1 *)malloc( numlines * sizeof(PORT_INFO_1) )) == NULL) {
+                               DEBUG(10,("Returning ERROR_NOT_ENOUGH_MEMORY [%x]\n", ERROR_NOT_ENOUGH_MEMORY));
+                               file_lines_free(qlines);
+                               return ERROR_NOT_ENOUGH_MEMORY;
                        }
 
-                       if (j < i)
-                               continue;
+                       for (i=0; i<numlines; i++) {
+                               DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
+                               fill_port_1(&ports[i], qlines[i]);
+                       }
 
-                       DEBUGADD(6,("Filling port number [%d]\n", i));
-                       fill_port_1(&ports[i], PRINTERNAME(snum));
-                       i++;
+                       file_lines_free(qlines);
                }
-       }
 
-       *returned = i;
+               *returned = numlines;
+
+       } else {
+               *returned = 1; /* Sole Samba port returned. */
+
+               if((ports=(PORT_INFO_1 *)malloc( sizeof(PORT_INFO_1) )) == NULL)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+       
+               DEBUG(10,("enumports_level_1: port name %s\n", SAMBA_PRINTER_PORT_NAME));
+
+               fill_port_1(&ports[0], SAMBA_PRINTER_PORT_NAME);
+       }
 
        /* check the required size. */
        for (i=0; i<*returned; i++) {
@@ -3758,46 +4154,71 @@ static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *need
 
 static uint32 enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       int n_services=lp_numservices();
-       int snum;
-       int i=0;
-       
        PORT_INFO_2 *ports=NULL;
+       int i=0;
 
-       for (snum=0; snum<n_services; snum++)
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) )
-                       (*returned)++;
-
-       if((ports=(PORT_INFO_2 *)malloc( (*returned+1) * sizeof(PORT_INFO_2) )) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
-       
-       for (snum=0; snum<n_services; snum++) {
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) ) {
-                       /*
-                        * Ensure this port name is unique.
-                        */
-                       int j;
-
-                       DEBUG(10,("enumports_level_2: port name %s\n", PRINTERNAME(snum)));
+       if (*lp_enumports_cmd()) {
+               pid_t local_pid = sys_getpid();
+               char *cmd = lp_enumports_cmd();
+               char *path;
+               char **qlines;
+               pstring tmp_file;
+               pstring command;
+               int numlines;
+               int ret;
+
+               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+               else
+                       path = tmpdir();
+
+               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+               slprintf(command, sizeof(command), "%s \"%d\"", cmd, 2);
+
+               unlink(tmp_file);
+               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+               ret = smbrun(command, tmp_file, False);
+               DEBUGADD(10,("returned [%d]\n", ret));
+               if (ret != 0) {
+                       unlink(tmp_file);
+                       // Is this the best error to return here?
+                       return ERROR_ACCESS_DENIED;
+               }
 
-                       for(j = 0; j < i; j++) {
-                               fstring port_name;
-                               unistr_to_dos(port_name, (const char *)&ports[j].port_name.buffer[0], sizeof(port_name));
+               numlines = 0;
+               qlines = file_lines_load(tmp_file, &numlines);
+               DEBUGADD(10,("Lines returned = [%d]\n", numlines));
+               DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
+               unlink(tmp_file);
 
-                               if (strequal(port_name, PRINTERNAME(snum)))
-                                       break;
+               if(numlines) {
+                       if((ports=(PORT_INFO_2 *)malloc( numlines * sizeof(PORT_INFO_2) )) == NULL) {
+                               DEBUG(10,("Returning ERROR_NOT_ENOUGH_MEMORY [%x]\n", ERROR_NOT_ENOUGH_MEMORY));
+                               file_lines_free(qlines);
+                               return ERROR_NOT_ENOUGH_MEMORY;
                        }
 
-                       if (j < i)
-                               continue;
+                       for (i=0; i<numlines; i++) {
+                               DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
+                               fill_port_2(&(ports[i]), qlines[i]);
+                       }
 
-                       DEBUGADD(6,("Filling port number [%d]\n", i));
-                       fill_port_2(&ports[i], PRINTERNAME(snum));
-                       i++;
+                       file_lines_free(qlines);
                }
-       }
 
-       *returned = i;
+               *returned = numlines;
+
+       } else {
+
+               *returned = 1;
+
+               if((ports=(PORT_INFO_2 *)malloc( sizeof(PORT_INFO_2) )) == NULL)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+       
+               DEBUG(10,("enumports_level_2: port name %s\n", SAMBA_PRINTER_PORT_NAME));
+
+               fill_port_2(&ports[0], SAMBA_PRINTER_PORT_NAME);
+       }
 
        /* check the required size. */
        for (i=0; i<*returned; i++) {
@@ -3861,7 +4282,7 @@ static uint32 spoolss_addprinterex_level_2( const UNISTR2 *uni_srv_name,
 {
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        fstring name;
-       fstring share_name;
+       int snum;
 
        if ((printer = (NT_PRINTER_INFO_LEVEL *)malloc(sizeof(NT_PRINTER_INFO_LEVEL))) == NULL) {
                DEBUG(0,("spoolss_addprinterex_level_2: malloc fail.\n"));
@@ -3870,34 +4291,48 @@ static uint32 spoolss_addprinterex_level_2( const UNISTR2 *uni_srv_name,
 
        ZERO_STRUCTP(printer);
 
-       clear_handle(handle);
-       
        /* convert from UNICODE to ASCII - this allocates the info_2 struct inside *printer.*/
        convert_printer_info(info, printer, 2);
 
-       unistr2_to_ascii(share_name, &info->info_2->printername, sizeof(share_name)-1);
-       
-       slprintf(name, sizeof(name)-1, "\\\\%s\\%s", global_myname, share_name);
+       if (*lp_addprinter_cmd() )
+               if ( !add_printer_hook(printer) ) {
+                       free_a_printer(&printer,2);
+                       return ERROR_ACCESS_DENIED;
+       }
 
-       /* write the ASCII on disk */
-       if (add_a_printer(*printer, 2) != 0) {
+       slprintf(name, sizeof(name)-1, "\\\\%s\\%s", global_myname,
+             printer->info_2->sharename);
+
+       if ((snum = print_queue_snum(printer->info_2->sharename)) == -1) {
                free_a_printer(&printer,2);
                return ERROR_ACCESS_DENIED;
        }
 
-       create_printer_hnd(handle);
+       /* you must be a printer admin to add a new printer */
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               free_a_printer(&printer,2);
+               return ERROR_ACCESS_DENIED;             
+       }
+       
+       /*
+        * Do sanity check on the requested changes for Samba.
+        */
 
-       open_printer_hnd(handle);
+       if (!check_printer_ok(printer->info_2, snum)) {
+               free_a_printer(&printer,2);
+               return ERROR_INVALID_PARAMETER;
+       }
 
-       if (!set_printer_hnd_printertype(handle, name)) {
+       /* write the ASCII on disk */
+       if (add_a_printer(*printer, 2) != 0) {
                free_a_printer(&printer,2);
-               close_printer_handle(handle);
                return ERROR_ACCESS_DENIED;
        }
 
-       if (!set_printer_hnd_printername(handle, name)) {
+       if (!open_printer_hnd(handle, name)) {
+               /* Handle open failed - remove addition. */
+               del_a_printer(printer->info_2->sharename);
                free_a_printer(&printer,2);
-               close_printer_handle(handle);
                return ERROR_ACCESS_DENIED;
        }
 
@@ -3930,80 +4365,43 @@ uint32 _spoolss_addprinterex( const UNISTR2 *uni_srv_name, uint32 level,
        }
 }
 
-/****************************************************************************
- Modify internal driver heirarchy.
-****************************************************************************/
-
-#if MANGLE_DRIVER_PATH
-static uint32 modify_driver_heirarchy(NT_PRINTER_DRIVER_INFO_LEVEL *driver, uint32 level)
-{
-       pstring path_old;
-       pstring path_new;
-       pstring short_archi;
-       pstring model_name;
-
-       /* find_service is an smbd-specific function call */
-       int snum = find_service("print$");
-       char *model = NULL;
-
-       *short_archi = '\0';
-       switch (level) {
-               case 3:
-                       get_short_archi(short_archi, driver->info_3->environment);
-                       model = driver->info_3->name;
-                       break;
-               case 6:
-                       get_short_archi(short_archi, driver->info_6->environment);
-                       model = driver->info_6->name;
-                       break;
-               default:
-                       DEBUG(0,("modify_driver_heirarchy: unknown info level (%d)\n", level));
-                       return ERROR_INVALID_LEVEL;
-                       break;
-       }
-
-       slprintf(path_old, sizeof(path_old)-1, "%s/%s/TMP_%s", lp_pathname(snum), short_archi,
-               client_addr());
-
-       /* Clean up any '/' and other characters in the model name. */
-       alpha_strcpy(model_name, model, sizeof(pstring));
-
-       slprintf(path_new, sizeof(path_new)-1, "%s/%s/%s", lp_pathname(snum), short_archi, model_name);
-
-       DEBUG(10,("modify_driver_heirarchy: old_path=%s, new_path=%s\n",
-                       path_old, path_new ));
-       if (dos_rename(path_old, path_new) == -1) {
-               DEBUG(0,("modify_driver_heirarchy: rename from %s to %s failed (%s)\n", 
-                       path_old, path_new, strerror(errno) ));
-               /* We need to clean up here.... - how ? */
-               return ERROR_ACCESS_DENIED; /* We need a generic mapping from NT errors here... */
-       }
-
-       return NT_STATUS_NO_PROBLEMO;
-}
-#endif
-
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addprinterdriver( const UNISTR2 *server_name,
-                               uint32 level,
-                               const SPOOL_PRINTER_DRIVER_INFO_LEVEL *info)
+uint32 _spoolss_addprinterdriver(pipes_struct *p, const UNISTR2 *server_name,
+                                uint32 level, const SPOOL_PRINTER_DRIVER_INFO_LEVEL *info)
 {
        uint32 err = NT_STATUS_NO_PROBLEMO;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
+       struct current_user user;
+       
        ZERO_STRUCT(driver);
        
+       if (p->ntlmssp_auth_validated) {
+               memcpy(&user, &p->pipe_user, sizeof(user));
+       } else {
+               extern struct current_user current_user;
+               memcpy(&user, &current_user, sizeof(user));
+       }
+       
        convert_printer_driver_info(info, &driver, level);
 
-       if (add_a_printer_driver(driver, level)!=0)
-               return ERROR_ACCESS_DENIED;
+       DEBUG(5,("Cleaning driver's information\n"));
+       clean_up_driver_struct(driver, level);
 
-#if MANGLE_DRIVER_PATH
-       err = modify_driver_heirarchy(&driver, level);
-#endif
+       DEBUG(5,("Moving driver to final destination\n"));
+       if(!move_driver_to_download_area(driver, level, &user, &err)) {
+               if (err == 0)
+                       err = ERROR_ACCESS_DENIED;
+               goto done;
+       }
 
-       free_a_printer_driver(driver, level);
+       if (add_a_printer_driver(driver, level)!=0) {
+               err = ERROR_ACCESS_DENIED;
+               goto done;
+       }
 
+ done:
+       free_a_printer_driver(driver, level);
        return err;
 }
 
@@ -4011,7 +4409,7 @@ uint32 _spoolss_addprinterdriver( const UNISTR2 *server_name,
 ****************************************************************************/
 static void fill_driverdir_1(DRIVER_DIRECTORY_1 *info, char *name)
 {
-       init_unistr(&(info->name), name);
+       init_unistr(&info->name, name);
 }
 
 /****************************************************************************
@@ -4022,20 +4420,17 @@ static uint32 getprinterdriverdir_level_1(UNISTR2 *name, UNISTR2 *uni_environmen
        pstring long_archi;
        pstring short_archi;
        DRIVER_DIRECTORY_1 *info=NULL;
-       
+
+       unistr2_to_ascii(long_archi, uni_environment, sizeof(long_archi)-1);
+
+       if (get_short_archi(short_archi, long_archi)==FALSE)
+               return ERROR_INVALID_ENVIRONMENT;
+
        if((info=(DRIVER_DIRECTORY_1 *)malloc(sizeof(DRIVER_DIRECTORY_1))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
-       
-       unistr2_to_ascii(long_archi, uni_environment, sizeof(long_archi)-1);
-       get_short_archi(short_archi, long_archi);
-               
-#if MANGLE_DRIVER_PATH
-       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s\\TMP_%s", global_myname, short_archi,
-               client_addr());
-#else
-       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s",
-                       global_myname, short_archi);
-#endif
+
+       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s", global_myname, short_archi);
+
        DEBUG(4,("printer driver directory: [%s]\n", path));
 
        fill_driverdir_1(info, path);
@@ -4079,7 +4474,7 @@ uint32 _spoolss_getprinterdriverdirectory(UNISTR2 *name, UNISTR2 *uni_environmen
        
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
+uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
                                uint32 in_value_len, uint32 in_data_len,
                                uint32 *out_max_value_len, uint16 **out_value, uint32 *out_value_len,
                                uint32 *out_type,
@@ -4112,8 +4507,10 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
 
        DEBUG(5,("spoolss_enumprinterdata\n"));
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_enumprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        if (!get_printer_snum(handle, &snum))
                return ERROR_INVALID_HANDLE;
@@ -4128,7 +4525,25 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
         */
        if ( (in_value_len==0) && (in_data_len==0) ) {
                DEBUGADD(6,("Activating NT mega-hack to find sizes\n"));
-               
+
+               /*
+                * NT can ask for a specific parameter size - we need to return NO_MORE_ITEMS
+                * if this parameter size doesn't exist.
+                * Ok - my opinion here is that the client is not asking for the greatest
+                * possible size of all the parameters, but is asking specifically for the size needed
+                * for this specific parameter. In that case we can remove the loop below and
+                * simplify this lookup code considerably. JF - comments welcome. JRA.
+                */
+
+               if (!get_specific_param_by_index(*printer, 2, idx, value, &data, &type, &data_len)) {
+                       safe_free(data);
+                       free_a_printer(&printer, 2);
+                       return ERROR_NO_MORE_ITEMS;
+               }
+
+               safe_free(data);
+               data = NULL;
+
                param_index=0;
                biggest_valuesize=0;
                biggest_datasize=0;
@@ -4140,9 +4555,22 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
                        DEBUG(6,("current values: [%d], [%d]\n", biggest_valuesize, biggest_datasize));
 
                        safe_free(data);
+                       data = NULL;
                        param_index++;
                }
 
+               /*
+                * I think this is correct, it doesn't break APW and
+                * allows Gerald's Win32 test programs to work correctly,
+                * but may need altering.... JRA.
+                */
+
+               if (param_index == 0) {
+                       /* No parameters found. */
+                       free_a_printer(&printer, 2);
+                       return ERROR_NO_MORE_ITEMS;
+               }
+
                /* the value is an UNICODE string but realvaluesize is the length in bytes including the leading 0 */
                *out_value_len=2*(1+biggest_valuesize);
                *out_data_len=biggest_datasize;
@@ -4180,10 +4608,9 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
                safe_free(data);
                return ERROR_NOT_ENOUGH_MEMORY;
        }
+       
+       ZERO_STRUCTP(*out_value);
        *out_value_len = (uint32)dos_PutUniCode((char *)*out_value, value, in_value_len, True);
-#if 0 /* JRATEST */
-       *out_max_value_len=(*out_value_len/sizeof(uint16));
-#endif /* JRATEST */
 
        *out_type=type;
 
@@ -4193,11 +4620,10 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
                safe_free(data);
                return ERROR_NOT_ENOUGH_MEMORY;
        }
+       
+       ZERO_STRUCTP(*data_out);
        memcpy(*data_out, data, (size_t)data_len);
        *out_data_len=data_len;
-#if 0 /* JRATEST */
-       *out_max_data_len=data_len;
-#endif /* JRATEST */
 
        safe_free(data);
        
@@ -4206,7 +4632,7 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setprinterdata( const POLICY_HND *handle,
+uint32 _spoolss_setprinterdata( POLICY_HND *handle,
                                const UNISTR2 *value,
                                uint32 type,
                                uint32 max_len,
@@ -4215,8 +4641,7 @@ uint32 _spoolss_setprinterdata( const POLICY_HND *handle,
                                uint32 numeric_data)
 {
        NT_PRINTER_INFO_LEVEL *printer = NULL;
-       NT_PRINTER_PARAM *param = NULL;
-               
+       NT_PRINTER_PARAM *param = NULL;         
        int snum=0;
        uint32 status = 0x0;
        Printer_entry *Printer=find_printer_index_by_hnd(handle);
@@ -4224,12 +4649,20 @@ uint32 _spoolss_setprinterdata( const POLICY_HND *handle,
        DEBUG(5,("spoolss_setprinterdata\n"));
 
        
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_setprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        if (!get_printer_snum(handle, &snum))
                return ERROR_INVALID_HANDLE;
 
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("security descriptor change denied by existing "
+                         "security descriptor\n"));
+               return ERROR_ACCESS_DENIED;
+       }
+
        status = get_a_printer(&printer, 2, lp_servicename(snum));
        if (status != 0x0)
                return ERROR_INVALID_NAME;
@@ -4248,7 +4681,7 @@ uint32 _spoolss_setprinterdata( const POLICY_HND *handle,
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addform( const POLICY_HND *handle,
+uint32 _spoolss_addform( POLICY_HND *handle,
                                uint32 level,
                                const FORM *form)
 {
@@ -4258,8 +4691,10 @@ uint32 _spoolss_addform( const POLICY_HND *handle,
 
        DEBUG(5,("spoolss_addform\n"));
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_addform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        count=get_ntforms(&list);
        if(!add_a_form(&list, form, &count))
@@ -4273,7 +4708,32 @@ uint32 _spoolss_addform( const POLICY_HND *handle,
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setform( const POLICY_HND *handle,
+uint32 _spoolss_deleteform( POLICY_HND *handle, UNISTR2 *form_name)
+{
+       int count=0;
+       uint32 ret = 0;
+       nt_forms_struct *list=NULL;
+       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+
+       DEBUG(5,("spoolss_deleteform\n"));
+
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_deleteform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
+               return ERROR_INVALID_HANDLE;
+       }
+
+       count = get_ntforms(&list);
+       if(!delete_a_form(&list, form_name, &count, &ret))
+               return ERROR_INVALID_PARAMETER;
+
+       safe_free(list);
+
+       return ret;
+}
+
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_setform( POLICY_HND *handle,
                                const UNISTR2 *uni_name,
                                uint32 level,
                                const FORM *form)
@@ -4284,8 +4744,8 @@ uint32 _spoolss_setform( const POLICY_HND *handle,
 
        DEBUG(5,("spoolss_setform\n"));
 
-       if (!OPEN_HANDLE(Printer))
-       {
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_setform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
        count=get_ntforms(&list);
@@ -4309,7 +4769,7 @@ static uint32 enumprintprocessors_level_1(NEW_BUFFER *buffer, uint32 offered, ui
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_1->name), "winprint");
+       init_unistr(&info_1->name, "winprint");
 
        *needed += spoolss_size_printprocessor_info_1(info_1);
 
@@ -4368,7 +4828,7 @@ static uint32 enumprintprocdatatypes_level_1(NEW_BUFFER *buffer, uint32 offered,
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_1->name), "RAW");
+       init_unistr(&info_1->name, "RAW");
 
        *needed += spoolss_size_printprocdatatype_info_1(info_1);
 
@@ -4420,7 +4880,7 @@ static uint32 enumprintmonitors_level_1(NEW_BUFFER *buffer, uint32 offered, uint
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_1->name), "Local Port");
+       init_unistr(&info_1->name, "Local Port");
 
        *needed += spoolss_size_printmonitor_info_1(info_1);
 
@@ -4451,9 +4911,9 @@ static uint32 enumprintmonitors_level_2(NEW_BUFFER *buffer, uint32 offered, uint
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_2->name), "Local Port");
-       init_unistr(&(info_2->environment), "Windows NT X86");
-       init_unistr(&(info_2->dll_name), "localmon.dll");
+       init_unistr(&info_2->name, "Local Port");
+       init_unistr(&info_2->environment, "Windows NT X86");
+       init_unistr(&info_2->dll_name, "localmon.dll");
 
        *needed += spoolss_size_printmonitor_info_2(info_2);