Adding Herb's compile warning fixes to HEAD.
[sfrench/samba-autobuild/.git] / source / rpc_server / srv_samr.c
index 74d06d1bcae02901c17b248abb4157c1e3e2c727..7891fc16dc1ea6eb8e37b8ae742b0e01c8a292df 100644 (file)
@@ -1,4 +1,4 @@
-
+#define OLD_NTDOMAIN 1
 /* 
  *  Unix SMB/Netbios implementation.
  *  Version 1.9.
@@ -6,6 +6,7 @@
  *  Copyright (C) Andrew Tridgell              1992-1997,
  *  Copyright (C) Luke Kenneth Casson Leighton 1996-1997,
  *  Copyright (C) Paul Ashton                       1997.
+ *  Copyright (C) Hewlett-Packard Company           1999.
  *  
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
  *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
-
 #include "includes.h"
-#include "nterr.h"
 
 extern int DEBUGLEVEL;
 
-extern BOOL sam_logon_in_ssb;
-extern pstring samlogon_user;
 extern fstring global_myworkgroup;
 extern pstring global_myname;
 extern DOM_SID global_sam_sid;
@@ -58,18 +55,15 @@ static BOOL get_sampwd_entries(SAM_USER_INFO_21 *pw_buf,
        if (pw_buf == NULL) return False;
 
        vp = startsmbpwent(False);
-       if (!vp)
-       {
+       if (!vp) {
                DEBUG(0, ("get_sampwd_entries: Unable to open SMB password database.\n"));
                return False;
        }
 
-       while (((pwd = getsam21pwent(vp)) != NULL) && (*num_entries) < max_num_entries)
-       {
+       while (((pwd = getsam21pwent(vp)) != NULL) && (*num_entries) < max_num_entries) {
                int user_name_len;
 
-               if (start_idx > 0)
-               {
+               if (start_idx > 0) {
                        /* skip the requested number of entries.
                           not very efficient, but hey...
                         */
@@ -78,15 +72,13 @@ static BOOL get_sampwd_entries(SAM_USER_INFO_21 *pw_buf,
                }
 
                user_name_len = strlen(pwd->smb_name);
-               make_unistr2(&(pw_buf[(*num_entries)].uni_user_name), pwd->smb_name, user_name_len-1);
-               make_uni_hdr(&(pw_buf[(*num_entries)].hdr_user_name), user_name_len-1, 
-                              user_name_len-1, 1);
+               init_unistr2(&(pw_buf[(*num_entries)].uni_user_name), pwd->smb_name, user_name_len);
+               init_uni_hdr(&(pw_buf[(*num_entries)].hdr_user_name), user_name_len);
                pw_buf[(*num_entries)].user_rid = pwd->user_rid;
-               bzero( pw_buf[(*num_entries)].nt_pwd , 16);
+               memset((char *)pw_buf[(*num_entries)].nt_pwd, '\0', 16);
 
                /* Now check if the NT compatible password is available. */
-               if (pwd->smb_nt_passwd != NULL)
-               {
+               if (pwd->smb_nt_passwd != NULL) {
                        memcpy( pw_buf[(*num_entries)].nt_pwd , pwd->smb_nt_passwd, 16);
                }
 
@@ -96,13 +88,10 @@ static BOOL get_sampwd_entries(SAM_USER_INFO_21 *pw_buf,
                          (*num_entries), pwd->smb_name,
                          pwd->user_rid, pwd->acct_ctrl));
 
-               if (acb_mask == 0 || IS_BITS_SET_SOME(pwd->acct_ctrl, acb_mask))
-               {
+               if (acb_mask == 0 || (pwd->acct_ctrl & acb_mask)) {
                        DEBUG(5,(" acb_mask %x accepts\n", acb_mask));
                        (*num_entries)++;
-               }
-               else
-               {
+               } else {
                        DEBUG(5,(" acb_mask %x rejects\n", acb_mask));
                }
 
@@ -114,16 +103,253 @@ static BOOL get_sampwd_entries(SAM_USER_INFO_21 *pw_buf,
        return (*num_entries) > 0;
 }
 
+/*******************************************************************
+ This function uses the username map file and tries to map a UNIX
+ user name to an DOS name.  (Sort of the reverse of the
+ map_username() function.)  Since more than one DOS name can map
+ to the UNIX name, to reverse the mapping you have to specify
+ which corresponding DOS name you want; that's where the name_idx
+ parameter comes in.  Returns the string requested or NULL if it
+ fails or can't complete the request for any reason.  This doesn't
+ handle group names (starting with '@') or names starting with
+ '+' or '&'.  If they are encountered, they are skipped.
+********************************************************************/
+
+static char *unmap_unixname(char *unix_user_name, int name_idx)
+{
+       char *mapfile = lp_username_map();
+       char **lines;
+       static pstring tok;
+       int i;
+
+       if (!*unix_user_name) return NULL;
+       if (!*mapfile) return NULL;
+
+       lines = file_lines_load(mapfile, NULL);
+       if (!lines) {
+               DEBUG(0,("unmap_unixname: can't open username map %s\n", mapfile));
+               return NULL;
+       }
+
+       DEBUG(5,("unmap_unixname: scanning username map %s, index: %d\n", mapfile, name_idx));
+
+       for (i=0; lines[i]; i++) {
+               char *unixname = lines[i];
+               char *dosname = strchr(unixname,'=');
+
+               if (!dosname)
+                       continue;
+
+               *dosname++ = 0;
+
+               while (isspace(*unixname))
+                       unixname++;
+               if ('!' == *unixname) {
+                       unixname++;
+                       while (*unixname && isspace(*unixname))
+                               unixname++;
+               }
+    
+               if (!*unixname || strchr("#;",*unixname))
+                       continue;
+
+               if (strncmp(unixname, unix_user_name, strlen(unix_user_name)))
+                       continue;
+
+               /* We have matched the UNIX user name */
+
+               while(next_token(&dosname, tok, LIST_SEP, sizeof(tok))) {
+                       if (!strchr("@&+", *tok)) {
+                               name_idx--;
+                               if (name_idx < 0 ) {
+                                       break;
+                               }
+                       }
+               }
+
+               if (name_idx >= 0) {
+                       DEBUG(0,("unmap_unixname: index too high - not that many DOS names\n"));
+                       file_lines_free(lines);
+                       return NULL;
+               } else {
+                       file_lines_free(lines);
+                       return tok;
+               }
+       }
+
+       DEBUG(0,("unmap_unixname: Couldn't find the UNIX user name\n"));
+       file_lines_free(lines);
+       return NULL;
+}
+
+/*******************************************************************
+ This function sets up a list of users taken from the list of
+ users that UNIX knows about, as well as all the user names that
+ Samba maps to a valid UNIX user name.  (This should work with
+ /etc/passwd or NIS.)
+********************************************************************/
+
+static BOOL get_passwd_entries(SAM_USER_INFO_21 *pw_buf,
+                               int start_idx,
+                               int *total_entries, int *num_entries,
+                               int max_num_entries,
+                               uint16 acb_mask)
+{
+       static struct passwd *pwd = NULL;
+       static uint32 pw_rid;
+       static BOOL orig_done = False;
+       static int current_idx = 0;
+       static int mapped_idx = 0;
+       char *sep;
+
+       DEBUG(5, ("get_passwd_entries: retrieving a list of UNIX users\n"));
+
+       (*num_entries) = 0;
+       (*total_entries) = 0;
+
+       if (pw_buf == NULL) return False;
+
+       if (current_idx == 0) {
+               setpwent();
+       }
+
+       /* These two cases are inefficient, but should be called very rarely */
+       /* they are the cases where the starting index isn't picking up      */
+       /* where we left off last time.  It is efficient when it starts over */
+       /* at zero though.                                                   */
+       if (start_idx > current_idx) {
+               /* We aren't far enough; advance to start_idx */
+               while (current_idx < start_idx) {
+                       char *unmap_name;
+
+                       if(!orig_done) {
+                               if ((pwd = getpwent()) == NULL) break;
+                               current_idx++;
+                               orig_done = True;
+                       }
+
+                       while (((unmap_name = unmap_unixname(pwd->pw_name, mapped_idx)) != NULL) && 
+                               (current_idx < start_idx)) {
+                               current_idx++;
+                               mapped_idx++;
+                       }
+
+                       if (unmap_name == NULL) {
+                               orig_done = False;
+                               mapped_idx = 0;
+                       }
+               }
+       } else if (start_idx < current_idx) {
+               /* We are already too far; start over and advance to start_idx */
+               endpwent();
+               setpwent();
+               current_idx = 0;
+               mapped_idx = 0;
+               orig_done = False;
+               while (current_idx < start_idx) {
+                       char *unmap_name;
+
+                       if(!orig_done) {
+                               if ((pwd = getpwent()) == NULL) break;
+                               current_idx++;
+                               orig_done = True;
+                       }
+
+                       while (((unmap_name = unmap_unixname(pwd->pw_name, mapped_idx)) != NULL) && 
+                               (current_idx < start_idx)) {
+                               current_idx++;
+                               mapped_idx++;
+                       }
+
+                       if (unmap_name == NULL) {
+                               orig_done = False;
+                               mapped_idx = 0;
+                       }
+               }
+       }
+
+       sep = lp_winbind_separator();
+
+       /* now current_idx == start_idx */
+       while ((*num_entries) < max_num_entries) {
+               int user_name_len;
+               char *unmap_name;
+
+               /* This does the original UNIX user itself */
+               if(!orig_done) {
+                       if ((pwd = getpwent()) == NULL) break;
+
+                       /* Don't enumerate winbind users as they are not local */
+
+                       if (strchr(pwd->pw_name, *sep) != NULL) {
+                               continue;
+                       }
+
+                       user_name_len = strlen(pwd->pw_name);
+                       pw_rid = pdb_uid_to_user_rid(pwd->pw_uid);
+                       ZERO_STRUCTP(&pw_buf[(*num_entries)]);
+                       init_unistr2(&(pw_buf[(*num_entries)].uni_user_name), pwd->pw_name, user_name_len);
+                       init_uni_hdr(&(pw_buf[(*num_entries)].hdr_user_name), user_name_len);
+                       pw_buf[(*num_entries)].user_rid = pw_rid;
+                       memset((char *)pw_buf[(*num_entries)].nt_pwd, '\0', 16);
+
+                       pw_buf[(*num_entries)].acb_info = ACB_NORMAL;
+
+                       DEBUG(5, ("get_passwd_entries: entry idx %d user %s, rid 0x%x\n", (*num_entries), pwd->pw_name, pw_rid));
+
+                       (*num_entries)++;
+                       (*total_entries)++;
+                       current_idx++;
+                       orig_done = True;
+               }
+
+               /* This does all the user names that map to the UNIX user */
+               while (((unmap_name = unmap_unixname(pwd->pw_name, mapped_idx)) != NULL) && 
+                       (*num_entries < max_num_entries)) {
+                       user_name_len = strlen(unmap_name);
+                       ZERO_STRUCTP(&pw_buf[(*num_entries)]);
+                       init_unistr2(&(pw_buf[(*num_entries)].uni_user_name), unmap_name, user_name_len);
+                       init_uni_hdr(&(pw_buf[(*num_entries)].hdr_user_name), user_name_len);
+                       pw_buf[(*num_entries)].user_rid = pw_rid;
+                       memset((char *)pw_buf[(*num_entries)].nt_pwd, '\0', 16);
+
+                       pw_buf[(*num_entries)].acb_info = ACB_NORMAL;
+
+                       DEBUG(5, ("get_passwd_entries: entry idx %d user %s, rid 0x%x\n", (*num_entries), pwd->pw_name, pw_rid));
+
+                       (*num_entries)++;
+                       (*total_entries)++;
+                       current_idx++;
+                       mapped_idx++;
+               }
+
+               if (unmap_name == NULL) {
+                       /* done with 'aliases', go on to next UNIX user */
+                       orig_done = False;
+                       mapped_idx = 0;
+               }
+       }
+
+       if (pwd == NULL) {
+               /* totally done, reset everything */
+               endpwent();
+               current_idx = 0;
+               mapped_idx = 0;
+       }
+
+       return (*num_entries) > 0;
+}
+
 /*******************************************************************
  samr_reply_unknown_1
  ********************************************************************/
-static void samr_reply_close_hnd(SAMR_Q_CLOSE_HND *q_u,
+static BOOL samr_reply_close_hnd(SAMR_Q_CLOSE_HND *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_CLOSE_HND r_u;
 
        /* set up the SAMR unknown_1 response */
-       bzero(r_u.pol.data, POL_HND_SIZE);
+       memset((char *)r_u.pol.data, '\0', POL_HND_SIZE);
 
        /* close the policy handle */
        if (close_lsa_policy_hnd(&(q_u->pol)))
@@ -138,31 +364,39 @@ static void samr_reply_close_hnd(SAMR_Q_CLOSE_HND *q_u,
        DEBUG(5,("samr_reply_close_hnd: %d\n", __LINE__));
 
        /* store the response in the SMB stream */
-       samr_io_r_close_hnd("", &r_u, rdata, 0);
+       if(!samr_io_r_close_hnd("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_reply_close_hnd: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_close_hnd
  ********************************************************************/
-static void api_samr_close_hnd( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_close_hnd(pipes_struct *p)
 {
        SAMR_Q_CLOSE_HND q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr unknown 1 */
-       samr_io_q_close_hnd("", &q_u, data, 0);
+       if(!samr_io_q_close_hnd("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_close_hnd(&q_u, rdata);
+       if(!samr_reply_close_hnd(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_open_domain
  ********************************************************************/
-static void samr_reply_open_domain(SAMR_Q_OPEN_DOMAIN *q_u,
+static BOOL samr_reply_open_domain(SAMR_Q_OPEN_DOMAIN *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_OPEN_DOMAIN r_u;
@@ -197,31 +431,39 @@ static void samr_reply_open_domain(SAMR_Q_OPEN_DOMAIN *q_u,
        DEBUG(5,("samr_open_domain: %d\n", __LINE__));
 
        /* store the response in the SMB stream */
-       samr_io_r_open_domain("", &r_u, rdata, 0);
+       if(!samr_io_r_open_domain("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_open_domain: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_open_domain
  ********************************************************************/
-static void api_samr_open_domain( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_open_domain(pipes_struct *p)
 {
        SAMR_Q_OPEN_DOMAIN q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open */
-       samr_io_q_open_domain("", &q_u, data, 0);
+       if(!samr_io_q_open_domain("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_open_domain(&q_u, rdata);
+       if(!samr_reply_open_domain(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_unknown_2c
  ********************************************************************/
-static void samr_reply_unknown_2c(SAMR_Q_UNKNOWN_2C *q_u,
+static BOOL samr_reply_unknown_2c(SAMR_Q_UNKNOWN_2C *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_UNKNOWN_2C r_u;
@@ -239,36 +481,44 @@ static void samr_reply_unknown_2c(SAMR_Q_UNKNOWN_2C *q_u,
                status = NT_STATUS_OBJECT_TYPE_MISMATCH;
        }
 
-       make_samr_r_unknown_2c(&r_u, status);
+       init_samr_r_unknown_2c(&r_u, status);
 
        DEBUG(5,("samr_unknown_2c: %d\n", __LINE__));
 
        /* store the response in the SMB stream */
-       samr_io_r_unknown_2c("", &r_u, rdata, 0);
+       if(!samr_io_r_unknown_2c("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_unknown_2c: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_unknown_2c
  ********************************************************************/
-static void api_samr_unknown_2c( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_unknown_2c(pipes_struct *p)
 {
        SAMR_Q_UNKNOWN_2C q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open */
-       samr_io_q_unknown_2c("", &q_u, data, 0);
+       if(!samr_io_q_unknown_2c("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_unknown_2c(&q_u, rdata);
+       if(!samr_reply_unknown_2c(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_unknown_3
  ********************************************************************/
-static void samr_reply_unknown_3(SAMR_Q_UNKNOWN_3 *q_u,
+static BOOL samr_reply_unknown_3(SAMR_Q_UNKNOWN_3 *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_UNKNOWN_3 r_u;
@@ -308,11 +558,11 @@ static void samr_reply_unknown_3(SAMR_Q_UNKNOWN_3 *q_u,
 
                        /* maybe need another 1 or 2 (S-1-5-0x20-0x220 and S-1-5-20-0x224) */
                        /* these two are DOMAIN_ADMIN and DOMAIN_ACCT_OP group RIDs */
-                       make_dom_sid3(&(sid[0]), 0x035b, 0x0002, &everyone_sid);
-                       make_dom_sid3(&(sid[1]), 0x0044, 0x0002, &user_sid);
+                       init_dom_sid3(&(sid[0]), 0x035b, 0x0002, &everyone_sid);
+                       init_dom_sid3(&(sid[1]), 0x0044, 0x0002, &user_sid);
        }
 
-       make_samr_r_unknown_3(&r_u,
+       init_samr_r_unknown_3(&r_u,
                                0x0001, 0x8004,
                                0x00000014, 0x0002, 0x0070,
                                2, sid, status);
@@ -320,37 +570,47 @@ static void samr_reply_unknown_3(SAMR_Q_UNKNOWN_3 *q_u,
        DEBUG(5,("samr_unknown_3: %d\n", __LINE__));
 
        /* store the response in the SMB stream */
-       samr_io_r_unknown_3("", &r_u, rdata, 0);
+       if(!samr_io_r_unknown_3("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_unknown_3: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_unknown_3
  ********************************************************************/
-static void api_samr_unknown_3( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_unknown_3(pipes_struct *p)
 {
        SAMR_Q_UNKNOWN_3 q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open */
-       samr_io_q_unknown_3("", &q_u, data, 0);
+       if(!samr_io_q_unknown_3("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_unknown_3(&q_u, rdata);
+       if(!samr_reply_unknown_3(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_enum_dom_users
  ********************************************************************/
-static void samr_reply_enum_dom_users(SAMR_Q_ENUM_DOM_USERS *q_u,
+static BOOL samr_reply_enum_dom_users(SAMR_Q_ENUM_DOM_USERS *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_ENUM_DOM_USERS r_e;
        SAM_USER_INFO_21 pass[MAX_SAM_ENTRIES];
        int num_entries;
        int total_entries;
+       
+       ZERO_STRUCT(r_e);
 
        r_e.status = 0x0;
        r_e.total_num_entries = 0;
@@ -363,40 +623,47 @@ static void samr_reply_enum_dom_users(SAMR_Q_ENUM_DOM_USERS *q_u,
 
        DEBUG(5,("samr_reply_enum_dom_users: %d\n", __LINE__));
 
-       become_root(True);
+       become_root();
        get_sampwd_entries(pass, 0, &total_entries, &num_entries, MAX_SAM_ENTRIES, q_u->acb_mask);
-       unbecome_root(True);
+       unbecome_root();
 
-       make_samr_r_enum_dom_users(&r_e, total_entries,
+       init_samr_r_enum_dom_users(&r_e, total_entries,
                                   q_u->unknown_0, num_entries,
                                   pass, r_e.status);
 
        /* store the response in the SMB stream */
-       samr_io_r_enum_dom_users("", &r_e, rdata, 0);
+       if(!samr_io_r_enum_dom_users("", &r_e, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_enum_dom_users: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_enum_dom_users
  ********************************************************************/
-static void api_samr_enum_dom_users( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_enum_dom_users(pipes_struct *p)
 {
        SAMR_Q_ENUM_DOM_USERS q_e;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open */
-       samr_io_q_enum_dom_users("", &q_e, data, 0);
+       if(!samr_io_q_enum_dom_users("", &q_e, data, 0))
+               return False;
 
        /* construct reply. */
-       samr_reply_enum_dom_users(&q_e, rdata);
-}
+       if(!samr_reply_enum_dom_users(&q_e, rdata))
+               return False;
 
+       return True;
+}
 
 /*******************************************************************
  samr_reply_enum_dom_groups
  ********************************************************************/
-static void samr_reply_enum_dom_groups(SAMR_Q_ENUM_DOM_GROUPS *q_u,
+static BOOL samr_reply_enum_dom_groups(SAMR_Q_ENUM_DOM_GROUPS *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_ENUM_DOM_GROUPS r_e;
@@ -404,6 +671,8 @@ static void samr_reply_enum_dom_groups(SAMR_Q_ENUM_DOM_GROUPS *q_u,
        int num_entries;
        BOOL got_grps;
        char *dummy_group = "Domain Admins";
+       
+       ZERO_STRUCT(r_e);
 
        r_e.status = 0x0;
        r_e.num_entries = 0;
@@ -418,40 +687,48 @@ static void samr_reply_enum_dom_groups(SAMR_Q_ENUM_DOM_GROUPS *q_u,
 
        got_grps = True;
        num_entries = 1;
-       make_unistr2(&(pass[0].uni_user_name), dummy_group, strlen(dummy_group));
+       ZERO_STRUCTP(&pass[0]);
+       init_unistr2(&(pass[0].uni_user_name), dummy_group, strlen(dummy_group));
        pass[0].user_rid = DOMAIN_GROUP_RID_ADMINS;
 
        if (r_e.status == 0 && got_grps)
        {
-               make_samr_r_enum_dom_groups(&r_e, q_u->start_idx, num_entries, pass, r_e.status);
+               init_samr_r_enum_dom_groups(&r_e, q_u->start_idx, num_entries, pass, r_e.status);
        }
 
        /* store the response in the SMB stream */
-       samr_io_r_enum_dom_groups("", &r_e, rdata, 0);
+       if(!samr_io_r_enum_dom_groups("", &r_e, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_enum_dom_groups: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_enum_dom_groups
  ********************************************************************/
-static void api_samr_enum_dom_groups( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_enum_dom_groups(pipes_struct *p)
 {
        SAMR_Q_ENUM_DOM_GROUPS q_e;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open */
-       samr_io_q_enum_dom_groups("", &q_e, data, 0);
+       if(!samr_io_q_enum_dom_groups("", &q_e, data, 0))
+               return False;
 
        /* construct reply. */
-       samr_reply_enum_dom_groups(&q_e, rdata);
-}
+       if(!samr_reply_enum_dom_groups(&q_e, rdata))
+               return False;
 
+       return True;
+}
 
 /*******************************************************************
  samr_reply_enum_dom_aliases
  ********************************************************************/
-static void samr_reply_enum_dom_aliases(SAMR_Q_ENUM_DOM_ALIASES *q_u,
+static BOOL samr_reply_enum_dom_aliases(SAMR_Q_ENUM_DOM_ALIASES *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_ENUM_DOM_ALIASES r_e;
@@ -460,9 +737,9 @@ static void samr_reply_enum_dom_aliases(SAMR_Q_ENUM_DOM_ALIASES *q_u,
        DOM_SID sid;
        fstring sid_str;
        fstring sam_sid_str;
-
-       r_e.status = 0x0;
-       r_e.num_entries = 0;
+       struct group *grp;
+       
+       ZERO_STRUCT(r_e);
 
        /* find the policy handle.  open a policy on it. */
        if (r_e.status == 0x0 && !get_lsa_policy_samr_sid(&q_u->pol, &sid))
@@ -481,48 +758,80 @@ static void samr_reply_enum_dom_aliases(SAMR_Q_ENUM_DOM_ALIASES *q_u,
                char *name;
                while (num_entries < MAX_SAM_ENTRIES && ((name = builtin_alias_rids[num_entries].name) != NULL))
                {
-                       make_unistr2(&(pass[num_entries].uni_user_name), name, strlen(name));
+                       init_unistr2(&(pass[num_entries].uni_user_name), name, strlen(name));
                        pass[num_entries].user_rid = builtin_alias_rids[num_entries].rid;
                        num_entries++;
                }
        }
        else if (strequal(sid_str, sam_sid_str))
        {
+               char *name;
+               char *sep;
+
+               sep = lp_winbind_separator();
+
                /* local aliases */
-               /* oops!  there's no code to deal with this */
-               DEBUG(3,("samr_reply_enum_dom_aliases: enum of aliases in our domain not supported yet\n"));
-               num_entries = 0;
+               /* we return the UNIX groups here.  This seems to be the right */
+               /* thing to do, since NT member servers return their local     */
+                /* groups in the same situation.                               */
+               setgrent();
+
+               while (num_entries < MAX_SAM_ENTRIES && ((grp = getgrent()) != NULL))
+               {
+                       name = grp->gr_name;
+
+                       /* Don't return winbind groups as they are not local! */
+
+                       if (strchr(name, *sep) != NULL) {
+                               continue;
+                       }
+
+                       init_unistr2(&(pass[num_entries].uni_user_name), name, strlen(name));
+                       pass[num_entries].user_rid = pdb_gid_to_group_rid(grp->gr_gid);
+                       num_entries++;
+               }
+
+               endgrent();
        }
                
-       make_samr_r_enum_dom_aliases(&r_e, num_entries, pass, r_e.status);
+       init_samr_r_enum_dom_aliases(&r_e, num_entries, pass, r_e.status);
 
        /* store the response in the SMB stream */
-       samr_io_r_enum_dom_aliases("", &r_e, rdata, 0);
+       if(!samr_io_r_enum_dom_aliases("", &r_e, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_enum_dom_aliases: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_enum_dom_aliases
  ********************************************************************/
-static void api_samr_enum_dom_aliases( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_enum_dom_aliases(pipes_struct *p)
 {
        SAMR_Q_ENUM_DOM_ALIASES q_e;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
+       
+       ZERO_STRUCT(q_e);
 
        /* grab the samr open */
-       samr_io_q_enum_dom_aliases("", &q_e, data, 0);
+       if(!samr_io_q_enum_dom_aliases("", &q_e, data, 0))
+               return False;
 
        /* construct reply. */
-       samr_reply_enum_dom_aliases(&q_e, rdata);
+       if(!samr_reply_enum_dom_aliases(&q_e, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_query_dispinfo
  ********************************************************************/
-static void samr_reply_query_dispinfo(SAMR_Q_QUERY_DISPINFO *q_u,
-                               prs_struct *rdata)
+static BOOL samr_reply_query_dispinfo(SAMR_Q_QUERY_DISPINFO *q_u, prs_struct *rdata)
 {
        SAMR_R_QUERY_DISPINFO r_e;
        SAM_INFO_CTR ctr;
@@ -536,8 +845,6 @@ static void samr_reply_query_dispinfo(SAMR_Q_QUERY_DISPINFO *q_u,
 
        ZERO_STRUCT(r_e);
 
-       r_e.status = 0x0;
-
        DEBUG(5,("samr_reply_query_dispinfo: %d\n", __LINE__));
 
        /* find the policy handle.  open a policy on it. */
@@ -549,9 +856,35 @@ static void samr_reply_query_dispinfo(SAMR_Q_QUERY_DISPINFO *q_u,
 
        if (r_e.status == 0x0)
        {
-               become_root(True);
-               got_pwds = get_sampwd_entries(pass, q_u->start_idx, &total_entries, &num_entries, MAX_SAM_ENTRIES, 0);
-               unbecome_root(True);
+         /* decide how many entries to get depending on the max_entries 
+            and max_size passed by client */
+         uint32 retsize;
+
+         if(q_u->max_entries > MAX_SAM_ENTRIES)
+           q_u->max_entries = MAX_SAM_ENTRIES;
+         
+         retsize = (q_u->max_entries * (sizeof(SAM_ENTRY1)+sizeof(SAM_STR1)))
+           + 3*sizeof(uint32);
+
+         if(retsize > q_u->max_size)
+           {
+             /* determine max_entries based on max_size */
+             q_u->max_entries = (q_u->max_size - 3*sizeof(uint32)) /
+               (sizeof(SAM_ENTRY1)+sizeof(SAM_STR1));
+             q_u->max_entries = (q_u->max_entries>0?q_u->max_entries:1);
+           }
+
+         DEBUG(10,("samr_reply_query_dispinfo: Setting q_u->max_entries to %u\n",q_u->max_entries));
+
+               become_root();
+               got_pwds = get_passwd_entries(pass, q_u->start_idx, &total_entries, &num_entries, q_u->max_entries, 0);
+               unbecome_root();
+
+               /* more left - set resume handle */
+               if(total_entries > num_entries)
+                 {
+                   r_e.status = 0x105;
+                 }
 
                switch (q_u->switch_level)
                {
@@ -559,8 +892,9 @@ static void samr_reply_query_dispinfo(SAMR_Q_QUERY_DISPINFO *q_u,
                        {
                        
                                /* query disp info is for users */
+                               ZERO_STRUCT (info1);
                                switch_level = 0x1;
-                               make_sam_info_1(&info1, ACB_NORMAL,
+                               init_sam_info_1(&info1, ACB_NORMAL,
                                        q_u->start_idx, num_entries, pass);
 
                                ctr.sam.info1 = &info1;
@@ -570,8 +904,9 @@ static void samr_reply_query_dispinfo(SAMR_Q_QUERY_DISPINFO *q_u,
                        case 0x2:
                        {
                                /* query disp info is for servers */
+                               ZERO_STRUCT (info2);
                                switch_level = 0x2;
-                               make_sam_info_2(&info2, ACB_WSTRUST,
+                               init_sam_info_2(&info2, ACB_WSTRUST,
                                        q_u->start_idx, num_entries, pass);
 
                                ctr.sam.info2 = &info2;
@@ -581,90 +916,114 @@ static void samr_reply_query_dispinfo(SAMR_Q_QUERY_DISPINFO *q_u,
                }
        }
 
-       if (r_e.status == 0 && got_pwds)
+       /* more left - set resume handle */
+       if(total_entries > num_entries)
+         {
+           r_e.status = 0x105;
+         }
+
+       if (r_e.status == 0 || r_e.status == 0x105)
        {
-               make_samr_r_query_dispinfo(&r_e, switch_level, &ctr, r_e.status);
+         init_samr_r_query_dispinfo(&r_e, switch_level, &ctr, r_e.status);
        }
 
        /* store the response in the SMB stream */
-       samr_io_r_query_dispinfo("", &r_e, rdata, 0);
+       if(!samr_io_r_query_dispinfo("", &r_e, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_query_dispinfo: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_query_dispinfo
  ********************************************************************/
-static void api_samr_query_dispinfo( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_query_dispinfo(pipes_struct *p)
 {
        SAMR_Q_QUERY_DISPINFO q_e;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open */
-       samr_io_q_query_dispinfo("", &q_e, data, 0);
+       if(!samr_io_q_query_dispinfo("", &q_e, data, 0))
+               return False;
 
        /* construct reply. */
-       samr_reply_query_dispinfo(&q_e, rdata);
+       if(!samr_reply_query_dispinfo(&q_e, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_query_aliasinfo
  ********************************************************************/
-static void samr_reply_query_aliasinfo(SAMR_Q_QUERY_ALIASINFO *q_u,
+static BOOL samr_reply_query_aliasinfo(SAMR_Q_QUERY_ALIASINFO *q_u,
                                prs_struct *rdata)
 {
-       SAMR_R_QUERY_ALIASINFO r_e;
-
-       r_e.status = 0x0;
-       r_e.ptr = 0;
-
-       /* find the policy handle.  open a policy on it. */
-       if (r_e.status == 0x0 && (find_lsa_policy_by_hnd(&(q_u->pol)) == -1))
-       {
-               r_e.status = 0xC0000000 | NT_STATUS_INVALID_HANDLE;
-       }
-
-       DEBUG(5,("samr_reply_query_aliasinfo: %d\n", __LINE__));
-
-       if (r_e.status == 0x0)
-       {
-               if (q_u->switch_level != 3)
-               {
-                       r_e.status = NT_STATUS_INVALID_INFO_CLASS;
-               }
-       }
-
-       make_samr_r_query_aliasinfo(&r_e, q_u->switch_level,
-                           "<account description>",
-                               r_e.status);
-
-       /* store the response in the SMB stream */
-       samr_io_r_query_aliasinfo("", &r_e, rdata, 0);
-
-       DEBUG(5,("samr_query_aliasinfo: %d\n", __LINE__));
+  SAMR_R_QUERY_ALIASINFO r_e;
+  fstring alias_desc = "Local Unix group";
+  fstring alias="";
+  enum SID_NAME_USE type;
+  uint32 alias_rid;
+
+  ZERO_STRUCT(r_e);
+
+  DEBUG(5,("samr_reply_query_aliasinfo: %d\n", __LINE__));
+
+  /* find the policy handle.  open a policy on it. */
+  if (r_e.status == 0x0 && (find_lsa_policy_by_hnd(&(q_u->pol)) == -1))
+    {
+      r_e.status = 0xC0000000 | NT_STATUS_INVALID_HANDLE;
+    }
+
+  alias_rid = get_lsa_policy_samr_rid(&q_u->pol);
+  if(alias_rid == 0xffffffff)
+      r_e.status = 0xC0000000 | NT_STATUS_NO_SUCH_ALIAS;
+
+  if(!local_lookup_rid(alias_rid, alias, &type))
+    {
+      r_e.status = 0xC0000000 | NT_STATUS_NO_SUCH_ALIAS;
+    }
+  
+  init_samr_r_query_aliasinfo(&r_e, q_u->switch_level, alias, alias_desc);
+  
+  /* store the response in the SMB stream */
+  if(!samr_io_r_query_aliasinfo("", &r_e, rdata, 0))
+               return False;
+  
+  DEBUG(5,("samr_query_aliasinfo: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_query_aliasinfo
  ********************************************************************/
-static void api_samr_query_aliasinfo( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_query_aliasinfo(pipes_struct *p)
 {
        SAMR_Q_QUERY_ALIASINFO q_e;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open */
-       samr_io_q_query_aliasinfo("", &q_e, data, 0);
+       if(!samr_io_q_query_aliasinfo("", &q_e, data, 0))
+               return False;
 
        /* construct reply. */
-       samr_reply_query_aliasinfo(&q_e, rdata);
+       if(!samr_reply_query_aliasinfo(&q_e, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_lookup_ids
  ********************************************************************/
-static void samr_reply_lookup_ids(SAMR_Q_LOOKUP_IDS *q_u,
+static BOOL samr_reply_lookup_ids(SAMR_Q_LOOKUP_IDS *q_u,
                                prs_struct *rdata)
 {
        uint32 rid[MAX_SAM_ENTRIES];
@@ -695,9 +1054,9 @@ static void samr_reply_lookup_ids(SAMR_Q_LOOKUP_IDS *q_u,
                                            q_u->uni_user_name[i].uni_str_len));
 
                /* find the user account */
-               become_root(True);
+               become_root();
                sam_pass = get_smb21pwd_entry(user_name, 0);
-               unbecome_root(True);
+               unbecome_root();
 
                if (sam_pass == NULL)
                {
@@ -714,92 +1073,141 @@ static void samr_reply_lookup_ids(SAMR_Q_LOOKUP_IDS *q_u,
        num_rids = 1;
        rid[0] = BUILTIN_ALIAS_RID_USERS;
 
-       make_samr_r_lookup_ids(&r_u, num_rids, rid, status);
+       init_samr_r_lookup_ids(&r_u, num_rids, rid, status);
 
        /* store the response in the SMB stream */
-       samr_io_r_lookup_ids("", &r_u, rdata, 0);
+       if(!samr_io_r_lookup_ids("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_lookup_ids: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_lookup_ids
  ********************************************************************/
-static void api_samr_lookup_ids( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_lookup_ids(pipes_struct *p)
 {
        SAMR_Q_LOOKUP_IDS q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr 0x10 */
-       samr_io_q_lookup_ids("", &q_u, data, 0);
+       if(!samr_io_q_lookup_ids("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_lookup_ids(&q_u, rdata);
+       if(!samr_reply_lookup_ids(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 /*******************************************************************
  samr_reply_lookup_names
  ********************************************************************/
-static void samr_reply_lookup_names(SAMR_Q_LOOKUP_NAMES *q_u,
-                               prs_struct *rdata)
+
+static BOOL samr_reply_lookup_names(SAMR_Q_LOOKUP_NAMES *q_u,
+                                   prs_struct *rdata)
 {
-       uint32 rid[MAX_SAM_ENTRIES];
-       uint32 status     = 0;
-       int i;
-       int num_rids = q_u->num_rids1;
+  uint32 rid[MAX_SAM_ENTRIES];
+  enum SID_NAME_USE type[MAX_SAM_ENTRIES];
+  uint32 status = 0;
+  int i;
+  int num_rids = q_u->num_names1;
+  DOM_SID pol_sid;
 
-       SAMR_R_LOOKUP_NAMES r_u;
+  SAMR_R_LOOKUP_NAMES r_u;
 
-       DEBUG(5,("samr_lookup_names: %d\n", __LINE__));
+  DEBUG(5,("samr_lookup_names: %d\n", __LINE__));
 
-       if (num_rids > MAX_SAM_ENTRIES)
-       {
-               num_rids = MAX_SAM_ENTRIES;
-               DEBUG(5,("samr_lookup_names: truncating entries to %d\n", num_rids));
-       }
+  ZERO_ARRAY(rid);
+  ZERO_ARRAY(type);
 
-       SMB_ASSERT_ARRAY(q_u->uni_user_name, num_rids);
+  if (!get_lsa_policy_samr_sid(&q_u->pol, &pol_sid)) {
+    status = 0xC0000000 | NT_STATUS_OBJECT_TYPE_MISMATCH;
+    init_samr_r_lookup_names(&r_u, 0, rid, type, status);
+    if(!samr_io_r_lookup_names("", &r_u, rdata, 0)) {
+      DEBUG(0,("samr_reply_lookup_names: failed to marshall SAMR_R_LOOKUP_NAMES.\n"));
+      return False;
+    }
+    return True;
+  }
 
-       for (i = 0; i < num_rids && status == 0; i++)
-       {
-               fstring name;
+  if (num_rids > MAX_SAM_ENTRIES) {
+    num_rids = MAX_SAM_ENTRIES;
+    DEBUG(5,("samr_lookup_names: truncating entries to %d\n", num_rids));
+  }
+
+  SMB_ASSERT_ARRAY(q_u->uni_name, num_rids);
+
+  for (i = 0; i < num_rids; i++) {
+    fstring name;
 
-               status = 0xC0000000 | NT_STATUS_NONE_MAPPED;
+    status = 0xC0000000 | NT_STATUS_NONE_MAPPED;
 
-               fstrcpy(name, unistrn2(q_u->uni_user_name[i].buffer, q_u->uni_user_name[i].uni_str_len));
+    rid [i] = 0xffffffff;
+    type[i] = SID_NAME_UNKNOWN;
 
-               status = (status != 0x0) ? lookup_user_rid (name, &(rid[i])) : status;
-               status = (status != 0x0) ? lookup_group_rid(name, &(rid[i])) : status;
-               status = (status != 0x0) ? lookup_alias_rid(name, &(rid[i])) : status;
+    fstrcpy(name, dos_unistrn2(q_u->uni_name[i].buffer,
+                              q_u->uni_name[i].uni_str_len));
+
+    if(sid_equal(&pol_sid, &global_sam_sid)) 
+    {
+      DOM_SID sid;
+      if(local_lookup_name(global_myname, name, 
+                          &sid, &type[i]))
+       {
+         sid_split_rid( &sid, &rid[i]);
+         status = 0;
        }
+    }
+  }
 
-       make_samr_r_lookup_names(&r_u, num_rids, rid, status);
+  init_samr_r_lookup_names(&r_u, num_rids, rid, type, status);
 
-       /* store the response in the SMB stream */
-       samr_io_r_lookup_names("", &r_u, rdata, 0);
+  /* store the response in the SMB stream */
+  if(!samr_io_r_lookup_names("", &r_u, rdata, 0)) {
+    DEBUG(0,("samr_reply_lookup_names: failed to marshall SAMR_R_LOOKUP_NAMES.\n"));
+    return False;
+  }
 
-       DEBUG(5,("samr_lookup_names: %d\n", __LINE__));
+  DEBUG(5,("samr_lookup_names: %d\n", __LINE__));
 
+  return True;
 }
 
 /*******************************************************************
  api_samr_lookup_names
  ********************************************************************/
-static void api_samr_lookup_names( uint16 vuid, prs_struct *data, prs_struct *rdata)
+
+static BOOL api_samr_lookup_names(pipes_struct *p)
 {
        SAMR_Q_LOOKUP_NAMES q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
+
+       memset(&q_u, '\0', sizeof(q_u));
 
        /* grab the samr lookup names */
-       samr_io_q_lookup_names("", &q_u, data, 0);
+       if(!samr_io_q_lookup_names("", &q_u, data, 0)) {
+               DEBUG(0,("api_samr_lookup_names: failed to unmarshall SAMR_Q_LOOKUP_NAMES.\n"));
+               return False;
+       }
 
        /* construct reply.  always indicate success */
-       samr_reply_lookup_names(&q_u, rdata);
+       if(!samr_reply_lookup_names(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 /*******************************************************************
  samr_reply_chgpasswd_user
  ********************************************************************/
-static void samr_reply_chgpasswd_user(SAMR_Q_CHGPASSWD_USER *q_u,
+
+static BOOL samr_reply_chgpasswd_user(SAMR_Q_CHGPASSWD_USER *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_CHGPASSWD_USER r_u;
@@ -807,8 +1215,8 @@ static void samr_reply_chgpasswd_user(SAMR_Q_CHGPASSWD_USER *q_u,
        fstring user_name;
        fstring wks;
 
-       fstrcpy(user_name, unistrn2(q_u->uni_user_name.buffer, q_u->uni_user_name.uni_str_len));
-       fstrcpy(wks      , unistrn2(q_u->uni_dest_host.buffer, q_u->uni_dest_host.uni_str_len));
+       fstrcpy(user_name, dos_unistrn2(q_u->uni_user_name.buffer, q_u->uni_user_name.uni_str_len));
+       fstrcpy(wks      , dos_unistrn2(q_u->uni_dest_host.buffer, q_u->uni_dest_host.uni_str_len));
 
        DEBUG(5,("samr_chgpasswd_user: user: %s wks: %s\n", user_name, wks));
 
@@ -819,66 +1227,88 @@ static void samr_reply_chgpasswd_user(SAMR_Q_CHGPASSWD_USER *q_u,
                status = 0xC0000000 | NT_STATUS_WRONG_PASSWORD;
        }
 
-       make_samr_r_chgpasswd_user(&r_u, status);
+       init_samr_r_chgpasswd_user(&r_u, status);
 
        /* store the response in the SMB stream */
-       samr_io_r_chgpasswd_user("", &r_u, rdata, 0);
+       if(!samr_io_r_chgpasswd_user("", &r_u, rdata, 0)) {
+               DEBUG(0,("samr_reply_chgpasswd_user: Failed to marshall SAMR_R_CHGPASSWD_USER struct.\n" ));
+               return False;
+       }
 
        DEBUG(5,("samr_chgpasswd_user: %d\n", __LINE__));
+       return True;
 }
 
 /*******************************************************************
  api_samr_chgpasswd_user
  ********************************************************************/
-static void api_samr_chgpasswd_user( uint16 vuid, prs_struct *data, prs_struct *rdata)
+
+static BOOL api_samr_chgpasswd_user(pipes_struct *p)
 {
        SAMR_Q_CHGPASSWD_USER q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* unknown 38 command */
-       samr_io_q_chgpasswd_user("", &q_u, data, 0);
+       if (!samr_io_q_chgpasswd_user("", &q_u, data, 0)) {
+               DEBUG(0,("api_samr_chgpasswd_user: samr_io_q_chgpasswd_user failed to parse RPC packet.\n"));
+               return False;
+       }
 
        /* construct reply. */
-       samr_reply_chgpasswd_user(&q_u, rdata);
+       if(!samr_reply_chgpasswd_user(&q_u, rdata)) {
+               DEBUG(0,("api_samr_chgpasswd_user: samr_reply_chgpasswd_user failed to create reply packet.\n"));
+               return False;
+       }
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_unknown_38
  ********************************************************************/
-static void samr_reply_unknown_38(SAMR_Q_UNKNOWN_38 *q_u,
-                               prs_struct *rdata)
+static BOOL samr_reply_unknown_38(SAMR_Q_UNKNOWN_38 *q_u, prs_struct *rdata)
 {
        SAMR_R_UNKNOWN_38 r_u;
 
        DEBUG(5,("samr_unknown_38: %d\n", __LINE__));
 
-       make_samr_r_unknown_38(&r_u);
+       init_samr_r_unknown_38(&r_u);
 
        /* store the response in the SMB stream */
-       samr_io_r_unknown_38("", &r_u, rdata, 0);
+       if(!samr_io_r_unknown_38("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_unknown_38: %d\n", __LINE__));
+       return True;
 }
 
 /*******************************************************************
  api_samr_unknown_38
  ********************************************************************/
-static void api_samr_unknown_38( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_unknown_38(pipes_struct *p)
 {
        SAMR_Q_UNKNOWN_38 q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* unknown 38 command */
-       samr_io_q_unknown_38("", &q_u, data, 0);
+       if(!samr_io_q_unknown_38("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_unknown_38(&q_u, rdata);
+       if(!samr_reply_unknown_38(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_unknown_12
  ********************************************************************/
-static void samr_reply_unknown_12(SAMR_Q_UNKNOWN_12 *q_u,
+static BOOL samr_reply_unknown_12(SAMR_Q_UNKNOWN_12 *q_u,
                                prs_struct *rdata)
 {
        fstring group_names[MAX_SAM_ENTRIES];
@@ -912,43 +1342,49 @@ static void samr_reply_unknown_12(SAMR_Q_UNKNOWN_12 *q_u,
                }
        }
 
-       make_samr_r_unknown_12(&r_u, num_gids, group_names, group_attrs, status);
+       init_samr_r_unknown_12(&r_u, num_gids, group_names, group_attrs, status);
 
        /* store the response in the SMB stream */
-       samr_io_r_unknown_12("", &r_u, rdata, 0);
+       if(!samr_io_r_unknown_12("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_unknown_12: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_unknown_12
  ********************************************************************/
-static void api_samr_unknown_12( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_unknown_12(pipes_struct *p)
 {
        SAMR_Q_UNKNOWN_12 q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr lookup names */
-       samr_io_q_unknown_12("", &q_u, data, 0);
+       if(!samr_io_q_unknown_12("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_unknown_12(&q_u, rdata);
+       if(!samr_reply_unknown_12(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_open_user
  ********************************************************************/
-static void samr_reply_open_user(SAMR_Q_OPEN_USER *q_u,
-                               prs_struct *rdata,
-                               int status)
+static BOOL samr_reply_open_user(SAMR_Q_OPEN_USER *q_u, prs_struct *rdata, int status)
 {
        SAMR_R_OPEN_USER r_u;
        struct sam_passwd *sam_pass;
        BOOL pol_open = False;
 
        /* set up the SAMR open_user response */
-       bzero(r_u.user_pol.data, POL_HND_SIZE);
+       memset((char *)r_u.user_pol.data, '\0', POL_HND_SIZE);
 
        r_u.status = 0x0;
 
@@ -964,9 +1400,9 @@ static void samr_reply_open_user(SAMR_Q_OPEN_USER *q_u,
                r_u.status = 0xC0000000 | NT_STATUS_OBJECT_NAME_NOT_FOUND;
        }
 
-       become_root(True);
+       become_root();
        sam_pass = getsam21pwrid(q_u->user_rid);
-       unbecome_root(True);
+       unbecome_root();
 
        /* check that the RID exists in our domain. */
        if (r_u.status == 0x0 && sam_pass == NULL)
@@ -989,24 +1425,32 @@ static void samr_reply_open_user(SAMR_Q_OPEN_USER *q_u,
        DEBUG(5,("samr_open_user: %d\n", __LINE__));
 
        /* store the response in the SMB stream */
-       samr_io_r_open_user("", &r_u, rdata, 0);
+       if(!samr_io_r_open_user("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_open_user: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_open_user
  ********************************************************************/
-static void api_samr_open_user( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_open_user(pipes_struct *p)
 {
        SAMR_Q_OPEN_USER q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr unknown 22 */
-       samr_io_q_open_user("", &q_u, data, 0);
+       if(!samr_io_q_open_user("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_open_user(&q_u, rdata, 0x0);
+       if(!samr_reply_open_user(&q_u, rdata, 0x0))
+               return False;
+
+       return True;
 }
 
 
@@ -1023,9 +1467,9 @@ static BOOL get_user_info_10(SAM_USER_INFO_10 *id10, uint32 user_rid)
                return False;
        }
 
-       become_root(True);
+       become_root();
        smb_pass = getsmbpwrid(user_rid);
-       unbecome_root(True);
+       unbecome_root();
 
        if (smb_pass == NULL)
        {
@@ -1035,7 +1479,7 @@ static BOOL get_user_info_10(SAM_USER_INFO_10 *id10, uint32 user_rid)
 
        DEBUG(3,("User:[%s]\n", smb_pass->smb_name));
 
-       make_sam_user_info10(id10, smb_pass->acct_ctrl); 
+       init_sam_user_info10(id10, smb_pass->acct_ctrl); 
 
        return True;
 }
@@ -1056,9 +1500,9 @@ static BOOL get_user_info_21(SAM_USER_INFO_21 *id21, uint32 user_rid)
                return False;
        }
 
-       become_root(True);
+       become_root();
        sam_pass = getsam21pwrid(user_rid);
-       unbecome_root(True);
+       unbecome_root();
 
        if (sam_pass == NULL)
        {
@@ -1071,7 +1515,7 @@ static BOOL get_user_info_21(SAM_USER_INFO_21 *id21, uint32 user_rid)
        dummy_time.low  = 0xffffffff;
        dummy_time.high = 0x7fffffff;
 
-       DEBUG(0,("get_user_info_21 - TODO: convert unix times to NTTIMEs\n"));
+       DEBUG(5,("get_user_info_21 - TODO: convert unix times to NTTIMEs\n"));
 
        /* create a LOGON_HRS structure */
        hrs.len = sam_pass->hours_len;
@@ -1081,7 +1525,7 @@ static BOOL get_user_info_21(SAM_USER_INFO_21 *id21, uint32 user_rid)
                hrs.hours[i] = sam_pass->hours[i];
        }
 
-       make_sam_user_info21(id21,
+       init_sam_user_info21(id21,
 
                           &dummy_time, /* logon_time */
                           &dummy_time, /* logoff_time */
@@ -1117,7 +1561,7 @@ static BOOL get_user_info_21(SAM_USER_INFO_21 *id21, uint32 user_rid)
 /*******************************************************************
  samr_reply_query_userinfo
  ********************************************************************/
-static void samr_reply_query_userinfo(SAMR_Q_QUERY_USERINFO *q_u,
+static BOOL samr_reply_query_userinfo(SAMR_Q_QUERY_USERINFO *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_QUERY_USERINFO r_u;
@@ -1189,34 +1633,42 @@ static void samr_reply_query_userinfo(SAMR_Q_QUERY_USERINFO *q_u,
                }
        }
 
-       make_samr_r_query_userinfo(&r_u, q_u->switch_value, info, status);
+       init_samr_r_query_userinfo(&r_u, q_u->switch_value, info, status);
 
        /* store the response in the SMB stream */
-       samr_io_r_query_userinfo("", &r_u, rdata, 0);
+       if(!samr_io_r_query_userinfo("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_reply_query_userinfo: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_query_userinfo
  ********************************************************************/
-static void api_samr_query_userinfo( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_query_userinfo(pipes_struct *p)
 {
        SAMR_Q_QUERY_USERINFO q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr unknown 24 */
-       samr_io_q_query_userinfo("", &q_u, data, 0);
+       if(!samr_io_q_query_userinfo("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_query_userinfo(&q_u, rdata);
+       if(!samr_reply_query_userinfo(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_query_usergroups
  ********************************************************************/
-static void samr_reply_query_usergroups(SAMR_Q_QUERY_USERGROUPS *q_u,
+static BOOL samr_reply_query_usergroups(SAMR_Q_QUERY_USERGROUPS *q_u,
                                prs_struct *rdata)
 {
        SAMR_R_QUERY_USERGROUPS r_u;
@@ -1243,9 +1695,9 @@ static void samr_reply_query_usergroups(SAMR_Q_QUERY_USERGROUPS *q_u,
 
        if (status == 0x0)
        {
-               become_root(True);
+               become_root();
                sam_pass = getsam21pwrid(rid);
-               unbecome_root(True);
+               unbecome_root();
 
                if (sam_pass == NULL)
                {
@@ -1262,39 +1714,48 @@ static void samr_reply_query_usergroups(SAMR_Q_QUERY_USERGROUPS *q_u,
        }
 
        /* construct the response.  lkclXXXX: gids are not copied! */
-       make_samr_r_query_usergroups(&r_u, num_groups, gids, status);
+       init_samr_r_query_usergroups(&r_u, num_groups, gids, status);
 
        /* store the response in the SMB stream */
-       samr_io_r_query_usergroups("", &r_u, rdata, 0);
+       if(!samr_io_r_query_usergroups("", &r_u, rdata, 0)) {
+               if (gids)
+                       free((char *)gids);
+               return False;
+       }
 
        if (gids)
-       {
                free((char *)gids);
-       }
 
        DEBUG(5,("samr_query_usergroups: %d\n", __LINE__));
-
+       
+       return True;
 }
 
 /*******************************************************************
  api_samr_query_usergroups
  ********************************************************************/
-static void api_samr_query_usergroups( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_query_usergroups(pipes_struct *p)
 {
        SAMR_Q_QUERY_USERGROUPS q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
+
        /* grab the samr unknown 32 */
-       samr_io_q_query_usergroups("", &q_u, data, 0);
+       if(!samr_io_q_query_usergroups("", &q_u, data, 0))
+               return False;
 
        /* construct reply. */
-       samr_reply_query_usergroups(&q_u, rdata);
+       if(!samr_reply_query_usergroups(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_query_dom_info
  ********************************************************************/
-static void samr_reply_query_dom_info(SAMR_Q_QUERY_DOMAIN_INFO *q_u,
-                               prs_struct *rdata)
+static BOOL samr_reply_query_dom_info(SAMR_Q_QUERY_DOMAIN_INFO *q_u, prs_struct *rdata)
 {
        SAMR_R_QUERY_DOMAIN_INFO r_u;
        SAM_UNK_CTR ctr;
@@ -1322,7 +1783,7 @@ static void samr_reply_query_dom_info(SAMR_Q_QUERY_DOMAIN_INFO *q_u,
                        case 0x02:
                        {
                                switch_value = 0x2;
-                               make_unk_info2(&ctr.info.inf2, global_myworkgroup, global_myname);
+                               init_unk_info2(&ctr.info.inf2, global_myworkgroup, global_myname);
 
                                break;
                        }
@@ -1334,76 +1795,71 @@ static void samr_reply_query_dom_info(SAMR_Q_QUERY_DOMAIN_INFO *q_u,
                }
        }
 
-       make_samr_r_query_dom_info(&r_u, switch_value, &ctr, status);
+       init_samr_r_query_dom_info(&r_u, switch_value, &ctr, status);
 
        /* store the response in the SMB stream */
-       samr_io_r_query_dom_info("", &r_u, rdata, 0);
+       if(!samr_io_r_query_dom_info("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_query_dom_info: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_query_dom_info
  ********************************************************************/
-static void api_samr_query_dom_info( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_query_dom_info(pipes_struct *p)
 {
        SAMR_Q_QUERY_DOMAIN_INFO q_e;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr unknown 8 command */
-       samr_io_q_query_dom_info("", &q_e, data, 0);
+       if(!samr_io_q_query_dom_info("", &q_e, data, 0))
+               return False;
 
        /* construct reply. */
-       samr_reply_query_dom_info(&q_e, rdata);
-}
+       if(!samr_reply_query_dom_info(&q_e, rdata))
+               return False;
 
+       return True;
+}
 
 
 /*******************************************************************
- samr_reply_unknown_32
+ api_samr_create_user
  ********************************************************************/
-static void samr_reply_unknown_32(SAMR_Q_UNKNOWN_32 *q_u,
-                               prs_struct *rdata,
-                               int status)
+static BOOL api_samr_create_user(pipes_struct *p)
 {
-       int i;
-       SAMR_R_UNKNOWN_32 r_u;
-
-       /* set up the SAMR unknown_32 response */
-       bzero(r_u.pol.data, POL_HND_SIZE);
-       if (status == 0)
-       {
-               for (i = 4; i < POL_HND_SIZE; i++)
-               {
-                       r_u.pol.data[i] = i+1;
-               }
-       }
-
-       make_dom_rid4(&(r_u.rid4), 0x0030, 0, 0);
-       r_u.status    = status;
-
-       DEBUG(5,("samr_unknown_32: %d\n", __LINE__));
-
-       /* store the response in the SMB stream */
-       samr_io_r_unknown_32("", &r_u, rdata, 0);
+       struct sam_passwd *sam_pass;
+       fstring mach_acct;
+       pstring err_str;
+       pstring msg_str;
+       int local_flags=0;
+       
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
-       DEBUG(5,("samr_unknown_32: %d\n", __LINE__));
+       SAMR_Q_CREATE_USER q_u;
+       SAMR_R_CREATE_USER r_u;
 
-}
+       ZERO_STRUCT(q_u);
+       ZERO_STRUCT(r_u);
 
-/*******************************************************************
- api_samr_unknown_32
- ********************************************************************/
-static void api_samr_unknown_32( uint16 vuid, prs_struct *data, prs_struct *rdata)
-{
-       uint32 status = 0;
-       struct sam_passwd *sam_pass;
-       fstring mach_acct;
+       DEBUG(5,("api_samr_create_user: %d\n", __LINE__));
 
-       SAMR_Q_UNKNOWN_32 q_u;
+       /* grab the samr create user */
+       if (!samr_io_q_create_user("", &q_u, data, 0)) {
+               DEBUG(0,("api_samr_create_user: Unable to unmarshall SAMR_Q_CREATE_USER.\n"));
+               return False;
+       }
 
-       /* grab the samr unknown 32 */
-       samr_io_q_unknown_32("", &q_u, data, 0);
+       /* find the policy handle.  open a policy on it. */
+       if ((find_lsa_policy_by_hnd(&q_u.pol) == -1)) {
+               r_u.status = NT_STATUS_INVALID_HANDLE;
+               goto out;
+       }
 
        /* find the machine account: tell the caller if it exists.
           lkclXXXX i have *no* idea if this is a problem or not
@@ -1411,35 +1867,80 @@ static void api_samr_unknown_32( uint16 vuid, prs_struct *data, prs_struct *rdat
           reply if the account already exists...
         */
 
-       fstrcpy(mach_acct, unistrn2(q_u.uni_mach_acct.buffer,
-                                   q_u.uni_mach_acct.uni_str_len));
+       fstrcpy(mach_acct, dos_unistrn2(q_u.uni_mach_acct.buffer, q_u.uni_mach_acct.uni_str_len));
+       strlower(mach_acct);
 
-       become_root(True);
+       become_root();
        sam_pass = getsam21pwnam(mach_acct);
-       unbecome_root(True);
-
-       if (sam_pass != NULL)
-       {
+       unbecome_root();
+       if (sam_pass != NULL) {
                /* machine account exists: say so */
-               status = 0xC0000000 | NT_STATUS_USER_EXISTS;
+               r_u.status = NT_STATUS_USER_EXISTS;
+               goto out;
        }
-       else
-       {
-               /* this could cause trouble... */
-               DEBUG(0,("trouble!\n"));
-               status = 0;
+
+       /* get a (unique) handle.  open a policy on it. */
+       if (!open_lsa_policy_hnd(&r_u.pol)) {
+               r_u.status = NT_STATUS_OBJECT_NAME_NOT_FOUND;
+               goto out;
        }
 
-       /* construct reply. */
-       samr_reply_unknown_32(&q_u, rdata, status);
+       local_flags=LOCAL_ADD_USER|LOCAL_DISABLE_USER|LOCAL_SET_NO_PASSWORD;
+       local_flags|= (q_u.acb_info & ACB_WSTRUST) ? LOCAL_TRUST_ACCOUNT:0;
+
+       /*
+        * NB. VERY IMPORTANT ! This call must be done as the current pipe user,
+        * *NOT* surrounded by a become_root()/unbecome_root() call. This ensures
+        * that only people with write access to the smbpasswd file will be able
+        * to create a user. JRA.
+        */
+
+       if (!local_password_change(mach_acct, local_flags, NULL, err_str, sizeof(err_str), msg_str, sizeof(msg_str))) {
+               DEBUG(0, ("%s\n", err_str));
+               r_u.status = NT_STATUS_ACCESS_DENIED;
+               close_lsa_policy_hnd(&r_u.pol);
+               memset((char *)r_u.pol.data, '\0', POL_HND_SIZE);
+               goto out;
+       }
+
+       become_root();
+       sam_pass = getsam21pwnam(mach_acct);
+       unbecome_root();
+       if (sam_pass == NULL) {
+               /* account doesn't exist: say so */
+               r_u.status = NT_STATUS_ACCESS_DENIED;
+               close_lsa_policy_hnd(&r_u.pol);
+               memset((char *)r_u.pol.data, '\0', POL_HND_SIZE);
+               goto out;
+       }
+
+       /* associate the RID with the (unique) handle. */
+       if (!set_lsa_policy_samr_rid(&r_u.pol, sam_pass->user_rid)) {
+               /* oh, whoops.  don't know what error message to return, here */
+               r_u.status = NT_STATUS_OBJECT_NAME_NOT_FOUND;
+               close_lsa_policy_hnd(&r_u.pol);
+               memset((char *)r_u.pol.data, '\0', POL_HND_SIZE);
+               goto out;
+       }
+
+       r_u.unknown_0=0x000703ff;
+       r_u.user_rid=sam_pass->user_rid;
+
+ out:  
+       /* store the response in the SMB stream */
+       if(!samr_io_r_create_user("", &r_u, rdata, 0))
+               return False;
+
+       DEBUG(5,("api_samr_create_user: %d\n", __LINE__));
+
+       return True;
 }
 
 
 /*******************************************************************
  samr_reply_connect_anon
  ********************************************************************/
-static void samr_reply_connect_anon(SAMR_Q_CONNECT_ANON *q_u,
-                               prs_struct *rdata)
+static BOOL samr_reply_connect_anon(SAMR_Q_CONNECT_ANON *q_u, prs_struct *rdata)
 {
        SAMR_R_CONNECT_ANON r_u;
        BOOL pol_open = False;
@@ -1468,31 +1969,38 @@ static void samr_reply_connect_anon(SAMR_Q_CONNECT_ANON *q_u,
        DEBUG(5,("samr_connect_anon: %d\n", __LINE__));
 
        /* store the response in the SMB stream */
-       samr_io_r_connect_anon("", &r_u, rdata, 0);
+       if(!samr_io_r_connect_anon("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_connect_anon: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_connect_anon
  ********************************************************************/
-static void api_samr_connect_anon( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_connect_anon(pipes_struct *p)
 {
        SAMR_Q_CONNECT_ANON q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open policy */
-       samr_io_q_connect_anon("", &q_u, data, 0);
+       if(!samr_io_q_connect_anon("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_connect_anon(&q_u, rdata);
+       if(!samr_reply_connect_anon(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 /*******************************************************************
  samr_reply_connect
  ********************************************************************/
-static void samr_reply_connect(SAMR_Q_CONNECT *q_u,
-                               prs_struct *rdata)
+static BOOL samr_reply_connect(SAMR_Q_CONNECT *q_u, prs_struct *rdata)
 {
        SAMR_R_CONNECT r_u;
        BOOL pol_open = False;
@@ -1521,31 +2029,127 @@ static void samr_reply_connect(SAMR_Q_CONNECT *q_u,
        DEBUG(5,("samr_connect: %d\n", __LINE__));
 
        /* store the response in the SMB stream */
-       samr_io_r_connect("", &r_u, rdata, 0);
+       if(!samr_io_r_connect("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_connect: %d\n", __LINE__));
 
+       return True;
 }
 
 /*******************************************************************
  api_samr_connect
  ********************************************************************/
-static void api_samr_connect( uint16 vuid, prs_struct *data, prs_struct *rdata)
+static BOOL api_samr_connect(pipes_struct *p)
 {
        SAMR_Q_CONNECT q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open policy */
-       samr_io_q_connect("", &q_u, data, 0);
+       if(!samr_io_q_connect("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_connect(&q_u, rdata);
+       if(!samr_reply_connect(&q_u, rdata))
+               return False;
+
+       return True;
+}
+
+/**********************************************************************
+ api_reply_lookup_domain
+ **********************************************************************/
+static BOOL samr_reply_lookup_domain(SAMR_Q_LOOKUP_DOMAIN* q_u, prs_struct* rdata)
+{
+  SAMR_R_LOOKUP_DOMAIN r_u;
+  
+  r_u.status = 0x0;
+  if (r_u.status == 0x0 && (find_lsa_policy_by_hnd(&(q_u->connect_pol)) == -1))
+       {
+               r_u.status = 0xC0000000 | NT_STATUS_INVALID_HANDLE;
+               DEBUG(5,("samr_reply_lookup_domain: invalid handle\n"));
+       }
+  
+  /* assume the domain name sent is our global_myname and 
+     send global_sam_sid */
+  init_samr_r_lookup_domain(&r_u, &global_sam_sid, r_u.status);
+  
+       if(!samr_io_r_lookup_domain("", &r_u, rdata, 0))
+               return False;
+
+  DEBUG(5,("samr_reply_lookup_domain: %d\n", __LINE__));
+       return True; 
+}
+  
+/**********************************************************************
+ api_samr_lookup_domain
+ **********************************************************************/
+static BOOL api_samr_lookup_domain(pipes_struct *p)
+{
+       SAMR_Q_LOOKUP_DOMAIN q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
+  
+       if(!samr_io_q_lookup_domain("", &q_u, data, 0))
+               return False;
+       
+       if(!samr_reply_lookup_domain(&q_u, rdata))
+               return False;
+       
+       return True;
+}
+
+/**********************************************************************
+ samr_reply_enum_domains
+ **********************************************************************/
+static BOOL samr_reply_enum_domains(SAMR_Q_ENUM_DOMAINS* q_u, prs_struct* rdata)
+{
+  SAMR_R_ENUM_DOMAINS r_u;
+  fstring dom[2];
+  
+  ZERO_STRUCT(r_u);
+
+  fstrcpy(dom[0],global_myname);
+  fstrcpy(dom[1],"Builtin");
+  r_u.status = 0;
+   
+  init_samr_r_enum_domains(&r_u, q_u->start_idx, dom, 2); 
+  if(!samr_io_r_enum_domains("", &r_u, rdata, 0)) {
+               free(r_u.sam);
+               free(r_u.uni_dom_name);
+               return False;
+       }
+
+  free(r_u.sam);
+  free(r_u.uni_dom_name);
+
+       return True;
+}
+
+/**********************************************************************
+ api_samr_enum_domains
+ **********************************************************************/
+static BOOL api_samr_enum_domains(pipes_struct *p)
+{
+       SAMR_Q_ENUM_DOMAINS q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
+
+       if(!samr_io_q_enum_domains("", &q_u, data, 0))
+               return False;
+       
+       if(!samr_reply_enum_domains(&q_u, rdata))
+               return False;
+       
+       return True;
 }
 
 /*******************************************************************
  samr_reply_open_alias
  ********************************************************************/
-static void samr_reply_open_alias(SAMR_Q_OPEN_ALIAS *q_u,
-                               prs_struct *rdata)
+static BOOL samr_reply_open_alias(SAMR_Q_OPEN_ALIAS *q_u, prs_struct *rdata)
 {
        SAMR_R_OPEN_ALIAS r_u;
        BOOL pol_open = False;
@@ -1574,25 +2178,32 @@ static void samr_reply_open_alias(SAMR_Q_OPEN_ALIAS *q_u,
        DEBUG(5,("samr_open_alias: %d\n", __LINE__));
 
        /* store the response in the SMB stream */
-       samr_io_r_open_alias("", &r_u, rdata, 0);
+       if(!samr_io_r_open_alias("", &r_u, rdata, 0))
+               return False;
 
        DEBUG(5,("samr_open_alias: %d\n", __LINE__));
-
+       
+       return True;
 }
 
 /*******************************************************************
  api_samr_open_alias
  ********************************************************************/
-static void api_samr_open_alias( uint16 vuid, prs_struct *data, prs_struct *rdata)
-                                
+static BOOL api_samr_open_alias(pipes_struct *p)
 {
        SAMR_Q_OPEN_ALIAS q_u;
+       prs_struct *data = &p->in_data.data;
+       prs_struct *rdata = &p->out_data.rdata;
 
        /* grab the samr open policy */
-       samr_io_q_open_alias("", &q_u, data, 0);
+       if(!samr_io_q_open_alias("", &q_u, data, 0))
+               return False;
 
        /* construct reply.  always indicate success */
-       samr_reply_open_alias(&q_u, rdata);
+       if(!samr_reply_open_alias(&q_u, rdata))
+               return False;
+
+       return True;
 }
 
 /*******************************************************************
@@ -1614,7 +2225,7 @@ static struct api_struct api_samr_cmds [] =
        { "SAMR_QUERY_USERGROUPS" , SAMR_QUERY_USERGROUPS , api_samr_query_usergroups },
        { "SAMR_QUERY_DISPINFO"   , SAMR_QUERY_DISPINFO   , api_samr_query_dispinfo   },
        { "SAMR_QUERY_ALIASINFO"  , SAMR_QUERY_ALIASINFO  , api_samr_query_aliasinfo  },
-       { "SAMR_0x32"             , 0x32                  , api_samr_unknown_32       },
+       { "SAMR_CREATE_USER"      , SAMR_CREATE_USER      , api_samr_create_user      },
        { "SAMR_UNKNOWN_12"       , SAMR_UNKNOWN_12       , api_samr_unknown_12       },
        { "SAMR_UNKNOWN_38"       , SAMR_UNKNOWN_38       , api_samr_unknown_38       },
        { "SAMR_CHGPASSWD_USER"   , SAMR_CHGPASSWD_USER   , api_samr_chgpasswd_user   },
@@ -1622,14 +2233,16 @@ static struct api_struct api_samr_cmds [] =
        { "SAMR_OPEN_DOMAIN"      , SAMR_OPEN_DOMAIN      , api_samr_open_domain      },
        { "SAMR_UNKNOWN_3"        , SAMR_UNKNOWN_3        , api_samr_unknown_3        },
        { "SAMR_UNKNOWN_2C"       , SAMR_UNKNOWN_2C       , api_samr_unknown_2c       },
+       { "SAMR_LOOKUP_DOMAIN"    , SAMR_LOOKUP_DOMAIN    , api_samr_lookup_domain    },
+       { "SAMR_ENUM_DOMAINS"     , SAMR_ENUM_DOMAINS     , api_samr_enum_domains     },
        { NULL                    , 0                     , NULL                      }
 };
 
 /*******************************************************************
  receives a samr pipe and responds.
  ********************************************************************/
-BOOL api_samr_rpc(pipes_struct *p, prs_struct *data)
+BOOL api_samr_rpc(pipes_struct *p)
 {
-    return api_rpcTNP(p, "api_samr_rpc", api_samr_cmds, data);
+       return api_rpcTNP(p, "api_samr_rpc", api_samr_cmds);
 }
-
+#undef OLD_NTDOMAIN