r23630: Found out what LSA_LOOKUP_NAMES level 5 means:
[sfrench/samba-autobuild/.git] / source / passdb / lookup_sid.c
index dbd466fe403e105eadb4688944421f275763d3f8..f6aacd17675353fe207a5be048af1e2fe5655a0b 100644 (file)
@@ -33,7 +33,7 @@
 BOOL lookup_name(TALLOC_CTX *mem_ctx,
                 const char *full_name, int flags,
                 const char **ret_domain, const char **ret_name,
-                DOM_SID *ret_sid, enum SID_NAME_USE *ret_type)
+                DOM_SID *ret_sid, enum lsa_SidType *ret_type)
 {
        char *p;
        const char *tmp;
@@ -41,7 +41,7 @@ BOOL lookup_name(TALLOC_CTX *mem_ctx,
        const char *name = NULL;
        uint32 rid;
        DOM_SID sid;
-       enum SID_NAME_USE type;
+       enum lsa_SidType type;
        TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
 
        if (tmp_ctx == NULL) {
@@ -102,7 +102,7 @@ BOOL lookup_name(TALLOC_CTX *mem_ctx,
                        goto ok;
        }
 
-       if (strequal(domain, unix_users_domain_name())) {
+       if (!(flags & LOOKUP_NAME_EXPLICIT) && strequal(domain, unix_users_domain_name())) {
                if (lookup_unix_user_name(name, &sid)) {
                        type = SID_NAME_USER;
                        goto ok;
@@ -111,7 +111,7 @@ BOOL lookup_name(TALLOC_CTX *mem_ctx,
                return False;
        }
 
-       if (strequal(domain, unix_groups_domain_name())) {
+       if (!(flags & LOOKUP_NAME_EXPLICIT) && strequal(domain, unix_groups_domain_name())) {
                if (lookup_unix_group_name(name, &sid)) {
                        type = SID_NAME_DOM_GRP;
                        goto ok;
@@ -178,8 +178,7 @@ BOOL lookup_name(TALLOC_CTX *mem_ctx,
        /* 5. Trusted domains as such, to me it looks as if members don't do
               this, tested an XP workstation in a NT domain -- vl */
 
-       if (IS_DC && (secrets_fetch_trusted_domain_password(name, NULL,
-                                                           &sid, NULL))) {
+       if (IS_DC && (pdb_get_trusteddom_pw(name, NULL, &sid, NULL))) {
                /* Swap domain and name */
                tmp = name; name = domain; domain = tmp;
                type = SID_NAME_DOMAIN;
@@ -232,7 +231,7 @@ BOOL lookup_name(TALLOC_CTX *mem_ctx,
        if (IS_DC && winbind_lookup_name("", name, &sid, &type)) {
                DOM_SID dom_sid;
                uint32 tmp_rid;
-               enum SID_NAME_USE domain_type;
+               enum lsa_SidType domain_type;
                
                if (type == SID_NAME_DOMAIN) {
                        /* Swap name and type */
@@ -263,13 +262,13 @@ BOOL lookup_name(TALLOC_CTX *mem_ctx,
        /* 11. Ok, windows would end here. Samba has two more options:
                Unmapped users and unmapped groups */
 
-       if (lookup_unix_user_name(name, &sid)) {
+       if (!(flags & LOOKUP_NAME_EXPLICIT) && lookup_unix_user_name(name, &sid)) {
                domain = talloc_strdup(tmp_ctx, unix_users_domain_name());
                type = SID_NAME_USER;
                goto ok;
        }
 
-       if (lookup_unix_group_name(name, &sid)) {
+       if (!(flags & LOOKUP_NAME_EXPLICIT) && lookup_unix_group_name(name, &sid)) {
                domain = talloc_strdup(tmp_ctx, unix_groups_domain_name());
                type = SID_NAME_DOM_GRP;
                goto ok;
@@ -332,7 +331,7 @@ BOOL lookup_name(TALLOC_CTX *mem_ctx,
 BOOL lookup_name_smbconf(TALLOC_CTX *mem_ctx,
                 const char *full_name, int flags,
                 const char **ret_domain, const char **ret_name,
-                DOM_SID *ret_sid, enum SID_NAME_USE *ret_type)
+                DOM_SID *ret_sid, enum lsa_SidType *ret_type)
 {
        char *qualified_name;
        const char *p;
@@ -393,11 +392,11 @@ static BOOL wb_lookup_rids(TALLOC_CTX *mem_ctx,
                           const DOM_SID *domain_sid,
                           int num_rids, uint32 *rids,
                           const char **domain_name,
-                          const char **names, enum SID_NAME_USE *types)
+                          const char **names, enum lsa_SidType *types)
 {
        int i;
        const char **my_names;
-       enum SID_NAME_USE *my_types;
+       enum lsa_SidType *my_types;
        TALLOC_CTX *tmp_ctx;
 
        if (!(tmp_ctx = talloc_init("wb_lookup_rids"))) {
@@ -406,12 +405,20 @@ static BOOL wb_lookup_rids(TALLOC_CTX *mem_ctx,
 
        if (!winbind_lookup_rids(tmp_ctx, domain_sid, num_rids, rids,
                                 domain_name, &my_names, &my_types)) {
+               *domain_name = "";
                for (i=0; i<num_rids; i++) {
+                       names[i] = "";
                        types[i] = SID_NAME_UNKNOWN;
                }
+               TALLOC_FREE(tmp_ctx);
                return True;
        }
 
+       if (!(*domain_name = talloc_strdup(mem_ctx, *domain_name))) {
+               TALLOC_FREE(tmp_ctx);
+               return False;
+       }
+
        /*
         * winbind_lookup_rids allocates its own array. We've been given the
         * array, so copy it over
@@ -435,15 +442,20 @@ static BOOL wb_lookup_rids(TALLOC_CTX *mem_ctx,
 static BOOL lookup_rids(TALLOC_CTX *mem_ctx, const DOM_SID *domain_sid,
                        int num_rids, uint32_t *rids,
                        const char **domain_name,
-                       const char ***names, enum SID_NAME_USE **types)
+                       const char ***names, enum lsa_SidType **types)
 {
        int i;
 
-       *names = TALLOC_ARRAY(mem_ctx, const char *, num_rids);
-       *types = TALLOC_ARRAY(mem_ctx, enum SID_NAME_USE, num_rids);
+       if (num_rids) {
+               *names = TALLOC_ARRAY(mem_ctx, const char *, num_rids);
+               *types = TALLOC_ARRAY(mem_ctx, enum lsa_SidType, num_rids);
 
-       if ((*names == NULL) || (*types == NULL)) {
-               return False;
+               if ((*names == NULL) || (*types == NULL)) {
+                       return False;
+               }
+       } else {
+               *names = NULL;
+               *types = NULL;
        }
 
        if (sid_check_is_domain(domain_sid)) {
@@ -549,7 +561,7 @@ static BOOL lookup_as_domain(const DOM_SID *sid, TALLOC_CTX *mem_ctx,
                             const char **name)
 {
        const char *tmp;
-       enum SID_NAME_USE type;
+       enum lsa_SidType type;
 
        if (sid_check_is_domain(sid)) {
                *name = talloc_strdup(mem_ctx, get_global_sam_name());
@@ -579,9 +591,9 @@ static BOOL lookup_as_domain(const DOM_SID *sid, TALLOC_CTX *mem_ctx,
                 * and for SIDs that have 4 sub-authorities and thus look like
                 * domains */
 
-               if (!NT_STATUS_IS_OK(secrets_trusted_domains(mem_ctx,
-                                                            &num_domains,
-                                                            &domains))) {
+               if (!NT_STATUS_IS_OK(pdb_enum_trusteddoms(mem_ctx,
+                                                         &num_domains,
+                                                         &domains))) {
                        return False;
                }
 
@@ -619,7 +631,7 @@ static BOOL lookup_as_domain(const DOM_SID *sid, TALLOC_CTX *mem_ctx,
  * Level 2: Ask domain and trusted domains, no builtin and wkn
  * Level 3: Only ask domain
  * Level 4: W2k3ad: Only ask AD trusts
- * Level 5: Don't lookup anything
+ * Level 5: Only ask transitive forest trusts
  * Level 6: Like 4
  */
 
@@ -671,7 +683,7 @@ NTSTATUS lookup_sids(TALLOC_CTX *mem_ctx, int num_sids,
        TALLOC_CTX *tmp_ctx;
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
        struct lsa_name_info *name_infos;
-       struct lsa_dom_info *dom_infos;
+       struct lsa_dom_info *dom_infos = NULL;
 
        int i, j;
 
@@ -680,10 +692,19 @@ NTSTATUS lookup_sids(TALLOC_CTX *mem_ctx, int num_sids,
                return NT_STATUS_NO_MEMORY;
        }
 
-       name_infos = TALLOC_ARRAY(mem_ctx, struct lsa_name_info, num_sids);
+       if (num_sids) {
+               name_infos = TALLOC_ARRAY(mem_ctx, struct lsa_name_info, num_sids);
+               if (name_infos == NULL) {
+                       result = NT_STATUS_NO_MEMORY;
+                       goto fail;
+               }
+       } else {
+               name_infos = NULL;
+       }
+
        dom_infos = TALLOC_ZERO_ARRAY(mem_ctx, struct lsa_dom_info,
                                      MAX_REF_DOMAINS);
-       if ((name_infos == NULL) || (dom_infos == NULL)) {
+       if (dom_infos == NULL) {
                result = NT_STATUS_NO_MEMORY;
                goto fail;
        }
@@ -809,7 +830,7 @@ NTSTATUS lookup_sids(TALLOC_CTX *mem_ctx, int num_sids,
                uint32_t *rids;
                const char *domain_name = NULL;
                const char **names;
-               enum SID_NAME_USE *types;
+               enum lsa_SidType *types;
                struct lsa_dom_info *dom = &dom_infos[i];
 
                if (!dom->valid) {
@@ -817,9 +838,13 @@ NTSTATUS lookup_sids(TALLOC_CTX *mem_ctx, int num_sids,
                        break;
                }
 
-               if (!(rids = TALLOC_ARRAY(tmp_ctx, uint32, dom->num_idxs))) {
-                       result = NT_STATUS_NO_MEMORY;
-                       goto fail;
+               if (dom->num_idxs) {
+                       if (!(rids = TALLOC_ARRAY(tmp_ctx, uint32, dom->num_idxs))) {
+                               result = NT_STATUS_NO_MEMORY;
+                               goto fail;
+                       }
+               } else {
+                       rids = NULL;
                }
 
                for (j=0; j<dom->num_idxs; j++) {
@@ -871,7 +896,7 @@ NTSTATUS lookup_sids(TALLOC_CTX *mem_ctx, int num_sids,
 
 BOOL lookup_sid(TALLOC_CTX *mem_ctx, const DOM_SID *sid,
                const char **ret_domain, const char **ret_name,
-               enum SID_NAME_USE *ret_type)
+               enum lsa_SidType *ret_type)
 {
        struct lsa_dom_info *domain;
        struct lsa_name_info *name;
@@ -941,14 +966,14 @@ static struct uid_sid_cache {
        struct uid_sid_cache *next, *prev;
        uid_t uid;
        DOM_SID sid;
-       enum SID_NAME_USE sidtype;
+       enum lsa_SidType sidtype;
 } *uid_sid_cache_head;
 
 static struct gid_sid_cache {
        struct gid_sid_cache *next, *prev;
        gid_t gid;
        DOM_SID sid;
-       enum SID_NAME_USE sidtype;
+       enum lsa_SidType sidtype;
 } *gid_sid_cache_head;
 
 /*****************************************************************
@@ -1110,28 +1135,21 @@ void store_gid_sid_cache(const DOM_SID *psid, gid_t gid)
 }
 
 /*****************************************************************
- *THE CANONICAL* convert uid_t to SID function.
+ *THE LEGACY* convert uid_t to SID function.
 *****************************************************************/  
 
-void uid_to_sid(DOM_SID *psid, uid_t uid)
+static void legacy_uid_to_sid(DOM_SID *psid, uid_t uid)
 {
-       uid_t low, high;
        uint32 rid;
+       BOOL ret;
 
        ZERO_STRUCTP(psid);
 
-       if (fetch_sid_from_uid_cache(psid, uid))
-               return;
-
-       if (lp_idmap_uid(&low, &high) && (uid >= low) && (uid <= high) &&
-           winbind_uid_to_sid(psid, uid)) {
+       become_root();
+       ret = pdb_uid_to_rid(uid, &rid);
+       unbecome_root();
 
-               DEBUG(10,("uid_to_sid: winbindd %u -> %s\n",
-                         (unsigned int)uid, sid_string_static(psid)));
-               goto done;
-       }
-
-       if (pdb_uid_to_rid(uid, &rid)) {
+       if (ret) {
                /* This is a mapped user */
                sid_copy(psid, get_global_sam_sid());
                sid_append_rid(psid, rid);
@@ -1143,7 +1161,7 @@ void uid_to_sid(DOM_SID *psid, uid_t uid)
        uid_to_unix_users_sid(uid, psid);
 
  done:
-       DEBUG(10,("uid_to_sid: local %u -> %s\n", (unsigned int)uid,
+       DEBUG(10,("LEGACY: uid %u -> sid %s\n", (unsigned int)uid,
                  sid_string_static(psid)));
 
        store_uid_sid_cache(psid, uid);
@@ -1151,27 +1169,20 @@ void uid_to_sid(DOM_SID *psid, uid_t uid)
 }
 
 /*****************************************************************
- *THE CANONICAL* convert gid_t to SID function.
+ *THE LEGACY* convert gid_t to SID function.
 *****************************************************************/  
 
-void gid_to_sid(DOM_SID *psid, gid_t gid)
+static void legacy_gid_to_sid(DOM_SID *psid, gid_t gid)
 {
-       gid_t low, high;
+       BOOL ret;
 
        ZERO_STRUCTP(psid);
 
-       if (fetch_sid_from_gid_cache(psid, gid))
-               return;
+       become_root();
+       ret = pdb_gid_to_sid(gid, psid);
+       unbecome_root();
 
-       if (lp_idmap_gid(&low, &high) && (gid >= low) && (gid <= high) &&
-           winbind_gid_to_sid(psid, gid)) {
-
-               DEBUG(10,("gid_to_sid: winbindd %u -> %s\n",
-                         (unsigned int)gid, sid_string_static(psid)));
-               goto done;
-       }
-
-       if (pdb_gid_to_sid(gid, psid)) {
+       if (ret) {
                /* This is a mapped group */
                goto done;
        }
@@ -1181,7 +1192,7 @@ void gid_to_sid(DOM_SID *psid, gid_t gid)
        gid_to_unix_groups_sid(gid, psid);
 
  done:
-       DEBUG(10,("gid_to_sid: local %u -> %s\n", (unsigned int)gid,
+       DEBUG(10,("LEGACY: gid %u -> sid %s\n", (unsigned int)gid,
                  sid_string_static(psid)));
 
        store_gid_sid_cache(psid, gid);
@@ -1189,32 +1200,23 @@ void gid_to_sid(DOM_SID *psid, gid_t gid)
 }
 
 /*****************************************************************
- *THE CANONICAL* convert SID to uid function.
+ *THE LEGACY* convert SID to uid function.
 *****************************************************************/  
 
-BOOL sid_to_uid(const DOM_SID *psid, uid_t *puid)
+static BOOL legacy_sid_to_uid(const DOM_SID *psid, uid_t *puid)
 {
-       enum SID_NAME_USE type;
+       enum lsa_SidType type;
        uint32 rid;
-       gid_t gid;
-
-       if (fetch_uid_from_cache(puid, psid))
-               return True;
-
-       if (fetch_gid_from_cache(&gid, psid)) {
-               return False;
-       }
-
-       if (sid_peek_check_rid(&global_sid_Unix_Users, psid, &rid)) {
-               uid_t uid = rid;
-               *puid = uid;
-               goto done;
-       }
 
        if (sid_peek_check_rid(get_global_sam_sid(), psid, &rid)) {
                union unid_t id;
+               BOOL ret;
 
-               if (pdb_sid_to_id(psid, &id, &type)) {
+               become_root();
+               ret = pdb_sid_to_id(psid, &id, &type);
+               unbecome_root();
+
+               if (ret) {
                        if (type != SID_NAME_USER) {
                                DEBUG(5, ("sid %s is a %s, expected a user\n",
                                          sid_string_static(psid),
@@ -1226,35 +1228,13 @@ BOOL sid_to_uid(const DOM_SID *psid, uid_t *puid)
                }
 
                /* This was ours, but it was not mapped.  Fail */
-
-               return False;
-       }
-
-       if (winbind_lookup_sid(NULL, psid, NULL, NULL, &type)) {
-
-               if (type != SID_NAME_USER) {
-                       DEBUG(10, ("sid_to_uid: sid %s is a %s\n",
-                                  sid_string_static(psid),
-                                  sid_type_lookup(type)));
-                       return False;
-               }
-
-               if (!winbind_sid_to_uid(puid, psid)) {
-                       DEBUG(5, ("sid_to_uid: winbind failed to allocate a "
-                                 "new uid for sid %s\n",
-                                 sid_string_static(psid)));
-                       return False;
-               }
-               goto done;
        }
 
-       /* TODO: Here would be the place to allocate both a gid and a uid for
-        * the SID in question */
-
+       DEBUG(10,("LEGACY: mapping failed for sid %s\n", sid_string_static(psid)));
        return False;
 
- done:
-       DEBUG(10,("sid_to_uid: %s -> %u\n", sid_string_static(psid),
+done:
+       DEBUG(10,("LEGACY: sid %s -> uid %u\n", sid_string_static(psid),
                (unsigned int)*puid ));
 
        store_uid_sid_cache(psid, *puid);
@@ -1262,44 +1242,44 @@ BOOL sid_to_uid(const DOM_SID *psid, uid_t *puid)
 }
 
 /*****************************************************************
- *THE CANONICAL* convert SID to gid function.
+ *THE LEGACY* convert SID to gid function.
  Group mapping is used for gids that maps to Wellknown SIDs
 *****************************************************************/  
 
-BOOL sid_to_gid(const DOM_SID *psid, gid_t *pgid)
+static BOOL legacy_sid_to_gid(const DOM_SID *psid, gid_t *pgid)
 {
        uint32 rid;
        GROUP_MAP map;
        union unid_t id;
-       enum SID_NAME_USE type;
-       uid_t uid;
-
-       if (fetch_gid_from_cache(pgid, psid))
-               return True;
-
-       if (fetch_uid_from_cache(&uid, psid))
-               return False;
-
-       if (sid_peek_check_rid(&global_sid_Unix_Groups, psid, &rid)) {
-               gid_t gid = rid;
-               *pgid = gid;
-               goto done;
-       }
+       enum lsa_SidType type;
 
        if ((sid_check_is_in_builtin(psid) ||
             sid_check_is_in_wellknown_domain(psid))) {
-               if (pdb_getgrsid(&map, *psid)) {
+               BOOL ret;
+
+               become_root();
+               ret = pdb_getgrsid(&map, *psid);
+               unbecome_root();
+
+               if (ret) {
                        *pgid = map.gid;
                        goto done;
                }
+               DEBUG(10,("LEGACY: mapping failed for sid %s\n", sid_string_static(psid)));
                return False;
        }
 
        if (sid_peek_check_rid(get_global_sam_sid(), psid, &rid)) {
-               if (pdb_sid_to_id(psid, &id, &type)) {
+               BOOL ret;
+
+               become_root();
+               ret = pdb_sid_to_id(psid, &id, &type);
+               unbecome_root();
+
+               if (ret) {
                        if ((type != SID_NAME_DOM_GRP) &&
                            (type != SID_NAME_ALIAS)) {
-                               DEBUG(5, ("sid %s is a %s, expected a group\n",
+                               DEBUG(5, ("LEGACY: sid %s is a %s, expected a group\n",
                                          sid_string_static(psid),
                                          sid_type_lookup(type)));
                                return False;
@@ -1307,39 +1287,170 @@ BOOL sid_to_gid(const DOM_SID *psid, gid_t *pgid)
                        *pgid = id.gid;
                        goto done;
                }
-
+       
                /* This was ours, but it was not mapped.  Fail */
+       }
 
-               return False;
+       DEBUG(10,("LEGACY: mapping failed for sid %s\n", sid_string_static(psid)));
+       return False;
+       
+ done:
+       DEBUG(10,("LEGACY: sid %s -> gid %u\n", sid_string_static(psid),
+                 (unsigned int)*pgid ));
+
+       store_gid_sid_cache(psid, *pgid);
+
+       return True;
+}
+
+/*****************************************************************
+ *THE CANONICAL* convert uid_t to SID function.
+*****************************************************************/  
+
+void uid_to_sid(DOM_SID *psid, uid_t uid)
+{
+       ZERO_STRUCTP(psid);
+
+       if (fetch_sid_from_uid_cache(psid, uid))
+               return;
+
+       if (!winbind_uid_to_sid(psid, uid)) {
+               if (!winbind_ping()) {
+                       legacy_uid_to_sid(psid, uid);
+                       return;
+               }
+
+               DEBUG(5, ("uid_to_sid: winbind failed to find a sid for uid %u\n",
+                       uid));
+               return;
+       }
+
+       DEBUG(10,("uid %u -> sid %s\n",
+                 (unsigned int)uid, sid_string_static(psid)));
+
+       store_uid_sid_cache(psid, uid);
+       return;
+}
+
+/*****************************************************************
+ *THE CANONICAL* convert gid_t to SID function.
+*****************************************************************/  
+
+void gid_to_sid(DOM_SID *psid, gid_t gid)
+{
+       ZERO_STRUCTP(psid);
+
+       if (fetch_sid_from_gid_cache(psid, gid))
+               return;
+
+       if (!winbind_gid_to_sid(psid, gid)) {
+               if (!winbind_ping()) {
+                       legacy_gid_to_sid(psid, gid);
+                       return;
+               }
+
+               DEBUG(5, ("gid_to_sid: winbind failed to find a sid for gid %u\n",
+                       gid));
+               return;
        }
+
+       DEBUG(10,("gid %u -> sid %s\n",
+                 (unsigned int)gid, sid_string_static(psid)));
        
-       if (!winbind_lookup_sid(NULL, psid, NULL, NULL, &type)) {
-               DEBUG(11,("sid_to_gid: no one knows the SID %s (tried local, "
-                         "then winbind)\n", sid_string_static(psid)));
-               
+       store_gid_sid_cache(psid, gid);
+       return;
+}
+
+/*****************************************************************
+ *THE CANONICAL* convert SID to uid function.
+*****************************************************************/  
+
+BOOL sid_to_uid(const DOM_SID *psid, uid_t *puid)
+{
+       uint32 rid;
+       gid_t gid;
+
+       if (fetch_uid_from_cache(puid, psid))
+               return True;
+
+       if (fetch_gid_from_cache(&gid, psid)) {
                return False;
        }
 
-       /* winbindd knows it; Ensure this is a group sid */
+       /* Optimize for the Unix Users Domain
+        * as the conversion is straightforward */
+       if (sid_peek_check_rid(&global_sid_Unix_Users, psid, &rid)) {
+               uid_t uid = rid;
+               *puid = uid;
+
+               /* return here, don't cache */
+               DEBUG(10,("sid %s -> uid %u\n", sid_string_static(psid),
+                       (unsigned int)*puid ));
+               return True;
+       }
+
+       if (!winbind_sid_to_uid(puid, psid)) {
+               if (!winbind_ping()) {
+                       return legacy_sid_to_uid(psid, puid);
+               }
 
-       if ((type != SID_NAME_DOM_GRP) && (type != SID_NAME_ALIAS) &&
-           (type != SID_NAME_WKN_GRP)) {
-               DEBUG(10,("sid_to_gid: winbind lookup succeeded but SID is "
-                         "a %s\n", sid_type_lookup(type)));
+               DEBUG(5, ("winbind failed to find a uid for sid %s\n",
+                         sid_string_static(psid)));
                return False;
        }
-       
-       /* winbindd knows it and it is a type of group; sid_to_gid must succeed
-          or we are dead in the water */
+
+       /* TODO: Here would be the place to allocate both a gid and a uid for
+        * the SID in question */
+
+       DEBUG(10,("sid %s -> uid %u\n", sid_string_static(psid),
+               (unsigned int)*puid ));
+
+       store_uid_sid_cache(psid, *puid);
+       return True;
+}
+
+/*****************************************************************
+ *THE CANONICAL* convert SID to gid function.
+ Group mapping is used for gids that maps to Wellknown SIDs
+*****************************************************************/  
+
+BOOL sid_to_gid(const DOM_SID *psid, gid_t *pgid)
+{
+       uint32 rid;
+       uid_t uid;
+
+       if (fetch_gid_from_cache(pgid, psid))
+               return True;
+
+       if (fetch_uid_from_cache(&uid, psid))
+               return False;
+
+       /* Optimize for the Unix Groups Domain
+        * as the conversion is straightforward */
+       if (sid_peek_check_rid(&global_sid_Unix_Groups, psid, &rid)) {
+               gid_t gid = rid;
+               *pgid = gid;
+
+               /* return here, don't cache */
+               DEBUG(10,("sid %s -> gid %u\n", sid_string_static(psid),
+                       (unsigned int)*pgid ));
+               return True;
+       }
+
+       /* Ask winbindd if it can map this sid to a gid.
+        * (Idmap will check it is a valid SID and of the right type) */
 
        if ( !winbind_sid_to_gid(pgid, psid) ) {
-               DEBUG(10,("sid_to_gid: winbind failed to allocate a new gid "
-                         "for sid %s\n", sid_string_static(psid)));
+               if (!winbind_ping()) {
+                       return legacy_sid_to_gid(psid, pgid);
+               }
+
+               DEBUG(10,("winbind failed to find a gid for sid %s\n",
+                                       sid_string_static(psid)));
                return False;
        }
 
- done:
-       DEBUG(10,("sid_to_gid: %s -> %u\n", sid_string_static(psid),
+       DEBUG(10,("sid %s -> gid %u\n", sid_string_static(psid),
                  (unsigned int)*pgid ));
 
        store_gid_sid_cache(psid, *pgid);