selftest: Fix use of --load-list.
[sfrench/samba-autobuild/.git] / selftest / selftest.pl
index 28e0460a5ad76d56a1098745654102792580c0f3..5457306c625a87b336a5d3bdcc43ed22344342ae 100755 (executable)
@@ -125,14 +125,21 @@ use strict;
 
 use FindBin qw($RealBin $Script);
 use File::Spec;
+use File::Temp qw(tempfile);
 use Getopt::Long;
 use POSIX;
 use Cwd qw(abs_path);
 use lib "$RealBin";
-use Subunit qw(parse_results);
-use Subunit::Filter;
+use Subunit;
 use SocketWrapper;
 
+eval {
+require Time::HiRes;
+};
+unless ($@) {
+       use Time::HiRes qw(time);
+}
+
 my $opt_help = 0;
 my $opt_target = "samba4";
 my $opt_quick = 0;
@@ -146,10 +153,9 @@ my $opt_verbose = 0;
 my $opt_image = undef;
 my $opt_testenv = 0;
 my $ldap = undef;
-my $opt_analyse_cmd = undef;
 my $opt_resetup_env = undef;
 my $opt_bindir = undef;
-my $opt_no_lazy_setup = undef;
+my $opt_load_list = undef;
 my @testlists = ();
 
 my $srcdir = ".";
@@ -212,55 +218,49 @@ sub cleanup_pcap($$)
        unlink($pcap_file);
 }
 
+# expand strings from %ENV
+sub expand_environment_strings($)
+{
+       my $s = shift;
+       # we use a reverse sort so we do the longer ones first
+       foreach my $k (sort { $b cmp $a } keys %ENV) {
+               $s =~ s/\$$k/$ENV{$k}/g;
+       }
+       return $s;
+}
+
 sub run_testsuite($$$$$)
 {
        my ($envname, $name, $cmd, $i, $totalsuites) = @_;
        my $pcap_file = setup_pcap($name);
 
-       Subunit::report_time(time());
        Subunit::start_testsuite($name);
+       Subunit::progress_push();
+       Subunit::report_time(time());
+       system($cmd);
+       Subunit::report_time(time());
+       Subunit::progress_pop();
 
-       open(RESULTS, "$cmd 2>&1|");
-       my $statistics = {
-               SUITES_FAIL => 0,
-
-               TESTS_UNEXPECTED_OK => 0,
-               TESTS_EXPECTED_OK => 0,
-               TESTS_UNEXPECTED_FAIL => 0,
-               TESTS_EXPECTED_FAIL => 0,
-               TESTS_ERROR => 0,
-               TESTS_SKIP => 0,
-       };
-
-       my $msg_ops = new Subunit::Filter("$name\.", []);
-
-       parse_results($msg_ops, $statistics, *RESULTS);
-
-       my $ret = 0;
-
-       unless (close(RESULTS)) {
-               if ($!) {
-                       Subunit::end_testsuite($name, "error", "Unable to run $cmd: $!");
-                       return 0;
-               } else {
-                       $ret = $?;
-               }
-       } 
-
-       if ($ret & 127) {
-               Subunit::end_testsuite($name, "error", sprintf("Testsuite died with signal %d, %s coredump", ($ret & 127), ($ret & 128) ? "with": "without"));
+       if ($? == -1) {
+               Subunit::progress_pop();
+               Subunit::end_testsuite($name, "error", "Unable to run $cmd: $!");
+               return 0;
+       } elsif ($? & 127) {
+               Subunit::end_testsuite($name, "error",
+                       sprintf("%s died with signal %d, %s coredump\n", $cmd, ($? & 127),  ($? & 128) ? 'with' : 'without'));
                return 0;
        }
+
+       my $exitcode = $? >> 8;
+
        my $envlog = getlog_env($envname);
        if ($envlog ne "") {
                print "envlog: $envlog\n";
        }
 
        print "command: $cmd\n";
+       printf "expanded command: %s\n", expand_environment_strings($cmd);
 
-       my $exitcode = $ret >> 8;
-
-       Subunit::report_time(time());
        if ($exitcode == 0) {
                Subunit::end_testsuite($name, "success");
        } else {
@@ -338,19 +338,21 @@ my $result = GetOptions (
                'verbose' => \$opt_verbose,
                'testenv' => \$opt_testenv,
                'ldap:s' => \$ldap,
-               'analyse-cmd=s' => \$opt_analyse_cmd,
-               'no-lazy-setup' => \$opt_no_lazy_setup,
                'resetup-environment' => \$opt_resetup_env,
                'bindir:s' => \$opt_bindir,
                'image=s' => \$opt_image,
-               'testlist=s' => \@testlists
+               'testlist=s' => \@testlists,
+               'load-list=s' => \$opt_load_list,
            );
 
 exit(1) if (not $result);
 
 ShowHelp() if ($opt_help);
 
-my $tests = shift;
+# we want unbuffered output
+$| = 1;
+
+my @tests = @ARGV;
 
 # quick hack to disable rpc validation when using valgrind - its way too slow
 unless (defined($ENV{VALGRIND})) {
@@ -358,6 +360,9 @@ unless (defined($ENV{VALGRIND})) {
        $ENV{MALLOC_CHECK_} = 2;
 }
 
+# make all our python scripts unbuffered
+$ENV{PYTHONUNBUFFERED} = 1;
+
 my $bindir = ($opt_bindir or "$builddir/bin");
 my $bindir_abs = abs_path($bindir);
 
@@ -429,7 +434,7 @@ if ($opt_socket_wrapper_pcap) {
 
 my $socket_wrapper_dir;
 if ($opt_socket_wrapper) {
-       $socket_wrapper_dir = SocketWrapper::setup_dir("$prefix/w", $opt_socket_wrapper_pcap);
+       $socket_wrapper_dir = SocketWrapper::setup_dir("$prefix_abs/w", $opt_socket_wrapper_pcap);
        print "SOCKET_WRAPPER_DIR=$socket_wrapper_dir\n";
 } else {
         unless ($< == 0) { 
@@ -441,7 +446,7 @@ my $target;
 my $testenv_default = "none";
 
 if ($opt_target eq "samba4") {
-       $testenv_default = "member";
+       $testenv_default = "all";
        require target::Samba4;
        $target = new Samba4($bindir, $ldap, "$srcdir/setup", $exeext);
 } elsif ($opt_target eq "samba3") {
@@ -517,12 +522,12 @@ foreach (@opt_include) {
        push (@includes, read_test_regexes($_));
 }
 
-my $interfaces = join(',', ("127.0.0.6/8", 
-                           "127.0.0.7/8",
-                           "127.0.0.8/8",
-                           "127.0.0.9/8",
-                           "127.0.0.10/8",
-                           "127.0.0.11/8"));
+my $interfaces = join(',', ("127.0.0.11/8",
+                           "127.0.0.12/8",
+                           "127.0.0.13/8",
+                           "127.0.0.14/8",
+                           "127.0.0.15/8",
+                           "127.0.0.16/8"));
 
 my $conffile = "$prefix_abs/client/client.conf";
 $ENV{SMB_CONF_PATH} = $conffile;
@@ -532,19 +537,25 @@ sub write_clientconf($$)
        my ($conffile, $vars) = @_;
 
        mkdir("$prefix/client", 0777) unless -d "$prefix/client";
-       
+
        if ( -d "$prefix/client/private" ) {
                unlink <$prefix/client/private/*>;
        } else {
                mkdir("$prefix/client/private", 0777);
        }
 
-       if ( -d "$prefix/client/lock" ) {
+       if ( -d "$prefix/client/lockdir" ) {
                unlink <$prefix/client/lockdir/*>;
        } else {
                mkdir("$prefix/client/lockdir", 0777);
        }
 
+       if ( -d "$prefix_abs/client/ncalrpcdir" ) {
+               unlink <$prefix/client/ncalrpcdir/*>;
+       } else {
+               mkdir("$prefix/client/ncalrpcdir", 0777);
+       }
+
        open(CF, ">$conffile");
        print CF "[global]\n";
        if (defined($ENV{VALGRIND})) {
@@ -565,17 +576,21 @@ sub write_clientconf($$)
        print CF "
        private dir = $prefix_abs/client/private
        lock dir = $prefix_abs/client/lockdir
-       name resolve order = bcast
+       ncalrpc dir = $prefix_abs/client/ncalrpcdir
+       name resolve order = bcast file
        panic action = $RealBin/gdb_backtrace \%PID\% \%PROG\%
        max xmit = 32K
        notify:inotify = false
        ldb:nosync = true
        system:anonymous = true
        client lanman auth = Yes
+       log level = 1
        torture:basedir = $prefix_abs/client
 #We don't want to pass our self-tests if the PAC code is wrong
        gensec:require_pac = true
        modules dir = $ENV{LD_SAMBA_MODULE_PATH}
+       setup directory = ./setup
+       resolv:host file = $prefix_abs/dns_host_file
 ";
        close(CF);
 }
@@ -584,7 +599,19 @@ my @todo = ();
 
 my $testsdir = "$srcdir/selftest";
 
-my %required_envs = ();
+sub should_run_test($)
+{
+       my $name = shift;
+       if ($#tests == -1) {
+               return 1;
+       }
+       for (my $i=0; $i <= $#tests; $i++) {
+               if ($name =~ /$tests[$i]/i) {
+                       return 1;
+               }
+       }
+       return 0;
+}
 
 sub read_testlist($)
 {
@@ -594,16 +621,17 @@ sub read_testlist($)
        open(IN, $filename) or die("Unable to open $filename: $!");
 
        while (<IN>) {
-               if ($_ eq "-- TEST --\n") {
+               if (/-- TEST(-LOADLIST|-IDLIST|) --\n/) {
+                       my $supports_loadlist = (defined($1) and $1 eq "-LOADLIST");
+                       my $supports_idlist = (defined($1) and $1 eq "-IDLIST");
                        my $name = <IN>;
                        $name =~ s/\n//g;
                        my $env = <IN>;
                        $env =~ s/\n//g;
                        my $cmdline = <IN>;
                        $cmdline =~ s/\n//g;
-                       if (not defined($tests) or $name =~ /$tests/) {
-                               $required_envs{$env} = 1;
-                               push (@ret, [$name, $env, $cmdline]);
+                       if (should_run_test($name) == 1) {
+                               push (@ret, [$name, $env, $cmdline, $supports_loadlist, $supports_idlist]);
                        }
                } else {
                        print;
@@ -645,23 +673,60 @@ foreach my $fn (@testlists) {
        }
 }
 
-Subunit::testsuite_count($#available+1);
+my $restricted = undef;
+my $restricted_used = {};
+
+if ($opt_load_list) {
+       $restricted = [];
+       open(LOAD_LIST, "<$opt_load_list") or die("Unable to open $opt_load_list");
+       while (<LOAD_LIST>) {
+               chomp;
+               push (@$restricted, $_);
+       }
+       close(LOAD_LIST);
+}
+
+Subunit::progress($#available+1);
 Subunit::report_time(time());
 
-foreach (@available) {
-       my $name = $$_[0];
+my $individual_tests = undef;
+$individual_tests = {};
+
+foreach my $testsuite (@available) {
+       my $name = $$testsuite[0];
        my $skipreason = skip($name);
        if (defined($skipreason)) {
                Subunit::skip_testsuite($name, $skipreason);
+       } elsif (defined($restricted)) {
+               # Find the testsuite for this test
+               my $match = undef;
+               foreach my $r (@$restricted) {
+                       if ($r eq $name) {
+                               $individual_tests->{$name} = [];
+                               $match = $r;
+                               $restricted_used->{$r} = 1;
+                       } elsif (substr($r, 0, length($name)+1) eq "$name.") {
+                               push(@{$individual_tests->{$name}}, substr($r, length($name)+1));
+                               $match = $r;
+                               $restricted_used->{$r} = 1;
+                       }
+               }
+               push(@todo, $testsuite) if ($match);
        } else {
-               push(@todo, $_); 
+               push(@todo, $testsuite); 
        }
 }
 
-if ($#todo == -1) {
+if (defined($restricted)) {
+       foreach (@$restricted) {
+               unless (defined($restricted_used->{$_})) {
+                       print "No test or testsuite found matching $_\n";
+               }
+       }
+} elsif ($#todo == -1) {
        print STDERR "No tests to run\n";
        exit(1);
-       }
+}
 
 my $suitestotal = $#todo + 1;
 my $i = 0;
@@ -691,6 +756,24 @@ my @exported_envvars = (
        "DC_NETBIOSNAME",
        "DC_NETBIOSALIAS",
 
+       # domain member
+       "MEMBER_SERVER",
+       "MEMBER_SERVER_IP",
+       "MEMBER_NETBIOSNAME",
+       "MEMBER_NETBIOSALIAS",
+
+       # rpc proxy controller stuff
+       "RPC_PROXY_SERVER",
+       "RPC_PROXY_SERVER_IP",
+       "RPC_PROXY_NETBIOSNAME",
+       "RPC_PROXY_NETBIOSALIAS",
+
+       # domain controller stuff for Vampired DC
+       "VAMPIRE_DC_SERVER",
+       "VAMPIRE_DC_SERVER_IP",
+       "VAMPIRE_DC_NETBIOSNAME",
+       "VAMPIRE_DC_NETBIOSALIAS",
+
        # server stuff
        "SERVER",
        "SERVER_IP",
@@ -699,6 +782,7 @@ my @exported_envvars = (
 
        # user stuff
        "USERNAME",
+       "USERID",
        "PASSWORD",
        "DC_USERNAME",
        "DC_PASSWORD",
@@ -706,7 +790,8 @@ my @exported_envvars = (
        # misc stuff
        "KRB5_CONFIG",
        "WINBINDD_SOCKET_DIR",
-       "WINBINDD_PRIV_PIPE_DIR"
+       "WINBINDD_PRIV_PIPE_DIR",
+       "LOCAL_PATH"
 );
 
 $SIG{INT} = $SIG{QUIT} = $SIG{TERM} = sub { 
@@ -735,6 +820,7 @@ sub setup_env($)
        } elsif (defined(get_running_env($envname))) {
                $testenv_vars = get_running_env($envname);
                if (not $target->check_env($testenv_vars)) {
+                       print $target->getlog_env($testenv_vars);
                        $testenv_vars = undef;
                }
        } else {
@@ -749,7 +835,7 @@ sub setup_env($)
                SocketWrapper::set_default_iface($testenv_vars->{SOCKET_WRAPPER_DEFAULT_IFACE});
                $ENV{SMB_CONF_PATH} = $testenv_vars->{SERVERCONFFILE};
        } elsif ($option eq "client") {
-               SocketWrapper::set_default_iface(6);
+               SocketWrapper::set_default_iface(11);
                write_clientconf($conffile, $testenv_vars);
                $ENV{SMB_CONF_PATH} = $conffile;
        } else {
@@ -802,9 +888,8 @@ sub teardown_env($)
        delete $running_envs{$envname};
 }
 
-if ($opt_no_lazy_setup) {
-       setup_env($_) foreach (keys %required_envs);
-}
+# This 'global' file needs to be empty when we start
+unlink("$prefix_abs/dns_host_file");
 
 if ($opt_testenv) {
        my $testenv_name = $ENV{SELFTEST_TESTENV};
@@ -812,11 +897,13 @@ if ($opt_testenv) {
 
        my $testenv_vars = setup_env($testenv_name);
 
+       die("Unable to setup environment $testenv_name") unless ($testenv_vars);
+
        $ENV{PIDDIR} = $testenv_vars->{PIDDIR};
 
        my $envvarstr = exported_envvars_str($testenv_vars);
 
-       my $term = ($ENV{TERM} or "xterm");
+       my $term = ($ENV{TERMINAL} or "xterm");
        system("$term -e 'echo -e \"
 Welcome to the Samba4 Test environment '$testenv_name'
 
@@ -834,23 +921,34 @@ $envvarstr
        foreach (@todo) {
                $i++;
                my $cmd = $$_[2];
-               $cmd =~ s/([\(\)])/\\$1/g;
                my $name = $$_[0];
                my $envname = $$_[1];
-               
+
                my $envvars = setup_env($envname);
                if (not defined($envvars)) {
-                       Subunit::skip_testsuite($name, 
+                       Subunit::start_testsuite($name);
+                       Subunit::end_testsuite($name, "error",
                                "unable to set up environment $envname");
                        next;
                }
 
-               run_testsuite($envname, $name, $cmd, $i, $suitestotal);
-
-               if (defined($opt_analyse_cmd)) {
-                       system("$opt_analyse_cmd \"$name\"");
+               # Generate a file with the individual tests to run, if the 
+               # test runner for this test suite supports it.
+               if ($individual_tests and $individual_tests->{$name}) {
+                       if ($$_[3]) {
+                               my ($fh, $listid_file) = tempfile(UNLINK => 0);
+                               foreach my $test (@{$individual_tests->{$name}}) {
+                                       print $fh "$test\n";
+                               }
+                               $cmd =~ s/\$LOADLIST/--load-list=$listid_file/g;
+                       } elsif ($$_[4]) {
+                               $cmd =~ s/\s+[^\s]+\s*$//;
+                               $cmd .= " " . join(' ', @{$individual_tests->{$name}});
+                       }
                }
 
+               run_testsuite($envname, $name, $cmd, $i, $suitestotal);
+
                teardown_env($envname) if ($opt_resetup_env);
        }
 }
@@ -859,18 +957,13 @@ print "\n";
 
 teardown_env($_) foreach (keys %running_envs);
 
-$target->stop();
-
 my $failed = 0;
 
 # if there were any valgrind failures, show them
 foreach (<$prefix/valgrind.log*>) {
        next unless (-s $_);
-       system("grep DWARF2.CFI.reader $_ > /dev/null");
-       if ($? >> 8 == 0) {
-           print "VALGRIND FAILURE\n";
-           $failed++;
-           system("cat $_");
-       }
+       print "VALGRIND FAILURE\n";
+       $failed++;
+       system("cat $_");
 }
 exit 0;