leds: avoid races with workqueue
authorPavel Machek <pavel@ucw.cz>
Mon, 29 Apr 2019 15:22:59 +0000 (17:22 +0200)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Thu, 2 May 2019 20:54:51 +0000 (22:54 +0200)
commit0db37915d912e8dc6588f25da76d3ed36718d92f
tree38722b37751981f868085562a6426b3d222abb4c
parent05b8ccfba5d4621072e541603b0f0a14c2203ca8
leds: avoid races with workqueue

There are races between "main" thread and workqueue. They manifest
themselves on Thinkpad X60:

This should result in LED blinking, but it turns it off instead:

    root@amd:/data/pavel# cd /sys/class/leds/tpacpi\:\:power
    root@amd:/sys/class/leds/tpacpi::power# echo timer > trigger
    root@amd:/sys/class/leds/tpacpi::power# echo timer > trigger

It should be possible to transition from blinking to solid on by echo
0 > brightness; echo 1 > brightness... but that does not work, either,
if done too quickly.

Synchronization of the workqueue fixes both.

Fixes: 1afcadfcd184 ("leds: core: Use set_brightness_work for the blocking op")
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/led-class.c
drivers/leds/led-core.c