sfrench/cifs-2.6.git
9 years agoMerge tag 'iio-for-4.1a' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio...
Greg Kroah-Hartman [Tue, 24 Mar 2015 21:53:52 +0000 (22:53 +0100)]
Merge tag 'iio-for-4.1a' of git://git./linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

First set of new drivers, cleanups and functionality for IIO in the 4.1 cycle.

New drivers
* CM3323 color sensor.
* MS5611 pressure and temperature sensor.

New functionality
* mup6050 - create mux clients for devices described via ACPI. The reasoning
     and approach taken in this patch are complex.  Basically there is no
     otherway of finding out what is there than by some esoteric look ups in
     the ACPI data.
* cm3232 - PM support
* itg3200 - suspend/resume support
* mcp320x - add more ADCs to the kconfig to reflect what the driver supports
     (this patch and the bindings got left behind when the support was added
      a while back).

Docs / utils
* ti-adc128s052 - DT bindings.
* mcp3422 - DT bindings.
* mcp320x - DT bindings
* ABI docs for event threshold scale attributes, in_magn_offset, proximity
  scan_element and thresh falling/rising values for accelerometers.  All
  elements long in use that have slipped by being explicitly documented.
* Tidy up the tools previously in drivers/staging/iio/Documentation and move
  them out to /tools/iio. Yet another move that should have happened long ago.
  This time Roberta Dobrescu did the leg work.  Thanks!

Core Cleanups
* Export userspace IIO headers.  We should have done the appropriate header
  splitting a long time ago. Thanks to Daniel for sorting this out.

* Refactor the registring of attributes for buffers to move all non-custom
  ones to a vector allowing easier additions to the current set in the future.

Driver Cleanups
* gpiod related cleanups.  Make use of the additional parameter to specify
   initial direciton to avoid extra code.
* bmc150 - Various refactorings to reduce code repitition and prepare for
           hardware buffer support.  Some of these cleanups are good even
   without the new functionality.
* kmx61 - direct use of index to an array avoiding a structure element which
          was always the index to an element in an array of that structure.
* vf610 - avoid incorrect type for return from wait_for_completion_timeout.
* gp2ap020a00f - use put_unaligned_le32 for slight code simplification.
ade7754 - improve error handling including suppressing some build warnings.
ade7759 - improve error handling including suppressing some build warnings.
* hmc5843 - Long line and indentation fixes. Also some constifying of various
      constant data.
ade7854 - 80+ character line splitting.
* ad2s1210 - fix wrong printf format string.
* mxs-lradc - fix wrong printf format string.
ade7954-i2c - code alignment fixes and other trivial but worthwhile bits.
* periodic rtc trigger - make the frequency type an unsigned int as it
  is always treated as such.
* jsa1212 - constify struct regmap_config as it is constant.
* ad7793 - typo in the MODULE_DESCRIPTION
* mma9551 - check gpiod_to_irq errors.  Note that this doesn't actually cause
    any trouble but is worth tidying up as obviously incorrect.
* mlx90614 - refactor the register symbols to make it clear which reads are to
    RAM not PROM.

9 years agodgnc: Clean up dgnc_sysfs.h
Giedrius Statkevičius [Fri, 13 Mar 2015 13:56:35 +0000 (15:56 +0200)]
dgnc: Clean up dgnc_sysfs.h

Remove redundant blank lines, move absolute include after relative
include.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agodgnc: remove unused stuff from dgnc_cls.h
Giedrius Statkevičius [Fri, 13 Mar 2015 13:56:34 +0000 (15:56 +0200)]
dgnc: remove unused stuff from dgnc_cls.h

Remove unused defines from dgnc_cls.h

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agodgnc: remove old 2.4-2.6 compat kernel defines
Giedrius Statkevičius [Fri, 13 Mar 2015 13:56:33 +0000 (15:56 +0200)]
dgnc: remove old 2.4-2.6 compat kernel defines

dgnc_kcompat.h contains some old legacy defines in case the kernel
doesn't have __user defined but for current kernel versions these
defines don't make sense and are useless so remove them. Move the
TTY_FLIPBUF_SIZE define to digi.h because it's used in the code.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agodgnc: use linux/types.h instead of dgnc_types.h
Giedrius Statkevičius [Fri, 13 Mar 2015 13:56:32 +0000 (15:56 +0200)]
dgnc: use linux/types.h instead of dgnc_types.h

Dgnc_types.h unnecesarily defines TRUE as 1 and FALSE as 0 because we
already have a widely used linux/types.h so convert all TRUE to true,
FALSE to false and edit the dgnc_board struct to make sure it uses
"bool".

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agodgnc: get rid of dpacompat.h, move remaining stuff to digi.h
Giedrius Statkevičius [Fri, 13 Mar 2015 13:56:31 +0000 (15:56 +0200)]
dgnc: get rid of dpacompat.h, move remaining stuff to digi.h

Dpacompat.h contained a lot of unused #defines and only few things are
used from it so since we've trimmed down digi.h, now we can delete
dpacompat.h and move remaining stuff into digi.h.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agodgnc: clean up digi.h
Giedrius Statkevičius [Fri, 13 Mar 2015 13:56:30 +0000 (15:56 +0200)]
dgnc: clean up digi.h

Remove a lot of unused structs and defines from digi.h. We still have to
be careful with TIOCM_LE and TIOCMSET/TIOCMBIC because termios.h and
ioctls.h respectfully redefine them.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agodgnc: remove unused dgnc_ioctl_name() command
Giedrius Statkevičius [Fri, 13 Mar 2015 13:56:29 +0000 (15:56 +0200)]
dgnc: remove unused dgnc_ioctl_name() command

dgnc_ioctl_name() is never used anywhere so remove it

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: dgnc: some off by one bugs
Dan Carpenter [Thu, 12 Mar 2015 17:24:31 +0000 (20:24 +0300)]
staging: dgnc: some off by one bugs

"dgnc_NumBoards" is the number of filled out elements in the
dgnc_Board[] array.  "->nasync" and "->maxports" are the same value.
They are the number of channels in the ->channels[] array so these tests
should be ">=" instead of ">" so we avoid reading past the end of the
arrays.

I cleaned up the conditions in dgnc_mgmt_ioctl() a bit.  There was a
work around for the off by one bug in the case where there were no
boards which is no longer needed.  "channel" is unsigned so it can't be
negative.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostating: octeon-usb: cvmx_usb_initialize(): eliminate extra indentation
Aaro Koskinen [Sun, 22 Mar 2015 15:38:02 +0000 (17:38 +0200)]
stating: octeon-usb: cvmx_usb_initialize(): eliminate extra indentation

Eliminate extra indentation by putting all the code into the same block.
Also delete a bogus comment.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: try to recover from failed hardware reset
Aaro Koskinen [Sun, 22 Mar 2015 15:38:01 +0000 (17:38 +0200)]
staging: octeon-usb: try to recover from failed hardware reset

On some hardware the USB fails to initialize to sane state after
cold boot. We can detect this based on some unexpected interrupt bits,
and recover by re-initializing.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: fail and warn if DMA counters are wrong
Aaro Koskinen [Sun, 22 Mar 2015 15:38:00 +0000 (17:38 +0200)]
staging: octeon-usb: fail and warn if DMA counters are wrong

Fail and WARN if DMA counters are wrong.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: move cvmx_usb_shutdown()
Aaro Koskinen [Sun, 22 Mar 2015 15:37:59 +0000 (17:37 +0200)]
staging: octeon-usb: move cvmx_usb_shutdown()

Move cvmx_usb_shutdown() to allow its use from some other functions.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: rewrite port reset
Aaro Koskinen [Sun, 22 Mar 2015 15:37:58 +0000 (17:37 +0200)]
staging: octeon-usb: rewrite port reset

Don't disable port before resetting. Also perform reset unconditionally
when requested.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: move fifo setup to controller reset from port reset
Aaro Koskinen [Sun, 22 Mar 2015 15:37:57 +0000 (17:37 +0200)]
staging: octeon-usb: move fifo setup to controller reset from port reset

Move FIFO setup to controller reset from port reset.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: move fifo setup into a separate routine
Aaro Koskinen [Sun, 22 Mar 2015 15:37:56 +0000 (17:37 +0200)]
staging: octeon-usb: move fifo setup into a separate routine

Move FIFO setup into a separate routine.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: use USB stack to turn on power
Aaro Koskinen [Sun, 22 Mar 2015 15:37:55 +0000 (17:37 +0200)]
staging: octeon-usb: use USB stack to turn on power

Use USB stack to turn on the power bit. It will also do
the necessary delays.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: don't poll interrupts early
Aaro Koskinen [Sun, 22 Mar 2015 15:37:54 +0000 (17:37 +0200)]
staging: octeon-usb: don't poll interrupts early

Don't poll interrupts before we have registered the HCD.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: refactor usbn block init
Aaro Koskinen [Sun, 22 Mar 2015 15:37:53 +0000 (17:37 +0200)]
staging: octeon-usb: refactor usbn block init

Move one-time state data structure initialization out of
cvmx_usb_initialize().

This enables to re-initialize USBN HW block without messing
up data structures.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: never retry after xacterr
Aaro Koskinen [Sun, 22 Mar 2015 15:37:52 +0000 (17:37 +0200)]
staging: octeon-usb: never retry after xacterr

Never retry after xacterr. The DMA engine cannot handle that properly
and may result in wrong transfer count and hang.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: program DMA engine based on transfer direction
Aaro Koskinen [Sun, 22 Mar 2015 15:37:51 +0000 (17:37 +0200)]
staging: octeon-usb: program DMA engine based on transfer direction

Program DMA engine based on transfer direction. We are only transferring
to one direction at a time.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: use __BITFIELD_FIELD
Aaro Koskinen [Sun, 22 Mar 2015 15:37:50 +0000 (17:37 +0200)]
staging: octeon-usb: use __BITFIELD_FIELD

Use __BITFIELD_FIELD to define bitfields. OCTEON can at least in theory
run also in little-endian mode, so the bitfield definitions should not
assume big-endian byte order.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: delete redundant field from octeon_temp_buffer
Aaro Koskinen [Sun, 22 Mar 2015 15:37:49 +0000 (17:37 +0200)]
staging: octeon-usb: delete redundant field from octeon_temp_buffer

Since we are not moving/realigning the original pointer returned
by kmalloc, we don't need to store the value in a separate field.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: remove useless prefix from pipe flags
Aaro Koskinen [Sun, 22 Mar 2015 15:37:48 +0000 (17:37 +0200)]
staging: octeon-usb: remove useless prefix from pipe flags

Remove useless prefix from pipe flags and adjust comments.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: remove useless prefix from internal routines
Aaro Koskinen [Sun, 22 Mar 2015 15:37:47 +0000 (17:37 +0200)]
staging: octeon-usb: remove useless prefix from internal routines

Original CVMX code used "__" to distinguis internal USB functions
from public ones. But in Linux all cvmx_usb routines are internal
to this driver, so such separation is useless.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: eliminate 64-bit register access wrappers
Aaro Koskinen [Sun, 22 Mar 2015 15:37:46 +0000 (17:37 +0200)]
staging: octeon-usb: eliminate 64-bit register access wrappers

Eliminate 64-bit register access wrappers. Since we don't implement
register-level debugging outputs, these are useless.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon-usb: remove internal function parameter sanity checks
Aaro Koskinen [Sun, 22 Mar 2015 15:37:45 +0000 (17:37 +0200)]
staging: octeon-usb: remove internal function parameter sanity checks

Remove some function parameter sanity checks from internal functions
where we can rely them being called with sane parameters.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: rtl8192u: Remove function prototype from .c file
Cristina Opriceana [Sun, 22 Mar 2015 18:49:51 +0000 (20:49 +0200)]
Staging: rtl8192u: Remove function prototype from .c file

Remove function prototype from r8192U_core.c since it is
declared in the r8192U.h header and this is included in r8192U_core.c

Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: rtl8192u: Make function prototypes static
Cristina Opriceana [Sun, 22 Mar 2015 18:49:28 +0000 (20:49 +0200)]
Staging: rtl8192u: Make function prototypes static

Make functions static since they are used locally and no other files
refer them.

Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: media: remove useless dev_info to avoid null ptr dereference
Haneen Mohammed [Sun, 22 Mar 2015 00:02:02 +0000 (03:02 +0300)]
Staging: media: remove useless dev_info to avoid null ptr dereference

Context is used in dev_info after it has been freed.
This patch fix that issue by removing the dev_info itself,
for msg doesn't look much necessary.

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: rtl8723au: Remove unused function rtw_atimdone_event_callback23a
Somya Anand [Sun, 22 Mar 2015 09:19:29 +0000 (14:49 +0530)]
Staging: rtl8723au: Remove unused function rtw_atimdone_event_callback23a

This patch fixes the following sparse warning:

warning: symbol 'rtw_atimdone_event_callback23a' was not declared.
Should it be static?
rtw_atimdone_event_callback23a is local to the file rtw_mlme.c but
it isn't exposed in a header file anywhere. Moreover it is never called
from anywhere as well.

So, this patch removes this function completely.

Signed-off-by: Somya Anand <somyaanand214@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: wlan-ng: Remove typedef prism2sta_accesslist_t
Vatika Harlalka [Sat, 21 Mar 2015 06:57:34 +0000 (12:27 +0530)]
Staging: wlan-ng: Remove typedef prism2sta_accesslist_t

Remove typedef prism2sta_accesslist_t and replace its uses
in the code.
Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rtl8723au: Do not byteswap timeout twice
Jes Sorensen [Sun, 22 Mar 2015 23:09:44 +0000 (19:09 -0400)]
staging: rtl8723au: Do not byteswap timeout twice

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rtl8723au: update_txdesc(): bagg_pkt is always false
Jes Sorensen [Sun, 22 Mar 2015 23:09:43 +0000 (19:09 -0400)]
staging: rtl8723au: update_txdesc(): bagg_pkt is always false

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rtl8723au: Fix trailing whitespace
Jes Sorensen [Sun, 22 Mar 2015 23:09:42 +0000 (19:09 -0400)]
staging: rtl8723au: Fix trailing whitespace

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rtl8723au: Fix mis-placed break
Jes Sorensen [Mon, 23 Mar 2015 20:54:08 +0000 (16:54 -0400)]
staging: rtl8723au: Fix mis-placed break

In 7c3a8f2a5ec95e2b13704562f36321e20ddfc190 I made a mistake and moved
a break below a bracket, causing a situation where the for loop would
always exit when it shouldn't.

This patch corrects that mistake.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: wlan-ng: Remove typedef prism2sta_authlist_t
Vatika Harlalka [Sat, 21 Mar 2015 06:57:24 +0000 (12:27 +0530)]
Staging: wlan-ng: Remove typedef prism2sta_authlist_t

Remove typdef prism2sta_authlist_t and replace its uses
in the code.
Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: rtl8188eu: Delete space
Hatice ERTÜRK [Fri, 20 Mar 2015 19:25:20 +0000 (21:25 +0200)]
Staging: rtl8188eu: Delete space

Deleted spaces before ','.Because it is prohibited by the kernel coding style.
Error found with checkpatch.pl

Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fbtft: Fix indentation style by space
Helen Fornazier [Sat, 21 Mar 2015 02:18:10 +0000 (23:18 -0300)]
staging: fbtft: Fix indentation style by space

This patch fixes the checkpatch.pl warning and error:

WARNING: please, no spaces at the start of a line

ERROR: code indent should use tabs where possible

Signed-off-by: Helen Fornazier <helen.fornazier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fbtft: remove trailing white space
Helen Fornazier [Sat, 21 Mar 2015 16:50:05 +0000 (13:50 -0300)]
staging: fbtft: remove trailing white space

Clean useless trailing white spaces

Signed-off-by: Helen Fornazier <helen.fornazier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: iio: use the BIT macro in .h files
Haneen Mohammed [Sun, 22 Mar 2015 18:23:23 +0000 (21:23 +0300)]
Staging: iio: use the BIT macro in .h files

This patch replace bit shifting on 1, 2, and 3 with the BIT(x) macro.
Issue addressed by checkpatch.pl with --strict flag.

This was done with the help of Coccninelle:

@r1@
constant int g;
@@
(
0<<g
|
1<<g
|
2<<g
|
3<<g
)

@script:python b@
g2 <<r1.g;
y;
@@
coccinelle.y = int(g2) + 1

@c@
constant int r1.g;
identifier b.y;
@@
(
-(1 << g)
+BIT(g)
|
-(0 << g)
+ 0
|
-(2 << g)
+BIT(y)
|
-(3 << g)
+(BIT(y)| BIT(g))
)

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: iio: Fix file header to match standards
Cristina Opriceana [Sun, 22 Mar 2015 18:43:16 +0000 (20:43 +0200)]
Staging: iio: Fix file header to match standards

Fix file header to match Linux Kernel style. Remove Free Software
Foundation reference to silence the checkpatch.pl warning.
Add driver description and correct spelling mistakes.

Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: iio: Place driver in sleep mode on error
Cristina Opriceana [Sun, 22 Mar 2015 18:42:42 +0000 (20:42 +0200)]
Staging: iio: Place driver in sleep mode on error

Put device in sleep mode if an error is encountered after
initialization in order to avoid wasting power.

Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: iio: Add kernel-doc for struct hmc5843
Cristina Opriceana [Fri, 20 Mar 2015 16:09:43 +0000 (18:09 +0200)]
Staging: iio: Add kernel-doc for struct hmc5843

This patch documents the struct hmc5843 specific data following
this warning:
"CHECK: struct mutex definition without comment".

Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: Fix Sparse warnings for static declarations
Haneen Mohammed [Sat, 21 Mar 2015 07:51:42 +0000 (10:51 +0300)]
Staging: lustre: Fix Sparse warnings for static declarations

The following patch fixes Sparse warnings in genops.c regrding:
"Symbol * was not declared. Should it be static?"

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStagin: lustre: Fix externs should be avoided in .c
Haneen Mohammed [Sat, 21 Mar 2015 07:48:30 +0000 (10:48 +0300)]
Stagin: lustre: Fix externs should be avoided in .c

This patch moves extern declaration from genops.c to obd_class.h,
addressing checkpatch.pl warning: externs should be avoided in .c

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: Fix externs should be avoided in .c
Haneen Mohammed [Sat, 21 Mar 2015 07:47:56 +0000 (10:47 +0300)]
Staging: lustre: Fix externs should be avoided in .c

Thi patch moves extern declaration to "obd_class.h".
Remove prototype from "class_obd.c".
Issue addressed by checkpatch.pl.

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: remove extern in .c file
Haneen Mohammed [Sat, 21 Mar 2015 05:51:35 +0000 (08:51 +0300)]
Staging: lustre: remove extern in .c file

This patch removes extern from .c file; for the variable is not used
anywhere else in the file.
In addition, it mark it static in the one file it is in
"ldlm_resource.c".

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: Convert macro class_export_rpc_dec into static inline function
Somya Anand [Sat, 21 Mar 2015 12:50:25 +0000 (18:20 +0530)]
Staging: lustre: Convert macro class_export_rpc_dec into static inline function

This patch converts the macro class_export_rpc_dec into static inline
function. This is possible because the types of arguments at all the call
sites are same. So, the type of parameter is compatible with the types of
the arguments at all of the call sites.

Signed-off-by: Somya Anand <somyaanand214@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: Convert macro class_export_rpc_inc into static inline function
Somya Anand [Sat, 21 Mar 2015 12:50:24 +0000 (18:20 +0530)]
Staging: lustre: Convert macro class_export_rpc_inc into static inline function

This patch converts the macro class_export_rpc_inc into static inline
function. This is possible because the types of arguments at all the call
sites are same. So, the type of parameter is compatible with the types of
the arguments at all of the call sites.

Signed-off-by: Somya Anand <somyaanand214@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix parenthesis alignment in visorchipset_main.c
Benjamin Romer [Mon, 16 Mar 2015 17:58:52 +0000 (13:58 -0400)]
staging: unisys: fix parenthesis alignment in visorchipset_main.c

Fix as many parenthesis alignment problems in this file as possible.

In cases where there was no good way to align to the leading parenthesis, the
content of the parenthesis were aligned as if there were no limit, and then the
leading indentation was moved back to one tab in from the previous line.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: Fix CamelCase local variable in remaining_steps functions
Benjamin Romer [Mon, 16 Mar 2015 17:58:51 +0000 (13:58 -0400)]
staging: unisys: Fix CamelCase local variable in remaining_steps functions

Rename the CamelCase local variable

remainingSteps => remaining_steps

Update all references to use the corrected name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase local in textid functions
Benjamin Romer [Mon, 16 Mar 2015 17:58:50 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase local in textid functions

Fix the CamelCased local variable

textId => text_id

In both of the textid sysfs functions, and update all references to use the
corrected name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase variables in boottotool functions
Benjamin Romer [Mon, 16 Mar 2015 17:58:49 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase variables in boottotool functions

Rename the local CamelCase variable

efiSparIndication => efi_spar_indication

Update all references to use the corrected name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase local toolAction
Benjamin Romer [Mon, 16 Mar 2015 17:58:48 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase local toolAction

Rename the CamelCase local

toolAction => tool_action

In both of the sysfs functions for exposing this value, and update all
references to use the corrected name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase parameter in chipset functions
Benjamin Romer [Mon, 16 Mar 2015 17:58:47 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase parameter in chipset functions

Fix the CamelCase parameter

msgHdr => msg_hdr

In all of the chipset functions. Update all references to use the corrected
name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase parameter msgHdr in controlvm functions
Benjamin Romer [Mon, 16 Mar 2015 17:58:46 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase parameter msgHdr in controlvm functions

Fix the CamelCase parameter name

msgHdr => msg_hdr

In all of the controlvm functions in visorchipset_main.c. Update all references
to use the corrected name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase global Visorchipset_platform_device
Benjamin Romer [Mon, 16 Mar 2015 17:58:45 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase global Visorchipset_platform_device

Rename the CamelCase variable:

Visorchipset_platform_device => visorchipset_platform_device

Update all references to use the corrected name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCased global MajorDev
Benjamin Romer [Mon, 16 Mar 2015 17:58:44 +0000 (13:58 -0400)]
staging: unisys: fix CamelCased global MajorDev

Rename the CamelCase global:

MajorDev => major_dev

Update references to use the corrected name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase in responders functions
Benjamin Romer [Mon, 16 Mar 2015 17:58:43 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase in responders functions

Fix the CamelCase parameters:

busNo => bus_no
devNo => dev_no

In the functions bus_create_response(), bus_destroy_response(),
device_create_response(), device_destroy_response(), and
device_resume_response().

Fix the CamelCase global structure name

BusDev_Responders => busdev_responders

And update all references to use the corrected names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCased notifier globals
Benjamin Romer [Mon, 16 Mar 2015 17:58:42 +0000 (13:58 -0400)]
staging: unisys: fix CamelCased notifier globals

Fix these CamelCased names:

BusDev_Server_Notifiers => busdev_server_notifiers
BusDev_Client_Notifiers => busdev_client_notifiers

Update references to use the fixed names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCased Parahotplug globals
Benjamin Romer [Mon, 16 Mar 2015 17:58:41 +0000 (13:58 -0400)]
staging: unisys: fix CamelCased Parahotplug globals

Fix the CamelCase names:

Parahotplug_request_list => parahotplug_request_list
Parahotplug_request_list_lock => parahotplug_request_list_lock

Update references to use the corrected names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase global Visorchipset_cache_buffers_in_use
Benjamin Romer [Mon, 16 Mar 2015 17:58:40 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase global Visorchipset_cache_buffers_in_use

Rename this variable:

Visorchipset_cache_buffers_in_use => visorchipset_cache_buffers_in_use

Update all references to use the fixed name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase in putfile-related globals
Benjamin Romer [Mon, 16 Mar 2015 17:58:39 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase in putfile-related globals

Fix the CamelCase global names:

Putfile_buffer_list_pool => putfile_buffer_list_pool
Putfile_buffer_list_pool_name => putfile_buffer_list_pool_name
Putfile_request_list => putfile_request_list

Update all references to use the corrected names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCased ControlVM globals
Benjamin Romer [Mon, 16 Mar 2015 17:58:38 +0000 (13:58 -0400)]
staging: unisys: fix CamelCased ControlVM globals

Fix the CamelCase global names:

ControlVm_Pending_Msg => controlvm_pending_msg
ControlVm_Pending_Msg_Valid => controlvm_pending_msg_valid

Update all references to use the corrected names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: remove last remnants of proc entry code
Benjamin Romer [Mon, 16 Mar 2015 17:58:37 +0000 (13:58 -0400)]
staging: unisys: remove last remnants of proc entry code

All of the proc code using easyproc and procobjecttree support is gone,
so we can remove it from the source entirely.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix NULL pointer comparisons in uislib.c
Benjamin Romer [Mon, 16 Mar 2015 17:58:35 +0000 (13:58 -0400)]
staging: unisys: fix NULL pointer comparisons in uislib.c

Change pointer comparisons to NULL to just use the pointer directly.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase label in visorchipset_init()
Benjamin Romer [Mon, 16 Mar 2015 17:58:34 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase label in visorchipset_init()

Fix the CamelCase label:

Away => cleanup

Update all references to use the fixed name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase in setup_crash_devices_work_queue()
Benjamin Romer [Mon, 16 Mar 2015 17:58:33 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase in setup_crash_devices_work_queue()

Fix CamelCase names:

localCrashCreateBusMsg => local_crash_bus_msg
localCrashCreateDevMsg => local_crash_dev_msg
localSavedCrashMsgOffset => local_crash_msg_offset
localSavedCrashMsgCount => local_crash_msg_count
Away => cleanup

Update all references to use the fixed names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor controlvm_periodic_work()
Benjamin Romer [Mon, 16 Mar 2015 17:58:32 +0000 (13:58 -0400)]
staging: unisys: refactor controlvm_periodic_work()

Fix the CamelCase variable names:

gotACommand => got_command
Poll_Count => poll_count
Away => cleanup

Fix all references to use the new names. Remove the empty braces in the
while() and put in a trailing semicolon, for clarity.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor handle_command()
Benjamin Romer [Mon, 16 Mar 2015 17:58:31 +0000 (13:58 -0400)]
staging: unisys: refactor handle_command()

First, fix the CamelCase local variable names:

parametersAddr => parm_addr
parametersBytes => parm_bytes
isLocalAddr => local_addr

Change the type of local_addr to bool instead of using the #defined
type. Update all references to use the fixed names. Fix the indentation of that
line that's over the 80 column limit.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix spacing in parahotplug_request_create
Benjamin Romer [Mon, 16 Mar 2015 17:58:30 +0000 (13:58 -0400)]
staging: unisys: fix spacing in parahotplug_request_create

Just fix the spacing around the logical or operator in this function.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor parahotplug_process_list()
Benjamin Romer [Mon, 16 Mar 2015 17:58:29 +0000 (13:58 -0400)]
staging: unisys: refactor parahotplug_process_list()

Simplify the code a little and shorten the indentation levels by
reversing the check for time_after_eq().

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix Camelcase in initialize_controlvm_payload()
Benjamin Romer [Mon, 16 Mar 2015 17:58:28 +0000 (13:58 -0400)]
staging: unisys: fix Camelcase in initialize_controlvm_payload()

Fix the CamelCase local variables:

payloadOffset => payload_offset
payloadBytes => payload_bytes

Update all references to use the new names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix NULL comparison in destroy_controlvm_payload_info()
Benjamin Romer [Mon, 16 Mar 2015 17:58:27 +0000 (13:58 -0400)]
staging: unisys: fix NULL comparison in destroy_controlvm_payload_info()

Just remove the NULL from the check and test the pointer directly.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor initialize_controlvm_payload_info()
Benjamin Romer [Mon, 16 Mar 2015 17:58:26 +0000 (13:58 -0400)]
staging: unisys: refactor initialize_controlvm_payload_info()

Fix the CamelCased goto label:

Away => cleanup

and get rid of the NULL comparison.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor my_device_destroy()
Benjamin Romer [Mon, 16 Mar 2015 17:58:25 +0000 (13:58 -0400)]
staging: unisys: refactor my_device_destroy()

Fix the CamelCase variable names:

busNo => bus_no
devNo => dev_no
pDevInfo => dev_info

Update all the references to the updated names, then remove the goto and
its label.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor my_device_changestate()
Benjamin Romer [Mon, 16 Mar 2015 17:58:24 +0000 (13:58 -0400)]
staging: unisys: refactor my_device_changestate()

Fix the CamelCase names:

busNo => bus_no
devNo => dev_no
pDevInfo => dev_info

Update all references to use the new names, and remove the goto and
label entirely.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor my_device_create()
Benjamin Romer [Mon, 16 Mar 2015 17:58:23 +0000 (13:58 -0400)]
staging: unisys: refactor my_device_create()

Fix local CamelCase variable names:

busNo => bus_no
devNo => dev_no
pDevinfo => dev_info
pBusInfo => bus_info
Away => cleanup

Update references to use the corrected names, and change the kzalloc()
to use the variable itself rather than the type.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor bus_configure()
Benjamin Romer [Mon, 16 Mar 2015 17:58:22 +0000 (13:58 -0400)]
staging: unisys: refactor bus_configure()

First, fix the CamelCase names:

busNo => bus_no
pBusInfo => bus_info

Update all references to use the corrected names, and remove the messy
goto and label.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor bus_destroy()
Benjamin Romer [Mon, 16 Mar 2015 17:58:21 +0000 (13:58 -0400)]
staging: unisys: refactor bus_destroy()

Fix CamelCase names:

busNo => bus_no
pBusInfo => bus_info

Update all references to use the corrected names, and remove the goto
statements and labels entirely.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor bus_create()
Benjamin Romer [Mon, 16 Mar 2015 17:58:20 +0000 (13:58 -0400)]
staging: unisys: refactor bus_create()

First, fix all CamelCase names:

busNo => bus_no
pBusInfo => bus_info
Away => cleanup

Fix the kzalloc() call so it uses the variable name rather than the
type, and update all of the references to the renamed variables and
labels.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix braces in visorchipset_main.c
Benjamin Romer [Mon, 16 Mar 2015 17:58:19 +0000 (13:58 -0400)]
staging: unisys: fix braces in visorchipset_main.c

Fix all of the bracing mistakes by adding missing braces, and removing
unnecessary braces.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix spaces after typecasts in visorchipset_main.c
Benjamin Romer [Mon, 16 Mar 2015 17:58:18 +0000 (13:58 -0400)]
staging: unisys: fix spaces after typecasts in visorchipset_main.c

Just remove a couple of extra spaces after typecasts.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase in epilog functions
Benjamin Romer [Mon, 16 Mar 2015 17:58:17 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase in epilog functions

Rename the CamelCase parameters:

busNo => bus_no
devNo => dev_no
needResponse => need_response

And the local variables

pBusInfo => bus_info
pDevInfo => dev_info

Update all references to use the corrected names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase params in responder functions
Benjamin Romer [Mon, 16 Mar 2015 17:58:16 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase params in responder functions

Fix the CamelCase parameter names in the set of responder functions:

cmdId => cmd_id
busNo => bus_no
devNo => dev_no
responseState => response_state

Update all references to use the fixed names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase locals in visorchipset_save_message
Benjamin Romer [Mon, 16 Mar 2015 17:58:15 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase locals in visorchipset_save_message

Rename CamelCased local variable names:

localSavedCrashMsgOffset => crash_msg_offset
localSavedCrashMsgCount => crash_msg_count

Update references to use the new names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix Camelcase Away goto label
Benjamin Romer [Mon, 16 Mar 2015 17:58:14 +0000 (13:58 -0400)]
staging: unisys: fix Camelcase Away goto label

Rename the label in both places:

Away => cleanup

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix all NULL comparisons in visorchipset_main.c
Benjamin Romer [Mon, 16 Mar 2015 17:58:13 +0000 (13:58 -0400)]
staging: unisys: fix all NULL comparisons in visorchipset_main.c

Fix all of the NULL comparison checks generated by checkpatch.pl.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: remove obsolete proc entry code
Benjamin Romer [Mon, 16 Mar 2015 17:58:12 +0000 (13:58 -0400)]
staging: unisys: remove obsolete proc entry code

There is an unused variable in the visorchipset_bus_info structure that
used to be for a proc entry, so remove it, and the code that referenced
it. We don't need it anymore.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase-named clearing functions
Benjamin Romer [Mon, 16 Mar 2015 17:58:11 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase-named clearing functions

Fix the CamelCase-named structure clearing functions in
visorchipset_main.c:

busInfo_clear => bus_info_clear
devInfo_clear => dev_info_clear

Update references to use the fixed names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: remove old code block in visorchipset_main.c
Benjamin Romer [Mon, 16 Mar 2015 17:58:10 +0000 (13:58 -0400)]
staging: unisys: remove old code block in visorchipset_main.c

The block of code is old and #if 0'd out, so just remove it.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: remove extra blank lines in visorchipset_main.c
Benjamin Romer [Mon, 16 Mar 2015 17:58:09 +0000 (13:58 -0400)]
staging: unisys: remove extra blank lines in visorchipset_main.c

Fix up the line spacing around braces in visorchipset_main.c.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: refactor livedump_info structure
Benjamin Romer [Mon, 16 Mar 2015 17:58:08 +0000 (13:58 -0400)]
staging: unisys: refactor livedump_info structure

Fix the CamelCase member names and that global variable:

Dumpcapture_header => dumpcapture_header
Gettextdump_header => gettextdump_header
Dumpcomplete_header => dumpcomplete_header
Gettextdump_outstanding => gettextdump_outstanding
LiveDump_info => livedump_info

Update all references and merge the definition and global structure
declaration.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase global ControlVm_payload_info
Benjamin Romer [Mon, 16 Mar 2015 17:58:07 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase global ControlVm_payload_info

Rename the CamelCase global structure

ControlVm_payload_info => controlvm_payload_info

Move the declaration to the struct definition, and update all references
to use the new name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: get rid of Test_Vnic_channel
Benjamin Romer [Mon, 16 Mar 2015 17:58:06 +0000 (13:58 -0400)]
staging: unisys: get rid of Test_Vnic_channel

Nobody is using this, so remove it.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase channel name ControlVm_channel
Benjamin Romer [Mon, 16 Mar 2015 17:58:05 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase channel name ControlVm_channel

Rename the channel:

ControlVm_channel => controlvm_channel

Update all references to use the new name. Fix the odd bracketing in the
while() statement with the reference to controlvm_channel, too, so the
patch doesn't generate a warning.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix placement of logical ops in visorchipset_main.c
Benjamin Romer [Mon, 16 Mar 2015 17:58:04 +0000 (13:58 -0400)]
staging: unisys: fix placement of logical ops in visorchipset_main.c

Several if statement lines had the logical operators in the wrong place,
so fix these by moving the operator to the end of the previous line.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase list names
Benjamin Romer [Mon, 16 Mar 2015 17:58:03 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase list names

Rename the CamelCased list names:

BusInfoList => bus_info_list
DevInfoList => dev_info_list

Update all references to use the fixed names.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: fix CamelCase name for devicechangestate packet
Benjamin Romer [Mon, 16 Mar 2015 17:58:02 +0000 (13:58 -0400)]
staging: unisys: fix CamelCase name for devicechangestate packet

Fix the variable's CamelCase name:

g_DeviceChangeStatePacket => g_devicechangestate_packet

Update all references to use the fixed name.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>