From: Or Gerlitz Date: Thu, 5 Apr 2018 11:55:39 +0000 (+0300) Subject: net/mlx5e: Return success when TC offloaded fdb actions parsed ok X-Git-Tag: 4.18-rc1-smb3-fixes~114^2~238^2~8 X-Git-Url: http://git.samba.org/samba.git/?p=sfrench%2Fcifs-2.6.git;a=commitdiff_plain;h=31c8eba5e860f5f35918b2f72c45e689805d1c32 net/mlx5e: Return success when TC offloaded fdb actions parsed ok Reaching here, means we didn't err anywhere, so lets just return success. Signed-off-by: Or Gerlitz Reviewed-by: Jianbo Liu Signed-off-by: Saeed Mahameed --- diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 7d88e813bad1..c15bd7b6a840 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -2458,7 +2458,6 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts, const struct tc_action *a; LIST_HEAD(actions); bool encap = false; - int err = 0; if (!tcf_exts_has_actions(exts)) return -EINVAL; @@ -2474,6 +2473,8 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts, } if (is_tcf_pedit(a)) { + int err; + err = parse_tc_pedit_action(priv, a, MLX5_FLOW_NAMESPACE_FDB, parse_attr); if (err) @@ -2561,7 +2562,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts, if (!actions_match_supported(priv, exts, parse_attr, flow)) return -EOPNOTSUPP; - return err; + return 0; } int mlx5e_configure_flower(struct mlx5e_priv *priv,