From: Nikolay Borisov Date: Wed, 15 Aug 2018 15:26:54 +0000 (+0300) Subject: btrfs: Remove extraneous extent_buffer_get from tree_mod_log_rewind X-Git-Tag: 4.21-smb3-small-fixes~79^2~98 X-Git-Url: http://git.samba.org/samba.git/?p=sfrench%2Fcifs-2.6.git;a=commitdiff_plain;h=24cee18a1c1d7c731ea5987e0c99daea22ae7f4a;hp=6c122e2a0c515cfb3f3a9cefb5dad4cb62109c78 btrfs: Remove extraneous extent_buffer_get from tree_mod_log_rewind When a rewound buffer is created it already has a ref count of 1 and the dummy flag set. Then another ref is taken bumping the count to 2. Finally when this buffer is released from btrfs_release_path the extra reference is decremented by the special handling code in free_extent_buffer. However, this special code is in fact redundant sinca ref count of 1 is still correct since the buffer is only accessed via btrfs_path struct. This paves the way forward of removing the special handling in free_extent_buffer. Signed-off-by: Nikolay Borisov Reviewed-by: David Sterba Signed-off-by: David Sterba --- diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 0c5ece3fe741..c1afcc269313 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -1290,7 +1290,6 @@ tree_mod_log_rewind(struct btrfs_fs_info *fs_info, struct btrfs_path *path, btrfs_tree_read_unlock_blocking(eb); free_extent_buffer(eb); - extent_buffer_get(eb_rewin); btrfs_tree_read_lock(eb_rewin); __tree_mod_log_rewind(fs_info, eb_rewin, time_seq, tm); WARN_ON(btrfs_header_nritems(eb_rewin) >