net: hns3: ensure media_type is unitialized
authorColin Ian King <colin.king@canonical.com>
Thu, 17 Aug 2017 09:01:07 +0000 (10:01 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Aug 2017 17:06:07 +0000 (10:06 -0700)
Media type is only set if h->ae_algo->ops->get_media_type is called
so there is a possibility that media_type is uninitialized when it is
used a switch statement.  Fix this by initializing media_type to
HNAE3_MEDIA_TYPE_UNKNOWN.

Detected by CoverityScan, CID#1452624("Uninitialized scalar variable")

Fixes: 496d03e960ae ("net: hns3: Add Ethtool support to HNS3 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c

index 0ad65e47c77ebe7a02ba00f805281942cfe39ff4..53cab3ad4cda47d1178716967e97653d6e66f109 100644 (file)
@@ -304,7 +304,7 @@ static int hns3_get_link_ksettings(struct net_device *netdev,
        struct hnae3_handle *h = priv->ae_handle;
        u32 supported_caps;
        u32 advertised_caps;
-       u8 media_type;
+       u8 media_type = HNAE3_MEDIA_TYPE_UNKNOWN;
        u8 link_stat;
        u8 auto_neg;
        u8 duplex;