s390/zcrypt: use fallthrough;
authorJoe Perches <joe@perches.com>
Tue, 10 Mar 2020 20:39:51 +0000 (13:39 -0700)
committerVasily Gorbik <gor@linux.ibm.com>
Wed, 25 Mar 2020 11:39:37 +0000 (12:39 +0100)
Convert the various uses of fallthrough comments to fallthrough;

Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
drivers/s390/crypto/ap_bus.c
drivers/s390/crypto/ap_queue.c
drivers/s390/crypto/zcrypt_msgtype6.c

index 0246bb35790ff6a8a9df0c6bd03f944728d71a40..c413211c61161edc39af941a0956936c8c69414b 100644 (file)
@@ -360,7 +360,7 @@ void ap_wait(enum ap_wait wait)
                        wake_up(&ap_poll_wait);
                        break;
                }
-               /* Fall through */
+               fallthrough;
        case AP_WAIT_TIMEOUT:
                spin_lock_bh(&ap_poll_timer_lock);
                if (!hrtimer_is_queued(&ap_poll_timer)) {
index 39c0b246c69a2df1409eb5d768fc9ef244e37df9..9cb997cffa6178d677f952c0b564f2dcdbb48391 100644 (file)
@@ -152,7 +152,7 @@ static struct ap_queue_status ap_sm_recv(struct ap_queue *aq)
                        ap_msg->receive(aq, ap_msg, aq->reply);
                        break;
                }
-               /* fall through */
+               fallthrough;
        case AP_RESPONSE_NO_PENDING_REPLY:
                if (!status.queue_empty || aq->queue_count <= 0)
                        break;
@@ -219,7 +219,7 @@ static enum ap_wait ap_sm_suspend_read(struct ap_queue *aq)
        case AP_RESPONSE_NORMAL:
                if (aq->queue_count > 0)
                        return AP_WAIT_AGAIN;
-               /* fall through */
+               fallthrough;
        default:
                return AP_WAIT_NONE;
        }
@@ -254,7 +254,7 @@ static enum ap_wait ap_sm_write(struct ap_queue *aq)
                        aq->state = AP_STATE_WORKING;
                        return AP_WAIT_AGAIN;
                }
-               /* fall through */
+               fallthrough;
        case AP_RESPONSE_Q_FULL:
                aq->state = AP_STATE_QUEUE_FULL;
                return AP_WAIT_INTERRUPT;
@@ -380,7 +380,7 @@ static enum ap_wait ap_sm_setirq_wait(struct ap_queue *aq)
        case AP_RESPONSE_NORMAL:
                if (aq->queue_count > 0)
                        return AP_WAIT_AGAIN;
-               /* fallthrough */
+               fallthrough;
        case AP_RESPONSE_NO_PENDING_REPLY:
                return AP_WAIT_TIMEOUT;
        default:
index eadd3a438a4b3fb1c09700393bea475d0c371cfe..fd1cbb2d6b3f894ae250775a235d045bc44c5f39 100644 (file)
@@ -801,7 +801,7 @@ static int convert_response_ica(struct zcrypt_queue *zq,
                if (msg->cprbx.cprb_ver_id == 0x02)
                        return convert_type86_ica(zq, reply,
                                                  outputdata, outputdatalength);
-               /* fall through - wrong cprb version is an unknown response */
+               fallthrough;    /* wrong cprb version is an unknown response */
        default: /* Unknown response type, this should NEVER EVER happen */
                zq->online = 0;
                pr_err("Cryptographic device %02x.%04x failed and was set offline\n",
@@ -834,7 +834,7 @@ static int convert_response_xcrb(struct zcrypt_queue *zq,
                }
                if (msg->cprbx.cprb_ver_id == 0x02)
                        return convert_type86_xcrb(zq, reply, xcRB);
-               /* fall through - wrong cprb version is an unknown response */
+               fallthrough;    /* wrong cprb version is an unknown response */
        default: /* Unknown response type, this should NEVER EVER happen */
                xcRB->status = 0x0008044DL; /* HDD_InvalidParm */
                zq->online = 0;
@@ -864,7 +864,7 @@ static int convert_response_ep11_xcrb(struct zcrypt_queue *zq,
                        return convert_error(zq, reply);
                if (msg->cprbx.cprb_ver_id == 0x04)
                        return convert_type86_ep11_xcrb(zq, reply, xcRB);
-               /* fall through - wrong cprb version is an unknown resp */
+               fallthrough;    /* wrong cprb version is an unknown resp */
        default: /* Unknown response type, this should NEVER EVER happen */
                zq->online = 0;
                pr_err("Cryptographic device %02x.%04x failed and was set offline\n",
@@ -894,7 +894,7 @@ static int convert_response_rng(struct zcrypt_queue *zq,
                        return -EINVAL;
                if (msg->cprbx.cprb_ver_id == 0x02)
                        return convert_type86_rng(zq, reply, data);
-               /* fall through - wrong cprb version is an unknown response */
+               fallthrough;    /* wrong cprb version is an unknown response */
        default: /* Unknown response type, this should NEVER EVER happen */
                zq->online = 0;
                pr_err("Cryptographic device %02x.%04x failed and was set offline\n",