kdb: replace strnicmp with strncasecmp
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Mon, 13 Oct 2014 22:55:03 +0000 (15:55 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 14 Oct 2014 00:18:25 +0000 (02:18 +0200)
The kernel used to contain two functions for length-delimited,
case-insensitive string comparison, strnicmp with correct semantics and
a slightly buggy strncasecmp.  The latter is the POSIX name, so strnicmp
was renamed to strncasecmp, and strnicmp made into a wrapper for the new
strncasecmp to avoid breaking existing users.

To allow the compat wrapper strnicmp to be removed at some point in the
future, and to avoid the extra indirection cost, do
s/strnicmp/strncasecmp/g.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/debug/kdb/kdb_bp.c

index 70a504601dc3909c15c424b1d2b1afdf25b9b341..b20d544f20c2a12c24ac492c4dae56961e0b959d 100644 (file)
@@ -52,11 +52,11 @@ static int kdb_parsebp(int argc, const char **argv, int *nextargp, kdb_bp_t *bp)
 
        bp->bph_length = 1;
        if ((argc + 1) != nextarg) {
 
        bp->bph_length = 1;
        if ((argc + 1) != nextarg) {
-               if (strnicmp(argv[nextarg], "datar", sizeof("datar")) == 0)
+               if (strncasecmp(argv[nextarg], "datar", sizeof("datar")) == 0)
                        bp->bp_type = BP_ACCESS_WATCHPOINT;
                        bp->bp_type = BP_ACCESS_WATCHPOINT;
-               else if (strnicmp(argv[nextarg], "dataw", sizeof("dataw")) == 0)
+               else if (strncasecmp(argv[nextarg], "dataw", sizeof("dataw")) == 0)
                        bp->bp_type = BP_WRITE_WATCHPOINT;
                        bp->bp_type = BP_WRITE_WATCHPOINT;
-               else if (strnicmp(argv[nextarg], "inst", sizeof("inst")) == 0)
+               else if (strncasecmp(argv[nextarg], "inst", sizeof("inst")) == 0)
                        bp->bp_type = BP_HARDWARE_BREAKPOINT;
                else
                        return KDB_ARGCOUNT;
                        bp->bp_type = BP_HARDWARE_BREAKPOINT;
                else
                        return KDB_ARGCOUNT;