pinctrl: pinmux: Return selector to the pinctrl driver
authorTony Lindgren <tony@atomide.com>
Thu, 5 Jul 2018 09:10:15 +0000 (02:10 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 17 Jul 2018 08:48:47 +0000 (10:48 +0200)
We must return the selector from pinmux_generic_add_function() so
pin controller device drivers can remove the right group if needed
for deferred probe for example. And we now must make sure that a
proper name is passed so we can use it to check if the entry already
exists.

Note that fixes are also needed for the pin controller drivers to
use the selector value.

Fixes: a76edc89b100 ("pinctrl: core: Add generic pinctrl functions for
managing groups")
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Cc: Christ van Willegen <cvwillegen@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Paul Cercueil <paul@crapouillou.net>
Cc: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Tested-By: H. Nikolaus Schaller <hns@goldelico.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinmux.c

index d7c5b4abd7417cc4ff03cf2684adec4764b51758..5780442c068b8743479d8c05eb6cdfb23365c8fe 100644 (file)
@@ -307,7 +307,6 @@ static int pinmux_func_name_to_selector(struct pinctrl_dev *pctldev,
                selector++;
        }
 
                selector++;
        }
 
-       dev_err(pctldev->dev, "function '%s' not supported\n", function);
        return -EINVAL;
 }
 
        return -EINVAL;
 }
 
@@ -774,6 +773,16 @@ int pinmux_generic_add_function(struct pinctrl_dev *pctldev,
                                void *data)
 {
        struct function_desc *function;
                                void *data)
 {
        struct function_desc *function;
+       int selector;
+
+       if (!name)
+               return -EINVAL;
+
+       selector = pinmux_func_name_to_selector(pctldev, name);
+       if (selector >= 0)
+               return selector;
+
+       selector = pctldev->num_functions;
 
        function = devm_kzalloc(pctldev->dev, sizeof(*function), GFP_KERNEL);
        if (!function)
 
        function = devm_kzalloc(pctldev->dev, sizeof(*function), GFP_KERNEL);
        if (!function)
@@ -784,12 +793,11 @@ int pinmux_generic_add_function(struct pinctrl_dev *pctldev,
        function->num_group_names = num_groups;
        function->data = data;
 
        function->num_group_names = num_groups;
        function->data = data;
 
-       radix_tree_insert(&pctldev->pin_function_tree, pctldev->num_functions,
-                         function);
+       radix_tree_insert(&pctldev->pin_function_tree, selector, function);
 
        pctldev->num_functions++;
 
 
        pctldev->num_functions++;
 
-       return 0;
+       return selector;
 }
 EXPORT_SYMBOL_GPL(pinmux_generic_add_function);
 
 }
 EXPORT_SYMBOL_GPL(pinmux_generic_add_function);