btrfs: lift uuid_mutex to callers of btrfs_open_devices
authorDavid Sterba <dsterba@suse.com>
Tue, 19 Jun 2018 15:09:47 +0000 (17:09 +0200)
committerDavid Sterba <dsterba@suse.com>
Mon, 6 Aug 2018 11:12:47 +0000 (13:12 +0200)
Prepartory work to fix race between mount and device scan.

The callers will have to manage the critical section, eg. mount wants to
scan and then call btrfs_open_devices without the ioctl scan walking in
and modifying the fs devices in the meantime.

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/super.c
fs/btrfs/volumes.c

index 0b6567f0c63d7345a095361f02642530ada4668c..d470eb6b922664538acf21750130815ea2ca36aa 100644 (file)
@@ -1567,7 +1567,9 @@ static struct dentry *btrfs_mount_root(struct file_system_type *fs_type,
                goto error_fs_info;
        }
 
                goto error_fs_info;
        }
 
+       mutex_lock(&uuid_mutex);
        error = btrfs_open_devices(fs_devices, mode, fs_type);
        error = btrfs_open_devices(fs_devices, mode, fs_type);
+       mutex_unlock(&uuid_mutex);
        if (error)
                goto error_fs_info;
 
        if (error)
                goto error_fs_info;
 
index df5dd6f67887128ee38cd088ea241c02e8b95086..459cc2a2a31c0ef7456e60a751fe6c3d94d5c56c 100644 (file)
@@ -1142,7 +1142,8 @@ int btrfs_open_devices(struct btrfs_fs_devices *fs_devices,
 {
        int ret;
 
 {
        int ret;
 
-       mutex_lock(&uuid_mutex);
+       lockdep_assert_held(&uuid_mutex);
+
        mutex_lock(&fs_devices->device_list_mutex);
        if (fs_devices->opened) {
                fs_devices->opened++;
        mutex_lock(&fs_devices->device_list_mutex);
        if (fs_devices->opened) {
                fs_devices->opened++;
@@ -1152,7 +1153,6 @@ int btrfs_open_devices(struct btrfs_fs_devices *fs_devices,
                ret = open_fs_devices(fs_devices, flags, holder);
        }
        mutex_unlock(&fs_devices->device_list_mutex);
                ret = open_fs_devices(fs_devices, flags, holder);
        }
        mutex_unlock(&fs_devices->device_list_mutex);
-       mutex_unlock(&uuid_mutex);
 
        return ret;
 }
 
        return ret;
 }