media: cxd2820r: make arrays tab static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Thu, 5 Sep 2019 17:57:26 +0000 (14:57 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 7 Oct 2019 10:43:14 +0000 (07:43 -0300)
Don't populate the array tab on the stack but instead make it
static const. Makes the object size smaller by 170 bytes in total.

Before:
   text    data     bss     dec     hex filename
   7045    1736       0    8781    224d media/dvb-frontends/cxd2820r_c.o
   8800    2216       0   11016    2b08 media/dvb-frontends/cxd2820r_t.o
   8981    2120       0   11101    2b5d media/dvb-frontends/cxd2820r_t2.o

After:
   text    data     bss     dec     hex filename
   6896    1832       0    8728    2218 media/dvb-frontends/cxd2820r_c.o
   8651    2312       0   10963    2ad3 media/dvb-frontends/cxd2820r_t.o
   8853    2184       0   11037    2b1d media/dvb-frontends/cxd2820r_t2.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/dvb-frontends/cxd2820r_c.c
drivers/media/dvb-frontends/cxd2820r_t.c
drivers/media/dvb-frontends/cxd2820r_t2.c

index 6f7eedb4c00e322e46b2504651c1917e5f896d48..0ba382948c5175c61522315fdd2a6e94ebb89e8f 100644 (file)
@@ -298,7 +298,7 @@ int cxd2820r_sleep_c(struct dvb_frontend *fe)
        struct cxd2820r_priv *priv = fe->demodulator_priv;
        struct i2c_client *client = priv->client[0];
        int ret;
-       struct reg_val_mask tab[] = {
+       static const struct reg_val_mask tab[] = {
                { 0x000ff, 0x1f, 0xff },
                { 0x00085, 0x00, 0xff },
                { 0x00088, 0x01, 0xff },
index d56c6f7881966cbb077549b0945da8fb13602003..fbdfa6bf38dcee538a348cb139b0a777f7148787 100644 (file)
@@ -392,7 +392,7 @@ int cxd2820r_sleep_t(struct dvb_frontend *fe)
        struct cxd2820r_priv *priv = fe->demodulator_priv;
        struct i2c_client *client = priv->client[0];
        int ret;
-       struct reg_val_mask tab[] = {
+       static struct reg_val_mask tab[] = {
                { 0x000ff, 0x1f, 0xff },
                { 0x00085, 0x00, 0xff },
                { 0x00088, 0x01, 0xff },
index f924a80b968a2bfe8c45999d45c7a3782ccb7923..34ef2bb2de34afa7f37089991c2c9e05b4e1f95f 100644 (file)
@@ -386,7 +386,7 @@ int cxd2820r_sleep_t2(struct dvb_frontend *fe)
        struct cxd2820r_priv *priv = fe->demodulator_priv;
        struct i2c_client *client = priv->client[0];
        int ret;
-       struct reg_val_mask tab[] = {
+       static const struct reg_val_mask tab[] = {
                { 0x000ff, 0x1f, 0xff },
                { 0x00085, 0x00, 0xff },
                { 0x00088, 0x01, 0xff },