cxgb4: fix coccinelle warnings
authorHariprasad Shenai <hariprasad@chelsio.com>
Tue, 10 Mar 2015 12:14:52 +0000 (17:44 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Mar 2015 17:42:00 +0000 (13:42 -0400)
Commit 16e47624e76b43db ("cxgb4: Add new scheme to update T4/T5 firmware")
introduced below coccinelle warning.

>> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:994:2-8: Replace memcpy with
   struct assignment

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

index 853c38997c822aa8ab48a6bca5e0e88ae075146d..1abdfa123c6cf8d42a4788400539b40b05ed84eb 100644 (file)
@@ -1120,7 +1120,7 @@ int t4_prep_fw(struct adapter *adap, struct fw_info *fw_info,
                }
 
                /* Installed successfully, update the cached header too. */
-               memcpy(card_fw, fs_fw, sizeof(*card_fw));
+               *card_fw = *fs_fw;
                card_fw_usable = 1;
                *reset = 0;     /* already reset as part of load_fw */
        }