PCI: pciehp: Use symbolic constants, not hard-coded bitmask
authorBjorn Helgaas <bhelgaas@google.com>
Sat, 14 Dec 2013 20:06:47 +0000 (13:06 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 16 Dec 2013 01:00:00 +0000 (18:00 -0700)
Use the PCI_EXP_SLTSTA definitions, not 0x1f, when clearing Slot Status
bits.

No functional change.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/pciehp_hpc.c

index cb3100af7e8c8e6d707713719392c0bd586333f8..915bb35f91802b882dcaeb98330eff91cd687fb0 100644 (file)
@@ -808,7 +808,10 @@ struct controller *pcie_init(struct pcie_device *dev)
         }
 
        /* Clear all remaining event bits in Slot Status register */
-       pcie_capability_write_word(pdev, PCI_EXP_SLTSTA, 0x1f);
+       pcie_capability_write_word(pdev, PCI_EXP_SLTSTA,
+               PCI_EXP_SLTSTA_ABP | PCI_EXP_SLTSTA_PFD |
+               PCI_EXP_SLTSTA_MRLSC | PCI_EXP_SLTSTA_PDC |
+               PCI_EXP_SLTSTA_CC);
 
        /* Disable software notification */
        pcie_disable_notification(ctrl);