pwm: sunxi: Use of_device_get_match_data()
authorCorentin Labbe <clabbe.montjoie@gmail.com>
Sat, 21 Oct 2017 17:38:12 +0000 (19:38 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 15 Nov 2017 09:56:55 +0000 (10:56 +0100)
The usage of of_device_get_match_data reduce the code size a bit.
Furthermore, it prevents an improbable dereference when
of_match_device() returns NULL.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-sun4i.c

index 6d23f1d1c9b73373e84ea4a954da634cbd7911dc..334199c58f1de78791cc748da3ce9f12f61ba5ba 100644 (file)
@@ -368,14 +368,15 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
        struct sun4i_pwm_chip *pwm;
        struct resource *res;
        int ret;
-       const struct of_device_id *match;
-
-       match = of_match_device(sun4i_pwm_dt_ids, &pdev->dev);
 
        pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL);
        if (!pwm)
                return -ENOMEM;
 
+       pwm->data = of_device_get_match_data(&pdev->dev);
+       if (!pwm->data)
+               return -ENODEV;
+
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        pwm->base = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(pwm->base))
@@ -385,7 +386,6 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
        if (IS_ERR(pwm->clk))
                return PTR_ERR(pwm->clk);
 
-       pwm->data = match->data;
        pwm->chip.dev = &pdev->dev;
        pwm->chip.ops = &sun4i_pwm_ops;
        pwm->chip.base = -1;