mm/ksm.c is doing an unneeded _notify in write_protect_page.
authorRobin Holt <>
Tue, 23 Mar 2010 20:35:26 +0000 (13:35 -0700)
committerLinus Torvalds <>
Wed, 24 Mar 2010 23:31:20 +0000 (16:31 -0700)
ksm.c's write_protect_page implements a lockless means of verifying a page
does not have any users of the page which are not accounted for via other
kernel tracking means.  It does this by removing the writable pte with TLB
flushes, checking the page_count against the total known users, and then
using set_pte_at_notify to make it a read-only entry.

An unneeded mmu_notifier callout is made in the case where the known users
does not match the page_count.  In that event, we are inserting the
identical pte and there is no need for the set_pte_at_notify, but rather
the simpler set_pte_at suffices.

Signed-off-by: Robin Holt <>
Acked-by: Izik Eidus <>
Acked-by: Andrea Arcangeli <>
Acked-by: Hugh Dickins <>
Cc: Chris Wright <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>

index a93f1b7f508cde17cb0b41f7183641dcfdb7a26f..8cdfc2a1e8bffbdfed7e7d92842552e3ee41aa6f 100644 (file)
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -751,7 +751,7 @@ static int write_protect_page(struct vm_area_struct *vma, struct page *page,
                 * page
                if (page_mapcount(page) + 1 + swapped != page_count(page)) {
-                       set_pte_at_notify(mm, addr, ptep, entry);
+                       set_pte_at(mm, addr, ptep, entry);
                        goto out_unlock;
                entry = pte_wrprotect(entry);