ALSA: dice: fix compiler warning due to returning uninitialized value
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Thu, 13 Jun 2019 03:35:22 +0000 (12:35 +0900)
committerTakashi Iwai <tiwai@suse.de>
Thu, 13 Jun 2019 04:59:09 +0000 (06:59 +0200)
This commit fixes the warning due to returning uninitialized value
from start_streams() helper function.

   sound/firewire/dice/dice-stream.c: In function 'start_streams.isra.0':
>> sound/firewire/dice/dice-stream.c:350:6: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
     int err;
         ^~~

Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 3cd2c2d780a2 ("ALSA: dice: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/dice/dice-stream.c

index f61b99a72655f1f7cb0ed76bd6bf7e630b4c7300..e9e5c5fffb7056971b1677c9ac814d32fbea6df8 100644 (file)
@@ -389,7 +389,7 @@ static int start_streams(struct snd_dice *dice, enum amdtp_stream_direction dir,
                        return err;
        }
 
-       return err;
+       return 0;
 }
 
 /*