net/sched: cls_flower: Set egress_dev mark when calling into the HW driver
authorOr Gerlitz <>
Mon, 16 Oct 2017 09:19:48 +0000 (12:19 +0300)
committerDavid S. Miller <>
Mon, 16 Oct 2017 20:18:59 +0000 (21:18 +0100)
Commit 7091d8c '(net/sched: cls_flower: Add offload support using egress
Hardware device') made sure (when fl_hw_replace_filter is called) to put
the egress_dev mark on persisent structure instance. Hence, following calls
into the HW driver for stats and deletion will note it and act accordingly.

With commit de4784ca030f this property is lost and hence when called,
the HW driver failes to operate (stats, delete) on the offloaded flow.

Fix it by setting the egress_dev flag whenever the ingress device is
different from the hw device since this is exactly the condition under
which we're calling into the HW driver through the egress port net-device.

Fixes: de4784ca030f ('net: sched: get rid of struct tc_to_netdev')
Signed-off-by: Or Gerlitz <>
Signed-off-by: Roi Dayan <>
Acked-by: Jiri Pirko <>
Signed-off-by: David S. Miller <>

index d230cb4c809454137968be4bb1537d92bc8ebc5d..b480d7c792ba03e26e2eece4998f1b82e9c75b05 100644 (file)
@@ -234,6 +234,7 @@ static void fl_hw_destroy_filter(struct tcf_proto *tp, struct cls_fl_filter *f)
        tc_cls_common_offload_init(&cls_flower.common, tp);
        cls_flower.command = TC_CLSFLOWER_DESTROY;
        cls_flower.cookie = (unsigned long) f;
+       cls_flower.egress_dev = f->hw_dev != tp->q->dev_queue->dev;
        dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_CLSFLOWER, &cls_flower);
@@ -289,6 +290,7 @@ static void fl_hw_update_stats(struct tcf_proto *tp, struct cls_fl_filter *f)
        cls_flower.command = TC_CLSFLOWER_STATS;
        cls_flower.cookie = (unsigned long) f;
        cls_flower.exts = &f->exts;
+       cls_flower.egress_dev = f->hw_dev != tp->q->dev_queue->dev;
        dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_CLSFLOWER,