nfsd4: fix xdr4 count of server in fs_location4
authorBenjamin Coddington <bcodding@redhat.com>
Sun, 7 Dec 2014 21:05:48 +0000 (16:05 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 9 Dec 2014 20:52:17 +0000 (15:52 -0500)
Fix a bug where nfsd4_encode_components_esc() incorrectly calculates the
length of server array in fs_location4--note that it is a count of the
number of array elements, not a length in bytes.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Fixes: 082d4bd72a45 (nfsd4: "backfill" using write_bytes_to_xdr_buf)
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4xdr.c

index a8549f8fef57399b08dbe745a535f83de927299c..e578c87d55279bec3862b7c7f7ed2f2a8b052c22 100644 (file)
@@ -1817,7 +1817,7 @@ static __be32 nfsd4_encode_components_esc(struct xdr_stream *xdr, char sep,
 
                str = end;
        }
-       pathlen = htonl(xdr->buf->len - pathlen_offset);
+       pathlen = htonl(count);
        write_bytes_to_xdr_buf(xdr->buf, pathlen_offset, &pathlen, 4);
        return 0;
 }