ALSA: sb: Delete an unnecessary check before the function call "snd_emux_free"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 3 Jan 2015 20:02:32 +0000 (21:02 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sun, 4 Jan 2015 14:13:32 +0000 (15:13 +0100)
The snd_emux_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/sb/emu8000_synth.c

index 95b39beb61c19b8d10f38b5e65e86b1fb7acdf9b..72332dfada9a3f2d089cecd7d257ae0121223a8d 100644 (file)
@@ -103,8 +103,7 @@ static int snd_emu8000_delete_device(struct snd_seq_device *dev)
        hw = dev->driver_data;
        if (hw->pcm)
                snd_device_free(dev->card, hw->pcm);
-       if (hw->emu)
-               snd_emux_free(hw->emu);
+       snd_emux_free(hw->emu);
        snd_util_memhdr_free(hw->memhdr);
        hw->emu = NULL;
        hw->memhdr = NULL;