x86: hpet: Use proper destructor for delayed work
authorThomas Gleixner <tglx@linutronix.de>
Sun, 23 Mar 2014 14:20:45 +0000 (14:20 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 25 Mar 2014 16:34:01 +0000 (17:34 +0100)
destroy_timer_on_stack() is hardly the right thing for a delayed
work. We leak a tracking object for the work itself when DEBUG_OBJECTS
is enabled.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: x86@kernel.org
Link: http://lkml.kernel.org/r/20140323141940.034005322@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/kernel/hpet.c

index da85a8e830a12d65e9d2f8a7f1db39b5477e9e85..b91abfdd49316a2300a33b86462222b5db53bed1 100644 (file)
@@ -699,7 +699,7 @@ static int hpet_cpuhp_notify(struct notifier_block *n,
                /* FIXME: add schedule_work_on() */
                schedule_delayed_work_on(cpu, &work.work, 0);
                wait_for_completion(&work.complete);
-               destroy_timer_on_stack(&work.work.timer);
+               destroy_delayed_work_on_stack(&work.work);
                break;
        case CPU_DEAD:
                if (hdev) {