watchdog: iTCO: fix link error
authorArnd Bergmann <arnd@arndb.de>
Tue, 28 Apr 2020 21:29:11 +0000 (23:29 +0200)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 25 May 2020 06:55:45 +0000 (08:55 +0200)
When the MFD driver is a loadable module, the watchdog driver fails
to get linked into the kernel:

drivers/watchdog/iTCO_wdt.o: In function `update_no_reboot_bit_pmc':
iTCO_wdt.c:(.text+0x54f): undefined reference to `intel_pmc_gcr_update'

The code is written to support operation without the MFD driver, so
add a Kconfig dependency that allows this, while disallowing the watchdog
to be built-in when the MFD driver is a module.

Fixes: 25f1ca31e230 ("platform/x86: intel_pmc_ipc: Convert to MFD")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20200428212959.2993304-1-arnd@arndb.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/Kconfig

index a0399a5b2a300f025b820291b7a004f8e7ded3dc..b3ab5a4bc71a9d8f07a7f2b881b05cab4f58cfc6 100644 (file)
@@ -1218,6 +1218,7 @@ config ITCO_WDT
        depends on (X86 || IA64) && PCI
        select WATCHDOG_CORE
        depends on I2C || I2C=n
+       depends on MFD_INTEL_PMC_BXT || !MFD_INTEL_PMC_BXT
        select LPC_ICH if !EXPERT
        select I2C_I801 if !EXPERT && I2C
        ---help---