ASoC: cs35l32: Improve two size determinations in cs35l32_i2c_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 22 Nov 2017 19:40:47 +0000 (20:40 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 27 Nov 2017 13:11:21 +0000 (13:11 +0000)
Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l32.c

index e41d8ebe6eeab681f6cbb5b81105aa312ed0ff44..bc3a72e4c4ed73d4d7d674603c14334d6461596a 100644 (file)
@@ -355,9 +355,7 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client,
        unsigned int devid = 0;
        unsigned int reg;
 
        unsigned int devid = 0;
        unsigned int reg;
 
-
-       cs35l32 = devm_kzalloc(&i2c_client->dev, sizeof(struct cs35l32_private),
-                              GFP_KERNEL);
+       cs35l32 = devm_kzalloc(&i2c_client->dev, sizeof(*cs35l32), GFP_KERNEL);
        if (!cs35l32)
                return -ENOMEM;
 
        if (!cs35l32)
                return -ENOMEM;
 
@@ -373,9 +371,8 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client,
        if (pdata) {
                cs35l32->pdata = *pdata;
        } else {
        if (pdata) {
                cs35l32->pdata = *pdata;
        } else {
-               pdata = devm_kzalloc(&i2c_client->dev,
-                                    sizeof(struct cs35l32_platform_data),
-                               GFP_KERNEL);
+               pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata),
+                                    GFP_KERNEL);
                if (!pdata)
                        return -ENOMEM;
 
                if (!pdata)
                        return -ENOMEM;