dmaengine: mmp_tdma: use dmaenginem_async_device_register to simplify the code
authorHuang Shijie <sjhuang@iluvatar.ai>
Mon, 6 Aug 2018 08:52:26 +0000 (16:52 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 29 Aug 2018 16:13:17 +0000 (21:43 +0530)
Use dmaenginem_async_device_register to simplify the code:
remove dma_async_device_unregister.
return error if it fails.

Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mmp_tdma.c

index 13c68b6434ce276dbf2b5780b24c32d5824badde..9f5869e1a017ab10dd52a003c98d7592457f0bcb 100644 (file)
@@ -530,9 +530,6 @@ static void mmp_tdma_issue_pending(struct dma_chan *chan)
 
 static int mmp_tdma_remove(struct platform_device *pdev)
 {
-       struct mmp_tdma_device *tdev = platform_get_drvdata(pdev);
-
-       dma_async_device_unregister(&tdev->device);
        return 0;
 }
 
@@ -696,7 +693,7 @@ static int mmp_tdma_probe(struct platform_device *pdev)
        dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
        platform_set_drvdata(pdev, tdev);
 
-       ret = dma_async_device_register(&tdev->device);
+       ret = dmaenginem_async_device_register(&tdev->device);
        if (ret) {
                dev_err(tdev->device.dev, "unable to register\n");
                return ret;
@@ -708,7 +705,7 @@ static int mmp_tdma_probe(struct platform_device *pdev)
                if (ret) {
                        dev_err(tdev->device.dev,
                                "failed to register controller\n");
-                       dma_async_device_unregister(&tdev->device);
+                       return ret;
                }
        }