net: phy: at803x: use phy_modify_mmd()
authorRussell King <rmk+kernel@armlinux.org.uk>
Sun, 10 Jan 2021 14:54:36 +0000 (14:54 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Jan 2021 00:30:27 +0000 (16:30 -0800)
Convert at803x_clk_out_config() to use phy_modify_mmd().

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/E1kyc72-0008Pq-1x@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/at803x.c

index d0b36fd6c2655f10832e55b53fa7cbcf903977ed..9636edb8d6187e3de02e247fcc432370cb4257ee 100644 (file)
@@ -529,19 +529,12 @@ static void at803x_remove(struct phy_device *phydev)
 static int at803x_clk_out_config(struct phy_device *phydev)
 {
        struct at803x_priv *priv = phydev->priv;
-       int val;
 
        if (!priv->clk_25m_mask)
                return 0;
 
-       val = phy_read_mmd(phydev, MDIO_MMD_AN, AT803X_MMD7_CLK25M);
-       if (val < 0)
-               return val;
-
-       val &= ~priv->clk_25m_mask;
-       val |= priv->clk_25m_reg;
-
-       return phy_write_mmd(phydev, MDIO_MMD_AN, AT803X_MMD7_CLK25M, val);
+       return phy_modify_mmd(phydev, MDIO_MMD_AN, AT803X_MMD7_CLK25M,
+                             priv->clk_25m_mask, priv->clk_25m_reg);
 }
 
 static int at8031_pll_config(struct phy_device *phydev)