power: supply: sbs-battery: remove incorrect le16_to_cpu calls
authorPhil Reid <preid@electromag.com.au>
Thu, 15 Jun 2017 13:59:29 +0000 (21:59 +0800)
committerSebastian Reichel <sebastian.reichel@collabora.co.uk>
Thu, 15 Jun 2017 14:45:55 +0000 (16:45 +0200)
i2c_smbus commands handle the correct byte order for smbus transactions
internally. This will currently result in incorrect operation on big
endian systems.

Signed-off-by: Phil Reid <preid@electromag.com.au>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
drivers/power/supply/sbs-battery.c

index e3a114e60f1a3cac1c72bf72800cb859cae12254..cf43e38a9443923610f9a1e8370fa9d4f48a2d56 100644 (file)
@@ -199,7 +199,7 @@ static int sbs_read_word_data(struct i2c_client *client, u8 address)
                return ret;
        }
 
-       return le16_to_cpu(ret);
+       return ret;
 }
 
 static int sbs_read_string_data(struct i2c_client *client, u8 address,
@@ -265,7 +265,7 @@ static int sbs_read_string_data(struct i2c_client *client, u8 address,
        memcpy(values, block_buffer + 1, block_length);
        values[block_length] = '\0';
 
-       return le16_to_cpu(ret);
+       return ret;
 }
 
 static int sbs_write_word_data(struct i2c_client *client, u8 address,
@@ -278,8 +278,7 @@ static int sbs_write_word_data(struct i2c_client *client, u8 address,
        retries = chip->i2c_retry_count;
 
        while (retries > 0) {
-               ret = i2c_smbus_write_word_data(client, address,
-                       le16_to_cpu(value));
+               ret = i2c_smbus_write_word_data(client, address, value);
                if (ret >= 0)
                        break;
                retries--;