Merge branch 'topic/drm_audio_component' of https://git.kernel.org/pub/scm/linux...
authorMark Brown <broonie@kernel.org>
Wed, 1 Aug 2018 09:32:05 +0000 (10:32 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 1 Aug 2018 09:32:05 +0000 (10:32 +0100)
31 files changed:
drivers/gpu/drm/i915/Kconfig
drivers/gpu/drm/i915/intel_audio.c
include/drm/drm_audio_component.h [new file with mode: 0644]
include/drm/i915_component.h
include/sound/hda_component.h [new file with mode: 0644]
include/sound/hda_i915.h
include/sound/hdaudio.h
include/sound/hdaudio_ext.h
sound/core/seq/seq_clientmgr.c
sound/core/timer.c
sound/hda/Kconfig
sound/hda/Makefile
sound/hda/ext/hdac_ext_bus.c
sound/hda/ext/hdac_ext_controller.c
sound/hda/ext/hdac_ext_stream.c
sound/hda/hdac_component.c [new file with mode: 0644]
sound/hda/hdac_i915.c
sound/pci/hda/hda_codec.c
sound/pci/hda/hda_codec.h
sound/pci/hda/patch_ca0132.c
sound/pci/hda/patch_hdmi.c
sound/pci/hda/patch_realtek.c
sound/pci/lx6464es/lx6464es.c
sound/soc/codecs/hdac_hdmi.c
sound/soc/intel/skylake/skl-messages.c
sound/soc/intel/skylake/skl-nhlt.c
sound/soc/intel/skylake/skl-pcm.c
sound/soc/intel/skylake/skl-topology.c
sound/soc/intel/skylake/skl-topology.h
sound/soc/intel/skylake/skl.c
sound/soc/intel/skylake/skl.h

index dfd95889f4b7ae1fa89366b766727c586b875d3f..5c607f2c707b6e0c4dab27d4bfcc052e1ca226d3 100644 (file)
@@ -23,6 +23,7 @@ config DRM_I915
        select SYNC_FILE
        select IOSF_MBI
        select CRC32
+       select SND_HDA_I915 if SND_HDA_CORE
        help
          Choose this option if you have a system that has "Intel Graphics
          Media Accelerator" or "HD Graphics" integrated graphics,
index 3ea566f99450e37f10317712b651b8104bda2a28..7dd5605d94ae8ae7a515e40ad056a2709d965a2d 100644 (file)
@@ -639,11 +639,12 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
        dev_priv->av_enc_map[pipe] = encoder;
        mutex_unlock(&dev_priv->av_mutex);
 
-       if (acomp && acomp->audio_ops && acomp->audio_ops->pin_eld_notify) {
+       if (acomp && acomp->base.audio_ops &&
+           acomp->base.audio_ops->pin_eld_notify) {
                /* audio drivers expect pipe = -1 to indicate Non-MST cases */
                if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST))
                        pipe = -1;
-               acomp->audio_ops->pin_eld_notify(acomp->audio_ops->audio_ptr,
+               acomp->base.audio_ops->pin_eld_notify(acomp->base.audio_ops->audio_ptr,
                                                 (int) port, (int) pipe);
        }
 
@@ -681,11 +682,12 @@ void intel_audio_codec_disable(struct intel_encoder *encoder,
        dev_priv->av_enc_map[pipe] = NULL;
        mutex_unlock(&dev_priv->av_mutex);
 
-       if (acomp && acomp->audio_ops && acomp->audio_ops->pin_eld_notify) {
+       if (acomp && acomp->base.audio_ops &&
+           acomp->base.audio_ops->pin_eld_notify) {
                /* audio drivers expect pipe = -1 to indicate Non-MST cases */
                if (!intel_crtc_has_type(old_crtc_state, INTEL_OUTPUT_DP_MST))
                        pipe = -1;
-               acomp->audio_ops->pin_eld_notify(acomp->audio_ops->audio_ptr,
+               acomp->base.audio_ops->pin_eld_notify(acomp->base.audio_ops->audio_ptr,
                                                 (int) port, (int) pipe);
        }
 
@@ -880,7 +882,7 @@ static int i915_audio_component_get_eld(struct device *kdev, int port,
        return ret;
 }
 
-static const struct i915_audio_component_ops i915_audio_component_ops = {
+static const struct drm_audio_component_ops i915_audio_component_ops = {
        .owner          = THIS_MODULE,
        .get_power      = i915_audio_component_get_power,
        .put_power      = i915_audio_component_put_power,
@@ -897,12 +899,12 @@ static int i915_audio_component_bind(struct device *i915_kdev,
        struct drm_i915_private *dev_priv = kdev_to_i915(i915_kdev);
        int i;
 
-       if (WARN_ON(acomp->ops || acomp->dev))
+       if (WARN_ON(acomp->base.ops || acomp->base.dev))
                return -EEXIST;
 
        drm_modeset_lock_all(&dev_priv->drm);
-       acomp->ops = &i915_audio_component_ops;
-       acomp->dev = i915_kdev;
+       acomp->base.ops = &i915_audio_component_ops;
+       acomp->base.dev = i915_kdev;
        BUILD_BUG_ON(MAX_PORTS != I915_MAX_PORTS);
        for (i = 0; i < ARRAY_SIZE(acomp->aud_sample_rate); i++)
                acomp->aud_sample_rate[i] = 0;
@@ -919,8 +921,8 @@ static void i915_audio_component_unbind(struct device *i915_kdev,
        struct drm_i915_private *dev_priv = kdev_to_i915(i915_kdev);
 
        drm_modeset_lock_all(&dev_priv->drm);
-       acomp->ops = NULL;
-       acomp->dev = NULL;
+       acomp->base.ops = NULL;
+       acomp->base.dev = NULL;
        dev_priv->audio_component = NULL;
        drm_modeset_unlock_all(&dev_priv->drm);
 }
diff --git a/include/drm/drm_audio_component.h b/include/drm/drm_audio_component.h
new file mode 100644 (file)
index 0000000..4923b00
--- /dev/null
@@ -0,0 +1,118 @@
+// SPDX-License-Identifier: MIT
+// Copyright © 2014 Intel Corporation
+
+#ifndef _DRM_AUDIO_COMPONENT_H_
+#define _DRM_AUDIO_COMPONENT_H_
+
+struct drm_audio_component;
+
+/**
+ * struct drm_audio_component_ops - Ops implemented by DRM driver, called by hda driver
+ */
+struct drm_audio_component_ops {
+       /**
+        * @owner: drm module to pin down
+        */
+       struct module *owner;
+       /**
+        * @get_power: get the POWER_DOMAIN_AUDIO power well
+        *
+        * Request the power well to be turned on.
+        */
+       void (*get_power)(struct device *);
+       /**
+        * @put_power: put the POWER_DOMAIN_AUDIO power well
+        *
+        * Allow the power well to be turned off.
+        */
+       void (*put_power)(struct device *);
+       /**
+        * @codec_wake_override: Enable/disable codec wake signal
+        */
+       void (*codec_wake_override)(struct device *, bool enable);
+       /**
+        * @get_cdclk_freq: Get the Core Display Clock in kHz
+        */
+       int (*get_cdclk_freq)(struct device *);
+       /**
+        * @sync_audio_rate: set n/cts based on the sample rate
+        *
+        * Called from audio driver. After audio driver sets the
+        * sample rate, it will call this function to set n/cts
+        */
+       int (*sync_audio_rate)(struct device *, int port, int pipe, int rate);
+       /**
+        * @get_eld: fill the audio state and ELD bytes for the given port
+        *
+        * Called from audio driver to get the HDMI/DP audio state of the given
+        * digital port, and also fetch ELD bytes to the given pointer.
+        *
+        * It returns the byte size of the original ELD (not the actually
+        * copied size), zero for an invalid ELD, or a negative error code.
+        *
+        * Note that the returned size may be over @max_bytes.  Then it
+        * implies that only a part of ELD has been copied to the buffer.
+        */
+       int (*get_eld)(struct device *, int port, int pipe, bool *enabled,
+                      unsigned char *buf, int max_bytes);
+};
+
+/**
+ * struct drm_audio_component_audio_ops - Ops implemented by hda driver, called by DRM driver
+ */
+struct drm_audio_component_audio_ops {
+       /**
+        * @audio_ptr: Pointer to be used in call to pin_eld_notify
+        */
+       void *audio_ptr;
+       /**
+        * @pin_eld_notify: Notify the HDA driver that pin sense and/or ELD information has changed
+        *
+        * Called when the DRM driver has set up audio pipeline or has just
+        * begun to tear it down. This allows the HDA driver to update its
+        * status accordingly (even when the HDA controller is in power save
+        * mode).
+        */
+       void (*pin_eld_notify)(void *audio_ptr, int port, int pipe);
+       /**
+        * @pin2port: Check and convert from pin node to port number
+        *
+        * Called by HDA driver to check and convert from the pin widget node
+        * number to a port number in the graphics side.
+        */
+       int (*pin2port)(void *audio_ptr, int pin);
+       /**
+        * @master_bind: (Optional) component master bind callback
+        *
+        * Called at binding master component, for HDA codec-specific
+        * handling of dynamic binding.
+        */
+       int (*master_bind)(struct device *dev, struct drm_audio_component *);
+       /**
+        * @master_unbind: (Optional) component master unbind callback
+        *
+        * Called at unbinding master component, for HDA codec-specific
+        * handling of dynamic unbinding.
+        */
+       void (*master_unbind)(struct device *dev, struct drm_audio_component *);
+};
+
+/**
+ * struct drm_audio_component - Used for direct communication between DRM and hda drivers
+ */
+struct drm_audio_component {
+       /**
+        * @dev: DRM device, used as parameter for ops
+        */
+       struct device *dev;
+       /**
+        * @ops: Ops implemented by DRM driver, called by hda driver
+        */
+       const struct drm_audio_component_ops *ops;
+       /**
+        * @audio_ops: Ops implemented by hda driver, called by DRM driver
+        */
+       const struct drm_audio_component_audio_ops *audio_ops;
+};
+
+#endif /* _DRM_AUDIO_COMPONENT_H_ */
index 346b1f5cb180c2618d3f9feb3b036d8e7bcdc55e..fca22d463e1bf707199bc0dbe8e77705c21c3a8b 100644 (file)
 #ifndef _I915_COMPONENT_H_
 #define _I915_COMPONENT_H_
 
+#include "drm_audio_component.h"
+
 /* MAX_PORT is the number of port
  * It must be sync with I915_MAX_PORTS defined i915_drv.h
  */
 #define MAX_PORTS 6
 
-/**
- * struct i915_audio_component_ops - Ops implemented by i915 driver, called by hda driver
- */
-struct i915_audio_component_ops {
-       /**
-        * @owner: i915 module
-        */
-       struct module *owner;
-       /**
-        * @get_power: get the POWER_DOMAIN_AUDIO power well
-        *
-        * Request the power well to be turned on.
-        */
-       void (*get_power)(struct device *);
-       /**
-        * @put_power: put the POWER_DOMAIN_AUDIO power well
-        *
-        * Allow the power well to be turned off.
-        */
-       void (*put_power)(struct device *);
-       /**
-        * @codec_wake_override: Enable/disable codec wake signal
-        */
-       void (*codec_wake_override)(struct device *, bool enable);
-       /**
-        * @get_cdclk_freq: Get the Core Display Clock in kHz
-        */
-       int (*get_cdclk_freq)(struct device *);
-       /**
-        * @sync_audio_rate: set n/cts based on the sample rate
-        *
-        * Called from audio driver. After audio driver sets the
-        * sample rate, it will call this function to set n/cts
-        */
-       int (*sync_audio_rate)(struct device *, int port, int pipe, int rate);
-       /**
-        * @get_eld: fill the audio state and ELD bytes for the given port
-        *
-        * Called from audio driver to get the HDMI/DP audio state of the given
-        * digital port, and also fetch ELD bytes to the given pointer.
-        *
-        * It returns the byte size of the original ELD (not the actually
-        * copied size), zero for an invalid ELD, or a negative error code.
-        *
-        * Note that the returned size may be over @max_bytes.  Then it
-        * implies that only a part of ELD has been copied to the buffer.
-        */
-       int (*get_eld)(struct device *, int port, int pipe, bool *enabled,
-                      unsigned char *buf, int max_bytes);
-};
-
-/**
- * struct i915_audio_component_audio_ops - Ops implemented by hda driver, called by i915 driver
- */
-struct i915_audio_component_audio_ops {
-       /**
-        * @audio_ptr: Pointer to be used in call to pin_eld_notify
-        */
-       void *audio_ptr;
-       /**
-        * @pin_eld_notify: Notify the HDA driver that pin sense and/or ELD information has changed
-        *
-        * Called when the i915 driver has set up audio pipeline or has just
-        * begun to tear it down. This allows the HDA driver to update its
-        * status accordingly (even when the HDA controller is in power save
-        * mode).
-        */
-       void (*pin_eld_notify)(void *audio_ptr, int port, int pipe);
-};
-
 /**
  * struct i915_audio_component - Used for direct communication between i915 and hda drivers
  */
 struct i915_audio_component {
        /**
-        * @dev: i915 device, used as parameter for ops
+        * @base: the drm_audio_component base class
         */
-       struct device *dev;
+       struct drm_audio_component      base;
+
        /**
         * @aud_sample_rate: the array of audio sample rate per port
         */
        int aud_sample_rate[MAX_PORTS];
-       /**
-        * @ops: Ops implemented by i915 driver, called by hda driver
-        */
-       const struct i915_audio_component_ops *ops;
-       /**
-        * @audio_ops: Ops implemented by hda driver, called by i915 driver
-        */
-       const struct i915_audio_component_audio_ops *audio_ops;
 };
 
 #endif /* _I915_COMPONENT_H_ */
diff --git a/include/sound/hda_component.h b/include/sound/hda_component.h
new file mode 100644 (file)
index 0000000..78626cd
--- /dev/null
@@ -0,0 +1,61 @@
+// SPDX-License-Identifier: GPL-2.0
+// HD-Audio helpers to sync with DRM driver
+
+#ifndef __SOUND_HDA_COMPONENT_H
+#define __SOUND_HDA_COMPONENT_H
+
+#include <drm/drm_audio_component.h>
+
+#ifdef CONFIG_SND_HDA_COMPONENT
+int snd_hdac_set_codec_wakeup(struct hdac_bus *bus, bool enable);
+int snd_hdac_display_power(struct hdac_bus *bus, bool enable);
+int snd_hdac_sync_audio_rate(struct hdac_device *codec, hda_nid_t nid,
+                            int dev_id, int rate);
+int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid, int dev_id,
+                          bool *audio_enabled, char *buffer, int max_bytes);
+int snd_hdac_acomp_init(struct hdac_bus *bus,
+                       const struct drm_audio_component_audio_ops *aops,
+                       int (*match_master)(struct device *, void *),
+                       size_t extra_size);
+int snd_hdac_acomp_exit(struct hdac_bus *bus);
+int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
+                                   const struct drm_audio_component_audio_ops *ops);
+#else
+static inline int snd_hdac_set_codec_wakeup(struct hdac_bus *bus, bool enable)
+{
+       return 0;
+}
+static inline int snd_hdac_display_power(struct hdac_bus *bus, bool enable)
+{
+       return 0;
+}
+static inline int snd_hdac_sync_audio_rate(struct hdac_device *codec,
+                                          hda_nid_t nid, int dev_id, int rate)
+{
+       return 0;
+}
+static inline int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid,
+                                        int dev_id, bool *audio_enabled,
+                                        char *buffer, int max_bytes)
+{
+       return -ENODEV;
+}
+static inline int snd_hdac_acomp_init(struct hdac_bus *bus,
+                                     const struct drm_audio_component_audio_ops *aops,
+                                     int (*match_master)(struct device *, void *),
+                                     size_t extra_size)
+{
+       return -ENODEV;
+}
+static inline int snd_hdac_acomp_exit(struct hdac_bus *bus)
+{
+       return 0;
+}
+static inline int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
+                                                 const struct drm_audio_component_audio_ops *ops)
+{
+       return -ENODEV;
+}
+#endif
+
+#endif /* __SOUND_HDA_COMPONENT_H */
index a94f5b6f92ac6bba9476b594d38da22a5a86a8a5..6b79614a893b90dceb92e3a2945af150ff234bea 100644 (file)
@@ -5,54 +5,23 @@
 #ifndef __SOUND_HDA_I915_H
 #define __SOUND_HDA_I915_H
 
-#include <drm/i915_component.h>
+#include "hda_component.h"
 
 #ifdef CONFIG_SND_HDA_I915
-int snd_hdac_set_codec_wakeup(struct hdac_bus *bus, bool enable);
-int snd_hdac_display_power(struct hdac_bus *bus, bool enable);
 void snd_hdac_i915_set_bclk(struct hdac_bus *bus);
-int snd_hdac_sync_audio_rate(struct hdac_device *codec, hda_nid_t nid,
-                            int dev_id, int rate);
-int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid, int dev_id,
-                          bool *audio_enabled, char *buffer, int max_bytes);
 int snd_hdac_i915_init(struct hdac_bus *bus);
-int snd_hdac_i915_exit(struct hdac_bus *bus);
-int snd_hdac_i915_register_notifier(const struct i915_audio_component_audio_ops *);
 #else
-static inline int snd_hdac_set_codec_wakeup(struct hdac_bus *bus, bool enable)
-{
-       return 0;
-}
-static inline int snd_hdac_display_power(struct hdac_bus *bus, bool enable)
-{
-       return 0;
-}
 static inline void snd_hdac_i915_set_bclk(struct hdac_bus *bus)
 {
 }
-static inline int snd_hdac_sync_audio_rate(struct hdac_device *codec,
-                                          hda_nid_t nid, int dev_id, int rate)
-{
-       return 0;
-}
-static inline int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid,
-                                        int dev_id, bool *audio_enabled,
-                                        char *buffer, int max_bytes)
-{
-       return -ENODEV;
-}
 static inline int snd_hdac_i915_init(struct hdac_bus *bus)
 {
        return -ENODEV;
 }
+#endif
 static inline int snd_hdac_i915_exit(struct hdac_bus *bus)
 {
-       return 0;
+       return snd_hdac_acomp_exit(bus);
 }
-static inline int snd_hdac_i915_register_notifier(const struct i915_audio_component_audio_ops *ops)
-{
-       return -ENODEV;
-}
-#endif
 
 #endif /* __SOUND_HDA_I915_H */
index c052afc2754721a00e8afbc40fb73875e2962423..ab5ee3ef219852ca278d6db8fa6865dd8f80d16a 100644 (file)
@@ -188,6 +188,11 @@ struct hdac_driver {
        const struct hda_device_id *id_table;
        int (*match)(struct hdac_device *dev, struct hdac_driver *drv);
        void (*unsol_event)(struct hdac_device *dev, unsigned int event);
+
+       /* fields used by ext bus APIs */
+       int (*probe)(struct hdac_device *dev);
+       int (*remove)(struct hdac_device *dev);
+       void (*shutdown)(struct hdac_device *dev);
 };
 
 #define drv_to_hdac_driver(_drv) container_of(_drv, struct hdac_driver, driver)
@@ -208,6 +213,14 @@ struct hdac_bus_ops {
        int (*link_power)(struct hdac_bus *bus, bool enable);
 };
 
+/*
+ * ops used for ASoC HDA codec drivers
+ */
+struct hdac_ext_bus_ops {
+       int (*hdev_attach)(struct hdac_device *hdev);
+       int (*hdev_detach)(struct hdac_device *hdev);
+};
+
 /*
  * Lowlevel I/O operators
  */
@@ -250,11 +263,17 @@ struct hdac_rb {
  * @mlcap: MultiLink capabilities pointer
  * @gtscap: gts capabilities pointer
  * @drsmcap: dma resume capabilities pointer
+ * @num_streams: streams supported
+ * @idx: HDA link index
+ * @hlink_list: link list of HDA links
+ * @lock: lock for link mgmt
+ * @cmd_dma_state: state of cmd DMAs: CORB and RIRB
  */
 struct hdac_bus {
        struct device *dev;
        const struct hdac_bus_ops *ops;
        const struct hdac_io_ops *io_ops;
+       const struct hdac_ext_bus_ops *ext_ops;
 
        /* h/w resources */
        unsigned long addr;
@@ -314,9 +333,19 @@ struct hdac_bus {
        spinlock_t reg_lock;
        struct mutex cmd_mutex;
 
-       /* i915 component interface */
-       struct i915_audio_component *audio_component;
-       int i915_power_refcount;
+       /* DRM component interface */
+       struct drm_audio_component *audio_component;
+       int drm_power_refcount;
+
+       /* parameters required for enhanced capabilities */
+       int num_streams;
+       int idx;
+
+       struct list_head hlink_list;
+
+       struct mutex lock;
+       bool cmd_dma_state;
+
 };
 
 int snd_hdac_bus_init(struct hdac_bus *bus, struct device *dev,
index 9c14e21dda85cf94ee47e3faa9bef10a881dc650..f34aced69ca803207e2196d58fd8de70518a4534 100644 (file)
@@ -4,38 +4,16 @@
 
 #include <sound/hdaudio.h>
 
-/**
- * hdac_ext_bus: HDAC extended bus for extended HDA caps
- *
- * @bus: hdac bus
- * @num_streams: streams supported
- * @hlink_list: link list of HDA links
- * @lock: lock for link mgmt
- * @cmd_dma_state: state of cmd DMAs: CORB and RIRB
- */
-struct hdac_ext_bus {
-       struct hdac_bus bus;
-       int num_streams;
-       int idx;
-
-       struct list_head hlink_list;
-
-       struct mutex lock;
-       bool cmd_dma_state;
-};
-
-int snd_hdac_ext_bus_init(struct hdac_ext_bus *sbus, struct device *dev,
+int snd_hdac_ext_bus_init(struct hdac_bus *bus, struct device *dev,
                      const struct hdac_bus_ops *ops,
-                     const struct hdac_io_ops *io_ops);
+                     const struct hdac_io_ops *io_ops,
+                     const struct hdac_ext_bus_ops *ext_ops);
 
-void snd_hdac_ext_bus_exit(struct hdac_ext_bus *sbus);
-int snd_hdac_ext_bus_device_init(struct hdac_ext_bus *sbus, int addr);
+void snd_hdac_ext_bus_exit(struct hdac_bus *bus);
+int snd_hdac_ext_bus_device_init(struct hdac_bus *bus, int addr,
+                                               struct hdac_device *hdev);
 void snd_hdac_ext_bus_device_exit(struct hdac_device *hdev);
-void snd_hdac_ext_bus_device_remove(struct hdac_ext_bus *ebus);
-
-#define ebus_to_hbus(ebus)     (&(ebus)->bus)
-#define hbus_to_ebus(_bus) \
-       container_of(_bus, struct hdac_ext_bus, bus)
+void snd_hdac_ext_bus_device_remove(struct hdac_bus *bus);
 
 #define HDA_CODEC_REV_EXT_ENTRY(_vid, _rev, _name, drv_data) \
        { .vendor_id = (_vid), .rev_id = (_rev), .name = (_name), \
@@ -44,14 +22,14 @@ void snd_hdac_ext_bus_device_remove(struct hdac_ext_bus *ebus);
 #define HDA_CODEC_EXT_ENTRY(_vid, _revid, _name, _drv_data) \
        HDA_CODEC_REV_EXT_ENTRY(_vid, _revid, _name, _drv_data)
 
-void snd_hdac_ext_bus_ppcap_enable(struct hdac_ext_bus *chip, bool enable);
-void snd_hdac_ext_bus_ppcap_int_enable(struct hdac_ext_bus *chip, bool enable);
+void snd_hdac_ext_bus_ppcap_enable(struct hdac_bus *chip, bool enable);
+void snd_hdac_ext_bus_ppcap_int_enable(struct hdac_bus *chip, bool enable);
 
-void snd_hdac_ext_stream_spbcap_enable(struct hdac_ext_bus *chip,
+void snd_hdac_ext_stream_spbcap_enable(struct hdac_bus *chip,
                                 bool enable, int index);
 
-int snd_hdac_ext_bus_get_ml_capabilities(struct hdac_ext_bus *bus);
-struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_ext_bus *bus,
+int snd_hdac_ext_bus_get_ml_capabilities(struct hdac_bus *bus);
+struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_bus *bus,
                                                const char *codec_name);
 
 enum hdac_ext_stream_type {
@@ -100,28 +78,28 @@ struct hdac_ext_stream {
 #define stream_to_hdac_ext_stream(s) \
        container_of(s, struct hdac_ext_stream, hstream)
 
-void snd_hdac_ext_stream_init(struct hdac_ext_bus *bus,
+void snd_hdac_ext_stream_init(struct hdac_bus *bus,
                                struct hdac_ext_stream *stream, int idx,
                                int direction, int tag);
-int snd_hdac_ext_stream_init_all(struct hdac_ext_bus *ebus, int start_idx,
+int snd_hdac_ext_stream_init_all(struct hdac_bus *bus, int start_idx,
                int num_stream, int dir);
-void snd_hdac_stream_free_all(struct hdac_ext_bus *ebus);
-void snd_hdac_link_free_all(struct hdac_ext_bus *ebus);
-struct hdac_ext_stream *snd_hdac_ext_stream_assign(struct hdac_ext_bus *bus,
+void snd_hdac_stream_free_all(struct hdac_bus *bus);
+void snd_hdac_link_free_all(struct hdac_bus *bus);
+struct hdac_ext_stream *snd_hdac_ext_stream_assign(struct hdac_bus *bus,
                                           struct snd_pcm_substream *substream,
                                           int type);
 void snd_hdac_ext_stream_release(struct hdac_ext_stream *azx_dev, int type);
-void snd_hdac_ext_stream_decouple(struct hdac_ext_bus *bus,
+void snd_hdac_ext_stream_decouple(struct hdac_bus *bus,
                                struct hdac_ext_stream *azx_dev, bool decouple);
-void snd_hdac_ext_stop_streams(struct hdac_ext_bus *sbus);
+void snd_hdac_ext_stop_streams(struct hdac_bus *bus);
 
-int snd_hdac_ext_stream_set_spib(struct hdac_ext_bus *ebus,
+int snd_hdac_ext_stream_set_spib(struct hdac_bus *bus,
                                 struct hdac_ext_stream *stream, u32 value);
-int snd_hdac_ext_stream_get_spbmaxfifo(struct hdac_ext_bus *ebus,
+int snd_hdac_ext_stream_get_spbmaxfifo(struct hdac_bus *bus,
                                 struct hdac_ext_stream *stream);
-void snd_hdac_ext_stream_drsm_enable(struct hdac_ext_bus *ebus,
+void snd_hdac_ext_stream_drsm_enable(struct hdac_bus *bus,
                                bool enable, int index);
-int snd_hdac_ext_stream_set_dpibr(struct hdac_ext_bus *ebus,
+int snd_hdac_ext_stream_set_dpibr(struct hdac_bus *bus,
                                struct hdac_ext_stream *stream, u32 value);
 int snd_hdac_ext_stream_set_lpib(struct hdac_ext_stream *stream, u32 value);
 
@@ -144,17 +122,15 @@ struct hdac_ext_link {
 
 int snd_hdac_ext_bus_link_power_up(struct hdac_ext_link *link);
 int snd_hdac_ext_bus_link_power_down(struct hdac_ext_link *link);
-int snd_hdac_ext_bus_link_power_up_all(struct hdac_ext_bus *ebus);
-int snd_hdac_ext_bus_link_power_down_all(struct hdac_ext_bus *ebus);
+int snd_hdac_ext_bus_link_power_up_all(struct hdac_bus *bus);
+int snd_hdac_ext_bus_link_power_down_all(struct hdac_bus *bus);
 void snd_hdac_ext_link_set_stream_id(struct hdac_ext_link *link,
                                 int stream);
 void snd_hdac_ext_link_clear_stream_id(struct hdac_ext_link *link,
                                 int stream);
 
-int snd_hdac_ext_bus_link_get(struct hdac_ext_bus *ebus,
-                               struct hdac_ext_link *link);
-int snd_hdac_ext_bus_link_put(struct hdac_ext_bus *ebus,
-                               struct hdac_ext_link *link);
+int snd_hdac_ext_bus_link_get(struct hdac_bus *bus, struct hdac_ext_link *link);
+int snd_hdac_ext_bus_link_put(struct hdac_bus *bus, struct hdac_ext_link *link);
 
 /* update register macro */
 #define snd_hdac_updatel(addr, reg, mask, val)         \
@@ -181,53 +157,12 @@ struct hda_dai_map {
        u32     maxbps;
 };
 
-#define HDA_MAX_NIDS 16
-
-/**
- * struct hdac_ext_device - HDAC Ext device
- *
- * @hdac: hdac core device
- * @nid_list - the dai map which matches the dai-name with the nid
- * @map_cur_idx - the idx in use in dai_map
- * @ops - the hda codec ops common to all codec drivers
- * @pvt_data - private data, for asoc contains asoc codec object
- */
-struct hdac_ext_device {
-       struct hdac_device hdev;
-       struct hdac_ext_bus *ebus;
-
-       /* soc-dai to nid map */
-       struct hda_dai_map nid_list[HDA_MAX_NIDS];
-       unsigned int map_cur_idx;
-
-       /* codec ops */
-       struct hdac_ext_codec_ops ops;
-
-       struct snd_card *card;
-       void *scodec;
-       void *private_data;
-};
-
 struct hdac_ext_dma_params {
        u32 format;
        u8 stream_tag;
 };
-#define to_ehdac_device(dev) (container_of((dev), \
-                                struct hdac_ext_device, hdev))
-/*
- * HD-audio codec base driver
- */
-struct hdac_ext_driver {
-       struct hdac_driver hdac;
-
-       int     (*probe)(struct hdac_ext_device *dev);
-       int     (*remove)(struct hdac_ext_device *dev);
-       void    (*shutdown)(struct hdac_ext_device *dev);
-};
-
-int snd_hda_ext_driver_register(struct hdac_ext_driver *drv);
-void snd_hda_ext_driver_unregister(struct hdac_ext_driver *drv);
 
-#define to_ehdac_driver(_drv) container_of(_drv, struct hdac_ext_driver, hdac)
+int snd_hda_ext_driver_register(struct hdac_driver *drv);
+void snd_hda_ext_driver_unregister(struct hdac_driver *drv);
 
 #endif /* __SOUND_HDAUDIO_EXT_H */
index 61a07fe34cd271e60dc0c31a7dddae750c2532b1..56ca78423040f09e6d0569b651ba631105b8bd02 100644 (file)
@@ -2004,7 +2004,8 @@ static int snd_seq_ioctl_query_next_client(struct snd_seq_client *client,
        struct snd_seq_client *cptr = NULL;
 
        /* search for next client */
-       info->client++;
+       if (info->client < INT_MAX)
+               info->client++;
        if (info->client < 0)
                info->client = 0;
        for (; info->client < SNDRV_SEQ_MAX_CLIENTS; info->client++) {
index 665089c455603c0c683144c419981f8215780e85..b6f076bbc72d14be37893e20b19cbfaedf2f728b 100644 (file)
@@ -1520,7 +1520,7 @@ static int snd_timer_user_next_device(struct snd_timer_id __user *_tid)
                                } else {
                                        if (id.subdevice < 0)
                                                id.subdevice = 0;
-                                       else
+                                       else if (id.subdevice < INT_MAX)
                                                id.subdevice++;
                                }
                        }
index 3129546398d0c20a27652ec4373281b1d0299dc1..2d90e11b3eaa2355621947d7e330dde12df014d6 100644 (file)
@@ -5,11 +5,12 @@ config SND_HDA_CORE
 config SND_HDA_DSP_LOADER
        bool
 
+config SND_HDA_COMPONENT
+       bool
+
 config SND_HDA_I915
        bool
-       default y
-       depends on DRM_I915
-       depends on SND_HDA_CORE
+       select SND_HDA_COMPONENT
 
 config SND_HDA_EXT_CORE
        tristate
index e4e726f2ce98b69a75ed81f38293bf7ad65f1749..2160202e2dc1b86e37874fa5e1e943fd3687130f 100644 (file)
@@ -6,6 +6,7 @@ snd-hda-core-objs += trace.o
 CFLAGS_trace.o := -I$(src)
 
 # for sync with i915 gfx driver
+snd-hda-core-$(CONFIG_SND_HDA_COMPONENT) += hdac_component.o
 snd-hda-core-$(CONFIG_SND_HDA_I915) += hdac_i915.o
 
 obj-$(CONFIG_SND_HDA_CORE) += snd-hda-core.o
index 0daf31383084d22a85553970b9480a4287515d5b..9c37d9af3023f67bdba2ba4a3d207580cd1f70c5 100644 (file)
@@ -87,9 +87,10 @@ static const struct hdac_io_ops hdac_ext_default_io = {
  *
  * Returns 0 if successful, or a negative error code.
  */
-int snd_hdac_ext_bus_init(struct hdac_ext_bus *ebus, struct device *dev,
+int snd_hdac_ext_bus_init(struct hdac_bus *bus, struct device *dev,
                        const struct hdac_bus_ops *ops,
-                       const struct hdac_io_ops *io_ops)
+                       const struct hdac_io_ops *io_ops,
+                       const struct hdac_ext_bus_ops *ext_ops)
 {
        int ret;
        static int idx;
@@ -98,15 +99,16 @@ int snd_hdac_ext_bus_init(struct hdac_ext_bus *ebus, struct device *dev,
        if (io_ops == NULL)
                io_ops = &hdac_ext_default_io;
 
-       ret = snd_hdac_bus_init(&ebus->bus, dev, ops, io_ops);
+       ret = snd_hdac_bus_init(bus, dev, ops, io_ops);
        if (ret < 0)
                return ret;
 
-       INIT_LIST_HEAD(&ebus->hlink_list);
-       ebus->idx = idx++;
+       bus->ext_ops = ext_ops;
+       INIT_LIST_HEAD(&bus->hlink_list);
+       bus->idx = idx++;
 
-       mutex_init(&ebus->lock);
-       ebus->cmd_dma_state = true;
+       mutex_init(&bus->lock);
+       bus->cmd_dma_state = true;
 
        return 0;
 }
@@ -116,10 +118,10 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_init);
  * snd_hdac_ext_bus_exit - clean up a HD-audio extended bus
  * @ebus: the pointer to extended bus object
  */
-void snd_hdac_ext_bus_exit(struct hdac_ext_bus *ebus)
+void snd_hdac_ext_bus_exit(struct hdac_bus *bus)
 {
-       snd_hdac_bus_exit(&ebus->bus);
-       WARN_ON(!list_empty(&ebus->hlink_list));
+       snd_hdac_bus_exit(bus);
+       WARN_ON(!list_empty(&bus->hlink_list));
 }
 EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_exit);
 
@@ -135,21 +137,15 @@ static void default_release(struct device *dev)
  *
  * Returns zero for success or a negative error code.
  */
-int snd_hdac_ext_bus_device_init(struct hdac_ext_bus *ebus, int addr)
+int snd_hdac_ext_bus_device_init(struct hdac_bus *bus, int addr,
+                                       struct hdac_device *hdev)
 {
-       struct hdac_ext_device *edev;
-       struct hdac_device *hdev = NULL;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
        char name[15];
        int ret;
 
-       edev = kzalloc(sizeof(*edev), GFP_KERNEL);
-       if (!edev)
-               return -ENOMEM;
-       hdev = &edev->hdev;
-       edev->ebus = ebus;
+       hdev->bus = bus;
 
-       snprintf(name, sizeof(name), "ehdaudio%dD%d", ebus->idx, addr);
+       snprintf(name, sizeof(name), "ehdaudio%dD%d", bus->idx, addr);
 
        ret  = snd_hdac_device_init(hdev, bus, name, addr);
        if (ret < 0) {
@@ -176,10 +172,8 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_device_init);
  */
 void snd_hdac_ext_bus_device_exit(struct hdac_device *hdev)
 {
-       struct hdac_ext_device *edev = to_ehdac_device(hdev);
-
        snd_hdac_device_exit(hdev);
-       kfree(edev);
+       kfree(hdev);
 }
 EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_device_exit);
 
@@ -188,14 +182,14 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_device_exit);
  *
  * @ebus: HD-audio extended bus
  */
-void snd_hdac_ext_bus_device_remove(struct hdac_ext_bus *ebus)
+void snd_hdac_ext_bus_device_remove(struct hdac_bus *bus)
 {
        struct hdac_device *codec, *__codec;
        /*
         * we need to remove all the codec devices objects created in the
         * snd_hdac_ext_bus_device_init
         */
-       list_for_each_entry_safe(codec, __codec, &ebus->bus.codec_list, list) {
+       list_for_each_entry_safe(codec, __codec, &bus->codec_list, list) {
                snd_hdac_device_unregister(codec);
                put_device(&codec->dev);
        }
@@ -204,35 +198,31 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_device_remove);
 #define dev_to_hdac(dev) (container_of((dev), \
                        struct hdac_device, dev))
 
-static inline struct hdac_ext_driver *get_edrv(struct device *dev)
+static inline struct hdac_driver *get_hdrv(struct device *dev)
 {
        struct hdac_driver *hdrv = drv_to_hdac_driver(dev->driver);
-       struct hdac_ext_driver *edrv = to_ehdac_driver(hdrv);
-
-       return edrv;
+       return hdrv;
 }
 
-static inline struct hdac_ext_device *get_edev(struct device *dev)
+static inline struct hdac_device *get_hdev(struct device *dev)
 {
        struct hdac_device *hdev = dev_to_hdac_dev(dev);
-       struct hdac_ext_device *edev = to_ehdac_device(hdev);
-
-       return edev;
+       return hdev;
 }
 
 static int hda_ext_drv_probe(struct device *dev)
 {
-       return (get_edrv(dev))->probe(get_edev(dev));
+       return (get_hdrv(dev))->probe(get_hdev(dev));
 }
 
 static int hdac_ext_drv_remove(struct device *dev)
 {
-       return (get_edrv(dev))->remove(get_edev(dev));
+       return (get_hdrv(dev))->remove(get_hdev(dev));
 }
 
 static void hdac_ext_drv_shutdown(struct device *dev)
 {
-       return (get_edrv(dev))->shutdown(get_edev(dev));
+       return (get_hdrv(dev))->shutdown(get_hdev(dev));
 }
 
 /**
@@ -240,20 +230,20 @@ static void hdac_ext_drv_shutdown(struct device *dev)
  *
  * @drv: ext hda driver structure
  */
-int snd_hda_ext_driver_register(struct hdac_ext_driver *drv)
+int snd_hda_ext_driver_register(struct hdac_driver *drv)
 {
-       drv->hdac.type = HDA_DEV_ASOC;
-       drv->hdac.driver.bus = &snd_hda_bus_type;
+       drv->type = HDA_DEV_ASOC;
+       drv->driver.bus = &snd_hda_bus_type;
        /* we use default match */
 
        if (drv->probe)
-               drv->hdac.driver.probe = hda_ext_drv_probe;
+               drv->driver.probe = hda_ext_drv_probe;
        if (drv->remove)
-               drv->hdac.driver.remove = hdac_ext_drv_remove;
+               drv->driver.remove = hdac_ext_drv_remove;
        if (drv->shutdown)
-               drv->hdac.driver.shutdown = hdac_ext_drv_shutdown;
+               drv->driver.shutdown = hdac_ext_drv_shutdown;
 
-       return driver_register(&drv->hdac.driver);
+       return driver_register(&drv->driver);
 }
 EXPORT_SYMBOL_GPL(snd_hda_ext_driver_register);
 
@@ -262,8 +252,8 @@ EXPORT_SYMBOL_GPL(snd_hda_ext_driver_register);
  *
  * @drv: ext hda driver structure
  */
-void snd_hda_ext_driver_unregister(struct hdac_ext_driver *drv)
+void snd_hda_ext_driver_unregister(struct hdac_driver *drv)
 {
-       driver_unregister(&drv->hdac.driver);
+       driver_unregister(&drv->driver);
 }
 EXPORT_SYMBOL_GPL(snd_hda_ext_driver_unregister);
index 84f3b81687164d419b4cff063011d774790273f3..5bc4a1d587d4f13121ca82433aeafa4b6594576c 100644 (file)
@@ -39,9 +39,8 @@
  * @ebus: HD-audio extended core bus
  * @enable: flag to turn on/off the capability
  */
-void snd_hdac_ext_bus_ppcap_enable(struct hdac_ext_bus *ebus, bool enable)
+void snd_hdac_ext_bus_ppcap_enable(struct hdac_bus *bus, bool enable)
 {
-       struct hdac_bus *bus = &ebus->bus;
 
        if (!bus->ppcap) {
                dev_err(bus->dev, "Address of PP capability is NULL");
@@ -60,9 +59,8 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_ppcap_enable);
  * @ebus: HD-audio extended core bus
  * @enable: flag to enable/disable interrupt
  */
-void snd_hdac_ext_bus_ppcap_int_enable(struct hdac_ext_bus *ebus, bool enable)
+void snd_hdac_ext_bus_ppcap_int_enable(struct hdac_bus *bus, bool enable)
 {
-       struct hdac_bus *bus = &ebus->bus;
 
        if (!bus->ppcap) {
                dev_err(bus->dev, "Address of PP capability is NULL\n");
@@ -89,12 +87,11 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_ppcap_int_enable);
  * in hlink_list of extended hdac bus
  * Note: this will be freed on bus exit by driver
  */
-int snd_hdac_ext_bus_get_ml_capabilities(struct hdac_ext_bus *ebus)
+int snd_hdac_ext_bus_get_ml_capabilities(struct hdac_bus *bus)
 {
        int idx;
        u32 link_count;
        struct hdac_ext_link *hlink;
-       struct hdac_bus *bus = &ebus->bus;
 
        link_count = readl(bus->mlcap + AZX_REG_ML_MLCD) + 1;
 
@@ -114,7 +111,7 @@ int snd_hdac_ext_bus_get_ml_capabilities(struct hdac_ext_bus *ebus)
                /* since link in On, update the ref */
                hlink->ref_count = 1;
 
-               list_add_tail(&hlink->list, &ebus->hlink_list);
+               list_add_tail(&hlink->list, &bus->hlink_list);
        }
 
        return 0;
@@ -127,12 +124,12 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_get_ml_capabilities);
  * @ebus: HD-audio ext core bus
  */
 
-void snd_hdac_link_free_all(struct hdac_ext_bus *ebus)
+void snd_hdac_link_free_all(struct hdac_bus *bus)
 {
        struct hdac_ext_link *l;
 
-       while (!list_empty(&ebus->hlink_list)) {
-               l = list_first_entry(&ebus->hlink_list, struct hdac_ext_link, list);
+       while (!list_empty(&bus->hlink_list)) {
+               l = list_first_entry(&bus->hlink_list, struct hdac_ext_link, list);
                list_del(&l->list);
                kfree(l);
        }
@@ -144,7 +141,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_link_free_all);
  * @ebus: HD-audio extended core bus
  * @codec_name: codec name
  */
-struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_ext_bus *ebus,
+struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_bus *bus,
                                                 const char *codec_name)
 {
        int i;
@@ -153,10 +150,10 @@ struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_ext_bus *ebus,
 
        if (sscanf(codec_name, "ehdaudio%dD%d", &bus_idx, &addr) != 2)
                return NULL;
-       if (ebus->idx != bus_idx)
+       if (bus->idx != bus_idx)
                return NULL;
 
-       list_for_each_entry(hlink, &ebus->hlink_list, list) {
+       list_for_each_entry(hlink, &bus->hlink_list, list) {
                for (i = 0; i < HDA_MAX_CODECS; i++) {
                        if (hlink->lsdiid & (0x1 << addr))
                                return hlink;
@@ -219,12 +216,12 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_link_power_down);
  * snd_hdac_ext_bus_link_power_up_all -power up all hda link
  * @ebus: HD-audio extended bus
  */
-int snd_hdac_ext_bus_link_power_up_all(struct hdac_ext_bus *ebus)
+int snd_hdac_ext_bus_link_power_up_all(struct hdac_bus *bus)
 {
        struct hdac_ext_link *hlink = NULL;
        int ret;
 
-       list_for_each_entry(hlink, &ebus->hlink_list, list) {
+       list_for_each_entry(hlink, &bus->hlink_list, list) {
                snd_hdac_updatel(hlink->ml_addr,
                                AZX_REG_ML_LCTL, 0, AZX_MLCTL_SPA);
                ret = check_hdac_link_power_active(hlink, true);
@@ -240,12 +237,12 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_link_power_up_all);
  * snd_hdac_ext_bus_link_power_down_all -power down all hda link
  * @ebus: HD-audio extended bus
  */
-int snd_hdac_ext_bus_link_power_down_all(struct hdac_ext_bus *ebus)
+int snd_hdac_ext_bus_link_power_down_all(struct hdac_bus *bus)
 {
        struct hdac_ext_link *hlink = NULL;
        int ret;
 
-       list_for_each_entry(hlink, &ebus->hlink_list, list) {
+       list_for_each_entry(hlink, &bus->hlink_list, list) {
                snd_hdac_updatel(hlink->ml_addr, AZX_REG_ML_LCTL, AZX_MLCTL_SPA, 0);
                ret = check_hdac_link_power_active(hlink, false);
                if (ret < 0)
@@ -256,39 +253,48 @@ int snd_hdac_ext_bus_link_power_down_all(struct hdac_ext_bus *ebus)
 }
 EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_link_power_down_all);
 
-int snd_hdac_ext_bus_link_get(struct hdac_ext_bus *ebus,
+int snd_hdac_ext_bus_link_get(struct hdac_bus *bus,
                                struct hdac_ext_link *link)
 {
        int ret = 0;
 
-       mutex_lock(&ebus->lock);
+       mutex_lock(&bus->lock);
 
        /*
         * if we move from 0 to 1, count will be 1 so power up this link
         * as well, also check the dma status and trigger that
         */
        if (++link->ref_count == 1) {
-               if (!ebus->cmd_dma_state) {
-                       snd_hdac_bus_init_cmd_io(&ebus->bus);
-                       ebus->cmd_dma_state = true;
+               if (!bus->cmd_dma_state) {
+                       snd_hdac_bus_init_cmd_io(bus);
+                       bus->cmd_dma_state = true;
                }
 
                ret = snd_hdac_ext_bus_link_power_up(link);
+
+               /*
+                *  wait for 521usec for codec to report status
+                *  HDA spec section 4.3 - Codec Discovery
+                */
+               udelay(521);
+               bus->codec_mask = snd_hdac_chip_readw(bus, STATESTS);
+               dev_dbg(bus->dev, "codec_mask = 0x%lx\n", bus->codec_mask);
+               snd_hdac_chip_writew(bus, STATESTS, bus->codec_mask);
        }
 
-       mutex_unlock(&ebus->lock);
+       mutex_unlock(&bus->lock);
        return ret;
 }
 EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_link_get);
 
-int snd_hdac_ext_bus_link_put(struct hdac_ext_bus *ebus,
+int snd_hdac_ext_bus_link_put(struct hdac_bus *bus,
                                struct hdac_ext_link *link)
 {
        int ret = 0;
        struct hdac_ext_link *hlink;
        bool link_up = false;
 
-       mutex_lock(&ebus->lock);
+       mutex_lock(&bus->lock);
 
        /*
         * if we move from 1 to 0, count will be 0
@@ -301,7 +307,7 @@ int snd_hdac_ext_bus_link_put(struct hdac_ext_bus *ebus,
                 * now check if all links are off, if so turn off
                 * cmd dma as well
                 */
-               list_for_each_entry(hlink, &ebus->hlink_list, list) {
+               list_for_each_entry(hlink, &bus->hlink_list, list) {
                        if (hlink->ref_count) {
                                link_up = true;
                                break;
@@ -309,12 +315,12 @@ int snd_hdac_ext_bus_link_put(struct hdac_ext_bus *ebus,
                }
 
                if (!link_up) {
-                       snd_hdac_bus_stop_cmd_io(&ebus->bus);
-                       ebus->cmd_dma_state = false;
+                       snd_hdac_bus_stop_cmd_io(bus);
+                       bus->cmd_dma_state = false;
                }
        }
 
-       mutex_unlock(&ebus->lock);
+       mutex_unlock(&bus->lock);
        return ret;
 }
 EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_link_put);
index c96d7a7a36af033b0c8241e20538e7722828bc0e..1bd27576db98d50cc12382c209c3938fe9fe5e14 100644 (file)
@@ -25,7 +25,7 @@
 
 /**
  * snd_hdac_ext_stream_init - initialize each stream (aka device)
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @stream: HD-audio ext core stream object to initialize
  * @idx: stream index number
  * @direction: stream direction (SNDRV_PCM_STREAM_PLAYBACK or SNDRV_PCM_STREAM_CAPTURE)
  * initialize the stream, if ppcap is enabled then init those and then
  * invoke hdac stream initialization routine
  */
-void snd_hdac_ext_stream_init(struct hdac_ext_bus *ebus,
+void snd_hdac_ext_stream_init(struct hdac_bus *bus,
                                struct hdac_ext_stream *stream,
                                int idx, int direction, int tag)
 {
-       struct hdac_bus *bus = &ebus->bus;
-
        if (bus->ppcap) {
                stream->pphc_addr = bus->ppcap + AZX_PPHC_BASE +
                                AZX_PPHC_INTERVAL * idx;
 
                stream->pplc_addr = bus->ppcap + AZX_PPLC_BASE +
-                               AZX_PPLC_MULTI * ebus->num_streams +
+                               AZX_PPLC_MULTI * bus->num_streams +
                                AZX_PPLC_INTERVAL * idx;
        }
 
@@ -71,12 +69,12 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_init);
 /**
  * snd_hdac_ext_stream_init_all - create and initialize the stream objects
  *   for an extended hda bus
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @start_idx: start index for streams
  * @num_stream: number of streams to initialize
  * @dir: direction of streams
  */
-int snd_hdac_ext_stream_init_all(struct hdac_ext_bus *ebus, int start_idx,
+int snd_hdac_ext_stream_init_all(struct hdac_bus *bus, int start_idx,
                int num_stream, int dir)
 {
        int stream_tag = 0;
@@ -88,7 +86,7 @@ int snd_hdac_ext_stream_init_all(struct hdac_ext_bus *ebus, int start_idx,
                if (!stream)
                        return -ENOMEM;
                tag = ++stream_tag;
-               snd_hdac_ext_stream_init(ebus, stream, idx, dir, tag);
+               snd_hdac_ext_stream_init(bus, stream, idx, dir, tag);
                idx++;
        }
 
@@ -100,17 +98,16 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_init_all);
 /**
  * snd_hdac_stream_free_all - free hdac extended stream objects
  *
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  */
-void snd_hdac_stream_free_all(struct hdac_ext_bus *ebus)
+void snd_hdac_stream_free_all(struct hdac_bus *bus)
 {
        struct hdac_stream *s, *_s;
        struct hdac_ext_stream *stream;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
 
        list_for_each_entry_safe(s, _s, &bus->stream_list, list) {
                stream = stream_to_hdac_ext_stream(s);
-               snd_hdac_ext_stream_decouple(ebus, stream, false);
+               snd_hdac_ext_stream_decouple(bus, stream, false);
                list_del(&s->list);
                kfree(stream);
        }
@@ -119,15 +116,14 @@ EXPORT_SYMBOL_GPL(snd_hdac_stream_free_all);
 
 /**
  * snd_hdac_ext_stream_decouple - decouple the hdac stream
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @stream: HD-audio ext core stream object to initialize
  * @decouple: flag to decouple
  */
-void snd_hdac_ext_stream_decouple(struct hdac_ext_bus *ebus,
+void snd_hdac_ext_stream_decouple(struct hdac_bus *bus,
                                struct hdac_ext_stream *stream, bool decouple)
 {
        struct hdac_stream *hstream = &stream->hstream;
-       struct hdac_bus *bus = &ebus->bus;
        u32 val;
        int mask = AZX_PPCTL_PROCEN(hstream->index);
 
@@ -251,19 +247,18 @@ void snd_hdac_ext_link_clear_stream_id(struct hdac_ext_link *link,
 EXPORT_SYMBOL_GPL(snd_hdac_ext_link_clear_stream_id);
 
 static struct hdac_ext_stream *
-hdac_ext_link_stream_assign(struct hdac_ext_bus *ebus,
+hdac_ext_link_stream_assign(struct hdac_bus *bus,
                                struct snd_pcm_substream *substream)
 {
        struct hdac_ext_stream *res = NULL;
        struct hdac_stream *stream = NULL;
-       struct hdac_bus *hbus = &ebus->bus;
 
-       if (!hbus->ppcap) {
-               dev_err(hbus->dev, "stream type not supported\n");
+       if (!bus->ppcap) {
+               dev_err(bus->dev, "stream type not supported\n");
                return NULL;
        }
 
-       list_for_each_entry(stream, &hbus->stream_list, list) {
+       list_for_each_entry(stream, &bus->stream_list, list) {
                struct hdac_ext_stream *hstream = container_of(stream,
                                                struct hdac_ext_stream,
                                                hstream);
@@ -277,34 +272,33 @@ hdac_ext_link_stream_assign(struct hdac_ext_bus *ebus,
                }
 
                if (!hstream->link_locked) {
-                       snd_hdac_ext_stream_decouple(ebus, hstream, true);
+                       snd_hdac_ext_stream_decouple(bus, hstream, true);
                        res = hstream;
                        break;
                }
        }
        if (res) {
-               spin_lock_irq(&hbus->reg_lock);
+               spin_lock_irq(&bus->reg_lock);
                res->link_locked = 1;
                res->link_substream = substream;
-               spin_unlock_irq(&hbus->reg_lock);
+               spin_unlock_irq(&bus->reg_lock);
        }
        return res;
 }
 
 static struct hdac_ext_stream *
-hdac_ext_host_stream_assign(struct hdac_ext_bus *ebus,
+hdac_ext_host_stream_assign(struct hdac_bus *bus,
                                struct snd_pcm_substream *substream)
 {
        struct hdac_ext_stream *res = NULL;
        struct hdac_stream *stream = NULL;
-       struct hdac_bus *hbus = &ebus->bus;
 
-       if (!hbus->ppcap) {
-               dev_err(hbus->dev, "stream type not supported\n");
+       if (!bus->ppcap) {
+               dev_err(bus->dev, "stream type not supported\n");
                return NULL;
        }
 
-       list_for_each_entry(stream, &hbus->stream_list, list) {
+       list_for_each_entry(stream, &bus->stream_list, list) {
                struct hdac_ext_stream *hstream = container_of(stream,
                                                struct hdac_ext_stream,
                                                hstream);
@@ -313,17 +307,17 @@ hdac_ext_host_stream_assign(struct hdac_ext_bus *ebus,
 
                if (!stream->opened) {
                        if (!hstream->decoupled)
-                               snd_hdac_ext_stream_decouple(ebus, hstream, true);
+                               snd_hdac_ext_stream_decouple(bus, hstream, true);
                        res = hstream;
                        break;
                }
        }
        if (res) {
-               spin_lock_irq(&hbus->reg_lock);
+               spin_lock_irq(&bus->reg_lock);
                res->hstream.opened = 1;
                res->hstream.running = 0;
                res->hstream.substream = substream;
-               spin_unlock_irq(&hbus->reg_lock);
+               spin_unlock_irq(&bus->reg_lock);
        }
 
        return res;
@@ -331,7 +325,7 @@ hdac_ext_host_stream_assign(struct hdac_ext_bus *ebus,
 
 /**
  * snd_hdac_ext_stream_assign - assign a stream for the PCM
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @substream: PCM substream to assign
  * @type: type of stream (coupled, host or link stream)
  *
@@ -346,27 +340,26 @@ hdac_ext_host_stream_assign(struct hdac_ext_bus *ebus,
  * the same stream object when it's used beforehand.  when a stream is
  * decoupled, it becomes a host stream and link stream.
  */
-struct hdac_ext_stream *snd_hdac_ext_stream_assign(struct hdac_ext_bus *ebus,
+struct hdac_ext_stream *snd_hdac_ext_stream_assign(struct hdac_bus *bus,
                                           struct snd_pcm_substream *substream,
                                           int type)
 {
        struct hdac_ext_stream *hstream = NULL;
        struct hdac_stream *stream = NULL;
-       struct hdac_bus *hbus = &ebus->bus;
 
        switch (type) {
        case HDAC_EXT_STREAM_TYPE_COUPLED:
-               stream = snd_hdac_stream_assign(hbus, substream);
+               stream = snd_hdac_stream_assign(bus, substream);
                if (stream)
                        hstream = container_of(stream,
                                        struct hdac_ext_stream, hstream);
                return hstream;
 
        case HDAC_EXT_STREAM_TYPE_HOST:
-               return hdac_ext_host_stream_assign(ebus, substream);
+               return hdac_ext_host_stream_assign(bus, substream);
 
        case HDAC_EXT_STREAM_TYPE_LINK:
-               return hdac_ext_link_stream_assign(ebus, substream);
+               return hdac_ext_link_stream_assign(bus, substream);
 
        default:
                return NULL;
@@ -384,7 +377,6 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_assign);
 void snd_hdac_ext_stream_release(struct hdac_ext_stream *stream, int type)
 {
        struct hdac_bus *bus = stream->hstream.bus;
-       struct hdac_ext_bus *ebus = hbus_to_ebus(bus);
 
        switch (type) {
        case HDAC_EXT_STREAM_TYPE_COUPLED:
@@ -393,13 +385,13 @@ void snd_hdac_ext_stream_release(struct hdac_ext_stream *stream, int type)
 
        case HDAC_EXT_STREAM_TYPE_HOST:
                if (stream->decoupled && !stream->link_locked)
-                       snd_hdac_ext_stream_decouple(ebus, stream, false);
+                       snd_hdac_ext_stream_decouple(bus, stream, false);
                snd_hdac_stream_release(&stream->hstream);
                break;
 
        case HDAC_EXT_STREAM_TYPE_LINK:
                if (stream->decoupled && !stream->hstream.opened)
-                       snd_hdac_ext_stream_decouple(ebus, stream, false);
+                       snd_hdac_ext_stream_decouple(bus, stream, false);
                spin_lock_irq(&bus->reg_lock);
                stream->link_locked = 0;
                stream->link_substream = NULL;
@@ -415,16 +407,15 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_release);
 
 /**
  * snd_hdac_ext_stream_spbcap_enable - enable SPIB for a stream
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @enable: flag to enable/disable SPIB
  * @index: stream index for which SPIB need to be enabled
  */
-void snd_hdac_ext_stream_spbcap_enable(struct hdac_ext_bus *ebus,
+void snd_hdac_ext_stream_spbcap_enable(struct hdac_bus *bus,
                                 bool enable, int index)
 {
        u32 mask = 0;
        u32 register_mask = 0;
-       struct hdac_bus *bus = &ebus->bus;
 
        if (!bus->spbcap) {
                dev_err(bus->dev, "Address of SPB capability is NULL\n");
@@ -446,14 +437,13 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_spbcap_enable);
 
 /**
  * snd_hdac_ext_stream_set_spib - sets the spib value of a stream
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @stream: hdac_ext_stream
  * @value: spib value to set
  */
-int snd_hdac_ext_stream_set_spib(struct hdac_ext_bus *ebus,
+int snd_hdac_ext_stream_set_spib(struct hdac_bus *bus,
                                 struct hdac_ext_stream *stream, u32 value)
 {
-       struct hdac_bus *bus = &ebus->bus;
 
        if (!bus->spbcap) {
                dev_err(bus->dev, "Address of SPB capability is NULL\n");
@@ -468,15 +458,14 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_set_spib);
 
 /**
  * snd_hdac_ext_stream_get_spbmaxfifo - gets the spib value of a stream
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @stream: hdac_ext_stream
  *
  * Return maxfifo for the stream
  */
-int snd_hdac_ext_stream_get_spbmaxfifo(struct hdac_ext_bus *ebus,
+int snd_hdac_ext_stream_get_spbmaxfifo(struct hdac_bus *bus,
                                 struct hdac_ext_stream *stream)
 {
-       struct hdac_bus *bus = &ebus->bus;
 
        if (!bus->spbcap) {
                dev_err(bus->dev, "Address of SPB capability is NULL\n");
@@ -490,11 +479,10 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_get_spbmaxfifo);
 
 /**
  * snd_hdac_ext_stop_streams - stop all stream if running
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  */
-void snd_hdac_ext_stop_streams(struct hdac_ext_bus *ebus)
+void snd_hdac_ext_stop_streams(struct hdac_bus *bus)
 {
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
        struct hdac_stream *stream;
 
        if (bus->chip_init) {
@@ -507,16 +495,15 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stop_streams);
 
 /**
  * snd_hdac_ext_stream_drsm_enable - enable DMA resume for a stream
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @enable: flag to enable/disable DRSM
  * @index: stream index for which DRSM need to be enabled
  */
-void snd_hdac_ext_stream_drsm_enable(struct hdac_ext_bus *ebus,
+void snd_hdac_ext_stream_drsm_enable(struct hdac_bus *bus,
                                bool enable, int index)
 {
        u32 mask = 0;
        u32 register_mask = 0;
-       struct hdac_bus *bus = &ebus->bus;
 
        if (!bus->drsmcap) {
                dev_err(bus->dev, "Address of DRSM capability is NULL\n");
@@ -538,14 +525,13 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_drsm_enable);
 
 /**
  * snd_hdac_ext_stream_set_dpibr - sets the dpibr value of a stream
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @stream: hdac_ext_stream
  * @value: dpib value to set
  */
-int snd_hdac_ext_stream_set_dpibr(struct hdac_ext_bus *ebus,
+int snd_hdac_ext_stream_set_dpibr(struct hdac_bus *bus,
                                 struct hdac_ext_stream *stream, u32 value)
 {
-       struct hdac_bus *bus = &ebus->bus;
 
        if (!bus->drsmcap) {
                dev_err(bus->dev, "Address of DRSM capability is NULL\n");
@@ -560,7 +546,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_set_dpibr);
 
 /**
  * snd_hdac_ext_stream_set_lpib - sets the lpib value of a stream
- * @ebus: HD-audio ext core bus
+ * @bus: HD-audio core bus
  * @stream: hdac_ext_stream
  * @value: lpib value to set
  */
diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c
new file mode 100644 (file)
index 0000000..6e46a9c
--- /dev/null
@@ -0,0 +1,335 @@
+// SPDX-License-Identifier: GPL-2.0
+// hdac_component.c - routines for sync between HD-A core and DRM driver
+
+#include <linux/init.h>
+#include <linux/module.h>
+#include <linux/pci.h>
+#include <linux/component.h>
+#include <sound/core.h>
+#include <sound/hdaudio.h>
+#include <sound/hda_component.h>
+#include <sound/hda_register.h>
+
+static void hdac_acomp_release(struct device *dev, void *res)
+{
+}
+
+static struct drm_audio_component *hdac_get_acomp(struct device *dev)
+{
+       return devres_find(dev, hdac_acomp_release, NULL, NULL);
+}
+
+/**
+ * snd_hdac_set_codec_wakeup - Enable / disable HDMI/DP codec wakeup
+ * @bus: HDA core bus
+ * @enable: enable or disable the wakeup
+ *
+ * This function is supposed to be used only by a HD-audio controller
+ * driver that needs the interaction with graphics driver.
+ *
+ * This function should be called during the chip reset, also called at
+ * resume for updating STATESTS register read.
+ *
+ * Returns zero for success or a negative error code.
+ */
+int snd_hdac_set_codec_wakeup(struct hdac_bus *bus, bool enable)
+{
+       struct drm_audio_component *acomp = bus->audio_component;
+
+       if (!acomp || !acomp->ops)
+               return -ENODEV;
+
+       if (!acomp->ops->codec_wake_override)
+               return 0;
+
+       dev_dbg(bus->dev, "%s codec wakeup\n",
+               enable ? "enable" : "disable");
+
+       acomp->ops->codec_wake_override(acomp->dev, enable);
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(snd_hdac_set_codec_wakeup);
+
+/**
+ * snd_hdac_display_power - Power up / down the power refcount
+ * @bus: HDA core bus
+ * @enable: power up or down
+ *
+ * This function is supposed to be used only by a HD-audio controller
+ * driver that needs the interaction with graphics driver.
+ *
+ * This function manages a refcount and calls the get_power() and
+ * put_power() ops accordingly, toggling the codec wakeup, too.
+ *
+ * Returns zero for success or a negative error code.
+ */
+int snd_hdac_display_power(struct hdac_bus *bus, bool enable)
+{
+       struct drm_audio_component *acomp = bus->audio_component;
+
+       if (!acomp || !acomp->ops)
+               return -ENODEV;
+
+       dev_dbg(bus->dev, "display power %s\n",
+               enable ? "enable" : "disable");
+
+       if (enable) {
+               if (!bus->drm_power_refcount++) {
+                       if (acomp->ops->get_power)
+                               acomp->ops->get_power(acomp->dev);
+                       snd_hdac_set_codec_wakeup(bus, true);
+                       snd_hdac_set_codec_wakeup(bus, false);
+               }
+       } else {
+               WARN_ON(!bus->drm_power_refcount);
+               if (!--bus->drm_power_refcount)
+                       if (acomp->ops->put_power)
+                               acomp->ops->put_power(acomp->dev);
+       }
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(snd_hdac_display_power);
+
+/**
+ * snd_hdac_sync_audio_rate - Set N/CTS based on the sample rate
+ * @codec: HDA codec
+ * @nid: the pin widget NID
+ * @dev_id: device identifier
+ * @rate: the sample rate to set
+ *
+ * This function is supposed to be used only by a HD-audio controller
+ * driver that needs the interaction with graphics driver.
+ *
+ * This function sets N/CTS value based on the given sample rate.
+ * Returns zero for success, or a negative error code.
+ */
+int snd_hdac_sync_audio_rate(struct hdac_device *codec, hda_nid_t nid,
+                            int dev_id, int rate)
+{
+       struct hdac_bus *bus = codec->bus;
+       struct drm_audio_component *acomp = bus->audio_component;
+       int port, pipe;
+
+       if (!acomp || !acomp->ops || !acomp->ops->sync_audio_rate)
+               return -ENODEV;
+       port = nid;
+       if (acomp->audio_ops && acomp->audio_ops->pin2port) {
+               port = acomp->audio_ops->pin2port(codec, nid);
+               if (port < 0)
+                       return -EINVAL;
+       }
+       pipe = dev_id;
+       return acomp->ops->sync_audio_rate(acomp->dev, port, pipe, rate);
+}
+EXPORT_SYMBOL_GPL(snd_hdac_sync_audio_rate);
+
+/**
+ * snd_hdac_acomp_get_eld - Get the audio state and ELD via component
+ * @codec: HDA codec
+ * @nid: the pin widget NID
+ * @dev_id: device identifier
+ * @audio_enabled: the pointer to store the current audio state
+ * @buffer: the buffer pointer to store ELD bytes
+ * @max_bytes: the max bytes to be stored on @buffer
+ *
+ * This function is supposed to be used only by a HD-audio controller
+ * driver that needs the interaction with graphics driver.
+ *
+ * This function queries the current state of the audio on the given
+ * digital port and fetches the ELD bytes onto the given buffer.
+ * It returns the number of bytes for the total ELD data, zero for
+ * invalid ELD, or a negative error code.
+ *
+ * The return size is the total bytes required for the whole ELD bytes,
+ * thus it may be over @max_bytes.  If it's over @max_bytes, it implies
+ * that only a part of ELD bytes have been fetched.
+ */
+int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid, int dev_id,
+                          bool *audio_enabled, char *buffer, int max_bytes)
+{
+       struct hdac_bus *bus = codec->bus;
+       struct drm_audio_component *acomp = bus->audio_component;
+       int port, pipe;
+
+       if (!acomp || !acomp->ops || !acomp->ops->get_eld)
+               return -ENODEV;
+
+       port = nid;
+       if (acomp->audio_ops && acomp->audio_ops->pin2port) {
+               port = acomp->audio_ops->pin2port(codec, nid);
+               if (port < 0)
+                       return -EINVAL;
+       }
+       pipe = dev_id;
+       return acomp->ops->get_eld(acomp->dev, port, pipe, audio_enabled,
+                                  buffer, max_bytes);
+}
+EXPORT_SYMBOL_GPL(snd_hdac_acomp_get_eld);
+
+static int hdac_component_master_bind(struct device *dev)
+{
+       struct drm_audio_component *acomp = hdac_get_acomp(dev);
+       int ret;
+
+       if (WARN_ON(!acomp))
+               return -EINVAL;
+
+       ret = component_bind_all(dev, acomp);
+       if (ret < 0)
+               return ret;
+
+       if (WARN_ON(!(acomp->dev && acomp->ops))) {
+               ret = -EINVAL;
+               goto out_unbind;
+       }
+
+       /* pin the module to avoid dynamic unbinding, but only if given */
+       if (!try_module_get(acomp->ops->owner)) {
+               ret = -ENODEV;
+               goto out_unbind;
+       }
+
+       if (acomp->audio_ops && acomp->audio_ops->master_bind) {
+               ret = acomp->audio_ops->master_bind(dev, acomp);
+               if (ret < 0)
+                       goto module_put;
+       }
+
+       return 0;
+
+ module_put:
+       module_put(acomp->ops->owner);
+out_unbind:
+       component_unbind_all(dev, acomp);
+
+       return ret;
+}
+
+static void hdac_component_master_unbind(struct device *dev)
+{
+       struct drm_audio_component *acomp = hdac_get_acomp(dev);
+
+       if (acomp->audio_ops && acomp->audio_ops->master_unbind)
+               acomp->audio_ops->master_unbind(dev, acomp);
+       module_put(acomp->ops->owner);
+       component_unbind_all(dev, acomp);
+       WARN_ON(acomp->ops || acomp->dev);
+}
+
+static const struct component_master_ops hdac_component_master_ops = {
+       .bind = hdac_component_master_bind,
+       .unbind = hdac_component_master_unbind,
+};
+
+/**
+ * snd_hdac_acomp_register_notifier - Register audio component ops
+ * @bus: HDA core bus
+ * @aops: audio component ops
+ *
+ * This function is supposed to be used only by a HD-audio controller
+ * driver that needs the interaction with graphics driver.
+ *
+ * This function sets the given ops to be called by the graphics driver.
+ *
+ * Returns zero for success or a negative error code.
+ */
+int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
+                                   const struct drm_audio_component_audio_ops *aops)
+{
+       if (!bus->audio_component)
+               return -ENODEV;
+
+       bus->audio_component->audio_ops = aops;
+       return 0;
+}
+EXPORT_SYMBOL_GPL(snd_hdac_acomp_register_notifier);
+
+/**
+ * snd_hdac_acomp_init - Initialize audio component
+ * @bus: HDA core bus
+ * @match_master: match function for finding components
+ * @extra_size: Extra bytes to allocate
+ *
+ * This function is supposed to be used only by a HD-audio controller
+ * driver that needs the interaction with graphics driver.
+ *
+ * This function initializes and sets up the audio component to communicate
+ * with graphics driver.
+ *
+ * Unlike snd_hdac_i915_init(), this function doesn't synchronize with the
+ * binding with the DRM component.  Each caller needs to sync via master_bind
+ * audio_ops.
+ *
+ * Returns zero for success or a negative error code.
+ */
+int snd_hdac_acomp_init(struct hdac_bus *bus,
+                       const struct drm_audio_component_audio_ops *aops,
+                       int (*match_master)(struct device *, void *),
+                       size_t extra_size)
+{
+       struct component_match *match = NULL;
+       struct device *dev = bus->dev;
+       struct drm_audio_component *acomp;
+       int ret;
+
+       if (WARN_ON(hdac_get_acomp(dev)))
+               return -EBUSY;
+
+       acomp = devres_alloc(hdac_acomp_release, sizeof(*acomp) + extra_size,
+                            GFP_KERNEL);
+       if (!acomp)
+               return -ENOMEM;
+       acomp->audio_ops = aops;
+       bus->audio_component = acomp;
+       devres_add(dev, acomp);
+
+       component_match_add(dev, &match, match_master, bus);
+       ret = component_master_add_with_match(dev, &hdac_component_master_ops,
+                                             match);
+       if (ret < 0)
+               goto out_err;
+
+       return 0;
+
+out_err:
+       bus->audio_component = NULL;
+       devres_destroy(dev, hdac_acomp_release, NULL, NULL);
+       dev_info(dev, "failed to add audio component master (%d)\n", ret);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(snd_hdac_acomp_init);
+
+/**
+ * snd_hdac_acomp_exit - Finalize audio component
+ * @bus: HDA core bus
+ *
+ * This function is supposed to be used only by a HD-audio controller
+ * driver that needs the interaction with graphics driver.
+ *
+ * This function releases the audio component that has been used.
+ *
+ * Returns zero for success or a negative error code.
+ */
+int snd_hdac_acomp_exit(struct hdac_bus *bus)
+{
+       struct device *dev = bus->dev;
+       struct drm_audio_component *acomp = bus->audio_component;
+
+       if (!acomp)
+               return 0;
+
+       WARN_ON(bus->drm_power_refcount);
+       if (bus->drm_power_refcount > 0 && acomp->ops)
+               acomp->ops->put_power(acomp->dev);
+
+       component_master_del(dev, &hdac_component_master_ops);
+
+       bus->audio_component = NULL;
+       devres_destroy(dev, hdac_acomp_release, NULL, NULL);
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(snd_hdac_acomp_exit);
index cbe818eda3363c0f0595c3496e980f64343776d6..8f2aa8bc1185d964e71d1545910f10e01f332fd6 100644 (file)
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/component.h>
-#include <drm/i915_component.h>
 #include <sound/core.h>
 #include <sound/hdaudio.h>
 #include <sound/hda_i915.h>
 #include <sound/hda_register.h>
 
-static struct i915_audio_component *hdac_acomp;
-
-/**
- * snd_hdac_set_codec_wakeup - Enable / disable HDMI/DP codec wakeup
- * @bus: HDA core bus
- * @enable: enable or disable the wakeup
- *
- * This function is supposed to be used only by a HD-audio controller
- * driver that needs the interaction with i915 graphics.
- *
- * This function should be called during the chip reset, also called at
- * resume for updating STATESTS register read.
- *
- * Returns zero for success or a negative error code.
- */
-int snd_hdac_set_codec_wakeup(struct hdac_bus *bus, bool enable)
-{
-       struct i915_audio_component *acomp = bus->audio_component;
-
-       if (!acomp || !acomp->ops)
-               return -ENODEV;
-
-       if (!acomp->ops->codec_wake_override) {
-               dev_warn(bus->dev,
-                       "Invalid codec wake callback\n");
-               return 0;
-       }
-
-       dev_dbg(bus->dev, "%s codec wakeup\n",
-               enable ? "enable" : "disable");
-
-       acomp->ops->codec_wake_override(acomp->dev, enable);
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(snd_hdac_set_codec_wakeup);
-
-/**
- * snd_hdac_display_power - Power up / down the power refcount
- * @bus: HDA core bus
- * @enable: power up or down
- *
- * This function is supposed to be used only by a HD-audio controller
- * driver that needs the interaction with i915 graphics.
- *
- * This function manages a refcount and calls the i915 get_power() and
- * put_power() ops accordingly, toggling the codec wakeup, too.
- *
- * Returns zero for success or a negative error code.
- */
-int snd_hdac_display_power(struct hdac_bus *bus, bool enable)
-{
-       struct i915_audio_component *acomp = bus->audio_component;
-
-       if (!acomp || !acomp->ops)
-               return -ENODEV;
-
-       dev_dbg(bus->dev, "display power %s\n",
-               enable ? "enable" : "disable");
-
-       if (enable) {
-               if (!bus->i915_power_refcount++) {
-                       acomp->ops->get_power(acomp->dev);
-                       snd_hdac_set_codec_wakeup(bus, true);
-                       snd_hdac_set_codec_wakeup(bus, false);
-               }
-       } else {
-               WARN_ON(!bus->i915_power_refcount);
-               if (!--bus->i915_power_refcount)
-                       acomp->ops->put_power(acomp->dev);
-       }
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(snd_hdac_display_power);
-
 #define CONTROLLER_IN_GPU(pci) (((pci)->device == 0x0a0c) || \
                                ((pci)->device == 0x0c0c) || \
                                ((pci)->device == 0x0d0c) || \
@@ -119,7 +41,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_display_power);
  */
 void snd_hdac_i915_set_bclk(struct hdac_bus *bus)
 {
-       struct i915_audio_component *acomp = bus->audio_component;
+       struct drm_audio_component *acomp = bus->audio_component;
        struct pci_dev *pci = to_pci_dev(bus->dev);
        int cdclk_freq;
        unsigned int bclk_m, bclk_n;
@@ -158,181 +80,11 @@ void snd_hdac_i915_set_bclk(struct hdac_bus *bus)
 }
 EXPORT_SYMBOL_GPL(snd_hdac_i915_set_bclk);
 
-/* There is a fixed mapping between audio pin node and display port.
- * on SNB, IVY, HSW, BSW, SKL, BXT, KBL:
- * Pin Widget 5 - PORT B (port = 1 in i915 driver)
- * Pin Widget 6 - PORT C (port = 2 in i915 driver)
- * Pin Widget 7 - PORT D (port = 3 in i915 driver)
- *
- * on VLV, ILK:
- * Pin Widget 4 - PORT B (port = 1 in i915 driver)
- * Pin Widget 5 - PORT C (port = 2 in i915 driver)
- * Pin Widget 6 - PORT D (port = 3 in i915 driver)
- */
-static int pin2port(struct hdac_device *codec, hda_nid_t pin_nid)
+static int i915_component_master_match(struct device *dev, void *data)
 {
-       int base_nid;
-
-       switch (codec->vendor_id) {
-       case 0x80860054: /* ILK */
-       case 0x80862804: /* ILK */
-       case 0x80862882: /* VLV */
-               base_nid = 3;
-               break;
-       default:
-               base_nid = 4;
-               break;
-       }
-
-       if (WARN_ON(pin_nid <= base_nid || pin_nid > base_nid + 3))
-               return -1;
-       return pin_nid - base_nid;
-}
-
-/**
- * snd_hdac_sync_audio_rate - Set N/CTS based on the sample rate
- * @codec: HDA codec
- * @nid: the pin widget NID
- * @dev_id: device identifier
- * @rate: the sample rate to set
- *
- * This function is supposed to be used only by a HD-audio controller
- * driver that needs the interaction with i915 graphics.
- *
- * This function sets N/CTS value based on the given sample rate.
- * Returns zero for success, or a negative error code.
- */
-int snd_hdac_sync_audio_rate(struct hdac_device *codec, hda_nid_t nid,
-                            int dev_id, int rate)
-{
-       struct hdac_bus *bus = codec->bus;
-       struct i915_audio_component *acomp = bus->audio_component;
-       int port, pipe;
-
-       if (!acomp || !acomp->ops || !acomp->ops->sync_audio_rate)
-               return -ENODEV;
-       port = pin2port(codec, nid);
-       if (port < 0)
-               return -EINVAL;
-       pipe = dev_id;
-       return acomp->ops->sync_audio_rate(acomp->dev, port, pipe, rate);
-}
-EXPORT_SYMBOL_GPL(snd_hdac_sync_audio_rate);
-
-/**
- * snd_hdac_acomp_get_eld - Get the audio state and ELD via component
- * @codec: HDA codec
- * @nid: the pin widget NID
- * @dev_id: device identifier
- * @audio_enabled: the pointer to store the current audio state
- * @buffer: the buffer pointer to store ELD bytes
- * @max_bytes: the max bytes to be stored on @buffer
- *
- * This function is supposed to be used only by a HD-audio controller
- * driver that needs the interaction with i915 graphics.
- *
- * This function queries the current state of the audio on the given
- * digital port and fetches the ELD bytes onto the given buffer.
- * It returns the number of bytes for the total ELD data, zero for
- * invalid ELD, or a negative error code.
- *
- * The return size is the total bytes required for the whole ELD bytes,
- * thus it may be over @max_bytes.  If it's over @max_bytes, it implies
- * that only a part of ELD bytes have been fetched.
- */
-int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid, int dev_id,
-                          bool *audio_enabled, char *buffer, int max_bytes)
-{
-       struct hdac_bus *bus = codec->bus;
-       struct i915_audio_component *acomp = bus->audio_component;
-       int port, pipe;
-
-       if (!acomp || !acomp->ops || !acomp->ops->get_eld)
-               return -ENODEV;
-
-       port = pin2port(codec, nid);
-       if (port < 0)
-               return -EINVAL;
-
-       pipe = dev_id;
-       return acomp->ops->get_eld(acomp->dev, port, pipe, audio_enabled,
-                                  buffer, max_bytes);
-}
-EXPORT_SYMBOL_GPL(snd_hdac_acomp_get_eld);
-
-static int hdac_component_master_bind(struct device *dev)
-{
-       struct i915_audio_component *acomp = hdac_acomp;
-       int ret;
-
-       ret = component_bind_all(dev, acomp);
-       if (ret < 0)
-               return ret;
-
-       if (WARN_ON(!(acomp->dev && acomp->ops && acomp->ops->get_power &&
-                     acomp->ops->put_power && acomp->ops->get_cdclk_freq))) {
-               ret = -EINVAL;
-               goto out_unbind;
-       }
-
-       /*
-        * Atm, we don't support dynamic unbinding initiated by the child
-        * component, so pin its containing module until we unbind.
-        */
-       if (!try_module_get(acomp->ops->owner)) {
-               ret = -ENODEV;
-               goto out_unbind;
-       }
-
-       return 0;
-
-out_unbind:
-       component_unbind_all(dev, acomp);
-
-       return ret;
-}
-
-static void hdac_component_master_unbind(struct device *dev)
-{
-       struct i915_audio_component *acomp = hdac_acomp;
-
-       module_put(acomp->ops->owner);
-       component_unbind_all(dev, acomp);
-       WARN_ON(acomp->ops || acomp->dev);
-}
-
-static const struct component_master_ops hdac_component_master_ops = {
-       .bind = hdac_component_master_bind,
-       .unbind = hdac_component_master_unbind,
-};
-
-static int hdac_component_master_match(struct device *dev, void *data)
-{
-       /* i915 is the only supported component */
        return !strcmp(dev->driver->name, "i915");
 }
 
-/**
- * snd_hdac_i915_register_notifier - Register i915 audio component ops
- * @aops: i915 audio component ops
- *
- * This function is supposed to be used only by a HD-audio controller
- * driver that needs the interaction with i915 graphics.
- *
- * This function sets the given ops to be called by the i915 graphics driver.
- *
- * Returns zero for success or a negative error code.
- */
-int snd_hdac_i915_register_notifier(const struct i915_audio_component_audio_ops *aops)
-{
-       if (!hdac_acomp)
-               return -ENODEV;
-
-       hdac_acomp->audio_ops = aops;
-       return 0;
-}
-EXPORT_SYMBOL_GPL(snd_hdac_i915_register_notifier);
-
 /* check whether intel graphics is present */
 static bool i915_gfx_present(void)
 {
@@ -359,83 +111,26 @@ static bool i915_gfx_present(void)
  */
 int snd_hdac_i915_init(struct hdac_bus *bus)
 {
-       struct component_match *match = NULL;
-       struct device *dev = bus->dev;
-       struct i915_audio_component *acomp;
-       int ret;
-
-       if (WARN_ON(hdac_acomp))
-               return -EBUSY;
+       struct drm_audio_component *acomp;
+       int err;
 
        if (!i915_gfx_present())
                return -ENODEV;
 
-       acomp = kzalloc(sizeof(*acomp), GFP_KERNEL);
+       err = snd_hdac_acomp_init(bus, NULL,
+                                 i915_component_master_match,
+                                 sizeof(struct i915_audio_component) - sizeof(*acomp));
+       if (err < 0)
+               return err;
+       acomp = bus->audio_component;
        if (!acomp)
-               return -ENOMEM;
-       bus->audio_component = acomp;
-       hdac_acomp = acomp;
-
-       component_match_add(dev, &match, hdac_component_master_match, bus);
-       ret = component_master_add_with_match(dev, &hdac_component_master_ops,
-                                             match);
-       if (ret < 0)
-               goto out_err;
-
-       /*
-        * Atm, we don't support deferring the component binding, so make sure
-        * i915 is loaded and that the binding successfully completes.
-        */
-       request_module("i915");
-
+               return -ENODEV;
+       if (!acomp->ops)
+               request_module("i915");
        if (!acomp->ops) {
-               ret = -ENODEV;
-               goto out_master_del;
+               snd_hdac_acomp_exit(bus);
+               return -ENODEV;
        }
-       dev_dbg(dev, "bound to i915 component master\n");
-
        return 0;
-out_master_del:
-       component_master_del(dev, &hdac_component_master_ops);
-out_err:
-       kfree(acomp);
-       bus->audio_component = NULL;
-       hdac_acomp = NULL;
-       dev_info(dev, "failed to add i915 component master (%d)\n", ret);
-
-       return ret;
 }
 EXPORT_SYMBOL_GPL(snd_hdac_i915_init);
-
-/**
- * snd_hdac_i915_exit - Finalize i915 audio component
- * @bus: HDA core bus
- *
- * This function is supposed to be used only by a HD-audio controller
- * driver that needs the interaction with i915 graphics.
- *
- * This function releases the i915 audio component that has been used.
- *
- * Returns zero for success or a negative error code.
- */
-int snd_hdac_i915_exit(struct hdac_bus *bus)
-{
-       struct device *dev = bus->dev;
-       struct i915_audio_component *acomp = bus->audio_component;
-
-       if (!acomp)
-               return 0;
-
-       WARN_ON(bus->i915_power_refcount);
-       if (bus->i915_power_refcount > 0 && acomp->ops)
-               acomp->ops->put_power(acomp->dev);
-
-       component_master_del(dev, &hdac_component_master_ops);
-
-       kfree(acomp);
-       bus->audio_component = NULL;
-       hdac_acomp = NULL;
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(snd_hdac_i915_exit);
index d91c87e41756ea5fceaee73d84e211b9ebba929d..3fd0c16fa602de98d3d88993e0b8be32c5e36e14 100644 (file)
@@ -858,6 +858,39 @@ static void snd_hda_codec_dev_release(struct device *dev)
        kfree(codec);
 }
 
+#define DEV_NAME_LEN 31
+
+static int snd_hda_codec_device_init(struct hda_bus *bus, struct snd_card *card,
+                       unsigned int codec_addr, struct hda_codec **codecp)
+{
+       char name[DEV_NAME_LEN];
+       struct hda_codec *codec;
+       int err;
+
+       dev_dbg(card->dev, "%s: entry\n", __func__);
+
+       if (snd_BUG_ON(!bus))
+               return -EINVAL;
+       if (snd_BUG_ON(codec_addr > HDA_MAX_CODEC_ADDRESS))
+               return -EINVAL;
+
+       codec = kzalloc(sizeof(*codec), GFP_KERNEL);
+       if (!codec)
+               return -ENOMEM;
+
+       sprintf(name, "hdaudioC%dD%d", card->number, codec_addr);
+       err = snd_hdac_device_init(&codec->core, &bus->core, name, codec_addr);
+       if (err < 0) {
+               kfree(codec);
+               return err;
+       }
+
+       codec->core.type = HDA_DEV_LEGACY;
+       *codecp = codec;
+
+       return err;
+}
+
 /**
  * snd_hda_codec_new - create a HDA codec
  * @bus: the bus to assign
@@ -869,7 +902,19 @@ static void snd_hda_codec_dev_release(struct device *dev)
 int snd_hda_codec_new(struct hda_bus *bus, struct snd_card *card,
                      unsigned int codec_addr, struct hda_codec **codecp)
 {
-       struct hda_codec *codec;
+       int ret;
+
+       ret = snd_hda_codec_device_init(bus, card, codec_addr, codecp);
+       if (ret < 0)
+               return ret;
+
+       return snd_hda_codec_device_new(bus, card, codec_addr, *codecp);
+}
+EXPORT_SYMBOL_GPL(snd_hda_codec_new);
+
+int snd_hda_codec_device_new(struct hda_bus *bus, struct snd_card *card,
+                       unsigned int codec_addr, struct hda_codec *codec)
+{
        char component[31];
        hda_nid_t fg;
        int err;
@@ -879,25 +924,14 @@ int snd_hda_codec_new(struct hda_bus *bus, struct snd_card *card,
                .dev_free = snd_hda_codec_dev_free,
        };
 
+       dev_dbg(card->dev, "%s: entry\n", __func__);
+
        if (snd_BUG_ON(!bus))
                return -EINVAL;
        if (snd_BUG_ON(codec_addr > HDA_MAX_CODEC_ADDRESS))
                return -EINVAL;
 
-       codec = kzalloc(sizeof(*codec), GFP_KERNEL);
-       if (!codec)
-               return -ENOMEM;
-
-       sprintf(component, "hdaudioC%dD%d", card->number, codec_addr);
-       err = snd_hdac_device_init(&codec->core, &bus->core, component,
-                                  codec_addr);
-       if (err < 0) {
-               kfree(codec);
-               return err;
-       }
-
        codec->core.dev.release = snd_hda_codec_dev_release;
-       codec->core.type = HDA_DEV_LEGACY;
        codec->core.exec_verb = codec_exec_verb;
 
        codec->bus = bus;
@@ -957,15 +991,13 @@ int snd_hda_codec_new(struct hda_bus *bus, struct snd_card *card,
        if (err < 0)
                goto error;
 
-       if (codecp)
-               *codecp = codec;
        return 0;
 
  error:
        put_device(hda_codec_dev(codec));
        return err;
 }
-EXPORT_SYMBOL_GPL(snd_hda_codec_new);
+EXPORT_SYMBOL_GPL(snd_hda_codec_device_new);
 
 /**
  * snd_hda_codec_update_widgets - Refresh widget caps and pin defaults
@@ -2899,8 +2931,9 @@ static int hda_codec_runtime_suspend(struct device *dev)
        list_for_each_entry(pcm, &codec->pcm_list_head, list)
                snd_pcm_suspend_all(pcm->pcm);
        state = hda_call_codec_suspend(codec);
-       if (codec_has_clkstop(codec) && codec_has_epss(codec) &&
-           (state & AC_PWRST_CLK_STOP_OK))
+       if (codec->link_down_at_suspend ||
+           (codec_has_clkstop(codec) && codec_has_epss(codec) &&
+            (state & AC_PWRST_CLK_STOP_OK)))
                snd_hdac_codec_link_down(&codec->core);
        snd_hdac_link_power(&codec->core, false);
        return 0;
@@ -2991,6 +3024,7 @@ int snd_hda_codec_build_controls(struct hda_codec *codec)
        sync_power_up_states(codec);
        return 0;
 }
+EXPORT_SYMBOL_GPL(snd_hda_codec_build_controls);
 
 /*
  * PCM stuff
@@ -3196,6 +3230,7 @@ int snd_hda_codec_parse_pcms(struct hda_codec *codec)
 
        return 0;
 }
+EXPORT_SYMBOL_GPL(snd_hda_codec_parse_pcms);
 
 /* assign all PCMs of the given codec */
 int snd_hda_codec_build_pcms(struct hda_codec *codec)
index 681c360f29f9d628cf4462c9bb7ef92879f27d91..e03b5c1ccc5cf5584c6a517b07b9820846d6b62d 100644 (file)
@@ -258,6 +258,7 @@ struct hda_codec {
        unsigned int power_save_node:1; /* advanced PM for each widget */
        unsigned int auto_runtime_pm:1; /* enable automatic codec runtime pm */
        unsigned int force_pin_prefix:1; /* Add location prefix */
+       unsigned int link_down_at_suspend:1; /* link down at runtime suspend */
 #ifdef CONFIG_PM
        unsigned long power_on_acct;
        unsigned long power_off_acct;
@@ -307,6 +308,8 @@ struct hda_codec {
  */
 int snd_hda_codec_new(struct hda_bus *bus, struct snd_card *card,
                      unsigned int codec_addr, struct hda_codec **codecp);
+int snd_hda_codec_device_new(struct hda_bus *bus, struct snd_card *card,
+                     unsigned int codec_addr, struct hda_codec *codec);
 int snd_hda_codec_configure(struct hda_codec *codec);
 int snd_hda_codec_update_widgets(struct hda_codec *codec);
 
index 04e949aa01ada5492765cd313608624f3a42c7b9..321e95c409c1427ddd5a56f802101fc9fe248bff 100644 (file)
@@ -991,6 +991,7 @@ struct ca0132_spec {
 enum {
        QUIRK_NONE,
        QUIRK_ALIENWARE,
+       QUIRK_ALIENWARE_M17XR4,
        QUIRK_SBZ,
        QUIRK_R3DI,
 };
@@ -1040,13 +1041,15 @@ static const struct hda_pintbl r3di_pincfgs[] = {
 };
 
 static const struct snd_pci_quirk ca0132_quirks[] = {
+       SND_PCI_QUIRK(0x1028, 0x057b, "Alienware M17x R4", QUIRK_ALIENWARE_M17XR4),
        SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15 2015", QUIRK_ALIENWARE),
        SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE),
        SND_PCI_QUIRK(0x1028, 0x0708, "Alienware 15 R2 2016", QUIRK_ALIENWARE),
        SND_PCI_QUIRK(0x1102, 0x0010, "Sound Blaster Z", QUIRK_SBZ),
        SND_PCI_QUIRK(0x1102, 0x0023, "Sound Blaster Z", QUIRK_SBZ),
        SND_PCI_QUIRK(0x1458, 0xA016, "Recon3Di", QUIRK_R3DI),
-       SND_PCI_QUIRK(0x1458, 0xA036, "Recon3Di", QUIRK_R3DI),
+       SND_PCI_QUIRK(0x1458, 0xA026, "Gigabyte G1.Sniper Z97", QUIRK_R3DI),
+       SND_PCI_QUIRK(0x1458, 0xA036, "Gigabyte GA-Z170X-Gaming 7", QUIRK_R3DI),
        {}
 };
 
@@ -5663,7 +5666,7 @@ static const char * const ca0132_alt_slave_pfxs[] = {
  * I think this has to do with the pin for rear surround being 0x11,
  * and the center/lfe being 0x10. Usually the pin order is the opposite.
  */
-const struct snd_pcm_chmap_elem ca0132_alt_chmaps[] = {
+static const struct snd_pcm_chmap_elem ca0132_alt_chmaps[] = {
        { .channels = 2,
          .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR } },
        { .channels = 4,
@@ -5966,7 +5969,7 @@ static int ca0132_build_pcms(struct hda_codec *codec)
        info->stream[SNDRV_PCM_STREAM_CAPTURE].nid = spec->adcs[0];
 
        /* With the DSP enabled, desktops don't use this ADC. */
-       if (spec->use_alt_functions) {
+       if (!spec->use_alt_functions) {
                info = snd_hda_codec_pcm_new(codec, "CA0132 Analog Mic-In2");
                if (!info)
                        return -ENOMEM;
@@ -6130,7 +6133,10 @@ static void ca0132_init_dmic(struct hda_codec *codec)
         * Bit   6: set to select Data2, clear for Data1
         * Bit   7: set to enable DMic, clear for AMic
         */
-       val = 0x23;
+       if (spec->quirk == QUIRK_ALIENWARE_M17XR4)
+               val = 0x33;
+       else
+               val = 0x23;
        /* keep a copy of dmic ctl val for enable/disable dmic purpuse */
        spec->dmic_ctl = val;
        snd_hda_codec_write(codec, spec->input_pins[0], 0,
@@ -7223,7 +7229,7 @@ static int ca0132_init(struct hda_codec *codec)
 
        snd_hda_sequence_write(codec, spec->base_init_verbs);
 
-       if (spec->quirk != QUIRK_NONE)
+       if (spec->use_alt_functions)
                ca0132_alt_init(codec);
 
        ca0132_download_dsp(codec);
@@ -7237,8 +7243,9 @@ static int ca0132_init(struct hda_codec *codec)
        case QUIRK_R3DI:
                r3di_setup_defaults(codec);
                break;
-       case QUIRK_NONE:
-       case QUIRK_ALIENWARE:
+       case QUIRK_SBZ:
+               break;
+       default:
                ca0132_setup_defaults(codec);
                ca0132_init_analog_mic2(codec);
                ca0132_init_dmic(codec);
@@ -7343,7 +7350,6 @@ static const struct hda_codec_ops ca0132_patch_ops = {
 static void ca0132_config(struct hda_codec *codec)
 {
        struct ca0132_spec *spec = codec->spec;
-       struct auto_pin_cfg *cfg = &spec->autocfg;
 
        spec->dacs[0] = 0x2;
        spec->dacs[1] = 0x3;
@@ -7405,12 +7411,7 @@ static void ca0132_config(struct hda_codec *codec)
                /* SPDIF I/O */
                spec->dig_out = 0x05;
                spec->multiout.dig_out_nid = spec->dig_out;
-               cfg->dig_out_pins[0] = 0x0c;
-               cfg->dig_outs = 1;
-               cfg->dig_out_type[0] = HDA_PCM_TYPE_SPDIF;
                spec->dig_in = 0x09;
-               cfg->dig_in_pin = 0x0e;
-               cfg->dig_in_type = HDA_PCM_TYPE_SPDIF;
                break;
        case QUIRK_R3DI:
                codec_dbg(codec, "%s: QUIRK_R3DI applied.\n", __func__);
@@ -7438,9 +7439,6 @@ static void ca0132_config(struct hda_codec *codec)
                /* SPDIF I/O */
                spec->dig_out = 0x05;
                spec->multiout.dig_out_nid = spec->dig_out;
-               cfg->dig_out_pins[0] = 0x0c;
-               cfg->dig_outs = 1;
-               cfg->dig_out_type[0] = HDA_PCM_TYPE_SPDIF;
                break;
        default:
                spec->num_outputs = 2;
@@ -7463,12 +7461,7 @@ static void ca0132_config(struct hda_codec *codec)
                /* SPDIF I/O */
                spec->dig_out = 0x05;
                spec->multiout.dig_out_nid = spec->dig_out;
-               cfg->dig_out_pins[0] = 0x0c;
-               cfg->dig_outs = 1;
-               cfg->dig_out_type[0] = HDA_PCM_TYPE_SPDIF;
                spec->dig_in = 0x09;
-               cfg->dig_in_pin = 0x0e;
-               cfg->dig_in_type = HDA_PCM_TYPE_SPDIF;
                break;
        }
 }
@@ -7476,7 +7469,7 @@ static void ca0132_config(struct hda_codec *codec)
 static int ca0132_prepare_verbs(struct hda_codec *codec)
 {
 /* Verbs + terminator (an empty element) */
-#define NUM_SPEC_VERBS 4
+#define NUM_SPEC_VERBS 2
        struct ca0132_spec *spec = codec->spec;
 
        spec->chip_init_verbs = ca0132_init_verbs0;
@@ -7488,34 +7481,24 @@ static int ca0132_prepare_verbs(struct hda_codec *codec)
        if (!spec->spec_init_verbs)
                return -ENOMEM;
 
-       /* HP jack autodetection */
-       spec->spec_init_verbs[0].nid = spec->unsol_tag_hp;
-       spec->spec_init_verbs[0].param = AC_VERB_SET_UNSOLICITED_ENABLE;
-       spec->spec_init_verbs[0].verb = AC_USRSP_EN | spec->unsol_tag_hp;
-
-       /* MIC1 jack autodetection */
-       spec->spec_init_verbs[1].nid = spec->unsol_tag_amic1;
-       spec->spec_init_verbs[1].param = AC_VERB_SET_UNSOLICITED_ENABLE;
-       spec->spec_init_verbs[1].verb = AC_USRSP_EN | spec->unsol_tag_amic1;
-
        /* config EAPD */
-       spec->spec_init_verbs[2].nid = 0x0b;
-       spec->spec_init_verbs[2].param = 0x78D;
-       spec->spec_init_verbs[2].verb = 0x00;
+       spec->spec_init_verbs[0].nid = 0x0b;
+       spec->spec_init_verbs[0].param = 0x78D;
+       spec->spec_init_verbs[0].verb = 0x00;
 
        /* Previously commented configuration */
        /*
-       spec->spec_init_verbs[3].nid = 0x0b;
-       spec->spec_init_verbs[3].param = AC_VERB_SET_EAPD_BTLENABLE;
+       spec->spec_init_verbs[2].nid = 0x0b;
+       spec->spec_init_verbs[2].param = AC_VERB_SET_EAPD_BTLENABLE;
+       spec->spec_init_verbs[2].verb = 0x02;
+
+       spec->spec_init_verbs[3].nid = 0x10;
+       spec->spec_init_verbs[3].param = 0x78D;
        spec->spec_init_verbs[3].verb = 0x02;
 
        spec->spec_init_verbs[4].nid = 0x10;
-       spec->spec_init_verbs[4].param = 0x78D;
+       spec->spec_init_verbs[4].param = AC_VERB_SET_EAPD_BTLENABLE;
        spec->spec_init_verbs[4].verb = 0x02;
-
-       spec->spec_init_verbs[5].nid = 0x10;
-       spec->spec_init_verbs[5].param = AC_VERB_SET_EAPD_BTLENABLE;
-       spec->spec_init_verbs[5].verb = 0x02;
        */
 
        /* Terminator: spec->spec_init_verbs[NUM_SPEC_VERBS-1] */
index 8840daf9c6a300899efaf02898430d158d5b972a..1de5491fb9bf611f2d1dda1a4e2d7f44da0cf3d5 100644 (file)
@@ -33,6 +33,7 @@
 #include <linux/delay.h>
 #include <linux/slab.h>
 #include <linux/module.h>
+#include <linux/pm_runtime.h>
 #include <sound/core.h>
 #include <sound/jack.h>
 #include <sound/asoundef.h>
@@ -176,13 +177,13 @@ struct hdmi_spec {
 
        /* i915/powerwell (Haswell+/Valleyview+) specific */
        bool use_acomp_notifier; /* use i915 eld_notify callback for hotplug */
-       struct i915_audio_component_audio_ops i915_audio_ops;
+       struct drm_audio_component_audio_ops drm_audio_ops;
 
        struct hdac_chmap chmap;
        hda_nid_t vendor_nid;
 };
 
-#ifdef CONFIG_SND_HDA_I915
+#ifdef CONFIG_SND_HDA_COMPONENT
 static inline bool codec_has_acomp(struct hda_codec *codec)
 {
        struct hdmi_spec *spec = codec->spec;
@@ -764,8 +765,10 @@ static void check_presence_and_report(struct hda_codec *codec, hda_nid_t nid,
 
        if (pin_idx < 0)
                return;
+       mutex_lock(&spec->pcm_lock);
        if (hdmi_present_sense(get_pin(spec, pin_idx), 1))
                snd_hda_jack_report_sync(codec);
+       mutex_unlock(&spec->pcm_lock);
 }
 
 static void jack_callback(struct hda_codec *codec,
@@ -1628,21 +1631,23 @@ static void sync_eld_via_acomp(struct hda_codec *codec,
 static bool hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, int repoll)
 {
        struct hda_codec *codec = per_pin->codec;
-       struct hdmi_spec *spec = codec->spec;
        int ret;
 
        /* no temporary power up/down needed for component notifier */
-       if (!codec_has_acomp(codec))
-               snd_hda_power_up_pm(codec);
+       if (!codec_has_acomp(codec)) {
+               ret = snd_hda_power_up_pm(codec);
+               if (ret < 0 && pm_runtime_suspended(hda_codec_dev(codec))) {
+                       snd_hda_power_down_pm(codec);
+                       return false;
+               }
+       }
 
-       mutex_lock(&spec->pcm_lock);
        if (codec_has_acomp(codec)) {
                sync_eld_via_acomp(codec, per_pin);
                ret = false; /* don't call snd_hda_jack_report_sync() */
        } else {
                ret = hdmi_present_sense_via_verbs(per_pin, repoll);
        }
-       mutex_unlock(&spec->pcm_lock);
 
        if (!codec_has_acomp(codec))
                snd_hda_power_down_pm(codec);
@@ -1654,12 +1659,16 @@ static void hdmi_repoll_eld(struct work_struct *work)
 {
        struct hdmi_spec_per_pin *per_pin =
        container_of(to_delayed_work(work), struct hdmi_spec_per_pin, work);
+       struct hda_codec *codec = per_pin->codec;
+       struct hdmi_spec *spec = codec->spec;
 
        if (per_pin->repoll_count++ > 6)
                per_pin->repoll_count = 0;
 
+       mutex_lock(&spec->pcm_lock);
        if (hdmi_present_sense(per_pin, per_pin->repoll_count))
                snd_hda_jack_report_sync(per_pin->codec);
+       mutex_unlock(&spec->pcm_lock);
 }
 
 static void intel_haswell_fixup_connect_list(struct hda_codec *codec,
@@ -2279,7 +2288,7 @@ static void generic_hdmi_free(struct hda_codec *codec)
        int pin_idx, pcm_idx;
 
        if (codec_has_acomp(codec))
-               snd_hdac_i915_register_notifier(NULL);
+               snd_hdac_acomp_register_notifier(&codec->bus->core, NULL);
 
        for (pin_idx = 0; pin_idx < spec->num_pins; pin_idx++) {
                struct hdmi_spec_per_pin *per_pin = get_pin(spec, pin_idx);
@@ -2462,6 +2471,38 @@ static void haswell_set_power_state(struct hda_codec *codec, hda_nid_t fg,
        snd_hda_codec_set_power_to_all(codec, fg, power_state);
 }
 
+/* There is a fixed mapping between audio pin node and display port.
+ * on SNB, IVY, HSW, BSW, SKL, BXT, KBL:
+ * Pin Widget 5 - PORT B (port = 1 in i915 driver)
+ * Pin Widget 6 - PORT C (port = 2 in i915 driver)
+ * Pin Widget 7 - PORT D (port = 3 in i915 driver)
+ *
+ * on VLV, ILK:
+ * Pin Widget 4 - PORT B (port = 1 in i915 driver)
+ * Pin Widget 5 - PORT C (port = 2 in i915 driver)
+ * Pin Widget 6 - PORT D (port = 3 in i915 driver)
+ */
+static int intel_base_nid(struct hda_codec *codec)
+{
+       switch (codec->core.vendor_id) {
+       case 0x80860054: /* ILK */
+       case 0x80862804: /* ILK */
+       case 0x80862882: /* VLV */
+               return 4;
+       default:
+               return 5;
+       }
+}
+
+static int intel_pin2port(void *audio_ptr, int pin_nid)
+{
+       int base_nid = intel_base_nid(audio_ptr);
+
+       if (WARN_ON(pin_nid < base_nid || pin_nid >= base_nid + 3))
+               return -1;
+       return pin_nid - base_nid + 1; /* intel port is 1-based */
+}
+
 static void intel_pin_eld_notify(void *audio_ptr, int port, int pipe)
 {
        struct hda_codec *codec = audio_ptr;
@@ -2472,16 +2513,7 @@ static void intel_pin_eld_notify(void *audio_ptr, int port, int pipe)
        if (port < 1 || port > 3)
                return;
 
-       switch (codec->core.vendor_id) {
-       case 0x80860054: /* ILK */
-       case 0x80862804: /* ILK */
-       case 0x80862882: /* VLV */
-               pin_nid = port + 0x03;
-               break;
-       default:
-               pin_nid = port + 0x04;
-               break;
-       }
+       pin_nid = port + intel_base_nid(codec) - 1; /* intel port is 1-based */
 
        /* skip notification during system suspend (but not in runtime PM);
         * the state will be updated at resume
@@ -2502,14 +2534,16 @@ static void register_i915_notifier(struct hda_codec *codec)
        struct hdmi_spec *spec = codec->spec;
 
        spec->use_acomp_notifier = true;
-       spec->i915_audio_ops.audio_ptr = codec;
+       spec->drm_audio_ops.audio_ptr = codec;
        /* intel_audio_codec_enable() or intel_audio_codec_disable()
         * will call pin_eld_notify with using audio_ptr pointer
         * We need make sure audio_ptr is really setup
         */
        wmb();
-       spec->i915_audio_ops.pin_eld_notify = intel_pin_eld_notify;
-       snd_hdac_i915_register_notifier(&spec->i915_audio_ops);
+       spec->drm_audio_ops.pin2port = intel_pin2port;
+       spec->drm_audio_ops.pin_eld_notify = intel_pin_eld_notify;
+       snd_hdac_acomp_register_notifier(&codec->bus->core,
+                                       &spec->drm_audio_ops);
 }
 
 /* setup_stream ops override for HSW+ */
@@ -3741,6 +3775,11 @@ static int patch_atihdmi(struct hda_codec *codec)
 
        spec->chmap.channels_max = max(spec->chmap.channels_max, 8u);
 
+       /* AMD GPUs have neither EPSS nor CLKSTOP bits, hence preventing
+        * the link-down as is.  Tell the core to allow it.
+        */
+       codec->link_down_at_suspend = 1;
+
        return 0;
 }
 
index e9bd33ea538f239891c031a1a81e075a35c75043..7496be4491b1967afff910da25681f19ffcb0af6 100644 (file)
@@ -2545,6 +2545,7 @@ static const struct snd_pci_quirk alc262_fixup_tbl[] = {
        SND_PCI_QUIRK(0x10cf, 0x1397, "Fujitsu Lifebook S7110", ALC262_FIXUP_FSC_S7110),
        SND_PCI_QUIRK(0x10cf, 0x142d, "Fujitsu Lifebook E8410", ALC262_FIXUP_BENQ),
        SND_PCI_QUIRK(0x10f1, 0x2915, "Tyan Thunder n6650W", ALC262_FIXUP_TYAN),
+       SND_PCI_QUIRK(0x1734, 0x1141, "FSC ESPRIMO U9210", ALC262_FIXUP_FSC_H270),
        SND_PCI_QUIRK(0x1734, 0x1147, "FSC Celsius H270", ALC262_FIXUP_FSC_H270),
        SND_PCI_QUIRK(0x17aa, 0x384e, "Lenovo 3000", ALC262_FIXUP_LENOVO_3000),
        SND_PCI_QUIRK(0x17ff, 0x0560, "Benq ED8", ALC262_FIXUP_BENQ),
@@ -4995,7 +4996,6 @@ static void alc_fixup_tpt440_dock(struct hda_codec *codec,
        struct alc_spec *spec = codec->spec;
 
        if (action == HDA_FIXUP_ACT_PRE_PROBE) {
-               spec->shutup = alc_no_shutup; /* reduce click noise */
                spec->reboot_notify = alc_d3_at_reboot; /* reduce noise */
                spec->parse_flags = HDA_PINCFG_NO_HP_FIXUP;
                codec->power_save_node = 0; /* avoid click noises */
@@ -5394,6 +5394,13 @@ static void alc274_fixup_bind_dacs(struct hda_codec *codec,
 /* for hda_fixup_thinkpad_acpi() */
 #include "thinkpad_helper.c"
 
+static void alc_fixup_thinkpad_acpi(struct hda_codec *codec,
+                                   const struct hda_fixup *fix, int action)
+{
+       alc_fixup_no_shutup(codec, fix, action); /* reduce click noise */
+       hda_fixup_thinkpad_acpi(codec, fix, action);
+}
+
 /* for dell wmi mic mute led */
 #include "dell_wmi_helper.c"
 
@@ -5946,7 +5953,7 @@ static const struct hda_fixup alc269_fixups[] = {
        },
        [ALC269_FIXUP_THINKPAD_ACPI] = {
                .type = HDA_FIXUP_FUNC,
-               .v.func = hda_fixup_thinkpad_acpi,
+               .v.func = alc_fixup_thinkpad_acpi,
                .chained = true,
                .chain_id = ALC269_FIXUP_SKU_IGNORE,
        },
@@ -6603,8 +6610,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
        SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
        SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
+       SND_PCI_QUIRK(0x17aa, 0x312a, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
        SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
-       SND_PCI_QUIRK(0x17aa, 0x3138, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
        SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
        SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
        SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
@@ -6782,6 +6789,17 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
                {0x14, 0x90170110},
                {0x19, 0x02a11030},
                {0x21, 0x02211020}),
+       SND_HDA_PIN_QUIRK(0x10ec0235, 0x17aa, "Lenovo", ALC294_FIXUP_LENOVO_MIC_LOCATION,
+               {0x14, 0x90170110},
+               {0x19, 0x02a11030},
+               {0x1a, 0x02a11040},
+               {0x1b, 0x01014020},
+               {0x21, 0x0221101f}),
+       SND_HDA_PIN_QUIRK(0x10ec0235, 0x17aa, "Lenovo", ALC294_FIXUP_LENOVO_MIC_LOCATION,
+               {0x14, 0x90170110},
+               {0x19, 0x02a11020},
+               {0x1a, 0x02a11030},
+               {0x21, 0x0221101f}),
        SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
                {0x12, 0x90a60140},
                {0x14, 0x90170110},
index 6c85f13ab23f17f7ef4031f5f73797fb383584a7..54f6252faca684b23ef91617318c8ae11e3de04e 100644 (file)
@@ -1018,6 +1018,7 @@ static int snd_lx6464es_create(struct snd_card *card,
        chip->port_dsp_bar = pci_ioremap_bar(pci, 2);
        if (!chip->port_dsp_bar) {
                dev_err(card->dev, "cannot remap PCI memory region\n");
+               err = -ENOMEM;
                goto remap_pci_failed;
        }
 
index 30ccc902e5cfd15bb95e05b1bf1256b3b710c648..7b8533abf637319e56de6f68a37e88912d7a0c2f 100644 (file)
@@ -85,7 +85,7 @@ struct hdac_hdmi_pin {
        bool mst_capable;
        struct hdac_hdmi_port *ports;
        int num_ports;
-       struct hdac_ext_device *edev;
+       struct hdac_device *hdev;
 };
 
 struct hdac_hdmi_port {
@@ -126,6 +126,9 @@ struct hdac_hdmi_drv_data {
 };
 
 struct hdac_hdmi_priv {
+       struct hdac_device *hdev;
+       struct snd_soc_component *component;
+       struct snd_card *card;
        struct hdac_hdmi_dai_port_map dai_map[HDA_MAX_CVTS];
        struct list_head pin_list;
        struct list_head cvt_list;
@@ -139,7 +142,7 @@ struct hdac_hdmi_priv {
        struct snd_soc_dai_driver *dai_drv;
 };
 
-#define hdev_to_hdmi_priv(_hdev) ((to_ehdac_device(_hdev))->private_data)
+#define hdev_to_hdmi_priv(_hdev) dev_get_drvdata(&(_hdev)->dev)
 
 static struct hdac_hdmi_pcm *
 hdac_hdmi_get_pcm_from_cvt(struct hdac_hdmi_priv *hdmi,
@@ -158,7 +161,7 @@ hdac_hdmi_get_pcm_from_cvt(struct hdac_hdmi_priv *hdmi,
 static void hdac_hdmi_jack_report(struct hdac_hdmi_pcm *pcm,
                struct hdac_hdmi_port *port, bool is_connect)
 {
-       struct hdac_ext_device *edev = port->pin->edev;
+       struct hdac_device *hdev = port->pin->hdev;
 
        if (is_connect)
                snd_soc_dapm_enable_pin(port->dapm, port->jack_pin);
@@ -172,7 +175,7 @@ static void hdac_hdmi_jack_report(struct hdac_hdmi_pcm *pcm,
                 * ports.
                 */
                if (pcm->jack_event == 0) {
-                       dev_dbg(&edev->hdev.dev,
+                       dev_dbg(&hdev->dev,
                                        "jack report for pcm=%d\n",
                                        pcm->pcm_id);
                        snd_soc_jack_report(pcm->jack, SND_JACK_AVOUT,
@@ -198,19 +201,18 @@ static void hdac_hdmi_jack_report(struct hdac_hdmi_pcm *pcm,
 /*
  * Get the no devices that can be connected to a port on the Pin widget.
  */
-static int hdac_hdmi_get_port_len(struct hdac_ext_device *edev, hda_nid_t nid)
+static int hdac_hdmi_get_port_len(struct hdac_device *hdev, hda_nid_t nid)
 {
        unsigned int caps;
        unsigned int type, param;
 
-       caps = get_wcaps(&edev->hdev, nid);
+       caps = get_wcaps(hdev, nid);
        type = get_wcaps_type(caps);
 
        if (!(caps & AC_WCAP_DIGITAL) || (type != AC_WID_PIN))
                return 0;
 
-       param = snd_hdac_read_parm_uncached(&edev->hdev, nid,
-                                       AC_PAR_DEVLIST_LEN);
+       param = snd_hdac_read_parm_uncached(hdev, nid, AC_PAR_DEVLIST_LEN);
        if (param == -1)
                return param;
 
@@ -222,10 +224,10 @@ static int hdac_hdmi_get_port_len(struct hdac_ext_device *edev, hda_nid_t nid)
  * id selected on the pin. Return 0 means the first port entry
  * is selected or MST is not supported.
  */
-static int hdac_hdmi_port_select_get(struct hdac_ext_device *edev,
+static int hdac_hdmi_port_select_get(struct hdac_device *hdev,
                                        struct hdac_hdmi_port *port)
 {
-       return snd_hdac_codec_read(&edev->hdev, port->pin->nid,
+       return snd_hdac_codec_read(hdev, port->pin->nid,
                                0, AC_VERB_GET_DEVICE_SEL, 0);
 }
 
@@ -233,7 +235,7 @@ static int hdac_hdmi_port_select_get(struct hdac_ext_device *edev,
  * Sets the selected port entry for the configuring Pin widget verb.
  * returns error if port set is not equal to port get otherwise success
  */
-static int hdac_hdmi_port_select_set(struct hdac_ext_device *edev,
+static int hdac_hdmi_port_select_set(struct hdac_device *hdev,
                                        struct hdac_hdmi_port *port)
 {
        int num_ports;
@@ -242,8 +244,7 @@ static int hdac_hdmi_port_select_set(struct hdac_ext_device *edev,
                return 0;
 
        /* AC_PAR_DEVLIST_LEN is 0 based. */
-       num_ports = hdac_hdmi_get_port_len(edev, port->pin->nid);
-
+       num_ports = hdac_hdmi_get_port_len(hdev, port->pin->nid);
        if (num_ports < 0)
                return -EIO;
        /*
@@ -253,13 +254,13 @@ static int hdac_hdmi_port_select_set(struct hdac_ext_device *edev,
        if (num_ports + 1  < port->id)
                return 0;
 
-       snd_hdac_codec_write(&edev->hdev, port->pin->nid, 0,
+       snd_hdac_codec_write(hdev, port->pin->nid, 0,
                        AC_VERB_SET_DEVICE_SEL, port->id);
 
-       if (port->id != hdac_hdmi_port_select_get(edev, port))
+       if (port->id != hdac_hdmi_port_select_get(hdev, port))
                return -EIO;
 
-       dev_dbg(&edev->hdev.dev, "Selected the port=%d\n", port->id);
+       dev_dbg(&hdev->dev, "Selected the port=%d\n", port->id);
 
        return 0;
 }
@@ -277,13 +278,6 @@ static struct hdac_hdmi_pcm *get_hdmi_pcm_from_id(struct hdac_hdmi_priv *hdmi,
        return NULL;
 }
 
-static inline struct hdac_ext_device *to_hda_ext_device(struct device *dev)
-{
-       struct hdac_device *hdev = dev_to_hdac_dev(dev);
-
-       return to_ehdac_device(hdev);
-}
-
 static unsigned int sad_format(const u8 *sad)
 {
        return ((sad[0] >> 0x3) & 0x1f);
@@ -324,15 +318,13 @@ format_constraint:
 }
 
 static void
-hdac_hdmi_set_dip_index(struct hdac_ext_device *edev, hda_nid_t pin_nid,
+hdac_hdmi_set_dip_index(struct hdac_device *hdev, hda_nid_t pin_nid,
                                int packet_index, int byte_index)
 {
        int val;
 
        val = (packet_index << 5) | (byte_index & 0x1f);
-
-       snd_hdac_codec_write(&edev->hdev, pin_nid, 0,
-                               AC_VERB_SET_HDMI_DIP_INDEX, val);
+       snd_hdac_codec_write(hdev, pin_nid, 0, AC_VERB_SET_HDMI_DIP_INDEX, val);
 }
 
 struct dp_audio_infoframe {
@@ -347,14 +339,14 @@ struct dp_audio_infoframe {
        u8 LFEPBL01_LSV36_DM_INH7;
 };
 
-static int hdac_hdmi_setup_audio_infoframe(struct hdac_ext_device *edev,
+static int hdac_hdmi_setup_audio_infoframe(struct hdac_device *hdev,
                   struct hdac_hdmi_pcm *pcm, struct hdac_hdmi_port *port)
 {
        uint8_t buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_AUDIO_INFOFRAME_SIZE];
        struct hdmi_audio_infoframe frame;
        struct hdac_hdmi_pin *pin = port->pin;
        struct dp_audio_infoframe dp_ai;
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_cvt *cvt = pcm->cvt;
        u8 *dip;
        int ret;
@@ -363,11 +355,11 @@ static int hdac_hdmi_setup_audio_infoframe(struct hdac_ext_device *edev,
        u8 conn_type;
        int channels, ca;
 
-       ca = snd_hdac_channel_allocation(&edev->hdev, port->eld.info.spk_alloc,
+       ca = snd_hdac_channel_allocation(hdev, port->eld.info.spk_alloc,
                        pcm->channels, pcm->chmap_set, true, pcm->chmap);
 
        channels = snd_hdac_get_active_channels(ca);
-       hdmi->chmap.ops.set_channel_count(&edev->hdev, cvt->nid, channels);
+       hdmi->chmap.ops.set_channel_count(hdev, cvt->nid, channels);
 
        snd_hdac_setup_channel_mapping(&hdmi->chmap, pin->nid, false, ca,
                                pcm->channels, pcm->chmap, pcm->chmap_set);
@@ -400,32 +392,31 @@ static int hdac_hdmi_setup_audio_infoframe(struct hdac_ext_device *edev,
                break;
 
        default:
-               dev_err(&edev->hdev.dev, "Invalid connection type: %d\n",
-                                               conn_type);
+               dev_err(&hdev->dev, "Invalid connection type: %d\n", conn_type);
                return -EIO;
        }
 
        /* stop infoframe transmission */
-       hdac_hdmi_set_dip_index(edev, pin->nid, 0x0, 0x0);
-       snd_hdac_codec_write(&edev->hdev, pin->nid, 0,
+       hdac_hdmi_set_dip_index(hdev, pin->nid, 0x0, 0x0);
+       snd_hdac_codec_write(hdev, pin->nid, 0,
                        AC_VERB_SET_HDMI_DIP_XMIT, AC_DIPXMIT_DISABLE);
 
 
        /*  Fill infoframe. Index auto-incremented */
-       hdac_hdmi_set_dip_index(edev, pin->nid, 0x0, 0x0);
+       hdac_hdmi_set_dip_index(hdev, pin->nid, 0x0, 0x0);
        if (conn_type == DRM_ELD_CONN_TYPE_HDMI) {
                for (i = 0; i < sizeof(buffer); i++)
-                       snd_hdac_codec_write(&edev->hdev, pin->nid, 0,
+                       snd_hdac_codec_write(hdev, pin->nid, 0,
                                AC_VERB_SET_HDMI_DIP_DATA, buffer[i]);
        } else {
                for (i = 0; i < sizeof(dp_ai); i++)
-                       snd_hdac_codec_write(&edev->hdev, pin->nid, 0,
+                       snd_hdac_codec_write(hdev, pin->nid, 0,
                                AC_VERB_SET_HDMI_DIP_DATA, dip[i]);
        }
 
        /* Start infoframe */
-       hdac_hdmi_set_dip_index(edev, pin->nid, 0x0, 0x0);
-       snd_hdac_codec_write(&edev->hdev, pin->nid, 0,
+       hdac_hdmi_set_dip_index(hdev, pin->nid, 0x0, 0x0);
+       snd_hdac_codec_write(hdev, pin->nid, 0,
                        AC_VERB_SET_HDMI_DIP_XMIT, AC_DIPXMIT_BEST);
 
        return 0;
@@ -435,12 +426,12 @@ static int hdac_hdmi_set_tdm_slot(struct snd_soc_dai *dai,
                unsigned int tx_mask, unsigned int rx_mask,
                int slots, int slot_width)
 {
-       struct hdac_ext_device *edev = snd_soc_dai_get_drvdata(dai);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = snd_soc_dai_get_drvdata(dai);
+       struct hdac_device *hdev = hdmi->hdev;
        struct hdac_hdmi_dai_port_map *dai_map;
        struct hdac_hdmi_pcm *pcm;
 
-       dev_dbg(&edev->hdev.dev, "%s: strm_tag: %d\n", __func__, tx_mask);
+       dev_dbg(&hdev->dev, "%s: strm_tag: %d\n", __func__, tx_mask);
 
        dai_map = &hdmi->dai_map[dai->id];
 
@@ -455,8 +446,8 @@ static int hdac_hdmi_set_tdm_slot(struct snd_soc_dai *dai,
 static int hdac_hdmi_set_hw_params(struct snd_pcm_substream *substream,
        struct snd_pcm_hw_params *hparams, struct snd_soc_dai *dai)
 {
-       struct hdac_ext_device *edev = snd_soc_dai_get_drvdata(dai);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = snd_soc_dai_get_drvdata(dai);
+       struct hdac_device *hdev = hdmi->hdev;
        struct hdac_hdmi_dai_port_map *dai_map;
        struct hdac_hdmi_port *port;
        struct hdac_hdmi_pcm *pcm;
@@ -469,7 +460,7 @@ static int hdac_hdmi_set_hw_params(struct snd_pcm_substream *substream,
                return -ENODEV;
 
        if ((!port->eld.monitor_present) || (!port->eld.eld_valid)) {
-               dev_err(&edev->hdev.dev,
+               dev_err(&hdev->dev,
                        "device is not configured for this pin:port%d:%d\n",
                                        port->pin->nid, port->id);
                return -ENODEV;
@@ -489,28 +480,28 @@ static int hdac_hdmi_set_hw_params(struct snd_pcm_substream *substream,
        return 0;
 }
 
-static int hdac_hdmi_query_port_connlist(struct hdac_ext_device *edev,
+static int hdac_hdmi_query_port_connlist(struct hdac_device *hdev,
                                        struct hdac_hdmi_pin *pin,
                                        struct hdac_hdmi_port *port)
 {
-       if (!(get_wcaps(&edev->hdev, pin->nid) & AC_WCAP_CONN_LIST)) {
-               dev_warn(&edev->hdev.dev,
+       if (!(get_wcaps(hdev, pin->nid) & AC_WCAP_CONN_LIST)) {
+               dev_warn(&hdev->dev,
                        "HDMI: pin %d wcaps %#x does not support connection list\n",
-                       pin->nid, get_wcaps(&edev->hdev, pin->nid));
+                       pin->nid, get_wcaps(hdev, pin->nid));
                return -EINVAL;
        }
 
-       if (hdac_hdmi_port_select_set(edev, port) < 0)
+       if (hdac_hdmi_port_select_set(hdev, port) < 0)
                return -EIO;
 
-       port->num_mux_nids = snd_hdac_get_connections(&edev->hdev, pin->nid,
+       port->num_mux_nids = snd_hdac_get_connections(hdev, pin->nid,
                        port->mux_nids, HDA_MAX_CONNECTIONS);
        if (port->num_mux_nids == 0)
-               dev_warn(&edev->hdev.dev,
+               dev_warn(&hdev->dev,
                        "No connections found for pin:port %d:%d\n",
                                                pin->nid, port->id);
 
-       dev_dbg(&edev->hdev.dev, "num_mux_nids %d for pin:port %d:%d\n",
+       dev_dbg(&hdev->dev, "num_mux_nids %d for pin:port %d:%d\n",
                        port->num_mux_nids, pin->nid, port->id);
 
        return port->num_mux_nids;
@@ -526,7 +517,7 @@ static int hdac_hdmi_query_port_connlist(struct hdac_ext_device *edev,
  * connected.
  */
 static struct hdac_hdmi_port *hdac_hdmi_get_port_from_cvt(
-                       struct hdac_ext_device *edev,
+                       struct hdac_device *hdev,
                        struct hdac_hdmi_priv *hdmi,
                        struct hdac_hdmi_cvt *cvt)
 {
@@ -541,7 +532,7 @@ static struct hdac_hdmi_port *hdac_hdmi_get_port_from_cvt(
 
                        list_for_each_entry(port, &pcm->port_list, head) {
                                mutex_lock(&pcm->lock);
-                               ret = hdac_hdmi_query_port_connlist(edev,
+                               ret = hdac_hdmi_query_port_connlist(hdev,
                                                        port->pin, port);
                                mutex_unlock(&pcm->lock);
                                if (ret < 0)
@@ -568,8 +559,8 @@ static struct hdac_hdmi_port *hdac_hdmi_get_port_from_cvt(
 static int hdac_hdmi_pcm_open(struct snd_pcm_substream *substream,
                        struct snd_soc_dai *dai)
 {
-       struct hdac_ext_device *edev = snd_soc_dai_get_drvdata(dai);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = snd_soc_dai_get_drvdata(dai);
+       struct hdac_device *hdev = hdmi->hdev;
        struct hdac_hdmi_dai_port_map *dai_map;
        struct hdac_hdmi_cvt *cvt;
        struct hdac_hdmi_port *port;
@@ -578,7 +569,7 @@ static int hdac_hdmi_pcm_open(struct snd_pcm_substream *substream,
        dai_map = &hdmi->dai_map[dai->id];
 
        cvt = dai_map->cvt;
-       port = hdac_hdmi_get_port_from_cvt(edev, hdmi, cvt);
+       port = hdac_hdmi_get_port_from_cvt(hdev, hdmi, cvt);
 
        /*
         * To make PA and other userland happy.
@@ -589,7 +580,7 @@ static int hdac_hdmi_pcm_open(struct snd_pcm_substream *substream,
        if ((!port->eld.monitor_present) ||
                        (!port->eld.eld_valid)) {
 
-               dev_warn(&edev->hdev.dev,
+               dev_warn(&hdev->dev,
                        "Failed: present?:%d ELD valid?:%d pin:port: %d:%d\n",
                        port->eld.monitor_present, port->eld.eld_valid,
                        port->pin->nid, port->id);
@@ -611,8 +602,7 @@ static int hdac_hdmi_pcm_open(struct snd_pcm_substream *substream,
 static void hdac_hdmi_pcm_close(struct snd_pcm_substream *substream,
                struct snd_soc_dai *dai)
 {
-       struct hdac_ext_device *edev = snd_soc_dai_get_drvdata(dai);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = snd_soc_dai_get_drvdata(dai);
        struct hdac_hdmi_dai_port_map *dai_map;
        struct hdac_hdmi_pcm *pcm;
 
@@ -695,10 +685,10 @@ static void hdac_hdmi_fill_route(struct snd_soc_dapm_route *route,
        route->connected = handler;
 }
 
-static struct hdac_hdmi_pcm *hdac_hdmi_get_pcm(struct hdac_ext_device *edev,
+static struct hdac_hdmi_pcm *hdac_hdmi_get_pcm(struct hdac_device *hdev,
                                        struct hdac_hdmi_port *port)
 {
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_pcm *pcm = NULL;
        struct hdac_hdmi_port *p;
 
@@ -715,33 +705,32 @@ static struct hdac_hdmi_pcm *hdac_hdmi_get_pcm(struct hdac_ext_device *edev,
        return NULL;
 }
 
-static void hdac_hdmi_set_power_state(struct hdac_ext_device *edev,
+static void hdac_hdmi_set_power_state(struct hdac_device *hdev,
                             hda_nid_t nid, unsigned int pwr_state)
 {
        int count;
        unsigned int state;
 
-       if (get_wcaps(&edev->hdev, nid) & AC_WCAP_POWER) {
-               if (!snd_hdac_check_power_state(&edev->hdev, nid, pwr_state)) {
+       if (get_wcaps(hdev, nid) & AC_WCAP_POWER) {
+               if (!snd_hdac_check_power_state(hdev, nid, pwr_state)) {
                        for (count = 0; count < 10; count++) {
-                               snd_hdac_codec_read(&edev->hdev, nid, 0,
+                               snd_hdac_codec_read(hdev, nid, 0,
                                                AC_VERB_SET_POWER_STATE,
                                                pwr_state);
-                               state = snd_hdac_sync_power_state(&edev->hdev,
+                               state = snd_hdac_sync_power_state(hdev,
                                                nid, pwr_state);
                                if (!(state & AC_PWRST_ERROR))
                                        break;
                        }
                }
-
        }
 }
 
-static void hdac_hdmi_set_amp(struct hdac_ext_device *edev,
+static void hdac_hdmi_set_amp(struct hdac_device *hdev,
                                   hda_nid_t nid, int val)
 {
-       if (get_wcaps(&edev->hdev, nid) & AC_WCAP_OUT_AMP)
-               snd_hdac_codec_write(&edev->hdev, nid, 0,
+       if (get_wcaps(hdev, nid) & AC_WCAP_OUT_AMP)
+               snd_hdac_codec_write(hdev, nid, 0,
                                        AC_VERB_SET_AMP_GAIN_MUTE, val);
 }
 
@@ -750,40 +739,40 @@ static int hdac_hdmi_pin_output_widget_event(struct snd_soc_dapm_widget *w,
                                        struct snd_kcontrol *kc, int event)
 {
        struct hdac_hdmi_port *port = w->priv;
-       struct hdac_ext_device *edev = to_hda_ext_device(w->dapm->dev);
+       struct hdac_device *hdev = dev_to_hdac_dev(w->dapm->dev);
        struct hdac_hdmi_pcm *pcm;
 
-       dev_dbg(&edev->hdev.dev, "%s: widget: %s event: %x\n",
+       dev_dbg(&hdev->dev, "%s: widget: %s event: %x\n",
                        __func__, w->name, event);
 
-       pcm = hdac_hdmi_get_pcm(edev, port);
+       pcm = hdac_hdmi_get_pcm(hdev, port);
        if (!pcm)
                return -EIO;
 
        /* set the device if pin is mst_capable */
-       if (hdac_hdmi_port_select_set(edev, port) < 0)
+       if (hdac_hdmi_port_select_set(hdev, port) < 0)
                return -EIO;
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
-               hdac_hdmi_set_power_state(edev, port->pin->nid, AC_PWRST_D0);
+               hdac_hdmi_set_power_state(hdev, port->pin->nid, AC_PWRST_D0);
 
                /* Enable out path for this pin widget */
-               snd_hdac_codec_write(&edev->hdev, port->pin->nid, 0,
+               snd_hdac_codec_write(hdev, port->pin->nid, 0,
                                AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
 
-               hdac_hdmi_set_amp(edev, port->pin->nid, AMP_OUT_UNMUTE);
+               hdac_hdmi_set_amp(hdev, port->pin->nid, AMP_OUT_UNMUTE);
 
-               return hdac_hdmi_setup_audio_infoframe(edev, pcm, port);
+               return hdac_hdmi_setup_audio_infoframe(hdev, pcm, port);
 
        case SND_SOC_DAPM_POST_PMD:
-               hdac_hdmi_set_amp(edev, port->pin->nid, AMP_OUT_MUTE);
+               hdac_hdmi_set_amp(hdev, port->pin->nid, AMP_OUT_MUTE);
 
                /* Disable out path for this pin widget */
-               snd_hdac_codec_write(&edev->hdev, port->pin->nid, 0,
+               snd_hdac_codec_write(hdev, port->pin->nid, 0,
                                AC_VERB_SET_PIN_WIDGET_CONTROL, 0);
 
-               hdac_hdmi_set_power_state(edev, port->pin->nid, AC_PWRST_D3);
+               hdac_hdmi_set_power_state(hdev, port->pin->nid, AC_PWRST_D3);
                break;
 
        }
@@ -795,11 +784,11 @@ static int hdac_hdmi_cvt_output_widget_event(struct snd_soc_dapm_widget *w,
                                        struct snd_kcontrol *kc, int event)
 {
        struct hdac_hdmi_cvt *cvt = w->priv;
-       struct hdac_ext_device *edev = to_hda_ext_device(w->dapm->dev);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_device *hdev = dev_to_hdac_dev(w->dapm->dev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_pcm *pcm;
 
-       dev_dbg(&edev->hdev.dev, "%s: widget: %s event: %x\n",
+       dev_dbg(&hdev->dev, "%s: widget: %s event: %x\n",
                        __func__, w->name, event);
 
        pcm = hdac_hdmi_get_pcm_from_cvt(hdmi, cvt);
@@ -808,29 +797,29 @@ static int hdac_hdmi_cvt_output_widget_event(struct snd_soc_dapm_widget *w,
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
-               hdac_hdmi_set_power_state(edev, cvt->nid, AC_PWRST_D0);
+               hdac_hdmi_set_power_state(hdev, cvt->nid, AC_PWRST_D0);
 
                /* Enable transmission */
-               snd_hdac_codec_write(&edev->hdev, cvt->nid, 0,
+               snd_hdac_codec_write(hdev, cvt->nid, 0,
                        AC_VERB_SET_DIGI_CONVERT_1, 1);
 
                /* Category Code (CC) to zero */
-               snd_hdac_codec_write(&edev->hdev, cvt->nid, 0,
+               snd_hdac_codec_write(hdev, cvt->nid, 0,
                        AC_VERB_SET_DIGI_CONVERT_2, 0);
 
-               snd_hdac_codec_write(&edev->hdev, cvt->nid, 0,
+               snd_hdac_codec_write(hdev, cvt->nid, 0,
                                AC_VERB_SET_CHANNEL_STREAMID, pcm->stream_tag);
-               snd_hdac_codec_write(&edev->hdev, cvt->nid, 0,
+               snd_hdac_codec_write(hdev, cvt->nid, 0,
                                AC_VERB_SET_STREAM_FORMAT, pcm->format);
                break;
 
        case SND_SOC_DAPM_POST_PMD:
-               snd_hdac_codec_write(&edev->hdev, cvt->nid, 0,
+               snd_hdac_codec_write(hdev, cvt->nid, 0,
                                AC_VERB_SET_CHANNEL_STREAMID, 0);
-               snd_hdac_codec_write(&edev->hdev, cvt->nid, 0,
+               snd_hdac_codec_write(hdev, cvt->nid, 0,
                                AC_VERB_SET_STREAM_FORMAT, 0);
 
-               hdac_hdmi_set_power_state(edev, cvt->nid, AC_PWRST_D3);
+               hdac_hdmi_set_power_state(hdev, cvt->nid, AC_PWRST_D3);
                break;
 
        }
@@ -842,10 +831,10 @@ static int hdac_hdmi_pin_mux_widget_event(struct snd_soc_dapm_widget *w,
                                        struct snd_kcontrol *kc, int event)
 {
        struct hdac_hdmi_port *port = w->priv;
-       struct hdac_ext_device *edev = to_hda_ext_device(w->dapm->dev);
+       struct hdac_device *hdev = dev_to_hdac_dev(w->dapm->dev);
        int mux_idx;
 
-       dev_dbg(&edev->hdev.dev, "%s: widget: %s event: %x\n",
+       dev_dbg(&hdev->dev, "%s: widget: %s event: %x\n",
                        __func__, w->name, event);
 
        if (!kc)
@@ -854,11 +843,11 @@ static int hdac_hdmi_pin_mux_widget_event(struct snd_soc_dapm_widget *w,
        mux_idx = dapm_kcontrol_get_value(kc);
 
        /* set the device if pin is mst_capable */
-       if (hdac_hdmi_port_select_set(edev, port) < 0)
+       if (hdac_hdmi_port_select_set(hdev, port) < 0)
                return -EIO;
 
        if (mux_idx > 0) {
-               snd_hdac_codec_write(&edev->hdev, port->pin->nid, 0,
+               snd_hdac_codec_write(hdev, port->pin->nid, 0,
                        AC_VERB_SET_CONNECT_SEL, (mux_idx - 1));
        }
 
@@ -877,8 +866,8 @@ static int hdac_hdmi_set_pin_port_mux(struct snd_kcontrol *kcontrol,
        struct snd_soc_dapm_widget *w = snd_soc_dapm_kcontrol_widget(kcontrol);
        struct snd_soc_dapm_context *dapm = w->dapm;
        struct hdac_hdmi_port *port = w->priv;
-       struct hdac_ext_device *edev = to_hda_ext_device(dapm->dev);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_device *hdev = dev_to_hdac_dev(dapm->dev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_pcm *pcm = NULL;
        const char *cvt_name =  e->texts[ucontrol->value.enumerated.item[0]];
 
@@ -931,12 +920,12 @@ static int hdac_hdmi_set_pin_port_mux(struct snd_kcontrol *kcontrol,
  * care of selecting the right one and leaving all other inputs selected to
  * "NONE"
  */
-static int hdac_hdmi_create_pin_port_muxs(struct hdac_ext_device *edev,
+static int hdac_hdmi_create_pin_port_muxs(struct hdac_device *hdev,
                                struct hdac_hdmi_port *port,
                                struct snd_soc_dapm_widget *widget,
                                const char *widget_name)
 {
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_pin *pin = port->pin;
        struct snd_kcontrol_new *kc;
        struct hdac_hdmi_cvt *cvt;
@@ -948,17 +937,17 @@ static int hdac_hdmi_create_pin_port_muxs(struct hdac_ext_device *edev,
        int i = 0;
        int num_items = hdmi->num_cvt + 1;
 
-       kc = devm_kzalloc(&edev->hdev.dev, sizeof(*kc), GFP_KERNEL);
+       kc = devm_kzalloc(&hdev->dev, sizeof(*kc), GFP_KERNEL);
        if (!kc)
                return -ENOMEM;
 
-       se = devm_kzalloc(&edev->hdev.dev, sizeof(*se), GFP_KERNEL);
+       se = devm_kzalloc(&hdev->dev, sizeof(*se), GFP_KERNEL);
        if (!se)
                return -ENOMEM;
 
        snprintf(kc_name, NAME_SIZE, "Pin %d port %d Input",
                                                pin->nid, port->id);
-       kc->name = devm_kstrdup(&edev->hdev.dev, kc_name, GFP_KERNEL);
+       kc->name = devm_kstrdup(&hdev->dev, kc_name, GFP_KERNEL);
        if (!kc->name)
                return -ENOMEM;
 
@@ -976,35 +965,35 @@ static int hdac_hdmi_create_pin_port_muxs(struct hdac_ext_device *edev,
        se->mask = roundup_pow_of_two(se->items) - 1;
 
        sprintf(mux_items, "NONE");
-       items[i] = devm_kstrdup(&edev->hdev.dev, mux_items, GFP_KERNEL);
+       items[i] = devm_kstrdup(&hdev->dev, mux_items, GFP_KERNEL);
        if (!items[i])
                return -ENOMEM;
 
        list_for_each_entry(cvt, &hdmi->cvt_list, head) {
                i++;
                sprintf(mux_items, "cvt %d", cvt->nid);
-               items[i] = devm_kstrdup(&edev->hdev.dev, mux_items, GFP_KERNEL);
+               items[i] = devm_kstrdup(&hdev->dev, mux_items, GFP_KERNEL);
                if (!items[i])
                        return -ENOMEM;
        }
 
-       se->texts = devm_kmemdup(&edev->hdev.dev, items,
+       se->texts = devm_kmemdup(&hdev->dev, items,
                        (num_items  * sizeof(char *)), GFP_KERNEL);
        if (!se->texts)
                return -ENOMEM;
 
-       return hdac_hdmi_fill_widget_info(&edev->hdev.dev, widget,
+       return hdac_hdmi_fill_widget_info(&hdev->dev, widget,
                        snd_soc_dapm_mux, port, widget_name, NULL, kc, 1,
                        hdac_hdmi_pin_mux_widget_event,
                        SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_REG);
 }
 
 /* Add cvt <- input <- mux route map */
-static void hdac_hdmi_add_pinmux_cvt_route(struct hdac_ext_device *edev,
+static void hdac_hdmi_add_pinmux_cvt_route(struct hdac_device *hdev,
                        struct snd_soc_dapm_widget *widgets,
                        struct snd_soc_dapm_route *route, int rindex)
 {
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        const struct snd_kcontrol_new *kc;
        struct soc_enum *se;
        int mux_index = hdmi->num_cvt + hdmi->num_ports;
@@ -1046,8 +1035,8 @@ static int create_fill_widget_route_map(struct snd_soc_dapm_context *dapm)
 {
        struct snd_soc_dapm_widget *widgets;
        struct snd_soc_dapm_route *route;
-       struct hdac_ext_device *edev = to_hda_ext_device(dapm->dev);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_device *hdev = dev_to_hdac_dev(dapm->dev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct snd_soc_dai_driver *dai_drv = hdmi->dai_drv;
        char widget_name[NAME_SIZE];
        struct hdac_hdmi_cvt *cvt;
@@ -1099,7 +1088,7 @@ static int create_fill_widget_route_map(struct snd_soc_dapm_context *dapm)
                for (j = 0; j < pin->num_ports; j++) {
                        sprintf(widget_name, "Pin%d-Port%d Mux",
                                pin->nid, pin->ports[j].id);
-                       ret = hdac_hdmi_create_pin_port_muxs(edev,
+                       ret = hdac_hdmi_create_pin_port_muxs(hdev,
                                                &pin->ports[j], &widgets[i],
                                                widget_name);
                        if (ret < 0)
@@ -1134,7 +1123,7 @@ static int create_fill_widget_route_map(struct snd_soc_dapm_context *dapm)
                }
        }
 
-       hdac_hdmi_add_pinmux_cvt_route(edev, widgets, route, i);
+       hdac_hdmi_add_pinmux_cvt_route(hdev, widgets, route, i);
 
        snd_soc_dapm_new_controls(dapm, widgets,
                ((2 * hdmi->num_ports) + hdmi->num_cvt));
@@ -1146,9 +1135,9 @@ static int create_fill_widget_route_map(struct snd_soc_dapm_context *dapm)
 
 }
 
-static int hdac_hdmi_init_dai_map(struct hdac_ext_device *edev)
+static int hdac_hdmi_init_dai_map(struct hdac_device *hdev)
 {
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_dai_port_map *dai_map;
        struct hdac_hdmi_cvt *cvt;
        int dai_id = 0;
@@ -1164,7 +1153,7 @@ static int hdac_hdmi_init_dai_map(struct hdac_ext_device *edev)
                dai_id++;
 
                if (dai_id == HDA_MAX_CVTS) {
-                       dev_warn(&edev->hdev.dev,
+                       dev_warn(&hdev->dev,
                                "Max dais supported: %d\n", dai_id);
                        break;
                }
@@ -1173,9 +1162,9 @@ static int hdac_hdmi_init_dai_map(struct hdac_ext_device *edev)
        return 0;
 }
 
-static int hdac_hdmi_add_cvt(struct hdac_ext_device *edev, hda_nid_t nid)
+static int hdac_hdmi_add_cvt(struct hdac_device *hdev, hda_nid_t nid)
 {
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_cvt *cvt;
        char name[NAME_SIZE];
 
@@ -1190,10 +1179,10 @@ static int hdac_hdmi_add_cvt(struct hdac_ext_device *edev, hda_nid_t nid)
        list_add_tail(&cvt->head, &hdmi->cvt_list);
        hdmi->num_cvt++;
 
-       return hdac_hdmi_query_cvt_params(&edev->hdev, cvt);
+       return hdac_hdmi_query_cvt_params(hdev, cvt);
 }
 
-static int hdac_hdmi_parse_eld(struct hdac_ext_device *edev,
+static int hdac_hdmi_parse_eld(struct hdac_device *hdev,
                        struct hdac_hdmi_port *port)
 {
        unsigned int ver, mnl;
@@ -1202,7 +1191,7 @@ static int hdac_hdmi_parse_eld(struct hdac_ext_device *edev,
                                                >> DRM_ELD_VER_SHIFT;
 
        if (ver != ELD_VER_CEA_861D && ver != ELD_VER_PARTIAL) {
-               dev_err(&edev->hdev.dev, "HDMI: Unknown ELD version %d\n", ver);
+               dev_err(&hdev->dev, "HDMI: Unknown ELD version %d\n", ver);
                return -EINVAL;
        }
 
@@ -1210,7 +1199,7 @@ static int hdac_hdmi_parse_eld(struct hdac_ext_device *edev,
                DRM_ELD_MNL_MASK) >> DRM_ELD_MNL_SHIFT;
 
        if (mnl > ELD_MAX_MNL) {
-               dev_err(&edev->hdev.dev, "HDMI: MNL Invalid %d\n", mnl);
+               dev_err(&hdev->dev, "HDMI: MNL Invalid %d\n", mnl);
                return -EINVAL;
        }
 
@@ -1222,8 +1211,8 @@ static int hdac_hdmi_parse_eld(struct hdac_ext_device *edev,
 static void hdac_hdmi_present_sense(struct hdac_hdmi_pin *pin,
                                    struct hdac_hdmi_port *port)
 {
-       struct hdac_ext_device *edev = pin->edev;
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_device *hdev = pin->hdev;
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_pcm *pcm;
        int size = 0;
        int port_id = -1;
@@ -1241,14 +1230,14 @@ static void hdac_hdmi_present_sense(struct hdac_hdmi_pin *pin,
        if (pin->mst_capable)
                port_id = port->id;
 
-       size = snd_hdac_acomp_get_eld(&edev->hdev, pin->nid, port_id,
+       size = snd_hdac_acomp_get_eld(hdev, pin->nid, port_id,
                                &port->eld.monitor_present,
                                port->eld.eld_buffer,
                                ELD_MAX_SIZE);
 
        if (size > 0) {
                size = min(size, ELD_MAX_SIZE);
-               if (hdac_hdmi_parse_eld(edev, port) < 0)
+               if (hdac_hdmi_parse_eld(hdev, port) < 0)
                        size = -EINVAL;
        }
 
@@ -1260,11 +1249,11 @@ static void hdac_hdmi_present_sense(struct hdac_hdmi_pin *pin,
                port->eld.eld_size = 0;
        }
 
-       pcm = hdac_hdmi_get_pcm(edev, port);
+       pcm = hdac_hdmi_get_pcm(hdev, port);
 
        if (!port->eld.monitor_present || !port->eld.eld_valid) {
 
-               dev_err(&edev->hdev.dev, "%s: disconnect for pin:port %d:%d\n",
+               dev_err(&hdev->dev, "%s: disconnect for pin:port %d:%d\n",
                                                __func__, pin->nid, port->id);
 
                /*
@@ -1316,9 +1305,9 @@ static int hdac_hdmi_add_ports(struct hdac_hdmi_priv *hdmi,
        return 0;
 }
 
-static int hdac_hdmi_add_pin(struct hdac_ext_device *edev, hda_nid_t nid)
+static int hdac_hdmi_add_pin(struct hdac_device *hdev, hda_nid_t nid)
 {
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_pin *pin;
        int ret;
 
@@ -1328,7 +1317,7 @@ static int hdac_hdmi_add_pin(struct hdac_ext_device *edev, hda_nid_t nid)
 
        pin->nid = nid;
        pin->mst_capable = false;
-       pin->edev = edev;
+       pin->hdev = hdev;
        ret = hdac_hdmi_add_ports(hdmi, pin);
        if (ret < 0)
                return ret;
@@ -1459,15 +1448,14 @@ static int hdac_hdmi_create_dais(struct hdac_device *hdev,
  * Parse all nodes and store the cvt/pin nids in array
  * Add one time initialization for pin and cvt widgets
  */
-static int hdac_hdmi_parse_and_map_nid(struct hdac_ext_device *edev,
+static int hdac_hdmi_parse_and_map_nid(struct hdac_device *hdev,
                struct snd_soc_dai_driver **dais, int *num_dais)
 {
        hda_nid_t nid;
        int i, num_nodes;
        struct hdac_hdmi_cvt *temp_cvt, *cvt_next;
        struct hdac_hdmi_pin *temp_pin, *pin_next;
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
-       struct hdac_device *hdev = &edev->hdev;
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        int ret;
 
        hdac_hdmi_skl_enable_all_pins(hdev);
@@ -1492,13 +1480,13 @@ static int hdac_hdmi_parse_and_map_nid(struct hdac_ext_device *edev,
                switch (type) {
 
                case AC_WID_AUD_OUT:
-                       ret = hdac_hdmi_add_cvt(edev, nid);
+                       ret = hdac_hdmi_add_cvt(hdev, nid);
                        if (ret < 0)
                                goto free_widgets;
                        break;
 
                case AC_WID_PIN:
-                       ret = hdac_hdmi_add_pin(edev, nid);
+                       ret = hdac_hdmi_add_pin(hdev, nid);
                        if (ret < 0)
                                goto free_widgets;
                        break;
@@ -1518,7 +1506,7 @@ static int hdac_hdmi_parse_and_map_nid(struct hdac_ext_device *edev,
        }
 
        *num_dais = hdmi->num_cvt;
-       ret = hdac_hdmi_init_dai_map(edev);
+       ret = hdac_hdmi_init_dai_map(hdev);
        if (ret < 0)
                goto free_widgets;
 
@@ -1542,19 +1530,24 @@ free_widgets:
        return ret;
 }
 
+static int hdac_hdmi_pin2port(void *aptr, int pin)
+{
+       return pin - 4; /* map NID 0x05 -> port #1 */
+}
+
 static void hdac_hdmi_eld_notify_cb(void *aptr, int port, int pipe)
 {
-       struct hdac_ext_device *edev = aptr;
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_device *hdev = aptr;
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_pin *pin = NULL;
        struct hdac_hdmi_port *hport = NULL;
-       struct snd_soc_component *component = edev->scodec;
+       struct snd_soc_component *component = hdmi->component;
        int i;
 
        /* Don't know how this mapping is derived */
        hda_nid_t pin_nid = port + 0x04;
 
-       dev_dbg(&edev->hdev.dev, "%s: for pin:%d port=%d\n", __func__,
+       dev_dbg(&hdev->dev, "%s: for pin:%d port=%d\n", __func__,
                                                        pin_nid, pipe);
 
        /*
@@ -1567,7 +1560,7 @@ static void hdac_hdmi_eld_notify_cb(void *aptr, int port, int pipe)
                        SNDRV_CTL_POWER_D0)
                return;
 
-       if (atomic_read(&edev->hdev.in_pm))
+       if (atomic_read(&hdev->in_pm))
                return;
 
        list_for_each_entry(pin, &hdmi->pin_list, head) {
@@ -1595,7 +1588,8 @@ static void hdac_hdmi_eld_notify_cb(void *aptr, int port, int pipe)
 
 }
 
-static struct i915_audio_component_audio_ops aops = {
+static struct drm_audio_component_audio_ops aops = {
+       .pin2port       = hdac_hdmi_pin2port,
        .pin_eld_notify = hdac_hdmi_eld_notify_cb,
 };
 
@@ -1614,15 +1608,15 @@ static struct snd_pcm *hdac_hdmi_get_pcm_from_id(struct snd_soc_card *card,
 
 /* create jack pin kcontrols */
 static int create_fill_jack_kcontrols(struct snd_soc_card *card,
-                                   struct hdac_ext_device *edev)
+                                   struct hdac_device *hdev)
 {
        struct hdac_hdmi_pin *pin;
        struct snd_kcontrol_new *kc;
        char kc_name[NAME_SIZE], xname[NAME_SIZE];
        char *name;
        int i = 0, j;
-       struct snd_soc_component *component = edev->scodec;
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
+       struct snd_soc_component *component = hdmi->component;
 
        kc = devm_kcalloc(component->dev, hdmi->num_ports,
                                sizeof(*kc), GFP_KERNEL);
@@ -1659,8 +1653,8 @@ static int create_fill_jack_kcontrols(struct snd_soc_card *card,
 int hdac_hdmi_jack_port_init(struct snd_soc_component *component,
                        struct snd_soc_dapm_context *dapm)
 {
-       struct hdac_ext_device *edev = snd_soc_component_get_drvdata(component);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = snd_soc_component_get_drvdata(component);
+       struct hdac_device *hdev = hdmi->hdev;
        struct hdac_hdmi_pin *pin;
        struct snd_soc_dapm_widget *widgets;
        struct snd_soc_dapm_route *route;
@@ -1715,7 +1709,7 @@ int hdac_hdmi_jack_port_init(struct snd_soc_component *component,
                return ret;
 
        /* Add Jack Pin switch Kcontrol */
-       ret = create_fill_jack_kcontrols(dapm->card, edev);
+       ret = create_fill_jack_kcontrols(dapm->card, hdev);
 
        if (ret < 0)
                return ret;
@@ -1735,8 +1729,8 @@ int hdac_hdmi_jack_init(struct snd_soc_dai *dai, int device,
                                struct snd_soc_jack *jack)
 {
        struct snd_soc_component *component = dai->component;
-       struct hdac_ext_device *edev = snd_soc_component_get_drvdata(component);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = snd_soc_component_get_drvdata(component);
+       struct hdac_device *hdev = hdmi->hdev;
        struct hdac_hdmi_pcm *pcm;
        struct snd_pcm *snd_pcm;
        int err;
@@ -1758,7 +1752,7 @@ int hdac_hdmi_jack_init(struct snd_soc_dai *dai, int device,
        if (snd_pcm) {
                err = snd_hdac_add_chmap_ctls(snd_pcm, device, &hdmi->chmap);
                if (err < 0) {
-                       dev_err(&edev->hdev.dev,
+                       dev_err(&hdev->dev,
                                "chmap control add failed with err: %d for pcm: %d\n",
                                err, device);
                        kfree(pcm);
@@ -1772,7 +1766,7 @@ int hdac_hdmi_jack_init(struct snd_soc_dai *dai, int device,
 }
 EXPORT_SYMBOL_GPL(hdac_hdmi_jack_init);
 
-static void hdac_hdmi_present_sense_all_pins(struct hdac_ext_device *edev,
+static void hdac_hdmi_present_sense_all_pins(struct hdac_device *hdev,
                        struct hdac_hdmi_priv *hdmi, bool detect_pin_caps)
 {
        int i;
@@ -1781,7 +1775,7 @@ static void hdac_hdmi_present_sense_all_pins(struct hdac_ext_device *edev,
        list_for_each_entry(pin, &hdmi->pin_list, head) {
                if (detect_pin_caps) {
 
-                       if (hdac_hdmi_get_port_len(edev, pin->nid)  == 0)
+                       if (hdac_hdmi_get_port_len(hdev, pin->nid)  == 0)
                                pin->mst_capable = false;
                        else
                                pin->mst_capable = true;
@@ -1798,68 +1792,67 @@ static void hdac_hdmi_present_sense_all_pins(struct hdac_ext_device *edev,
 
 static int hdmi_codec_probe(struct snd_soc_component *component)
 {
-       struct hdac_ext_device *edev = snd_soc_component_get_drvdata(component);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = snd_soc_component_get_drvdata(component);
+       struct hdac_device *hdev = hdmi->hdev;
        struct snd_soc_dapm_context *dapm =
                snd_soc_component_get_dapm(component);
        struct hdac_ext_link *hlink = NULL;
        int ret;
 
-       edev->scodec = component;
+       hdmi->component = component;
 
        /*
         * hold the ref while we probe, also no need to drop the ref on
         * exit, we call pm_runtime_suspend() so that will do for us
         */
-       hlink = snd_hdac_ext_bus_get_link(edev->ebus, dev_name(&edev->hdev.dev));
+       hlink = snd_hdac_ext_bus_get_link(hdev->bus, dev_name(&hdev->dev));
        if (!hlink) {
-               dev_err(&edev->hdev.dev, "hdac link not found\n");
+               dev_err(&hdev->dev, "hdac link not found\n");
                return -EIO;
        }
 
-       snd_hdac_ext_bus_link_get(edev->ebus, hlink);
+       snd_hdac_ext_bus_link_get(hdev->bus, hlink);
 
        ret = create_fill_widget_route_map(dapm);
        if (ret < 0)
                return ret;
 
-       aops.audio_ptr = edev;
-       ret = snd_hdac_i915_register_notifier(&aops);
+       aops.audio_ptr = hdev;
+       ret = snd_hdac_acomp_register_notifier(hdev->bus, &aops);
        if (ret < 0) {
-               dev_err(&edev->hdev.dev, "notifier register failed: err: %d\n",
-                               ret);
+               dev_err(&hdev->dev, "notifier register failed: err: %d\n", ret);
                return ret;
        }
 
-       hdac_hdmi_present_sense_all_pins(edev, hdmi, true);
+       hdac_hdmi_present_sense_all_pins(hdev, hdmi, true);
        /* Imp: Store the card pointer in hda_codec */
-       edev->card = dapm->card->snd_card;
+       hdmi->card = dapm->card->snd_card;
 
        /*
         * hdac_device core already sets the state to active and calls
         * get_noresume. So enable runtime and set the device to suspend.
         */
-       pm_runtime_enable(&edev->hdev.dev);
-       pm_runtime_put(&edev->hdev.dev);
-       pm_runtime_suspend(&edev->hdev.dev);
+       pm_runtime_enable(&hdev->dev);
+       pm_runtime_put(&hdev->dev);
+       pm_runtime_suspend(&hdev->dev);
 
        return 0;
 }
 
 static void hdmi_codec_remove(struct snd_soc_component *component)
 {
-       struct hdac_ext_device *edev = snd_soc_component_get_drvdata(component);
+       struct hdac_hdmi_priv *hdmi = snd_soc_component_get_drvdata(component);
+       struct hdac_device *hdev = hdmi->hdev;
 
-       pm_runtime_disable(&edev->hdev.dev);
+       pm_runtime_disable(&hdev->dev);
 }
 
 #ifdef CONFIG_PM
 static int hdmi_codec_prepare(struct device *dev)
 {
-       struct hdac_ext_device *edev = to_hda_ext_device(dev);
-       struct hdac_device *hdev = &edev->hdev;
+       struct hdac_device *hdev = dev_to_hdac_dev(dev);
 
-       pm_runtime_get_sync(&edev->hdev.dev);
+       pm_runtime_get_sync(&hdev->dev);
 
        /*
         * Power down afg.
@@ -1876,16 +1869,15 @@ static int hdmi_codec_prepare(struct device *dev)
 
 static void hdmi_codec_complete(struct device *dev)
 {
-       struct hdac_ext_device *edev = to_hda_ext_device(dev);
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
-       struct hdac_device *hdev = &edev->hdev;
+       struct hdac_device *hdev = dev_to_hdac_dev(dev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
 
        /* Power up afg */
        snd_hdac_codec_read(hdev, hdev->afg, 0, AC_VERB_SET_POWER_STATE,
                                                        AC_PWRST_D0);
 
-       hdac_hdmi_skl_enable_all_pins(&edev->hdev);
-       hdac_hdmi_skl_enable_dp12(&edev->hdev);
+       hdac_hdmi_skl_enable_all_pins(hdev);
+       hdac_hdmi_skl_enable_dp12(hdev);
 
        /*
         * As the ELD notify callback request is not entertained while the
@@ -1893,9 +1885,9 @@ static void hdmi_codec_complete(struct device *dev)
         * all pins here. pin capablity change is not support, so use the
         * already set pin caps.
         */
-       hdac_hdmi_present_sense_all_pins(edev, hdmi, false);
+       hdac_hdmi_present_sense_all_pins(hdev, hdmi, false);
 
-       pm_runtime_put_sync(&edev->hdev.dev);
+       pm_runtime_put_sync(&hdev->dev);
 }
 #else
 #define hdmi_codec_prepare NULL
@@ -1922,7 +1914,6 @@ static void hdac_hdmi_get_chmap(struct hdac_device *hdev, int pcm_idx,
 static void hdac_hdmi_set_chmap(struct hdac_device *hdev, int pcm_idx,
                                unsigned char *chmap, int prepared)
 {
-       struct hdac_ext_device *edev = to_ehdac_device(hdev);
        struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_pcm *pcm = get_hdmi_pcm_from_id(hdmi, pcm_idx);
        struct hdac_hdmi_port *port;
@@ -1938,7 +1929,7 @@ static void hdac_hdmi_set_chmap(struct hdac_device *hdev, int pcm_idx,
        memcpy(pcm->chmap, chmap, ARRAY_SIZE(pcm->chmap));
        list_for_each_entry(port, &pcm->port_list, head)
                if (prepared)
-                       hdac_hdmi_setup_audio_infoframe(edev, pcm, port);
+                       hdac_hdmi_setup_audio_infoframe(hdev, pcm, port);
        mutex_unlock(&pcm->lock);
 }
 
@@ -1987,10 +1978,9 @@ static struct hdac_hdmi_drv_data intel_drv_data  = {
        .vendor_nid = INTEL_VENDOR_NID,
 };
 
-static int hdac_hdmi_dev_probe(struct hdac_ext_device *edev)
+static int hdac_hdmi_dev_probe(struct hdac_device *hdev)
 {
-       struct hdac_device *hdev = &edev->hdev;
-       struct hdac_hdmi_priv *hdmi_priv;
+       struct hdac_hdmi_priv *hdmi_priv = NULL;
        struct snd_soc_dai_driver *hdmi_dais = NULL;
        struct hdac_ext_link *hlink = NULL;
        int num_dais = 0;
@@ -1999,24 +1989,24 @@ static int hdac_hdmi_dev_probe(struct hdac_ext_device *edev)
        const struct hda_device_id *hdac_id = hdac_get_device_id(hdev, hdrv);
 
        /* hold the ref while we probe */
-       hlink = snd_hdac_ext_bus_get_link(edev->ebus, dev_name(&edev->hdev.dev));
+       hlink = snd_hdac_ext_bus_get_link(hdev->bus, dev_name(&hdev->dev));
        if (!hlink) {
-               dev_err(&edev->hdev.dev, "hdac link not found\n");
+               dev_err(&hdev->dev, "hdac link not found\n");
                return -EIO;
        }
 
-       snd_hdac_ext_bus_link_get(edev->ebus, hlink);
+       snd_hdac_ext_bus_link_get(hdev->bus, hlink);
 
        hdmi_priv = devm_kzalloc(&hdev->dev, sizeof(*hdmi_priv), GFP_KERNEL);
        if (hdmi_priv == NULL)
                return -ENOMEM;
 
-       edev->private_data = hdmi_priv;
        snd_hdac_register_chmap_ops(hdev, &hdmi_priv->chmap);
        hdmi_priv->chmap.ops.get_chmap = hdac_hdmi_get_chmap;
        hdmi_priv->chmap.ops.set_chmap = hdac_hdmi_set_chmap;
        hdmi_priv->chmap.ops.is_pcm_attached = is_hdac_hdmi_pcm_attached;
        hdmi_priv->chmap.ops.get_spk_alloc = hdac_hdmi_get_spk_alloc;
+       hdmi_priv->hdev = hdev;
 
        if (!hdac_id)
                return -ENODEV;
@@ -2027,7 +2017,7 @@ static int hdac_hdmi_dev_probe(struct hdac_ext_device *edev)
        else
                hdmi_priv->drv_data = &intel_drv_data;
 
-       dev_set_drvdata(&hdev->dev, edev);
+       dev_set_drvdata(&hdev->dev, hdmi_priv);
 
        INIT_LIST_HEAD(&hdmi_priv->pin_list);
        INIT_LIST_HEAD(&hdmi_priv->cvt_list);
@@ -2038,15 +2028,15 @@ static int hdac_hdmi_dev_probe(struct hdac_ext_device *edev)
         * Turned off in the runtime_suspend during the first explicit
         * pm_runtime_suspend call.
         */
-       ret = snd_hdac_display_power(edev->hdev.bus, true);
+       ret = snd_hdac_display_power(hdev->bus, true);
        if (ret < 0) {
-               dev_err(&edev->hdev.dev,
+               dev_err(&hdev->dev,
                        "Cannot turn on display power on i915 err: %d\n",
                        ret);
                return ret;
        }
 
-       ret = hdac_hdmi_parse_and_map_nid(edev, &hdmi_dais, &num_dais);
+       ret = hdac_hdmi_parse_and_map_nid(hdev, &hdmi_dais, &num_dais);
        if (ret < 0) {
                dev_err(&hdev->dev,
                        "Failed in parse and map nid with err: %d\n", ret);
@@ -2058,14 +2048,14 @@ static int hdac_hdmi_dev_probe(struct hdac_ext_device *edev)
        ret = devm_snd_soc_register_component(&hdev->dev, &hdmi_hda_codec,
                                        hdmi_dais, num_dais);
 
-       snd_hdac_ext_bus_link_put(edev->ebus, hlink);
+       snd_hdac_ext_bus_link_put(hdev->bus, hlink);
 
        return ret;
 }
 
-static int hdac_hdmi_dev_remove(struct hdac_ext_device *edev)
+static int hdac_hdmi_dev_remove(struct hdac_device *hdev)
 {
-       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(&edev->hdev);
+       struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev);
        struct hdac_hdmi_pin *pin, *pin_next;
        struct hdac_hdmi_cvt *cvt, *cvt_next;
        struct hdac_hdmi_pcm *pcm, *pcm_next;
@@ -2174,10 +2164,8 @@ static int hdac_hdmi_dev_remove(struct hdac_ext_device *edev)
  */
 static int hdac_hdmi_runtime_suspend(struct device *dev)
 {
-       struct hdac_ext_device *edev = to_hda_ext_device(dev);
-       struct hdac_device *hdev = &edev->hdev;
+       struct hdac_device *hdev = dev_to_hdac_dev(dev);
        struct hdac_bus *bus = hdev->bus;
-       struct hdac_ext_bus *ebus = hbus_to_ebus(bus);
        struct hdac_ext_link *hlink = NULL;
        int err;
 
@@ -2198,27 +2186,25 @@ static int hdac_hdmi_runtime_suspend(struct device *dev)
                                                        AC_PWRST_D3);
        err = snd_hdac_display_power(bus, false);
        if (err < 0) {
-               dev_err(bus->dev, "Cannot turn on display power on i915\n");
+               dev_err(dev, "Cannot turn on display power on i915\n");
                return err;
        }
 
-       hlink = snd_hdac_ext_bus_get_link(ebus, dev_name(dev));
+       hlink = snd_hdac_ext_bus_get_link(bus, dev_name(dev));
        if (!hlink) {
                dev_err(dev, "hdac link not found\n");
                return -EIO;
        }
 
-       snd_hdac_ext_bus_link_put(ebus, hlink);
+       snd_hdac_ext_bus_link_put(bus, hlink);
 
        return 0;
 }
 
 static int hdac_hdmi_runtime_resume(struct device *dev)
 {
-       struct hdac_ext_device *edev = to_hda_ext_device(dev);
-       struct hdac_device *hdev = &edev->hdev;
+       struct hdac_device *hdev = dev_to_hdac_dev(dev);
        struct hdac_bus *bus = hdev->bus;
-       struct hdac_ext_bus *ebus = hbus_to_ebus(bus);
        struct hdac_ext_link *hlink = NULL;
        int err;
 
@@ -2228,22 +2214,22 @@ static int hdac_hdmi_runtime_resume(struct device *dev)
        if (!bus)
                return 0;
 
-       hlink = snd_hdac_ext_bus_get_link(ebus, dev_name(dev));
+       hlink = snd_hdac_ext_bus_get_link(bus, dev_name(dev));
        if (!hlink) {
                dev_err(dev, "hdac link not found\n");
                return -EIO;
        }
 
-       snd_hdac_ext_bus_link_get(ebus, hlink);
+       snd_hdac_ext_bus_link_get(bus, hlink);
 
        err = snd_hdac_display_power(bus, true);
        if (err < 0) {
-               dev_err(bus->dev, "Cannot turn on display power on i915\n");
+               dev_err(dev, "Cannot turn on display power on i915\n");
                return err;
        }
 
-       hdac_hdmi_skl_enable_all_pins(&edev->hdev);
-       hdac_hdmi_skl_enable_dp12(&edev->hdev);
+       hdac_hdmi_skl_enable_all_pins(hdev);
+       hdac_hdmi_skl_enable_dp12(hdev);
 
        /* Power up afg */
        snd_hdac_codec_read(hdev, hdev->afg, 0, AC_VERB_SET_POWER_STATE,
@@ -2275,14 +2261,12 @@ static const struct hda_device_id hdmi_list[] = {
 
 MODULE_DEVICE_TABLE(hdaudio, hdmi_list);
 
-static struct hdac_ext_driver hdmi_driver = {
-       . hdac = {
-               .driver = {
-                       .name   = "HDMI HDA Codec",
-                       .pm = &hdac_hdmi_pm,
-               },
-               .id_table       = hdmi_list,
+static struct hdac_driver hdmi_driver = {
+       .driver = {
+               .name   = "HDMI HDA Codec",
+               .pm = &hdac_hdmi_pm,
        },
+       .id_table       = hdmi_list,
        .probe          = hdac_hdmi_dev_probe,
        .remove         = hdac_hdmi_dev_remove,
 };
index d5f9c30eba32cb01de6b037fe9811681b2a175ad..8bfb8b0fa3d5959b25ee42ef9bcb35255b2eb97f 100644 (file)
@@ -33,8 +33,7 @@
 static int skl_alloc_dma_buf(struct device *dev,
                struct snd_dma_buffer *dmab, size_t size)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
 
        if (!bus)
                return -ENODEV;
@@ -44,8 +43,7 @@ static int skl_alloc_dma_buf(struct device *dev,
 
 static int skl_free_dma_buf(struct device *dev, struct snd_dma_buffer *dmab)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
 
        if (!bus)
                return -ENODEV;
@@ -89,8 +87,7 @@ void skl_dsp_enable_notification(struct skl_sst *ctx, bool enable)
 static int skl_dsp_setup_spib(struct device *dev, unsigned int size,
                                int stream_tag, int enable)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
        struct hdac_stream *stream = snd_hdac_get_stream(bus,
                        SNDRV_PCM_STREAM_PLAYBACK, stream_tag);
        struct hdac_ext_stream *estream;
@@ -100,10 +97,10 @@ static int skl_dsp_setup_spib(struct device *dev, unsigned int size,
 
        estream = stream_to_hdac_ext_stream(stream);
        /* enable/disable SPIB for this hdac stream */
-       snd_hdac_ext_stream_spbcap_enable(ebus, enable, stream->index);
+       snd_hdac_ext_stream_spbcap_enable(bus, enable, stream->index);
 
        /* set the spib value */
-       snd_hdac_ext_stream_set_spib(ebus, estream, size);
+       snd_hdac_ext_stream_set_spib(bus, estream, size);
 
        return 0;
 }
@@ -111,8 +108,7 @@ static int skl_dsp_setup_spib(struct device *dev, unsigned int size,
 static int skl_dsp_prepare(struct device *dev, unsigned int format,
                        unsigned int size, struct snd_dma_buffer *dmab)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
        struct hdac_ext_stream *estream;
        struct hdac_stream *stream;
        struct snd_pcm_substream substream;
@@ -124,7 +120,7 @@ static int skl_dsp_prepare(struct device *dev, unsigned int format,
        memset(&substream, 0, sizeof(substream));
        substream.stream = SNDRV_PCM_STREAM_PLAYBACK;
 
-       estream = snd_hdac_ext_stream_assign(ebus, &substream,
+       estream = snd_hdac_ext_stream_assign(bus, &substream,
                                        HDAC_EXT_STREAM_TYPE_HOST);
        if (!estream)
                return -ENODEV;
@@ -143,9 +139,8 @@ static int skl_dsp_prepare(struct device *dev, unsigned int format,
 
 static int skl_dsp_trigger(struct device *dev, bool start, int stream_tag)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
        struct hdac_stream *stream;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
 
        if (!bus)
                return -ENODEV;
@@ -163,10 +158,9 @@ static int skl_dsp_trigger(struct device *dev, bool start, int stream_tag)
 static int skl_dsp_cleanup(struct device *dev,
                struct snd_dma_buffer *dmab, int stream_tag)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
        struct hdac_stream *stream;
        struct hdac_ext_stream *estream;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
 
        if (!bus)
                return -ENODEV;
@@ -270,8 +264,7 @@ const struct skl_dsp_ops *skl_get_dsp_ops(int pci_id)
 int skl_init_dsp(struct skl *skl)
 {
        void __iomem *mmio_base;
-       struct hdac_ext_bus *ebus = &skl->ebus;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = skl_to_bus(skl);
        struct skl_dsp_loader_ops loader_ops;
        int irq = bus->irq;
        const struct skl_dsp_ops *ops;
@@ -279,8 +272,8 @@ int skl_init_dsp(struct skl *skl)
        int ret;
 
        /* enable ppcap interrupt */
-       snd_hdac_ext_bus_ppcap_enable(&skl->ebus, true);
-       snd_hdac_ext_bus_ppcap_int_enable(&skl->ebus, true);
+       snd_hdac_ext_bus_ppcap_enable(bus, true);
+       snd_hdac_ext_bus_ppcap_int_enable(bus, true);
 
        /* read the BAR of the ADSP MMIO */
        mmio_base = pci_ioremap_bar(skl->pci, 4);
@@ -335,12 +328,11 @@ unmap_mmio:
 
 int skl_free_dsp(struct skl *skl)
 {
-       struct hdac_ext_bus *ebus = &skl->ebus;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = skl_to_bus(skl);
        struct skl_sst *ctx = skl->skl_sst;
 
        /* disable  ppcap interrupt */
-       snd_hdac_ext_bus_ppcap_int_enable(&skl->ebus, false);
+       snd_hdac_ext_bus_ppcap_int_enable(bus, false);
 
        ctx->dsp_ops->cleanup(bus->dev, ctx);
 
@@ -383,10 +375,11 @@ int skl_suspend_late_dsp(struct skl *skl)
 int skl_suspend_dsp(struct skl *skl)
 {
        struct skl_sst *ctx = skl->skl_sst;
+       struct hdac_bus *bus = skl_to_bus(skl);
        int ret;
 
        /* if ppcap is not supported return 0 */
-       if (!skl->ebus.bus.ppcap)
+       if (!bus->ppcap)
                return 0;
 
        ret = skl_dsp_sleep(ctx->dsp);
@@ -394,8 +387,8 @@ int skl_suspend_dsp(struct skl *skl)
                return ret;
 
        /* disable ppcap interrupt */
-       snd_hdac_ext_bus_ppcap_int_enable(&skl->ebus, false);
-       snd_hdac_ext_bus_ppcap_enable(&skl->ebus, false);
+       snd_hdac_ext_bus_ppcap_int_enable(bus, false);
+       snd_hdac_ext_bus_ppcap_enable(bus, false);
 
        return 0;
 }
@@ -403,15 +396,16 @@ int skl_suspend_dsp(struct skl *skl)
 int skl_resume_dsp(struct skl *skl)
 {
        struct skl_sst *ctx = skl->skl_sst;
+       struct hdac_bus *bus = skl_to_bus(skl);
        int ret;
 
        /* if ppcap is not supported return 0 */
-       if (!skl->ebus.bus.ppcap)
+       if (!bus->ppcap)
                return 0;
 
        /* enable ppcap interrupt */
-       snd_hdac_ext_bus_ppcap_enable(&skl->ebus, true);
-       snd_hdac_ext_bus_ppcap_int_enable(&skl->ebus, true);
+       snd_hdac_ext_bus_ppcap_enable(bus, true);
+       snd_hdac_ext_bus_ppcap_int_enable(bus, true);
 
        /* check if DSP 1st boot is done */
        if (skl->skl_sst->is_first_boot == true)
index b9b140275be09908e93e1936a7d9d86772387106..01a050cf877537ddab712863e50fe1b523db98de 100644 (file)
@@ -141,7 +141,7 @@ struct nhlt_specific_cfg
 {
        struct nhlt_fmt *fmt;
        struct nhlt_endpoint *epnt;
-       struct hdac_bus *bus = ebus_to_hbus(&skl->ebus);
+       struct hdac_bus *bus = skl_to_bus(skl);
        struct device *dev = bus->dev;
        struct nhlt_specific_cfg *sp_config;
        struct nhlt_acpi_table *nhlt = skl->nhlt;
@@ -228,7 +228,7 @@ static void skl_nhlt_trim_space(char *trim)
 int skl_nhlt_update_topology_bin(struct skl *skl)
 {
        struct nhlt_acpi_table *nhlt = (struct nhlt_acpi_table *)skl->nhlt;
-       struct hdac_bus *bus = ebus_to_hbus(&skl->ebus);
+       struct hdac_bus *bus = skl_to_bus(skl);
        struct device *dev = bus->dev;
 
        dev_dbg(dev, "oem_id %.6s, oem_table_id %8s oem_revision %d\n",
@@ -248,8 +248,8 @@ static ssize_t skl_nhlt_platform_id_show(struct device *dev,
                        struct device_attribute *attr, char *buf)
 {
        struct pci_dev *pci = to_pci_dev(dev);
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct skl *skl = ebus_to_skl(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
+       struct skl *skl = bus_to_skl(bus);
        struct nhlt_acpi_table *nhlt = (struct nhlt_acpi_table *)skl->nhlt;
        char platform_id[32];
 
index 1f4dd08d36c55efbdc2d52f802fb63d5d0f274d2..823e39103edd30bedefaf50ff84cd60004eb9fbb 100644 (file)
@@ -67,16 +67,15 @@ struct hdac_ext_stream *get_hdac_ext_stream(struct snd_pcm_substream *substream)
        return substream->runtime->private_data;
 }
 
-static struct hdac_ext_bus *get_bus_ctx(struct snd_pcm_substream *substream)
+static struct hdac_bus *get_bus_ctx(struct snd_pcm_substream *substream)
 {
        struct hdac_ext_stream *stream = get_hdac_ext_stream(substream);
        struct hdac_stream *hstream = hdac_stream(stream);
        struct hdac_bus *bus = hstream->bus;
-
-       return hbus_to_ebus(bus);
+       return bus;
 }
 
-static int skl_substream_alloc_pages(struct hdac_ext_bus *ebus,
+static int skl_substream_alloc_pages(struct hdac_bus *bus,
                                 struct snd_pcm_substream *substream,
                                 size_t size)
 {
@@ -95,7 +94,7 @@ static int skl_substream_free_pages(struct hdac_bus *bus,
        return snd_pcm_lib_free_pages(substream);
 }
 
-static void skl_set_pcm_constrains(struct hdac_ext_bus *ebus,
+static void skl_set_pcm_constrains(struct hdac_bus *bus,
                                 struct snd_pcm_runtime *runtime)
 {
        snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
@@ -105,9 +104,9 @@ static void skl_set_pcm_constrains(struct hdac_ext_bus *ebus,
                                     20, 178000000);
 }
 
-static enum hdac_ext_stream_type skl_get_host_stream_type(struct hdac_ext_bus *ebus)
+static enum hdac_ext_stream_type skl_get_host_stream_type(struct hdac_bus *bus)
 {
-       if ((ebus_to_hbus(ebus))->ppcap)
+       if (bus->ppcap)
                return HDAC_EXT_STREAM_TYPE_HOST;
        else
                return HDAC_EXT_STREAM_TYPE_COUPLED;
@@ -123,9 +122,9 @@ static enum hdac_ext_stream_type skl_get_host_stream_type(struct hdac_ext_bus *e
 static void skl_set_suspend_active(struct snd_pcm_substream *substream,
                                         struct snd_soc_dai *dai, bool enable)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);
+       struct hdac_bus *bus = dev_get_drvdata(dai->dev);
        struct snd_soc_dapm_widget *w;
-       struct skl *skl = ebus_to_skl(ebus);
+       struct skl *skl = bus_to_skl(bus);
 
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
                w = dai->playback_widget;
@@ -140,8 +139,7 @@ static void skl_set_suspend_active(struct snd_pcm_substream *substream,
 
 int skl_pcm_host_dma_prepare(struct device *dev, struct skl_pipe_params *params)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
        unsigned int format_val;
        struct hdac_stream *hstream;
        struct hdac_ext_stream *stream;
@@ -153,7 +151,7 @@ int skl_pcm_host_dma_prepare(struct device *dev, struct skl_pipe_params *params)
                return -EINVAL;
 
        stream = stream_to_hdac_ext_stream(hstream);
-       snd_hdac_ext_stream_decouple(ebus, stream, true);
+       snd_hdac_ext_stream_decouple(bus, stream, true);
 
        format_val = snd_hdac_calc_stream_format(params->s_freq,
                        params->ch, params->format, params->host_bps, 0);
@@ -177,8 +175,7 @@ int skl_pcm_host_dma_prepare(struct device *dev, struct skl_pipe_params *params)
 
 int skl_pcm_link_dma_prepare(struct device *dev, struct skl_pipe_params *params)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
        unsigned int format_val;
        struct hdac_stream *hstream;
        struct hdac_ext_stream *stream;
@@ -190,7 +187,7 @@ int skl_pcm_link_dma_prepare(struct device *dev, struct skl_pipe_params *params)
                return -EINVAL;
 
        stream = stream_to_hdac_ext_stream(hstream);
-       snd_hdac_ext_stream_decouple(ebus, stream, true);
+       snd_hdac_ext_stream_decouple(bus, stream, true);
        format_val = snd_hdac_calc_stream_format(params->s_freq, params->ch,
                                        params->format, params->link_bps, 0);
 
@@ -201,7 +198,7 @@ int skl_pcm_link_dma_prepare(struct device *dev, struct skl_pipe_params *params)
 
        snd_hdac_ext_link_stream_setup(stream, format_val);
 
-       list_for_each_entry(link, &ebus->hlink_list, list) {
+       list_for_each_entry(link, &bus->hlink_list, list) {
                if (link->index == params->link_index)
                        snd_hdac_ext_link_set_stream_id(link,
                                        hstream->stream_tag);
@@ -215,7 +212,7 @@ int skl_pcm_link_dma_prepare(struct device *dev, struct skl_pipe_params *params)
 static int skl_pcm_open(struct snd_pcm_substream *substream,
                struct snd_soc_dai *dai)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);
+       struct hdac_bus *bus = dev_get_drvdata(dai->dev);
        struct hdac_ext_stream *stream;
        struct snd_pcm_runtime *runtime = substream->runtime;
        struct skl_dma_params *dma_params;
@@ -224,12 +221,12 @@ static int skl_pcm_open(struct snd_pcm_substream *substream,
 
        dev_dbg(dai->dev, "%s: %s\n", __func__, dai->name);
 
-       stream = snd_hdac_ext_stream_assign(ebus, substream,
-                                       skl_get_host_stream_type(ebus));
+       stream = snd_hdac_ext_stream_assign(bus, substream,
+                                       skl_get_host_stream_type(bus));
        if (stream == NULL)
                return -EBUSY;
 
-       skl_set_pcm_constrains(ebus, runtime);
+       skl_set_pcm_constrains(bus, runtime);
 
        /*
         * disable WALLCLOCK timestamps for capture streams
@@ -301,7 +298,7 @@ static int skl_pcm_hw_params(struct snd_pcm_substream *substream,
                                struct snd_pcm_hw_params *params,
                                struct snd_soc_dai *dai)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);
+       struct hdac_bus *bus = dev_get_drvdata(dai->dev);
        struct hdac_ext_stream *stream = get_hdac_ext_stream(substream);
        struct snd_pcm_runtime *runtime = substream->runtime;
        struct skl_pipe_params p_params = {0};
@@ -309,7 +306,7 @@ static int skl_pcm_hw_params(struct snd_pcm_substream *substream,
        int ret, dma_id;
 
        dev_dbg(dai->dev, "%s: %s\n", __func__, dai->name);
-       ret = skl_substream_alloc_pages(ebus, substream,
+       ret = skl_substream_alloc_pages(bus, substream,
                                          params_buffer_bytes(params));
        if (ret < 0)
                return ret;
@@ -343,14 +340,14 @@ static void skl_pcm_close(struct snd_pcm_substream *substream,
                struct snd_soc_dai *dai)
 {
        struct hdac_ext_stream *stream = get_hdac_ext_stream(substream);
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);
+       struct hdac_bus *bus = dev_get_drvdata(dai->dev);
        struct skl_dma_params *dma_params = NULL;
-       struct skl *skl = ebus_to_skl(ebus);
+       struct skl *skl = bus_to_skl(bus);
        struct skl_module_cfg *mconfig;
 
        dev_dbg(dai->dev, "%s: %s\n", __func__, dai->name);
 
-       snd_hdac_ext_stream_release(stream, skl_get_host_stream_type(ebus));
+       snd_hdac_ext_stream_release(stream, skl_get_host_stream_type(bus));
 
        dma_params = snd_soc_dai_get_dma_data(dai, substream);
        /*
@@ -380,7 +377,7 @@ static void skl_pcm_close(struct snd_pcm_substream *substream,
 static int skl_pcm_hw_free(struct snd_pcm_substream *substream,
                struct snd_soc_dai *dai)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);
+       struct hdac_bus *bus = dev_get_drvdata(dai->dev);
        struct hdac_ext_stream *stream = get_hdac_ext_stream(substream);
        struct skl *skl = get_skl_ctx(dai->dev);
        struct skl_module_cfg *mconfig;
@@ -400,7 +397,7 @@ static int skl_pcm_hw_free(struct snd_pcm_substream *substream,
        snd_hdac_stream_cleanup(hdac_stream(stream));
        hdac_stream(stream)->prepared = 0;
 
-       return skl_substream_free_pages(ebus_to_hbus(ebus), substream);
+       return skl_substream_free_pages(bus, substream);
 }
 
 static int skl_be_hw_params(struct snd_pcm_substream *substream,
@@ -420,8 +417,7 @@ static int skl_be_hw_params(struct snd_pcm_substream *substream,
 static int skl_decoupled_trigger(struct snd_pcm_substream *substream,
                int cmd)
 {
-       struct hdac_ext_bus *ebus = get_bus_ctx(substream);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = get_bus_ctx(substream);
        struct hdac_ext_stream *stream;
        int start;
        unsigned long cookie;
@@ -470,7 +466,7 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
        struct skl *skl = get_skl_ctx(dai->dev);
        struct skl_sst *ctx = skl->skl_sst;
        struct skl_module_cfg *mconfig;
-       struct hdac_ext_bus *ebus = get_bus_ctx(substream);
+       struct hdac_bus *bus = get_bus_ctx(substream);
        struct hdac_ext_stream *stream = get_hdac_ext_stream(substream);
        struct snd_soc_dapm_widget *w;
        int ret;
@@ -492,9 +488,9 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
                         * dpib & lpib position to resume before starting the
                         * DMA
                         */
-                       snd_hdac_ext_stream_drsm_enable(ebus, true,
+                       snd_hdac_ext_stream_drsm_enable(bus, true,
                                                hdac_stream(stream)->index);
-                       snd_hdac_ext_stream_set_dpibr(ebus, stream,
+                       snd_hdac_ext_stream_set_dpibr(bus, stream,
                                                        stream->lpib);
                        snd_hdac_ext_stream_set_lpib(stream, stream->lpib);
                }
@@ -528,14 +524,14 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
                ret = skl_decoupled_trigger(substream, cmd);
                if ((cmd == SNDRV_PCM_TRIGGER_SUSPEND) && !w->ignore_suspend) {
                        /* save the dpib and lpib positions */
-                       stream->dpib = readl(ebus->bus.remap_addr +
+                       stream->dpib = readl(bus->remap_addr +
                                        AZX_REG_VS_SDXDPIB_XBASE +
                                        (AZX_REG_VS_SDXDPIB_XINTERVAL *
                                        hdac_stream(stream)->index));
 
                        stream->lpib = snd_hdac_stream_get_pos_lpib(
                                                        hdac_stream(stream));
-                       snd_hdac_ext_stream_decouple(ebus, stream, false);
+                       snd_hdac_ext_stream_decouple(bus, stream, false);
                }
                break;
 
@@ -546,11 +542,12 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
        return 0;
 }
 
+
 static int skl_link_hw_params(struct snd_pcm_substream *substream,
                                struct snd_pcm_hw_params *params,
                                struct snd_soc_dai *dai)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);
+       struct hdac_bus *bus = dev_get_drvdata(dai->dev);
        struct hdac_ext_stream *link_dev;
        struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream);
        struct snd_soc_dai *codec_dai = rtd->codec_dai;
@@ -558,14 +555,14 @@ static int skl_link_hw_params(struct snd_pcm_substream *substream,
        struct hdac_ext_link *link;
        int stream_tag;
 
-       link_dev = snd_hdac_ext_stream_assign(ebus, substream,
+       link_dev = snd_hdac_ext_stream_assign(bus, substream,
                                        HDAC_EXT_STREAM_TYPE_LINK);
        if (!link_dev)
                return -EBUSY;
 
        snd_soc_dai_set_dma_data(dai, substream, (void *)link_dev);
 
-       link = snd_hdac_ext_bus_get_link(ebus, codec_dai->component->name);
+       link = snd_hdac_ext_bus_get_link(bus, codec_dai->component->name);
        if (!link)
                return -EINVAL;
 
@@ -610,7 +607,7 @@ static int skl_link_pcm_trigger(struct snd_pcm_substream *substream,
 {
        struct hdac_ext_stream *link_dev =
                                snd_soc_dai_get_dma_data(dai, substream);
-       struct hdac_ext_bus *ebus = get_bus_ctx(substream);
+       struct hdac_bus *bus = get_bus_ctx(substream);
        struct hdac_ext_stream *stream = get_hdac_ext_stream(substream);
 
        dev_dbg(dai->dev, "In %s cmd=%d\n", __func__, cmd);
@@ -626,7 +623,7 @@ static int skl_link_pcm_trigger(struct snd_pcm_substream *substream,
        case SNDRV_PCM_TRIGGER_STOP:
                snd_hdac_ext_link_stream_clear(link_dev);
                if (cmd == SNDRV_PCM_TRIGGER_SUSPEND)
-                       snd_hdac_ext_stream_decouple(ebus, stream, false);
+                       snd_hdac_ext_stream_decouple(bus, stream, false);
                break;
 
        default:
@@ -638,7 +635,7 @@ static int skl_link_pcm_trigger(struct snd_pcm_substream *substream,
 static int skl_link_hw_free(struct snd_pcm_substream *substream,
                struct snd_soc_dai *dai)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);
+       struct hdac_bus *bus = dev_get_drvdata(dai->dev);
        struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream);
        struct hdac_ext_stream *link_dev =
                                snd_soc_dai_get_dma_data(dai, substream);
@@ -648,7 +645,7 @@ static int skl_link_hw_free(struct snd_pcm_substream *substream,
 
        link_dev->link_prepared = 0;
 
-       link = snd_hdac_ext_bus_get_link(ebus, rtd->codec_dai->component->name);
+       link = snd_hdac_ext_bus_get_link(bus, rtd->codec_dai->component->name);
        if (!link)
                return -EINVAL;
 
@@ -1042,8 +1039,7 @@ static int skl_platform_open(struct snd_pcm_substream *substream)
 static int skl_coupled_trigger(struct snd_pcm_substream *substream,
                                        int cmd)
 {
-       struct hdac_ext_bus *ebus = get_bus_ctx(substream);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = get_bus_ctx(substream);
        struct hdac_ext_stream *stream;
        struct snd_pcm_substream *s;
        bool start;
@@ -1116,9 +1112,9 @@ static int skl_coupled_trigger(struct snd_pcm_substream *substream,
 static int skl_platform_pcm_trigger(struct snd_pcm_substream *substream,
                                        int cmd)
 {
-       struct hdac_ext_bus *ebus = get_bus_ctx(substream);
+       struct hdac_bus *bus = get_bus_ctx(substream);
 
-       if (!(ebus_to_hbus(ebus))->ppcap)
+       if (!bus->ppcap)
                return skl_coupled_trigger(substream, cmd);
 
        return 0;
@@ -1128,7 +1124,7 @@ static snd_pcm_uframes_t skl_platform_pcm_pointer
                        (struct snd_pcm_substream *substream)
 {
        struct hdac_ext_stream *hstream = get_hdac_ext_stream(substream);
-       struct hdac_ext_bus *ebus = get_bus_ctx(substream);
+       struct hdac_bus *bus = get_bus_ctx(substream);
        unsigned int pos;
 
        /*
@@ -1153,12 +1149,12 @@ static snd_pcm_uframes_t skl_platform_pcm_pointer
         */
 
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-               pos = readl(ebus->bus.remap_addr + AZX_REG_VS_SDXDPIB_XBASE +
+               pos = readl(bus->remap_addr + AZX_REG_VS_SDXDPIB_XBASE +
                                (AZX_REG_VS_SDXDPIB_XINTERVAL *
                                hdac_stream(hstream)->index));
        } else {
                udelay(20);
-               readl(ebus->bus.remap_addr +
+               readl(bus->remap_addr +
                                AZX_REG_VS_SDXDPIB_XBASE +
                                (AZX_REG_VS_SDXDPIB_XINTERVAL *
                                 hdac_stream(hstream)->index));
@@ -1243,11 +1239,11 @@ static void skl_pcm_free(struct snd_pcm *pcm)
 static int skl_pcm_new(struct snd_soc_pcm_runtime *rtd)
 {
        struct snd_soc_dai *dai = rtd->cpu_dai;
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);
+       struct hdac_bus *bus = dev_get_drvdata(dai->dev);
        struct snd_pcm *pcm = rtd->pcm;
        unsigned int size;
        int retval = 0;
-       struct skl *skl = ebus_to_skl(ebus);
+       struct skl *skl = bus_to_skl(bus);
 
        if (dai->driver->playback.channels_min ||
                dai->driver->capture.channels_min) {
@@ -1357,19 +1353,19 @@ static int skl_populate_modules(struct skl *skl)
 
 static int skl_platform_soc_probe(struct snd_soc_component *component)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(component->dev);
-       struct skl *skl = ebus_to_skl(ebus);
+       struct hdac_bus *bus = dev_get_drvdata(component->dev);
+       struct skl *skl = bus_to_skl(bus);
        const struct skl_dsp_ops *ops;
        int ret;
 
        pm_runtime_get_sync(component->dev);
-       if ((ebus_to_hbus(ebus))->ppcap) {
+       if (bus->ppcap) {
                skl->component = component;
 
                /* init debugfs */
                skl->debugfs = skl_debugfs_init(skl);
 
-               ret = skl_tplg_init(component, ebus);
+               ret = skl_tplg_init(component, bus);
                if (ret < 0) {
                        dev_err(component->dev, "Failed to init topology!\n");
                        return ret;
@@ -1426,10 +1422,10 @@ static const struct snd_soc_component_driver skl_component  = {
 int skl_platform_register(struct device *dev)
 {
        int ret;
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
-       struct skl *skl = ebus_to_skl(ebus);
        struct snd_soc_dai_driver *dais;
        int num_dais = ARRAY_SIZE(skl_platform_dai);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
+       struct skl *skl = bus_to_skl(bus);
 
        INIT_LIST_HEAD(&skl->ppl_list);
        INIT_LIST_HEAD(&skl->bind_list);
@@ -1465,8 +1461,8 @@ err:
 
 int skl_platform_unregister(struct device *dev)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
-       struct skl *skl = ebus_to_skl(ebus);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
+       struct skl *skl = bus_to_skl(bus);
        struct skl_module_deferred_bind *modules, *tmp;
 
        if (!list_empty(&skl->bind_list)) {
index 9845d853644c2bf9124e2609ddf77fcf2ca3f806..2620d77729c52edf06dd4d347825b9872b9070da 100644 (file)
@@ -937,7 +937,7 @@ static int skl_tplg_find_moduleid_from_uuid(struct skl *skl,
        struct soc_bytes_ext *sb = (void *) k->private_value;
        struct skl_algo_data *bc = (struct skl_algo_data *)sb->dobj.private;
        struct skl_kpb_params *uuid_params, *params;
-       struct hdac_bus *bus = ebus_to_hbus(skl_to_ebus(skl));
+       struct hdac_bus *bus = skl_to_bus(skl);
        int i, size, module_id;
 
        if (bc->set_params == SKL_PARAM_BIND && bc->max) {
@@ -3032,9 +3032,8 @@ static int skl_tplg_widget_load(struct snd_soc_component *cmpnt, int index,
                                struct snd_soc_tplg_dapm_widget *tplg_w)
 {
        int ret;
-       struct hdac_ext_bus *ebus = snd_soc_component_get_drvdata(cmpnt);
-       struct skl *skl = ebus_to_skl(ebus);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = snd_soc_component_get_drvdata(cmpnt);
+       struct skl *skl = bus_to_skl(bus);
        struct skl_module_cfg *mconfig;
 
        if (!tplg_w->priv.size)
@@ -3141,8 +3140,7 @@ static int skl_tplg_control_load(struct snd_soc_component *cmpnt,
        struct soc_bytes_ext *sb;
        struct snd_soc_tplg_bytes_control *tplg_bc;
        struct snd_soc_tplg_enum_control *tplg_ec;
-       struct hdac_ext_bus *ebus  = snd_soc_component_get_drvdata(cmpnt);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus  = snd_soc_component_get_drvdata(cmpnt);
        struct soc_enum *se;
 
        switch (hdr->ops.info) {
@@ -3626,9 +3624,8 @@ static int skl_tplg_get_manifest_data(struct snd_soc_tplg_manifest *manifest,
 static int skl_manifest_load(struct snd_soc_component *cmpnt, int index,
                                struct snd_soc_tplg_manifest *manifest)
 {
-       struct hdac_ext_bus *ebus = snd_soc_component_get_drvdata(cmpnt);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
-       struct skl *skl = ebus_to_skl(ebus);
+       struct hdac_bus *bus = snd_soc_component_get_drvdata(cmpnt);
+       struct skl *skl = bus_to_skl(bus);
 
        /* proceed only if we have private data defined */
        if (manifest->priv.size == 0)
@@ -3717,12 +3714,11 @@ static void skl_tplg_set_pipe_type(struct skl *skl, struct skl_pipe *pipe)
 /*
  * SKL topology init routine
  */
-int skl_tplg_init(struct snd_soc_component *component, struct hdac_ext_bus *ebus)
+int skl_tplg_init(struct snd_soc_component *component, struct hdac_bus *bus)
 {
        int ret;
        const struct firmware *fw;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
-       struct skl *skl = ebus_to_skl(ebus);
+       struct skl *skl = bus_to_skl(bus);
        struct skl_pipeline *ppl;
 
        ret = request_firmware(&fw, skl->tplg_name, bus->dev);
index af198ea0379e64c0e305d81b7a73571454438e00..82282cac9751ed37b3b18aa91f1ca06bb65afbd1 100644 (file)
@@ -458,9 +458,9 @@ enum skl_channel {
 
 static inline struct skl *get_skl_ctx(struct device *dev)
 {
-       struct hdac_ext_bus *ebus = dev_get_drvdata(dev);
+       struct hdac_bus *bus = dev_get_drvdata(dev);
 
-       return ebus_to_skl(ebus);
+       return bus_to_skl(bus);
 }
 
 int skl_tplg_be_update_params(struct snd_soc_dai *dai,
@@ -470,7 +470,7 @@ int skl_dsp_set_dma_control(struct skl_sst *ctx, u32 *caps,
 void skl_tplg_set_be_dmic_config(struct snd_soc_dai *dai,
        struct skl_pipe_params *params, int stream);
 int skl_tplg_init(struct snd_soc_component *component,
-                               struct hdac_ext_bus *ebus);
+                               struct hdac_bus *ebus);
 struct skl_module_cfg *skl_tplg_fe_get_cpr_module(
                struct snd_soc_dai *dai, int stream);
 int skl_tplg_update_pipe_params(struct device *dev,
index 670ff9aaca55de69b35579a56c41f4ce11e56a73..dce64948564940ea7383e0f4975de4b4ec7293ec 100644 (file)
@@ -53,7 +53,7 @@ static void skl_update_pci_byte(struct pci_dev *pci, unsigned int reg,
 
 static void skl_init_pci(struct skl *skl)
 {
-       struct hdac_ext_bus *ebus = &skl->ebus;
+       struct hdac_bus *bus = skl_to_bus(skl);
 
        /*
         * Clear bits 0-2 of PCI register TCSEL (at offset 0x44)
@@ -62,7 +62,7 @@ static void skl_init_pci(struct skl *skl)
         * codecs.
         * The PCI register TCSEL is defined in the Intel manuals.
         */
-       dev_dbg(ebus_to_hbus(ebus)->dev, "Clearing TCSEL\n");
+       dev_dbg(bus->dev, "Clearing TCSEL\n");
        skl_update_pci_byte(skl->pci, AZX_PCIREG_TCSEL, 0x07, 0);
 }
 
@@ -102,8 +102,7 @@ static void skl_enable_miscbdcge(struct device *dev, bool enable)
 static void skl_clock_power_gating(struct device *dev, bool enable)
 {
        struct pci_dev *pci = to_pci_dev(dev);
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
        u32 val;
 
        /* Update PDCGE bit of CGCTL register */
@@ -126,7 +125,6 @@ static void skl_clock_power_gating(struct device *dev, bool enable)
  */
 static int skl_init_chip(struct hdac_bus *bus, bool full_reset)
 {
-       struct hdac_ext_bus *ebus = hbus_to_ebus(bus);
        struct hdac_ext_link *hlink;
        int ret;
 
@@ -134,7 +132,7 @@ static int skl_init_chip(struct hdac_bus *bus, bool full_reset)
        ret = snd_hdac_bus_init_chip(bus, full_reset);
 
        /* Reset stream-to-link mapping */
-       list_for_each_entry(hlink, &ebus->hlink_list, list)
+       list_for_each_entry(hlink, &bus->hlink_list, list)
                bus->io_ops->reg_writel(0, hlink->ml_addr + AZX_REG_ML_LOSIDV);
 
        skl_enable_miscbdcge(bus->dev, true);
@@ -145,8 +143,7 @@ static int skl_init_chip(struct hdac_bus *bus, bool full_reset)
 void skl_update_d0i3c(struct device *dev, bool enable)
 {
        struct pci_dev *pci = to_pci_dev(dev);
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
        u8 reg;
        int timeout = 50;
 
@@ -196,8 +193,7 @@ static void skl_stream_update(struct hdac_bus *bus, struct hdac_stream *hstr)
 
 static irqreturn_t skl_interrupt(int irq, void *dev_id)
 {
-       struct hdac_ext_bus *ebus = dev_id;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = dev_id;
        u32 status;
 
        if (!pm_runtime_active(bus->dev))
@@ -226,8 +222,7 @@ static irqreturn_t skl_interrupt(int irq, void *dev_id)
 
 static irqreturn_t skl_threaded_handler(int irq, void *dev_id)
 {
-       struct hdac_ext_bus *ebus = dev_id;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = dev_id;
        u32 status;
 
        status = snd_hdac_chip_readl(bus, INTSTS);
@@ -237,16 +232,15 @@ static irqreturn_t skl_threaded_handler(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static int skl_acquire_irq(struct hdac_ext_bus *ebus, int do_disconnect)
+static int skl_acquire_irq(struct hdac_bus *bus, int do_disconnect)
 {
-       struct skl *skl = ebus_to_skl(ebus);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct skl *skl = bus_to_skl(bus);
        int ret;
 
        ret = request_threaded_irq(skl->pci->irq, skl_interrupt,
                        skl_threaded_handler,
                        IRQF_SHARED,
-                       KBUILD_MODNAME, ebus);
+                       KBUILD_MODNAME, bus);
        if (ret) {
                dev_err(bus->dev,
                        "unable to grab IRQ %d, disabling device\n",
@@ -263,21 +257,20 @@ static int skl_acquire_irq(struct hdac_ext_bus *ebus, int do_disconnect)
 static int skl_suspend_late(struct device *dev)
 {
        struct pci_dev *pci = to_pci_dev(dev);
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct skl *skl = ebus_to_skl(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
+       struct skl *skl = bus_to_skl(bus);
 
        return skl_suspend_late_dsp(skl);
 }
 
 #ifdef CONFIG_PM
-static int _skl_suspend(struct hdac_ext_bus *ebus)
+static int _skl_suspend(struct hdac_bus *bus)
 {
-       struct skl *skl = ebus_to_skl(ebus);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct skl *skl = bus_to_skl(bus);
        struct pci_dev *pci = to_pci_dev(bus->dev);
        int ret;
 
-       snd_hdac_ext_bus_link_power_down_all(ebus);
+       snd_hdac_ext_bus_link_power_down_all(bus);
 
        ret = skl_suspend_dsp(skl);
        if (ret < 0)
@@ -294,10 +287,9 @@ static int _skl_suspend(struct hdac_ext_bus *ebus)
        return 0;
 }
 
-static int _skl_resume(struct hdac_ext_bus *ebus)
+static int _skl_resume(struct hdac_bus *bus)
 {
-       struct skl *skl = ebus_to_skl(ebus);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct skl *skl = bus_to_skl(bus);
 
        skl_init_pci(skl);
        skl_init_chip(bus, true);
@@ -313,9 +305,8 @@ static int _skl_resume(struct hdac_ext_bus *ebus)
 static int skl_suspend(struct device *dev)
 {
        struct pci_dev *pci = to_pci_dev(dev);
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct skl *skl  = ebus_to_skl(ebus);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
+       struct skl *skl  = bus_to_skl(bus);
        int ret = 0;
 
        /*
@@ -324,15 +315,15 @@ static int skl_suspend(struct device *dev)
         */
        if (skl->supend_active) {
                /* turn off the links and stop the CORB/RIRB DMA if it is On */
-               snd_hdac_ext_bus_link_power_down_all(ebus);
+               snd_hdac_ext_bus_link_power_down_all(bus);
 
-               if (ebus->cmd_dma_state)
-                       snd_hdac_bus_stop_cmd_io(&ebus->bus);
+               if (bus->cmd_dma_state)
+                       snd_hdac_bus_stop_cmd_io(bus);
 
                enable_irq_wake(bus->irq);
                pci_save_state(pci);
        } else {
-               ret = _skl_suspend(ebus);
+               ret = _skl_suspend(bus);
                if (ret < 0)
                        return ret;
                skl->skl_sst->fw_loaded = false;
@@ -351,9 +342,8 @@ static int skl_suspend(struct device *dev)
 static int skl_resume(struct device *dev)
 {
        struct pci_dev *pci = to_pci_dev(dev);
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct skl *skl  = ebus_to_skl(ebus);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
+       struct skl *skl  = bus_to_skl(bus);
        struct hdac_ext_link *hlink = NULL;
        int ret;
 
@@ -373,32 +363,32 @@ static int skl_resume(struct device *dev)
         */
        if (skl->supend_active) {
                pci_restore_state(pci);
-               snd_hdac_ext_bus_link_power_up_all(ebus);
+               snd_hdac_ext_bus_link_power_up_all(bus);
                disable_irq_wake(bus->irq);
                /*
                 * turn On the links which are On before active suspend
                 * and start the CORB/RIRB DMA if On before
                 * active suspend.
                 */
-               list_for_each_entry(hlink, &ebus->hlink_list, list) {
+               list_for_each_entry(hlink, &bus->hlink_list, list) {
                        if (hlink->ref_count)
                                snd_hdac_ext_bus_link_power_up(hlink);
                }
 
-               if (ebus->cmd_dma_state)
-                       snd_hdac_bus_init_cmd_io(&ebus->bus);
                ret = 0;
+               if (bus->cmd_dma_state)
+                       snd_hdac_bus_init_cmd_io(bus);
        } else {
-               ret = _skl_resume(ebus);
+               ret = _skl_resume(bus);
 
                /* turn off the links which are off before suspend */
-               list_for_each_entry(hlink, &ebus->hlink_list, list) {
+               list_for_each_entry(hlink, &bus->hlink_list, list) {
                        if (!hlink->ref_count)
                                snd_hdac_ext_bus_link_power_down(hlink);
                }
 
-               if (!ebus->cmd_dma_state)
-                       snd_hdac_bus_stop_cmd_io(&ebus->bus);
+               if (!bus->cmd_dma_state)
+                       snd_hdac_bus_stop_cmd_io(bus);
        }
 
        return ret;
@@ -409,23 +399,21 @@ static int skl_resume(struct device *dev)
 static int skl_runtime_suspend(struct device *dev)
 {
        struct pci_dev *pci = to_pci_dev(dev);
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
 
        dev_dbg(bus->dev, "in %s\n", __func__);
 
-       return _skl_suspend(ebus);
+       return _skl_suspend(bus);
 }
 
 static int skl_runtime_resume(struct device *dev)
 {
        struct pci_dev *pci = to_pci_dev(dev);
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
 
        dev_dbg(bus->dev, "in %s\n", __func__);
 
-       return _skl_resume(ebus);
+       return _skl_resume(bus);
 }
 #endif /* CONFIG_PM */
 
@@ -438,20 +426,19 @@ static const struct dev_pm_ops skl_pm = {
 /*
  * destructor
  */
-static int skl_free(struct hdac_ext_bus *ebus)
+static int skl_free(struct hdac_bus *bus)
 {
-       struct skl *skl  = ebus_to_skl(ebus);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct skl *skl  = bus_to_skl(bus);
 
        skl->init_done = 0; /* to be sure */
 
-       snd_hdac_ext_stop_streams(ebus);
+       snd_hdac_ext_stop_streams(bus);
 
        if (bus->irq >= 0)
-               free_irq(bus->irq, (void *)ebus);
+               free_irq(bus->irq, (void *)bus);
        snd_hdac_bus_free_stream_pages(bus);
-       snd_hdac_stream_free_all(ebus);
-       snd_hdac_link_free_all(ebus);
+       snd_hdac_stream_free_all(bus);
+       snd_hdac_link_free_all(bus);
 
        if (bus->remap_addr)
                iounmap(bus->remap_addr);
@@ -459,11 +446,11 @@ static int skl_free(struct hdac_ext_bus *ebus)
        pci_release_regions(skl->pci);
        pci_disable_device(skl->pci);
 
-       snd_hdac_ext_bus_exit(ebus);
+       snd_hdac_ext_bus_exit(bus);
 
        cancel_work_sync(&skl->probe_work);
        if (IS_ENABLED(CONFIG_SND_SOC_HDAC_HDMI))
-               snd_hdac_i915_exit(&ebus->bus);
+               snd_hdac_i915_exit(bus);
 
        return 0;
 }
@@ -487,8 +474,8 @@ static struct skl_ssp_clk skl_ssp_clks[] = {
 
 static int skl_find_machine(struct skl *skl, void *driver_data)
 {
+       struct hdac_bus *bus = skl_to_bus(skl);
        struct snd_soc_acpi_mach *mach = driver_data;
-       struct hdac_bus *bus = ebus_to_hbus(&skl->ebus);
        struct skl_machine_pdata *pdata;
 
        mach = snd_soc_acpi_find_machine(mach);
@@ -511,7 +498,7 @@ static int skl_find_machine(struct skl *skl, void *driver_data)
 
 static int skl_machine_device_register(struct skl *skl)
 {
-       struct hdac_bus *bus = ebus_to_hbus(&skl->ebus);
+       struct hdac_bus *bus = skl_to_bus(skl);
        struct snd_soc_acpi_mach *mach = skl->mach;
        struct platform_device *pdev;
        int ret;
@@ -545,7 +532,7 @@ static void skl_machine_device_unregister(struct skl *skl)
 
 static int skl_dmic_device_register(struct skl *skl)
 {
-       struct hdac_bus *bus = ebus_to_hbus(&skl->ebus);
+       struct hdac_bus *bus = skl_to_bus(skl);
        struct platform_device *pdev;
        int ret;
 
@@ -644,12 +631,13 @@ static void skl_clock_device_unregister(struct skl *skl)
 /*
  * Probe the given codec address
  */
-static int probe_codec(struct hdac_ext_bus *ebus, int addr)
+static int probe_codec(struct hdac_bus *bus, int addr)
 {
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
        unsigned int cmd = (addr << 28) | (AC_NODE_ROOT << 20) |
                (AC_VERB_PARAMETERS << 8) | AC_PAR_VENDOR_ID;
        unsigned int res = -1;
+       struct skl *skl = bus_to_skl(bus);
+       struct hdac_device *hdev;
 
        mutex_lock(&bus->cmd_mutex);
        snd_hdac_bus_send_cmd(bus, cmd);
@@ -659,13 +647,16 @@ static int probe_codec(struct hdac_ext_bus *ebus, int addr)
                return -EIO;
        dev_dbg(bus->dev, "codec #%d probed OK\n", addr);
 
-       return snd_hdac_ext_bus_device_init(ebus, addr);
+       hdev = devm_kzalloc(&skl->pci->dev, sizeof(*hdev), GFP_KERNEL);
+       if (!hdev)
+               return -ENOMEM;
+
+       return snd_hdac_ext_bus_device_init(bus, addr, hdev);
 }
 
 /* Codec initialization */
-static void skl_codec_create(struct hdac_ext_bus *ebus)
+static void skl_codec_create(struct hdac_bus *bus)
 {
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
        int c, max_slots;
 
        max_slots = HDA_MAX_CODECS;
@@ -673,7 +664,7 @@ static void skl_codec_create(struct hdac_ext_bus *ebus)
        /* First try to probe all given codec slots */
        for (c = 0; c < max_slots; c++) {
                if ((bus->codec_mask & (1 << c))) {
-                       if (probe_codec(ebus, c) < 0) {
+                       if (probe_codec(bus, c) < 0) {
                                /*
                                 * Some BIOSen give you wrong codec addresses
                                 * that don't exist
@@ -723,8 +714,7 @@ static int skl_i915_init(struct hdac_bus *bus)
 static void skl_probe_work(struct work_struct *work)
 {
        struct skl *skl = container_of(work, struct skl, probe_work);
-       struct hdac_ext_bus *ebus = &skl->ebus;
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = skl_to_bus(skl);
        struct hdac_ext_link *hlink = NULL;
        int err;
 
@@ -745,7 +735,7 @@ static void skl_probe_work(struct work_struct *work)
                dev_info(bus->dev, "no hda codecs found!\n");
 
        /* create codec instances */
-       skl_codec_create(ebus);
+       skl_codec_create(bus);
 
        /* register platform dai and controls */
        err = skl_platform_register(bus->dev);
@@ -774,8 +764,8 @@ static void skl_probe_work(struct work_struct *work)
        /*
         * we are done probing so decrement link counts
         */
-       list_for_each_entry(hlink, &ebus->hlink_list, list)
-               snd_hdac_ext_bus_link_put(ebus, hlink);
+       list_for_each_entry(hlink, &bus->hlink_list, list)
+               snd_hdac_ext_bus_link_put(bus, hlink);
 
        /* configure PM */
        pm_runtime_put_noidle(bus->dev);
@@ -797,7 +787,7 @@ static int skl_create(struct pci_dev *pci,
                      struct skl **rskl)
 {
        struct skl *skl;
-       struct hdac_ext_bus *ebus;
+       struct hdac_bus *bus;
 
        int err;
 
@@ -812,23 +802,22 @@ static int skl_create(struct pci_dev *pci,
                pci_disable_device(pci);
                return -ENOMEM;
        }
-       ebus = &skl->ebus;
-       snd_hdac_ext_bus_init(ebus, &pci->dev, &bus_core_ops, io_ops);
-       ebus->bus.use_posbuf = 1;
+
+       bus = skl_to_bus(skl);
+       snd_hdac_ext_bus_init(bus, &pci->dev, &bus_core_ops, io_ops, NULL);
+       bus->use_posbuf = 1;
        skl->pci = pci;
        INIT_WORK(&skl->probe_work, skl_probe_work);
-
-       ebus->bus.bdl_pos_adj = 0;
+       bus->bdl_pos_adj = 0;
 
        *rskl = skl;
 
        return 0;
 }
 
-static int skl_first_init(struct hdac_ext_bus *ebus)
+static int skl_first_init(struct hdac_bus *bus)
 {
-       struct skl *skl = ebus_to_skl(ebus);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct skl *skl = bus_to_skl(bus);
        struct pci_dev *pci = skl->pci;
        int err;
        unsigned short gcap;
@@ -849,7 +838,7 @@ static int skl_first_init(struct hdac_ext_bus *ebus)
 
        snd_hdac_bus_parse_capabilities(bus);
 
-       if (skl_acquire_irq(ebus, 0) < 0)
+       if (skl_acquire_irq(bus, 0) < 0)
                return -EBUSY;
 
        pci_set_master(pci);
@@ -873,14 +862,14 @@ static int skl_first_init(struct hdac_ext_bus *ebus)
        if (!pb_streams && !cp_streams)
                return -EIO;
 
-       ebus->num_streams = cp_streams + pb_streams;
+       bus->num_streams = cp_streams + pb_streams;
 
        /* initialize streams */
        snd_hdac_ext_stream_init_all
-               (ebus, 0, cp_streams, SNDRV_PCM_STREAM_CAPTURE);
+               (bus, 0, cp_streams, SNDRV_PCM_STREAM_CAPTURE);
        start_idx = cp_streams;
        snd_hdac_ext_stream_init_all
-               (ebus, start_idx, pb_streams, SNDRV_PCM_STREAM_PLAYBACK);
+               (bus, start_idx, pb_streams, SNDRV_PCM_STREAM_PLAYBACK);
 
        err = snd_hdac_bus_alloc_stream_pages(bus);
        if (err < 0)
@@ -896,7 +885,6 @@ static int skl_probe(struct pci_dev *pci,
                     const struct pci_device_id *pci_id)
 {
        struct skl *skl;
-       struct hdac_ext_bus *ebus = NULL;
        struct hdac_bus *bus = NULL;
        int err;
 
@@ -905,10 +893,9 @@ static int skl_probe(struct pci_dev *pci,
        if (err < 0)
                return err;
 
-       ebus = &skl->ebus;
-       bus = ebus_to_hbus(ebus);
+       bus = skl_to_bus(skl);
 
-       err = skl_first_init(ebus);
+       err = skl_first_init(bus);
        if (err < 0)
                goto out_free;
 
@@ -929,7 +916,7 @@ static int skl_probe(struct pci_dev *pci,
 
        skl_nhlt_update_topology_bin(skl);
 
-       pci_set_drvdata(skl->pci, ebus);
+       pci_set_drvdata(skl->pci, bus);
 
        /* check if dsp is there */
        if (bus->ppcap) {
@@ -951,7 +938,7 @@ static int skl_probe(struct pci_dev *pci,
                skl->skl_sst->clock_power_gating = skl_clock_power_gating;
        }
        if (bus->mlcap)
-               snd_hdac_ext_bus_get_ml_capabilities(ebus);
+               snd_hdac_ext_bus_get_ml_capabilities(bus);
 
        snd_hdac_bus_stop_chip(bus);
 
@@ -971,31 +958,30 @@ out_clk_free:
 out_nhlt_free:
        skl_nhlt_free(skl->nhlt);
 out_free:
-       skl_free(ebus);
+       skl_free(bus);
 
        return err;
 }
 
 static void skl_shutdown(struct pci_dev *pci)
 {
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct hdac_bus *bus = ebus_to_hbus(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
        struct hdac_stream *s;
        struct hdac_ext_stream *stream;
        struct skl *skl;
 
-       if (ebus == NULL)
+       if (!bus)
                return;
 
-       skl = ebus_to_skl(ebus);
+       skl = bus_to_skl(bus);
 
        if (!skl->init_done)
                return;
 
-       snd_hdac_ext_stop_streams(ebus);
+       snd_hdac_ext_stop_streams(bus);
        list_for_each_entry(s, &bus->stream_list, list) {
                stream = stream_to_hdac_ext_stream(s);
-               snd_hdac_ext_stream_decouple(ebus, stream, false);
+               snd_hdac_ext_stream_decouple(bus, stream, false);
        }
 
        snd_hdac_bus_stop_chip(bus);
@@ -1003,15 +989,15 @@ static void skl_shutdown(struct pci_dev *pci)
 
 static void skl_remove(struct pci_dev *pci)
 {
-       struct hdac_ext_bus *ebus = pci_get_drvdata(pci);
-       struct skl *skl = ebus_to_skl(ebus);
+       struct hdac_bus *bus = pci_get_drvdata(pci);
+       struct skl *skl = bus_to_skl(bus);
 
        release_firmware(skl->tplg);
 
        pm_runtime_get_noresume(&pci->dev);
 
        /* codec removal, invoke bus_device_remove */
-       snd_hdac_ext_bus_device_remove(ebus);
+       snd_hdac_ext_bus_device_remove(bus);
 
        skl->debugfs = NULL;
        skl_platform_unregister(&pci->dev);
@@ -1021,7 +1007,7 @@ static void skl_remove(struct pci_dev *pci)
        skl_clock_device_unregister(skl);
        skl_nhlt_remove_sysfs(skl);
        skl_nhlt_free(skl->nhlt);
-       skl_free(ebus);
+       skl_free(bus);
        dev_set_drvdata(&pci->dev, NULL);
 }
 
index 0d5375cbcf6ec3cff3fdc044e87493e6c46b3765..78aa8bdcb61929dcafcd93112e4a2b05cca9fbc1 100644 (file)
@@ -71,7 +71,7 @@ struct skl_fw_config {
 };
 
 struct skl {
-       struct hdac_ext_bus ebus;
+       struct hdac_bus hbus;
        struct pci_dev *pci;
 
        unsigned int init_done:1; /* delayed init status */
@@ -105,9 +105,8 @@ struct skl {
        struct snd_soc_acpi_mach *mach;
 };
 
-#define skl_to_ebus(s) (&(s)->ebus)
-#define ebus_to_skl(sbus) \
-       container_of(sbus, struct skl, sbus)
+#define skl_to_bus(s)  (&(s)->hbus)
+#define bus_to_skl(bus) container_of(bus, struct skl, hbus)
 
 /* to pass dai dma data */
 struct skl_dma_params {