Input: synaptics-rmi4 - log when we create a guest serio port
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 17 Jan 2018 19:58:31 +0000 (11:58 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 23 Jan 2018 00:27:40 +0000 (16:27 -0800)
To ease analyzing boot behavior from logs, let's log when we are about to
register the pass-through serio port.

Also, let's drop "Synaptics" prefix from the port name, as RMI4 is good
enough indicator already, and having the prefix means that the name does
not fit into serio->name field. While at it move from hard-coded seio->phys
to one mentioning the sensor ID (such as "rmi4-00.fn03/serio0").

Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_f03.c

index 7ccbb370a9a81ecd8098801453c0122c2bc99f8e..88822196d6b723fcf69efd9c3b685fb92dedcf7b 100644 (file)
@@ -184,14 +184,15 @@ static int rmi_f03_register_pt(struct f03_data *f03)
        serio->close = rmi_f03_pt_close;
        serio->port_data = f03;
 
-       strlcpy(serio->name, "Synaptics RMI4 PS/2 pass-through",
-               sizeof(serio->name));
-       strlcpy(serio->phys, "synaptics-rmi4-pt/serio1",
-               sizeof(serio->phys));
+       strlcpy(serio->name, "RMI4 PS/2 pass-through", sizeof(serio->name));
+       snprintf(serio->phys, sizeof(serio->phys), "%s/serio0",
+                dev_name(&f03->fn->dev));
        serio->dev.parent = &f03->fn->dev;
 
        f03->serio = serio;
 
+       printk(KERN_INFO "serio: %s port at %s\n",
+               serio->name, dev_name(&f03->fn->dev));
        serio_register_port(serio);
 
        return 0;