netvsc: unshare skb in VF rx handler
authorStephen Hemminger <stephen@networkplumber.org>
Tue, 28 May 2019 18:47:30 +0000 (11:47 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 30 May 2019 18:12:21 +0000 (11:12 -0700)
The netvsc VF skb handler should make sure that skb is not
shared. Similar logic already exists in bonding and team device
drivers.

This is not an issue in practice because the VF devicex
does not send up shared skb's. But the netvsc driver
should do the right thing if it did.

Fixes: 0c195567a8f6 ("netvsc: transparent VF management")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hyperv/netvsc_drv.c

index 06393b2151021d4cafa4f7308f4070ad7f741932..9873b8679f8164527f7071daf27c881de034a930 100644 (file)
@@ -2000,6 +2000,12 @@ static rx_handler_result_t netvsc_vf_handle_frame(struct sk_buff **pskb)
        struct netvsc_vf_pcpu_stats *pcpu_stats
                 = this_cpu_ptr(ndev_ctx->vf_stats);
 
+       skb = skb_share_check(skb, GFP_ATOMIC);
+       if (unlikely(!skb))
+               return RX_HANDLER_CONSUMED;
+
+       *pskb = skb;
+
        skb->dev = ndev;
 
        u64_stats_update_begin(&pcpu_stats->syncp);