clk: cdce925: remove redundant check for non-null parent_name
authorColin Ian King <colin.king@canonical.com>
Tue, 5 Sep 2017 15:03:48 +0000 (16:03 +0100)
committerStephen Boyd <sboyd@codeaurora.org>
Tue, 14 Nov 2017 01:44:15 +0000 (17:44 -0800)
The check for a non-null parent_name is always true as there is an
earlier check for a null parent_name that returns -ENODEV. Remove this
redundant check and always set init.num_parents to 1.

Detected by CoverityScan CID#1309477 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk-cdce925.c

index c933be01c7db66f999331b9d187c1125682b127e..0a7e7d5a750605c5be12d953ac912f3fb9105962 100644 (file)
@@ -665,7 +665,7 @@ static int cdce925_probe(struct i2c_client *client,
        init.ops = &cdce925_pll_ops;
        init.flags = 0;
        init.parent_names = &parent_name;
-       init.num_parents = parent_name ? 1 : 0;
+       init.num_parents = 1;
 
        /* Register PLL clocks */
        for (i = 0; i < data->chip_info->num_plls; ++i) {