dma-fence: Allow wait_any_timeout for all fences
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 27 Apr 2018 06:17:11 +0000 (08:17 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 3 May 2018 09:49:00 +0000 (11:49 +0200)
When this was introduced in

commit a519435a96597d8cd96123246fea4ae5a6c90b02
Author: Christian König <christian.koenig@amd.com>
Date:   Tue Oct 20 16:34:16 2015 +0200

    dma-buf/fence: add fence_wait_any_timeout function v2

there was a restriction added that this only works if the dma-fence
uses the dma_fence_default_wait hook. Which works for amdgpu, which is
the only caller. Well, until you share some buffers with e.g. i915,
then you get an -EINVAL.

But there's really no reason for this, because all drivers must
support callbacks. The special ->wait hook is only as an optimization;
if the driver needs to create a worker thread for an active callback,
then it can avoid to do that if it knows that there's a process
context available already. So ->wait is just an optimization, just
using the logic in dma_fence_default_wait() should work for all
drivers.

Let's remove this restriction.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180427061724.28497-5-daniel.vetter@ffwll.ch
drivers/dma-buf/dma-fence.c

index 7b5b40d6b70e6565a653aa0a15a338c2eb5aeb2a..59049375bd192123f9262c60f6fe4a8b3d1f280a 100644 (file)
@@ -503,11 +503,6 @@ dma_fence_wait_any_timeout(struct dma_fence **fences, uint32_t count,
        for (i = 0; i < count; ++i) {
                struct dma_fence *fence = fences[i];
 
-               if (fence->ops->wait != dma_fence_default_wait) {
-                       ret = -EINVAL;
-                       goto fence_rm_cb;
-               }
-
                cb[i].task = current;
                if (dma_fence_add_callback(fence, &cb[i].base,
                                           dma_fence_default_wait_cb)) {