btrfs: replace empty string with NULL when getting attribute length in btrfs_get_acl
authorChengguang Xu <cgxu519@gmx.com>
Wed, 27 Jun 2018 04:16:35 +0000 (12:16 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 6 Aug 2018 11:12:40 +0000 (13:12 +0200)
In btrfs_get_acl() the first call of btr_getxattr() is for getting the
length of attribute, the value buffer is never used in this case. So
it's better to replace empty string with NULL.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/acl.c

index 60f83a3bd77caf03281a0974e9a728e12a99fc87..83fdd80c51c659ed6f3945dfd1742c2774fafde9 100644 (file)
@@ -33,7 +33,7 @@ struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
                return ERR_PTR(-EINVAL);
        }
 
                return ERR_PTR(-EINVAL);
        }
 
-       size = btrfs_getxattr(inode, name, "", 0);
+       size = btrfs_getxattr(inode, name, NULL, 0);
        if (size > 0) {
                value = kzalloc(size, GFP_KERNEL);
                if (!value)
        if (size > 0) {
                value = kzalloc(size, GFP_KERNEL);
                if (!value)