libata: do not suspend port if normal ODD is attached

For ODDs, the upper layer will poll for media change every few
seconds, which will make it enter and leave suspend state very
often. And as each suspend will also cause a hard/soft reset,
the gain of runtime suspend is very little while the ODD may
malfunction after constantly being reset. So the idle callback
here will not proceed to suspend if a non-ZPODD capable ODD is
attached to the port.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index c7ecd8492f1ecba8782e08f6f063ab9d3ea732bf..b7eed827daaea56baff7701ffea02cfc3ac8fec1 100644 (file)
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5413,8 +5413,27 @@ static int ata_port_resume(struct device *dev)
        return rc;
 }
 
+/*
+ * For ODDs, the upper layer will poll for media change every few seconds,
+ * which will make it enter and leave suspend state every few seconds. And
+ * as each suspend will cause a hard/soft reset, the gain of runtime suspend
+ * is very little and the ODD may malfunction after constantly being reset.
+ * So the idle callback here will not proceed to suspend if a non-ZPODD capable
+ * ODD is attached to the port.
+ */
 static int ata_port_runtime_idle(struct device *dev)
 {
+       struct ata_port *ap = to_ata_port(dev);
+       struct ata_link *link;
+       struct ata_device *adev;
+
+       ata_for_each_link(link, ap, HOST_FIRST) {
+               ata_for_each_dev(adev, link, ENABLED)
+                       if (adev->class == ATA_DEV_ATAPI &&
+                           !zpodd_dev_enabled(adev))
+                               return -EBUSY;
+       }
+
        return pm_runtime_suspend(dev);
 }