drm/amdgpu: Make amdgpu_vram_mgr_bo_invisible_size always accurate
authorMichel Dänzer <michel.daenzer@amd.com>
Thu, 14 Jun 2018 11:02:07 +0000 (13:02 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 19 Jun 2018 18:51:45 +0000 (13:51 -0500)
Even BOs with AMDGPU_GEM_CREATE_NO_CPU_ACCESS may end up at least
partially in CPU visible VRAM, in particular when all VRAM is visible.

v2:
* Don't take VRAM mgr spinlock, not needed (Christian König)
* Make loop logic simpler and clearer.

Cc: stable@vger.kernel.org
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c

index ae0049c6c52c98790dc8138e0f9d636d6389fe22..b6333f92ba4565e9b5949f48e643f2d47daaa2a0 100644 (file)
@@ -106,10 +106,26 @@ static u64 amdgpu_vram_mgr_vis_size(struct amdgpu_device *adev,
  */
 u64 amdgpu_vram_mgr_bo_invisible_size(struct amdgpu_bo *bo)
 {
-       if (bo->flags & AMDGPU_GEM_CREATE_NO_CPU_ACCESS)
+       struct amdgpu_device *adev = amdgpu_ttm_adev(bo->tbo.bdev);
+       struct ttm_mem_reg *mem = &bo->tbo.mem;
+       struct drm_mm_node *nodes = mem->mm_node;
+       unsigned pages = mem->num_pages;
+       u64 usage = 0;
+
+       if (adev->gmc.visible_vram_size == adev->gmc.real_vram_size)
+               return 0;
+
+       if (mem->start >= adev->gmc.visible_vram_size >> PAGE_SHIFT)
                return amdgpu_bo_size(bo);
 
-       return 0;
+       while (nodes && pages) {
+               usage += nodes->size << PAGE_SHIFT;
+               usage -= amdgpu_vram_mgr_vis_size(adev, nodes);
+               pages -= nodes->size;
+               ++nodes;
+       }
+
+       return usage;
 }
 
 /**