ipv6: Consider sk_bound_dev_if when binding a raw socket to an address
authorMike Manning <mmanning@vyatta.att-mail.com>
Mon, 20 May 2019 18:57:17 +0000 (19:57 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 May 2019 20:12:39 +0000 (13:12 -0700)
IPv6 does not consider if the socket is bound to a device when binding
to an address. The result is that a socket can be bound to eth0 and
then bound to the address of eth1. If the device is a VRF, the result
is that a socket can only be bound to an address in the default VRF.

Resolve by considering the device if sk_bound_dev_if is set.

Signed-off-by: Mike Manning <mmanning@vyatta.att-mail.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Tested-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/raw.c

index 84dbe21b71e5ea39bda5fc73003501e0bb30e6f8..96a3559f2a0948a5258b0509888ef470ecc5fd59 100644 (file)
@@ -287,7 +287,9 @@ static int rawv6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
                        /* Binding to link-local address requires an interface */
                        if (!sk->sk_bound_dev_if)
                                goto out_unlock;
+               }
 
+               if (sk->sk_bound_dev_if) {
                        err = -ENODEV;
                        dev = dev_get_by_index_rcu(sock_net(sk),
                                                   sk->sk_bound_dev_if);