spi: qup: Remove spi_master_put in spi_qup_remove()
authorWei Yongjun <weiyj.lk@gmail.com>
Tue, 26 Jul 2016 14:53:53 +0000 (14:53 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 27 Jul 2016 18:00:13 +0000 (19:00 +0100)
The call to spi_master_put() in spi_qup_remove() is redundant since
the master is registered using devm_spi_register_master() and no
reference hold by using spi_master_get() in spi_qup_remove().

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qup.c

index c338ef1136f6c6052b72b9394f74ef89b58273a5..7f1555621f8ec262459a0ebd65ffb680b24fbae8 100644 (file)
@@ -1030,7 +1030,6 @@ static int spi_qup_remove(struct platform_device *pdev)
 
        pm_runtime_put_noidle(&pdev->dev);
        pm_runtime_disable(&pdev->dev);
-       spi_master_put(master);
 
        return 0;
 }