ASoC: SOF: Fix snd_sof_ipc_stream_posn()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 3 Mar 2020 10:18:58 +0000 (13:18 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 3 Mar 2020 14:00:02 +0000 (14:00 +0000)
We're passing "&posn" instead of "posn" so it ends up corrupting
memory instead of doing something useful.

Fixes: 53e0c72d98ba ("ASoC: SOF: Add support for IPC IO between DSP and Host")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200303101858.ytehbrivocyp3cnf@kili.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc.c

index b63fc529b4568e476cf6d22b4176189c74d97313..78aa1da7c7a9564dd5a5e606edd1759fd2fce6bb 100644 (file)
@@ -499,7 +499,7 @@ int snd_sof_ipc_stream_posn(struct snd_soc_component *scomp,
 
        /* send IPC to the DSP */
        err = sof_ipc_tx_message(sdev->ipc,
-                                stream.hdr.cmd, &stream, sizeof(stream), &posn,
+                                stream.hdr.cmd, &stream, sizeof(stream), posn,
                                 sizeof(*posn));
        if (err < 0) {
                dev_err(sdev->dev, "error: failed to get stream %d position\n",