btrfs: remove unnecessary -ERANGE check in btrfs_get_acl
authorChengguang Xu <cgxu519@gmx.com>
Wed, 27 Jun 2018 04:16:36 +0000 (12:16 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 6 Aug 2018 11:12:40 +0000 (13:12 +0200)
There is no chance to get into -ERANGE error condition because we first
call btrfs_getxattr to get the length of the attribute, then we do a
subsequent call with the size from the first call.  Between the 2 calls
the size shouldn't change. So remove the unnecessary -ERANGE error
check.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/acl.c

index 83fdd80c51c659ed6f3945dfd1742c2774fafde9..a1d7211c88846fa5e4ace5acf01ff4499c309ce4 100644 (file)
@@ -42,7 +42,7 @@ struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
        }
        if (size > 0) {
                acl = posix_acl_from_xattr(&init_user_ns, value, size);
        }
        if (size > 0) {
                acl = posix_acl_from_xattr(&init_user_ns, value, size);
-       } else if (size == -ERANGE || size == -ENODATA || size == 0) {
+       } else if (size == -ENODATA || size == 0) {
                acl = NULL;
        } else {
                acl = ERR_PTR(-EIO);
                acl = NULL;
        } else {
                acl = ERR_PTR(-EIO);