Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux
authorLinus Torvalds <torvalds@linux-foundation.org>
Sun, 6 Jan 2019 00:07:28 +0000 (16:07 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 6 Jan 2019 00:07:28 +0000 (16:07 -0800)
Pull thermal management updates from Zhang Rui:

 - Add locking for cooling device sysfs attribute in case the cooling
   device state is changed by userspace and thermal framework
   simultaneously. (Thara Gopinath)

 - Fix a problem that passive cooling is reset improperly after system
   suspend/resume. (Wei Wang)

 - Cleanup the driver/thermal/ directory by moving intel and qcom
   platform specific drivers to platform specific sub-directories. (Amit
   Kucheria)

 - Some trivial cleanups. (Lukasz Luba, Wolfram Sang)

* 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux:
  thermal/intel: fixup for Kconfig string parsing tightening up
  drivers: thermal: Move QCOM_SPMI_TEMP_ALARM into the qcom subdir
  drivers: thermal: Move various drivers for intel platforms into a subdir
  thermal: Fix locking in cooling device sysfs update cur_state
  Thermal: do not clear passive state during system sleep
  thermal: zx2967_thermal: simplify getting .driver_data
  thermal: st: st_thermal: simplify getting .driver_data
  thermal: spear_thermal: simplify getting .driver_data
  thermal: rockchip_thermal: simplify getting .driver_data
  thermal: int340x_thermal: int3400_thermal: simplify getting .driver_data
  thermal: remove unused function parameter

32 files changed:
drivers/thermal/Kconfig
drivers/thermal/Makefile
drivers/thermal/intel/Kconfig [new file with mode: 0644]
drivers/thermal/intel/Makefile [new file with mode: 0644]
drivers/thermal/intel/int340x_thermal/Kconfig [moved from drivers/thermal/int340x_thermal/Kconfig with 100% similarity]
drivers/thermal/intel/int340x_thermal/Makefile [moved from drivers/thermal/int340x_thermal/Makefile with 100% similarity]
drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c [moved from drivers/thermal/int340x_thermal/acpi_thermal_rel.c with 100% similarity]
drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.h [moved from drivers/thermal/int340x_thermal/acpi_thermal_rel.h with 100% similarity]
drivers/thermal/intel/int340x_thermal/int3400_thermal.c [moved from drivers/thermal/int340x_thermal/int3400_thermal.c with 96% similarity]
drivers/thermal/intel/int340x_thermal/int3402_thermal.c [moved from drivers/thermal/int340x_thermal/int3402_thermal.c with 100% similarity]
drivers/thermal/intel/int340x_thermal/int3403_thermal.c [moved from drivers/thermal/int340x_thermal/int3403_thermal.c with 100% similarity]
drivers/thermal/intel/int340x_thermal/int3406_thermal.c [moved from drivers/thermal/int340x_thermal/int3406_thermal.c with 100% similarity]
drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c [moved from drivers/thermal/int340x_thermal/int340x_thermal_zone.c with 100% similarity]
drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.h [moved from drivers/thermal/int340x_thermal/int340x_thermal_zone.h with 100% similarity]
drivers/thermal/intel/int340x_thermal/processor_thermal_device.c [moved from drivers/thermal/int340x_thermal/processor_thermal_device.c with 100% similarity]
drivers/thermal/intel/intel_bxt_pmic_thermal.c [moved from drivers/thermal/intel_bxt_pmic_thermal.c with 100% similarity]
drivers/thermal/intel/intel_pch_thermal.c [moved from drivers/thermal/intel_pch_thermal.c with 100% similarity]
drivers/thermal/intel/intel_powerclamp.c [moved from drivers/thermal/intel_powerclamp.c with 100% similarity]
drivers/thermal/intel/intel_quark_dts_thermal.c [moved from drivers/thermal/intel_quark_dts_thermal.c with 100% similarity]
drivers/thermal/intel/intel_soc_dts_iosf.c [moved from drivers/thermal/intel_soc_dts_iosf.c with 100% similarity]
drivers/thermal/intel/intel_soc_dts_iosf.h [moved from drivers/thermal/intel_soc_dts_iosf.h with 100% similarity]
drivers/thermal/intel/intel_soc_dts_thermal.c [moved from drivers/thermal/intel_soc_dts_thermal.c with 100% similarity]
drivers/thermal/intel/x86_pkg_temp_thermal.c [moved from drivers/thermal/x86_pkg_temp_thermal.c with 100% similarity]
drivers/thermal/qcom/Kconfig
drivers/thermal/qcom/Makefile
drivers/thermal/qcom/qcom-spmi-temp-alarm.c [moved from drivers/thermal/qcom-spmi-temp-alarm.c with 99% similarity]
drivers/thermal/rockchip_thermal.c
drivers/thermal/spear_thermal.c
drivers/thermal/st/st_thermal.c
drivers/thermal/thermal_core.c
drivers/thermal/thermal_sysfs.c
drivers/thermal/zx2967_thermal.c

index fdc48a1655e744f4c537334498556e2327136868..30323426902e41bbf81a60e7558c8fe391d0729e 100644 (file)
@@ -326,84 +326,6 @@ config DA9062_THERMAL
          zone.
          Compatible with the DA9062 and DA9061 PMICs.
 
-config INTEL_POWERCLAMP
-       tristate "Intel PowerClamp idle injection driver"
-       depends on THERMAL
-       depends on X86
-       depends on CPU_SUP_INTEL
-       help
-         Enable this to enable Intel PowerClamp idle injection driver. This
-         enforce idle time which results in more package C-state residency. The
-         user interface is exposed via generic thermal framework.
-
-config X86_PKG_TEMP_THERMAL
-       tristate "X86 package temperature thermal driver"
-       depends on X86_THERMAL_VECTOR
-       select THERMAL_GOV_USER_SPACE
-       select THERMAL_WRITABLE_TRIPS
-       default m
-       help
-         Enable this to register CPU digital sensor for package temperature as
-         thermal zone. Each package will have its own thermal zone. There are
-         two trip points which can be set by user to get notifications via thermal
-         notification methods.
-
-config INTEL_SOC_DTS_IOSF_CORE
-       tristate
-       depends on X86 && PCI
-       select IOSF_MBI
-       help
-         This is becoming a common feature for Intel SoCs to expose the additional
-         digital temperature sensors (DTSs) using side band interface (IOSF). This
-         implements the common set of helper functions to register, get temperature
-         and get/set thresholds on DTSs.
-
-config INTEL_SOC_DTS_THERMAL
-       tristate "Intel SoCs DTS thermal driver"
-       depends on X86 && PCI && ACPI
-       select INTEL_SOC_DTS_IOSF_CORE
-       select THERMAL_WRITABLE_TRIPS
-       help
-         Enable this to register Intel SoCs (e.g. Bay Trail) platform digital
-         temperature sensor (DTS). These SoCs have two additional DTSs in
-         addition to DTSs on CPU cores. Each DTS will be registered as a
-         thermal zone. There are two trip points. One of the trip point can
-         be set by user mode programs to get notifications via Linux thermal
-         notification methods.The other trip is a critical trip point, which
-         was set by the driver based on the TJ MAX temperature.
-
-config INTEL_QUARK_DTS_THERMAL
-       tristate "Intel Quark DTS thermal driver"
-       depends on X86_INTEL_QUARK
-       help
-         Enable this to register Intel Quark SoC (e.g. X1000) platform digital
-         temperature sensor (DTS). For X1000 SoC, it has one on-die DTS.
-         The DTS will be registered as a thermal zone. There are two trip points:
-         hot & critical. The critical trip point default value is set by
-         underlying BIOS/Firmware.
-
-menu "ACPI INT340X thermal drivers"
-source "drivers/thermal/int340x_thermal/Kconfig"
-endmenu
-
-config INTEL_BXT_PMIC_THERMAL
-       tristate "Intel Broxton PMIC thermal driver"
-       depends on X86 && INTEL_SOC_PMIC_BXTWC && REGMAP
-       help
-         Select this driver for Intel Broxton PMIC with ADC channels monitoring
-         system temperature measurements and alerts.
-         This driver is used for monitoring the ADC channels of PMIC and handles
-         the alert trip point interrupts and notifies the thermal framework with
-         the trip point and temperature details of the zone.
-
-config INTEL_PCH_THERMAL
-       tristate "Intel PCH Thermal Reporting Driver"
-       depends on X86 && PCI
-       help
-         Enable this to support thermal reporting on certain intel PCHs.
-         Thermal reporting device will provide temperature reading,
-         programmable trip points and other information.
-
 config MTK_THERMAL
        tristate "Temperature sensor driver for mediatek SoCs"
        depends on ARCH_MEDIATEK || COMPILE_TEST
@@ -415,6 +337,11 @@ config MTK_THERMAL
          Enable this option if you want to have support for thermal management
          controller present in Mediatek SoCs
 
+menu "Intel thermal drivers"
+depends on X86 || X86_INTEL_QUARK || COMPILE_TEST
+source "drivers/thermal/intel/Kconfig"
+endmenu
+
 menu "Broadcom thermal drivers"
 depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST
 source "drivers/thermal/broadcom/Kconfig"
@@ -447,17 +374,6 @@ config TANGO_THERMAL
 
 source "drivers/thermal/tegra/Kconfig"
 
-config QCOM_SPMI_TEMP_ALARM
-       tristate "Qualcomm SPMI PMIC Temperature Alarm"
-       depends on OF && SPMI && IIO
-       select REGMAP_SPMI
-       help
-         This enables a thermal sysfs driver for Qualcomm plug-and-play (QPNP)
-         PMIC devices. It shows up in sysfs as a thermal sensor with multiple
-         trip points. The temperature reported by the thermal sensor reflects the
-         real time die temperature if an ADC is present or an estimate of the
-         temperature based upon the over temperature stage value.
-
 config GENERIC_ADC_THERMAL
        tristate "Generic ADC based thermal sensor"
        depends on IIO
index 82bb50dc6423026741d5c22312e52d9b9e4c3b14..486d682be0477e3052600c958de837302f243421 100644 (file)
@@ -29,7 +29,6 @@ thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
 
 # platform thermal drivers
 obj-y                          += broadcom/
-obj-$(CONFIG_QCOM_SPMI_TEMP_ALARM)     += qcom-spmi-temp-alarm.o
 obj-$(CONFIG_SPEAR_THERMAL)    += spear_thermal.o
 obj-$(CONFIG_ROCKCHIP_THERMAL) += rockchip_thermal.o
 obj-$(CONFIG_RCAR_THERMAL)     += rcar_thermal.o
@@ -44,15 +43,8 @@ obj-$(CONFIG_IMX_THERMAL)    += imx_thermal.o
 obj-$(CONFIG_MAX77620_THERMAL) += max77620_thermal.o
 obj-$(CONFIG_QORIQ_THERMAL)    += qoriq_thermal.o
 obj-$(CONFIG_DA9062_THERMAL)   += da9062-thermal.o
-obj-$(CONFIG_INTEL_POWERCLAMP) += intel_powerclamp.o
-obj-$(CONFIG_X86_PKG_TEMP_THERMAL)     += x86_pkg_temp_thermal.o
-obj-$(CONFIG_INTEL_SOC_DTS_IOSF_CORE)  += intel_soc_dts_iosf.o
-obj-$(CONFIG_INTEL_SOC_DTS_THERMAL)    += intel_soc_dts_thermal.o
-obj-$(CONFIG_INTEL_QUARK_DTS_THERMAL)  += intel_quark_dts_thermal.o
+obj-y                          += intel/
 obj-$(CONFIG_TI_SOC_THERMAL)   += ti-soc-thermal/
-obj-$(CONFIG_INT340X_THERMAL)  += int340x_thermal/
-obj-$(CONFIG_INTEL_BXT_PMIC_THERMAL) += intel_bxt_pmic_thermal.o
-obj-$(CONFIG_INTEL_PCH_THERMAL)        += intel_pch_thermal.o
 obj-y                          += st/
 obj-$(CONFIG_QCOM_TSENS)       += qcom/
 obj-y                          += tegra/
diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
new file mode 100644 (file)
index 0000000..2e013ee
--- /dev/null
@@ -0,0 +1,77 @@
+config INTEL_POWERCLAMP
+       tristate "Intel PowerClamp idle injection driver"
+       depends on THERMAL
+       depends on X86
+       depends on CPU_SUP_INTEL
+       help
+         Enable this to enable Intel PowerClamp idle injection driver. This
+         enforce idle time which results in more package C-state residency. The
+         user interface is exposed via generic thermal framework.
+
+config X86_PKG_TEMP_THERMAL
+       tristate "X86 package temperature thermal driver"
+       depends on X86_THERMAL_VECTOR
+       select THERMAL_GOV_USER_SPACE
+       select THERMAL_WRITABLE_TRIPS
+       default m
+       help
+         Enable this to register CPU digital sensor for package temperature as
+         thermal zone. Each package will have its own thermal zone. There are
+         two trip points which can be set by user to get notifications via thermal
+         notification methods.
+
+config INTEL_SOC_DTS_IOSF_CORE
+       tristate
+       depends on X86 && PCI
+       select IOSF_MBI
+       help
+         This is becoming a common feature for Intel SoCs to expose the additional
+         digital temperature sensors (DTSs) using side band interface (IOSF). This
+         implements the common set of helper functions to register, get temperature
+         and get/set thresholds on DTSs.
+
+config INTEL_SOC_DTS_THERMAL
+       tristate "Intel SoCs DTS thermal driver"
+       depends on X86 && PCI && ACPI
+       select INTEL_SOC_DTS_IOSF_CORE
+       select THERMAL_WRITABLE_TRIPS
+       help
+         Enable this to register Intel SoCs (e.g. Bay Trail) platform digital
+         temperature sensor (DTS). These SoCs have two additional DTSs in
+         addition to DTSs on CPU cores. Each DTS will be registered as a
+         thermal zone. There are two trip points. One of the trip point can
+         be set by user mode programs to get notifications via Linux thermal
+         notification methods.The other trip is a critical trip point, which
+         was set by the driver based on the TJ MAX temperature.
+
+config INTEL_QUARK_DTS_THERMAL
+       tristate "Intel Quark DTS thermal driver"
+       depends on X86_INTEL_QUARK
+       help
+         Enable this to register Intel Quark SoC (e.g. X1000) platform digital
+         temperature sensor (DTS). For X1000 SoC, it has one on-die DTS.
+         The DTS will be registered as a thermal zone. There are two trip points:
+         hot & critical. The critical trip point default value is set by
+         underlying BIOS/Firmware.
+
+menu "ACPI INT340X thermal drivers"
+source "drivers/thermal/intel/int340x_thermal/Kconfig"
+endmenu
+
+config INTEL_BXT_PMIC_THERMAL
+       tristate "Intel Broxton PMIC thermal driver"
+       depends on X86 && INTEL_SOC_PMIC_BXTWC && REGMAP
+       help
+         Select this driver for Intel Broxton PMIC with ADC channels monitoring
+         system temperature measurements and alerts.
+         This driver is used for monitoring the ADC channels of PMIC and handles
+         the alert trip point interrupts and notifies the thermal framework with
+         the trip point and temperature details of the zone.
+
+config INTEL_PCH_THERMAL
+       tristate "Intel PCH Thermal Reporting Driver"
+       depends on X86 && PCI
+       help
+         Enable this to support thermal reporting on certain intel PCHs.
+         Thermal reporting device will provide temperature reading,
+         programmable trip points and other information.
diff --git a/drivers/thermal/intel/Makefile b/drivers/thermal/intel/Makefile
new file mode 100644 (file)
index 0000000..0d9736c
--- /dev/null
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for various Intel thermal drivers.
+
+obj-$(CONFIG_INTEL_POWERCLAMP) += intel_powerclamp.o
+obj-$(CONFIG_X86_PKG_TEMP_THERMAL)     += x86_pkg_temp_thermal.o
+obj-$(CONFIG_INTEL_SOC_DTS_IOSF_CORE)  += intel_soc_dts_iosf.o
+obj-$(CONFIG_INTEL_SOC_DTS_THERMAL)    += intel_soc_dts_thermal.o
+obj-$(CONFIG_INTEL_QUARK_DTS_THERMAL)  += intel_quark_dts_thermal.o
+obj-$(CONFIG_INT340X_THERMAL)  += int340x_thermal/
+obj-$(CONFIG_INTEL_BXT_PMIC_THERMAL) += intel_bxt_pmic_thermal.o
+obj-$(CONFIG_INTEL_PCH_THERMAL)        += intel_pch_thermal.o
similarity index 96%
rename from drivers/thermal/int340x_thermal/int3400_thermal.c
rename to drivers/thermal/intel/int340x_thermal/int3400_thermal.c
index e26b01c05e8224cec140633bb3b47787759662db..61ca7ce3624ed4298c6b0b99ee2d5e63f0f534cc 100644 (file)
@@ -48,8 +48,7 @@ static ssize_t available_uuids_show(struct device *dev,
                                    struct device_attribute *attr,
                                    char *buf)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct int3400_thermal_priv *priv = platform_get_drvdata(pdev);
+       struct int3400_thermal_priv *priv = dev_get_drvdata(dev);
        int i;
        int length = 0;
 
@@ -68,8 +67,7 @@ static ssize_t available_uuids_show(struct device *dev,
 static ssize_t current_uuid_show(struct device *dev,
                                 struct device_attribute *devattr, char *buf)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct int3400_thermal_priv *priv = platform_get_drvdata(pdev);
+       struct int3400_thermal_priv *priv = dev_get_drvdata(dev);
 
        if (priv->uuid_bitmap & (1 << priv->current_uuid_index))
                return sprintf(buf, "%s\n",
@@ -82,8 +80,7 @@ static ssize_t current_uuid_store(struct device *dev,
                                  struct device_attribute *attr,
                                  const char *buf, size_t count)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct int3400_thermal_priv *priv = platform_get_drvdata(pdev);
+       struct int3400_thermal_priv *priv = dev_get_drvdata(dev);
        int i;
 
        for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; ++i) {
index be32e5abce3cb134683c19432e37cc372adb9f6b..cdb455ffd5752ef1e7c9094ebf5205ee97bf4403 100644 (file)
@@ -9,3 +9,14 @@ config QCOM_TSENS
          thermal zone device via the mode file results in disabling the sensor.
          Also able to set threshold temperature for both hot and cold and update
          when a threshold is reached.
+
+config QCOM_SPMI_TEMP_ALARM
+       tristate "Qualcomm SPMI PMIC Temperature Alarm"
+       depends on OF && SPMI && IIO
+       select REGMAP_SPMI
+       help
+         This enables a thermal sysfs driver for Qualcomm plug-and-play (QPNP)
+         PMIC devices. It shows up in sysfs as a thermal sensor with multiple
+         trip points. The temperature reported by the thermal sensor reflects the
+         real time die temperature if an ADC is present or an estimate of the
+         temperature based upon the over temperature stage value.
index a821929ede0bd014c42437dd964605e06746fdf2..717a08600bb5662c983bb9cc5761c3ad148b82c0 100644 (file)
@@ -1,2 +1,3 @@
 obj-$(CONFIG_QCOM_TSENS)       += qcom_tsens.o
 qcom_tsens-y                   += tsens.o tsens-common.o tsens-8916.o tsens-8974.o tsens-8960.o tsens-v2.o
+obj-$(CONFIG_QCOM_SPMI_TEMP_ALARM)     += qcom-spmi-temp-alarm.o
similarity index 99%
rename from drivers/thermal/qcom-spmi-temp-alarm.c
rename to drivers/thermal/qcom/qcom-spmi-temp-alarm.c
index b2d5d5bf4a9bd1638eb53b8f5d420e719f0ad140..c1fd71dbab3ebb2e9ee338f4f38590aa8e3904d4 100644 (file)
@@ -23,7 +23,7 @@
 #include <linux/regmap.h>
 #include <linux/thermal.h>
 
-#include "thermal_core.h"
+#include "../thermal_core.h"
 
 #define QPNP_TM_REG_TYPE               0x04
 #define QPNP_TM_REG_SUBTYPE            0x05
index f36375d5a16c57dae499820522accbe979101db8..9c7643d62ed70782e35a7807f90692e9c47670b2 100644 (file)
@@ -1327,8 +1327,7 @@ static int rockchip_thermal_remove(struct platform_device *pdev)
 
 static int __maybe_unused rockchip_thermal_suspend(struct device *dev)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct rockchip_thermal_data *thermal = platform_get_drvdata(pdev);
+       struct rockchip_thermal_data *thermal = dev_get_drvdata(dev);
        int i;
 
        for (i = 0; i < thermal->chip->chn_num; i++)
@@ -1346,8 +1345,7 @@ static int __maybe_unused rockchip_thermal_suspend(struct device *dev)
 
 static int __maybe_unused rockchip_thermal_resume(struct device *dev)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct rockchip_thermal_data *thermal = platform_get_drvdata(pdev);
+       struct rockchip_thermal_data *thermal = dev_get_drvdata(dev);
        int i;
        int error;
 
@@ -1376,7 +1374,7 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev)
                                              id, thermal->regs,
                                              thermal->tshut_temp);
                if (error)
-                       dev_err(&pdev->dev, "%s: invalid tshut=%d, error=%d\n",
+                       dev_err(dev, "%s: invalid tshut=%d, error=%d\n",
                                __func__, thermal->tshut_temp, error);
        }
 
index 81b35aace9de0439c4dd76c4c4c0d91597d3b3f3..8b9d567134d01a4aa95afd4981aec0ed7545c5bd 100644 (file)
@@ -56,8 +56,7 @@ static struct thermal_zone_device_ops ops = {
 
 static int __maybe_unused spear_thermal_suspend(struct device *dev)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct thermal_zone_device *spear_thermal = platform_get_drvdata(pdev);
+       struct thermal_zone_device *spear_thermal = dev_get_drvdata(dev);
        struct spear_thermal_dev *stdev = spear_thermal->devdata;
        unsigned int actual_mask = 0;
 
@@ -73,15 +72,14 @@ static int __maybe_unused spear_thermal_suspend(struct device *dev)
 
 static int __maybe_unused spear_thermal_resume(struct device *dev)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct thermal_zone_device *spear_thermal = platform_get_drvdata(pdev);
+       struct thermal_zone_device *spear_thermal = dev_get_drvdata(dev);
        struct spear_thermal_dev *stdev = spear_thermal->devdata;
        unsigned int actual_mask = 0;
        int ret = 0;
 
        ret = clk_enable(stdev->clk);
        if (ret) {
-               dev_err(&pdev->dev, "Can't enable clock\n");
+               dev_err(dev, "Can't enable clock\n");
                return ret;
        }
 
index be637e6b01d217f9ab54929fbb93322fb5ca086a..b2bbdf6eb02b9a17a1e9d5efb5254805a7eac2ce 100644 (file)
@@ -277,8 +277,7 @@ EXPORT_SYMBOL_GPL(st_thermal_unregister);
 #ifdef CONFIG_PM_SLEEP
 static int st_thermal_suspend(struct device *dev)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct st_thermal_sensor *sensor = platform_get_drvdata(pdev);
+       struct st_thermal_sensor *sensor = dev_get_drvdata(dev);
 
        return st_thermal_sensor_off(sensor);
 }
@@ -286,8 +285,7 @@ static int st_thermal_suspend(struct device *dev)
 static int st_thermal_resume(struct device *dev)
 {
        int ret;
-       struct platform_device *pdev = to_platform_device(dev);
-       struct st_thermal_sensor *sensor = platform_get_drvdata(pdev);
+       struct st_thermal_sensor *sensor = dev_get_drvdata(dev);
 
        ret = st_thermal_sensor_on(sensor);
        if (ret)
index d6ebc1cf6aa9b197089a07ed074610e0124869e5..6590bb5cb6885e4d2d0af88e3aa741cc24bd7745 100644 (file)
@@ -315,9 +315,7 @@ static void monitor_thermal_zone(struct thermal_zone_device *tz)
        mutex_unlock(&tz->lock);
 }
 
-static void handle_non_critical_trips(struct thermal_zone_device *tz,
-                                     int trip,
-                                     enum thermal_trip_type trip_type)
+static void handle_non_critical_trips(struct thermal_zone_device *tz, int trip)
 {
        tz->governor ? tz->governor->throttle(tz, trip) :
                       def_governor->throttle(tz, trip);
@@ -418,7 +416,7 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
        if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
                handle_critical_trips(tz, trip, type);
        else
-               handle_non_critical_trips(tz, trip, type);
+               handle_non_critical_trips(tz, trip);
        /*
         * Alright, we handled this trip successfully.
         * So, start monitoring again.
@@ -453,16 +451,20 @@ static void update_temperature(struct thermal_zone_device *tz)
                        tz->last_temperature, tz->temperature);
 }
 
-static void thermal_zone_device_reset(struct thermal_zone_device *tz)
+static void thermal_zone_device_init(struct thermal_zone_device *tz)
 {
        struct thermal_instance *pos;
-
        tz->temperature = THERMAL_TEMP_INVALID;
-       tz->passive = 0;
        list_for_each_entry(pos, &tz->thermal_instances, tz_node)
                pos->initialized = false;
 }
 
+static void thermal_zone_device_reset(struct thermal_zone_device *tz)
+{
+       tz->passive = 0;
+       thermal_zone_device_init(tz);
+}
+
 void thermal_zone_device_update(struct thermal_zone_device *tz,
                                enum thermal_notify_event event)
 {
@@ -1504,7 +1506,7 @@ static int thermal_pm_notify(struct notifier_block *nb,
        case PM_POST_SUSPEND:
                atomic_set(&in_suspend, 0);
                list_for_each_entry(tz, &thermal_tz_list, node) {
-                       thermal_zone_device_reset(tz);
+                       thermal_zone_device_init(tz);
                        thermal_zone_device_update(tz,
                                                   THERMAL_EVENT_UNSPECIFIED);
                }
index 2241ceae7d7f15eaf09fa89ae2423ad470dd839f..aa99edb4dff7dca35439ed9536dee82f1e1c5b8c 100644 (file)
@@ -712,11 +712,14 @@ cur_state_store(struct device *dev, struct device_attribute *attr,
        if ((long)state < 0)
                return -EINVAL;
 
+       mutex_lock(&cdev->lock);
+
        result = cdev->ops->set_cur_state(cdev, state);
-       if (result)
-               return result;
-       thermal_cooling_device_stats_update(cdev, state);
-       return count;
+       if (!result)
+               thermal_cooling_device_stats_update(cdev, state);
+
+       mutex_unlock(&cdev->lock);
+       return result ? result : count;
 }
 
 static struct device_attribute
index 6acce0bce7c02b3faf3fad01295197fb979d4701..145ebf37159872349ed7a79430f67aa892248be2 100644 (file)
@@ -207,8 +207,7 @@ MODULE_DEVICE_TABLE(of, zx2967_thermal_id_table);
 #ifdef CONFIG_PM_SLEEP
 static int zx2967_thermal_suspend(struct device *dev)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct zx2967_thermal_priv *priv = platform_get_drvdata(pdev);
+       struct zx2967_thermal_priv *priv = dev_get_drvdata(dev);
 
        if (priv && priv->clk_topcrm)
                clk_disable_unprepare(priv->clk_topcrm);
@@ -221,8 +220,7 @@ static int zx2967_thermal_suspend(struct device *dev)
 
 static int zx2967_thermal_resume(struct device *dev)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct zx2967_thermal_priv *priv = platform_get_drvdata(pdev);
+       struct zx2967_thermal_priv *priv = dev_get_drvdata(dev);
        int error;
 
        error = clk_prepare_enable(priv->clk_topcrm);